Commit Graph

16287 Commits

Author SHA1 Message Date
Sunny Goyal 7b74a5c53f Merge "Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""" into udc-dev 2023-04-07 01:02:09 +00:00
Tracy Zhou 47d4769357 Merge "Log the input type for gesture nav gestures" into udc-dev 2023-04-06 23:33:51 +00:00
Charlie Anderson 39fbf0e1a7 Merge "Prevents cropping of shortcuts in the app popup menu by limiting rows to available screen space." into udc-dev 2023-04-06 22:44:42 +00:00
Sunny Goyal 5cd1b198b0 Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""
This reverts commit 7025765c72.

Reason for revert: 274169859

Change-Id: I86a114bf2c713fea6ec7095f68816820ba5f7495
2023-04-06 22:33:11 +00:00
Treehugger Robot 4c61c48dd4 Merge "Clean up ENABLE_INPUT_CONSUMER_REASON_LOGGING" into udc-dev 2023-04-06 21:28:38 +00:00
TreeHugger Robot a47bd20ce4 Merge "Cleanup ENABLE_TASKBAR_POPUP_MENU" into udc-dev 2023-04-06 20:30:30 +00:00
Treehugger Robot 4f93cc72a5 Merge "Cleanup ENABLE_BULK_ALL_APPS_ICON_LOADING" into udc-dev 2023-04-06 20:29:39 +00:00
Treehugger Robot 6a9a1b39f7 Merge "Cleanup ENABLE_SMARTSPACE_DISMISS" into udc-dev 2023-04-06 20:29:35 +00:00
Charlie Anderson 471b88269f Prevents cropping of shortcuts in the app popup menu by limiting rows to available screen space.
- Limit the number of shortcut rows shown to what will fit the screen.
 - Fix drag testDragShortcut so that it works for all screen sizes.
 - Prevent cropping and misalignment of shortcut text.

Bug: 247880037
Fixes: 275115239
Test: locally on different devices, and with Display Size set to different sizes
Change-Id: I18b27ec302c34d1d801171ab18c64169a9f252ee
2023-04-06 15:23:38 -04:00
Tracy Zhou 5a56d022cb Log the input type for gesture nav gestures
Test: N/A
Bug: 276152142
Change-Id: I84a7a9470aa3151d4c6b9dbfc61d8f158987ea47
2023-04-06 09:49:28 -07:00
TreeHugger Robot 3c98169752 Merge "Update the pending app icon to match new specs" into udc-dev 2023-04-06 16:24:53 +00:00
Brian Isganitis 93f20cc2d5 Merge "Make navbar scrim taskbar background if taskbar is enabled." into udc-dev 2023-04-05 23:58:01 +00:00
Schneider Victor-tulias bbe9ca616a Cleanup ENABLE_TASKBAR_POPUP_MENU
Flag: ENABLE_TASKBAR_POPUP_MENU
Fixes: 270392477
Test: opened a popup menu from the taskbar
Change-Id: I779e5410163aa1c9042d2fe128e0c528d168a964
2023-04-05 15:42:40 -07:00
Schneider Victor-tulias 7d8a0df175 Clean up ENABLE_INPUT_CONSUMER_REASON_LOGGING
flag: ENABLE_INPUT_CONSUMER_REASON_LOGGING
Fixes: 270390028
Test: ran launcher and printed gesture nav logs
Change-Id: I0fd0b82c1c812ddc43beba03bd456795f68ada55
2023-04-05 15:40:32 -07:00
Schneider Victor-tulias aba2d9796e Cleanup ENABLE_BULK_ALL_APPS_ICON_LOADING
Flag: ENABLE_BULK_ALL_APPS_ICON_LOADING
Fixes: 270392465
Test: restarted device
Change-Id: I2fe963a512632919c12e1caaf54b2aa8ecd5a3b5
2023-04-05 15:39:51 -07:00
Schneider Victor-tulias 948fc94e12 Cleanup ENABLE_SMARTSPACE_DISMISS
Flag: ENABLE_SMARTSPACE_DISMISS
Fixes: 270391664
Test: dismissed a smartspace card
Change-Id: Ife2dd2fdc023474f59638f2d423fdb9c21823676
2023-04-05 15:38:43 -07:00
TreeHugger Robot 75f7bbc150 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev am: 65ac592f40 am: a2b770b484
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22361600

Change-Id: I41eea8cf3fa15c9c5c3f3184f2ba75318332f623
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 22:36:14 +00:00
Sunny Goyal 8382546a11 Merge "Removing support for legacy shortcuts from default layouts" into udc-dev 2023-04-05 22:26:36 +00:00
TreeHugger Robot a2b770b484 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev am: 65ac592f40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22361600

Change-Id: I71c7f33286ccfa770f87b812c8ec27fa4ecb25ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 22:06:49 +00:00
Brian Isganitis 5489507e69 Merge "Clean up QUICK_WALLPAPER_PICKER." into udc-dev 2023-04-05 21:56:33 +00:00
Sunny Goyal afaa8f0bfe Removing support for legacy shortcuts from default layouts
Launcher will only allow deep shortcuts to be pinned on homescreen.

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I4f2674deb9cd81dd07d5d537f35a51b030a183da
2023-04-05 20:20:34 +00:00
TreeHugger Robot c62a0672ab Merge "Don't return early if searching during rebindAdapters()." into udc-dev 2023-04-05 19:33:43 +00:00
Jon Miranda 04f051045c Allow grids to specify if we should start align taskbar in 3 button
nav.

Bug: 259712417
Test: check layout on tablet
      check layout on multi_display devices

Change-Id: I282f51e5d76a30e9ad9d8c52d03d4853e965d65a
2023-04-05 10:29:51 -07:00
Brian Isganitis 296f8776f7 Merge "Support simple A-Z search in Taskbar All Apps." into udc-dev 2023-04-05 17:13:52 +00:00
Federico Baron 7122921153 Merge "Rename widgets two pane sheet layout files and spec files to more fitting name" into udc-dev 2023-04-05 16:36:36 +00:00
fbaron d2f0676112 Create flag for multi-select edit mode
Bug: 270709220
Test: n/a
Change-Id: I3855662b56b9d26b5513c7681e7f83fa453a1173
2023-04-05 00:43:38 +00:00
Brian Isganitis 728d19a0e2 Support simple A-Z search in Taskbar All Apps.
Supporting the Launcher3 search box is low hanging fruit, so we might as
well do it.

Also renamed the feature flag to be for search in general.

Test: Launching, split screen, and popups work in search.
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR=false
Change-Id: I056b89be6f458d1d90100e34551baa34037574d1
2023-04-04 20:35:31 -04:00
TreeHugger Robot aa017b3c84 Merge "Don't show two pane widget picker in foldables." into udc-dev 2023-04-05 00:29:16 +00:00
Andy Wickham 764c21b207 Don't return early if searching during rebindAdapters().
This was a rare case (made less rare by rocket gesture) which was
not actually updating the UI correctly.

Expected flow:
 1. All Apps is inflated with a single recyclerview for apps (as
    defined in xml).
 2. Later, rebindAdapters() is called, and if there are work apps,
    the recyclerview is removed and replaced by a viewpager with 2
    children recyclerviews (one for personal and one for work).
 3. At any point if you start searching, the app rv or viewpager
    is hidden and the search rv is shown.

Actual flow in the error case:
 - Same as above, but if you were searching when 2 happens, we
   returned early, so we never replaced the app rv with the
   viewpager, so all the apps were dumped in the single rv, and
   the header with tabs showed above it.

Fix: 272575605
Test: Manually force first rebind ta happen while searching, and
verify this bug was hit before the fix but not after.

Change-Id: I25b8991564645368840a390733aa893dee4cd10e
2023-04-04 14:46:26 -07:00
fbaron 6664d8c80b Update the pending app icon to match new specs
Bug: 276950579
Test: Download apps and verify that they match the updated specs
Change-Id: I03b9a5c87514e91c646e961ec57f63f1305d0327
2023-04-04 13:40:55 -07:00
Tracy Zhou 7a8cbd3186 Merge "Support second meta key closing the all apps tray" into udc-dev 2023-04-04 20:13:23 +00:00
Sunny Goyal 6b543872fb Merge "Removing unnecessary device sumaltion code" into tm-qpr-dev am: 08a13d6aae am: e2d73bf57d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22432108

Change-Id: I007c3bcd9a5d5dd8c986efc089420f73f7bad18f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 17:50:24 +00:00
Sunny Goyal e2d73bf57d Merge "Removing unnecessary device sumaltion code" into tm-qpr-dev am: 08a13d6aae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22432108

Change-Id: I883a06a1bf44f7f25928b1355637bd3a8b5d7bdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 17:20:58 +00:00
Sunny Goyal 08a13d6aae Merge "Removing unnecessary device sumaltion code" into tm-qpr-dev 2023-04-04 17:00:34 +00:00
fbaron 55fed64ced Rename widgets two pane sheet layout files and spec files to more fitting name
Currently the names used for widgets two pane sheet files are similar to full sheet files, just with "_large_screen" added to it. This is not a good name as it can cause confusion. The new name includes "_two_pane" which is more indicative of the actual functionality of these files.

Fix: 276917926
Test: verify widget picker two pane still works
Change-Id: I23cf2a20fc137cc3e99c5fdc90100648a0926368
2023-04-04 09:55:31 -07:00
fbaron 12ff85c0ae Don't show two pane widget picker in foldables.
Currently, the two pane widget picker shows up in unfolded foldables. Here we guard against that.

Fix: 276913797
Test: Verify that widget picker in foldable doesn't have two panel layout
Change-Id: I7b949bdf9b0497c381ea43a4b8b473393ff59039
2023-04-04 16:52:33 +00:00
Tony Wickham af02f865ee Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev am: c8d8c58f5b am: 3979706e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22391708

Change-Id: I6213932faa483c24c9d083b95ee9247c47127128
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 16:37:08 +00:00
Brandon Dayauon 13d13491c6 Merge "Enable twoLine for device search for teamfood" into udc-dev 2023-04-04 16:17:47 +00:00
Tony Wickham 3979706e06 Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev am: c8d8c58f5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22391708

Change-Id: I1bea5537e4bfbe6bac55010f58979c2f9fcf6fe4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 16:07:16 +00:00
Tony Wickham c8d8c58f5b Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev 2023-04-04 15:40:28 +00:00
Tracy Zhou cb93ec5f21 Support second meta key closing the all apps tray
Bug: 270244718
Test: Tap meta key twice, see all apps tray open an close
Change-Id: I6db84aa16b7d21663053bf1b269af6ba36874e47
2023-04-03 20:26:39 -07:00
TreeHugger Robot 0770b619ed Merge "Ensuring that badge override is respected even if component name is set on the Shortcut" into udc-dev 2023-04-04 00:40:14 +00:00
Tony Wickham df59884370 Add debug logs for why taskbar might not be destroyed
Test: Manually read log output
Flag: None
Bug: 254119092
Change-Id: Ibaa7ffdc91030c5c999ddc5f2807a55763854331
2023-04-03 23:20:57 +00:00
TreeHugger Robot 150cfcd8a0 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: b32fd3a556 am: 01ebdf81a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163528

Change-Id: I04aa2458a861f403ae82dce1fd7965aaf2ed20f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 21:34:47 +00:00
TreeHugger Robot 01ebdf81a7 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: b32fd3a556
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163528

Change-Id: Ib755f18a8f763120fdaa0fd5d39e9491f05f5705
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 21:00:44 +00:00
TreeHugger Robot b32fd3a556 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev 2023-04-03 20:54:16 +00:00
Brandon Dayauon 4294a77e1b Enable twoLine for device search for teamfood
bug: 275906280
test: manual
Change-Id: I097b78d22afacf775399826202feb3c6d4f102f9
2023-04-03 12:58:59 -07:00
Sunny Goyal 076e04bcc2 Removing unnecessary device sumaltion code
Bug: 276774148
Test: Verified on device
Change-Id: Icb8c2e7649e5b0e107af184b63f7e30f2df717bd
2023-04-03 12:38:52 -07:00
Brian Isganitis 0039ded8ef Clean up QUICK_WALLPAPER_PICKER.
Has been launched for over a year. Also very trivial to cleanup :)

Test: Manual
Fix: 270393112
Flag: QUICK_WALLPAPER_PICKER true
Change-Id: I7388ae741a37119a0f434deb518c352710c200b6
2023-04-03 13:13:33 -04:00
Vinit Nayak 02f20dddb0 Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev am: 8e307ba50a am: 3e5b212204
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22347415

Change-Id: I2f3da1c74ed5ae04ff9cbc4bc06e280da5390b4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 15:54:11 +00:00