Commit Graph

60459 Commits

Author SHA1 Message Date
Ats Jenk ae7e03440c Add support for showing border for desktop tile
When a external keyboard is connected and ENABLE_KEYBOARD_QUICK_SWITCH
feature flag is enabled, we highlight the selected tile in overview.
Add support to the new desktop tile to show the highlight.

Bug: 269342116
Test: connect an external keyboard, use alt+tab to open overview and
  switch between the tiles
Change-Id: I29ac5864776a9a251ecdb0cb4b741b12747de564
2023-02-14 14:40:07 -08:00
Tony Wickham 38e8e4c324 Merge "Change Developer Options search to be single-line" into tm-qpr-dev am: a9e67196e6 am: cd2ed61f83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21339440

Change-Id: I9a2aee61e2455946864d4ab44f67046918a02f3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 21:50:21 +00:00
Federico Baron 716af0c88e Merge "Fix wrong widget appearing in widget picker for tablet" into tm-qpr-dev am: 521e3748d8 am: 301cca1f9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407087

Change-Id: I8426e28448dd6372196a05ae2483528d183c5951
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 21:48:55 +00:00
Sebastian Franco 40f94c84f8 Fix issue where bottom scrim appears in homescreen when it shouldn't
The bottom scrim should be shown for the Pixel Launcher, other third
party launchers show it when the 3 bottom navigation is activated.

The existing condition for 3 bottom navigation is no longer valid
because the insets at the bottom can be greather than 0 in other
situations other than 3 bottom navigation.

Test: the scrom should not show at all
Test: It appears in some situations where the taskbar is showing
and the scrim gets updates which not always happens so it's hard to
manually recreate, but there is a test that is flaky because of it
HomeScreenImageTabletTest#comparePixelTablet2023HomeScreen.
Fix: 267614579

Change-Id: Iacaf93011aa3f2f643186560fe34b4b26ce52314
2023-02-14 13:46:44 -08:00
Schneider Victor-tulias ae5dc0264a Enable ENABLE_KEYBOARD_QUICK_SWITCH on master
Bug: 267520665
Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Change-Id: Ic1f49c097ddfc2303023c1c47df3efca27e73a51
2023-02-14 21:35:31 +00:00
Schneider Victor-tulias de7ceba80b Add the KeyboardQuickSwitchView (2/2)
Adding KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
2023-02-14 13:34:37 -08:00
Charlie Anderson 8ad9144ca2 adding the new Material U App Shortcut Popup design
Bug: 247880037
Test: tested manually
Change-Id: I66c291df54dfc2a76fc974082a19091deb167f73
2023-02-14 16:03:15 -05:00
Sunny Goyal 892fab2c14 Using DiffUtil for calculating widget diff instead
of a custom implementation

This uses the same version as all-apps and avoids whole list refresh
when a widget entry is expanded for the first time

Removing tests which were essentially testing the diffing logic

Bug: 268646258
Test: Verified on device
Change-Id: I4799c66b4674e754547317317e7a63f098fce735
2023-02-14 20:59:29 +00:00
Tony Wickham cd2ed61f83 Merge "Change Developer Options search to be single-line" into tm-qpr-dev am: a9e67196e6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21339440

Change-Id: I0b5567f342d0d8bfe21990b917b9b2c92998919c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 20:52:38 +00:00
Federico Baron 301cca1f9b Merge "Fix wrong widget appearing in widget picker for tablet" into tm-qpr-dev am: 521e3748d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407087

Change-Id: I0ee7a8605a1f4cc7f83622e0b14ed569c6450228
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 20:48:50 +00:00
Tony Wickham a9e67196e6 Merge "Change Developer Options search to be single-line" into tm-qpr-dev 2023-02-14 19:54:17 +00:00
Schneider Victor-tulias 556d37bf01 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev am: 673e6437b8 am: 031e3d38b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087434

Change-Id: Ib0389210f200baa71f346edbc0ca78678702707a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 19:43:13 +00:00
Federico Baron 521e3748d8 Merge "Fix wrong widget appearing in widget picker for tablet" into tm-qpr-dev 2023-02-14 19:28:19 +00:00
Schneider Victor-tulias 031e3d38b8 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev am: 673e6437b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087434

Change-Id: Ifdb495e6480338f41650431c6a8944ae9caad639
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 18:52:06 +00:00
Ats Jenk ce6cebd392 Disable quickswitch for desktop windowing
When desktop windowing prototypes are enabled, disable quickswitch for
now.
Quickswitch causes issues with how tasks are moved between desktop and
fullscreen in prototype 2. We are currently doing it based on shell
transitions. And whether there are desktop tasks visible or not.
Directly switching from a fullscreen task to desktop tasks does not fit
well into this model. And supporting this is not trivial.
As quickswitch is not a core user journey right now, will disable
quickswitch for the time being.
We can revisit this at a later date, when building out the production
version.

Bug: 268075592
Test: enable proto 1, try to quickswitch from home screen and from apps
Test: enable proto 2, try to quickswitch from home screen, from
  fullscreen app to desktop, fullscreen app to another fullscreen app,
  from desktop to fullscreen app
Change-Id: I06b3461f0134819cfa7c9e5f61df8ed84cc90eb8
2023-02-14 10:47:37 -08:00
Schneider Victor-tulias 673e6437b8 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev 2023-02-14 17:46:23 +00:00
Federico Baron b215c5416e Remove unused file WidgetsListSearchHeaderHolder
WidgetsListSearchHeaderHolder was the only file that remained after all the redundant widget search header logic got removed. It is dead code now so this CL deletes it.

Bug: 268646258
Test: Verified on device
Change-Id: I670364bd7c2d5ce46d2c8837ef483e5ac2315547
2023-02-14 01:49:55 -08:00
Winson Chung d5b9cdc6fa Merge "Update region sampling to account for window visibility" into tm-qpr-dev am: c5180384d5 am: 30616e83d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21384584

Change-Id: If15c741da1eae2b399b3a41ea406d5fa7c56cf7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 06:28:41 +00:00
Evan Rosky 11d81bbe76 Update willFinishToHome during follow-up gestures
AbsSwipeUpHandler updates RAC.setWillFinishToHome when the
initial gesture crosses the resume/recents threshold. However,
follow-up gestures don't use AbsSwipeUpHandler -- they go through
RecentsView instead which wasn't updating willFinishToHome. This
confuses RecentsAnimationController.

Bug: 269212678
Test: open app, swipe to overview (let go), swipe down back to fullscreen.
Change-Id: I6cff6856eadf1539ace8a03715491d31920d41e7
2023-02-13 22:19:47 -08:00
Winson Chung 95de6078b0 Merge "Have Taskbar report left/right gesture insets" into tm-qpr-dev am: b41d15b5f6 am: 3e815cbbb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21344502

Change-Id: I195b250bec9a965d916659d8c3490e62bde5065b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 05:41:35 +00:00
Winson Chung 30616e83d9 Merge "Update region sampling to account for window visibility" into tm-qpr-dev am: c5180384d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21384584

Change-Id: I8e5912836ab786e5f1ee389763775c3c6a2df6b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 05:39:55 +00:00
Winson Chung 3e815cbbb9 Merge "Have Taskbar report left/right gesture insets" into tm-qpr-dev am: b41d15b5f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21344502

Change-Id: I6cee95301d8927c185d54364092cfa5ebb274ea8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 05:37:24 +00:00
Winson Chung c5180384d5 Merge "Update region sampling to account for window visibility" into tm-qpr-dev 2023-02-14 04:48:02 +00:00
Winson Chung b41d15b5f6 Merge "Have Taskbar report left/right gesture insets" into tm-qpr-dev 2023-02-14 04:45:24 +00:00
Tony Wickham fc97f74e82 Have Taskbar report left/right gesture insets
Fixes: 231648761
Test: output from adb shell dumpsys activity service
TouchInteractionService, specifically TaskbarInsetsController

Change-Id: I8ed7fefb482bd4f73d2b2026ccb4ac369b6321ab
2023-02-14 04:43:01 +00:00
Tony Wickham d39c298d4c Change Developer Options search to be single-line
Now pressing the enter key will exit the keyboard instead of clearing
filtered results.

Test: manual
Bug: 269200077
Change-Id: I9b717aa3300cad1eede874108e50dd62eeec82ff
2023-02-14 03:11:52 +00:00
Winson Chung c3a8254e65 Merge "Reapply previous states when recreating the task bar" into tm-qpr-dev am: a097a960c8 am: f51df33fc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21383817

Change-Id: Ia95dbef74947a2530b8b8f7ceaa371dc2c804acd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 01:50:02 +00:00
Winson Chung f51df33fc8 Merge "Reapply previous states when recreating the task bar" into tm-qpr-dev am: a097a960c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21383817

Change-Id: I55eb0eab27b323198f36983cbcd5e39eee8a9374
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 00:57:57 +00:00
Winson Chung a097a960c8 Merge "Reapply previous states when recreating the task bar" into tm-qpr-dev 2023-02-14 00:05:58 +00:00
Saumya Prakash 6de5f183ee Merge "Update with current team members working on Launcher." into tm-qpr-dev am: c83b44156a am: dc76528fe1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21358874

Change-Id: I3913a56571df8a72b682efec7351bbbac37afeb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 23:58:59 +00:00
Tracy Zhou 99c447459b Merge "Revert "Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav"" 2023-02-13 23:43:11 +00:00
Schneider Victor-tulias f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Saumya Prakash dc76528fe1 Merge "Update with current team members working on Launcher." into tm-qpr-dev am: c83b44156a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21358874

Change-Id: Ia768156b8399961677fb5cac33a38d533809be9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 23:06:26 +00:00
Sunny Goyal a13cc8167f Deferred widget update
Maintaing a list of pending updates while the host
is not listening, so that these can be applied when
host starts listening again

Bug: 267351283
Test: Manual
Change-Id: I38423862a3461724b36f17ffe44e44c55fee06de
2023-02-13 14:54:25 -08:00
Saumya Prakash c83b44156a Merge "Update with current team members working on Launcher." into tm-qpr-dev 2023-02-13 22:14:14 +00:00
Federico Baron ecb0532597 Fix wrong widget appearing in widget picker for tablet
The wrong widget would appear in tablets because we were finding the widgets by PackageUserKey title instead of comparing the PackageUserKey objects themselves.

Fix: 269160189
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that in landscape mode in tablet clicking the battery header shows the correct widget
Change-Id: I4f17ba057d9287fc83e3b1e0072cacf0eee3deef
2023-02-13 13:53:55 -08:00
Jagrut Desai ec0b4e1693 Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY
Test: Visual(pics in buganizer)
Bug: 265462138
Bug: 267382941

Change-Id: I223cd5ea7e5b553619dfc81c36f1be93e399639d
2023-02-13 13:34:23 -08:00
Andy Wickham 82ab3fb3e3 Reset fast scroller when All Apps resets.
This ensures the scrollbar is not left in a bad state, in
particular if you close All Apps while still scrolling (e.g.
pressing the Home button while holding the scroll bar).

Fix: 267583704
Test: Manual
Change-Id: I0e159f8e5ed289bf1628f77eab1879743b5aea00
2023-02-13 13:32:09 -08:00
Sunny Goyal 591a128e57 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev am: a75105ef03 am: 67e1e03913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381944

Change-Id: Icde51114b8f5655ea516b0ea8233c5f6734d2997
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 19:32:50 +00:00
Brandon Dayauon 3412c1f152 Merge "Add featureFlag for icon in textheader" into tm-qpr-dev am: 0abe8af6a6 am: 50878a997e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074659

Change-Id: I99e13e21853ce27ebad9d5175415bbe347c37f5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 19:32:21 +00:00
Sebastian Franco 81b82720de Making ReorderWidget test more reliable
In some cases when starting to drag you can go to the next
CellLayout wich end in an error. Now the dragging functions
will move the item to the desired CellLayout no matter what
CellLayout you start in.

Fix: 266116487
Test: atest ReorderWidgets
Change-Id: Ie3ad2ff88f734856e2c66d5d51b7578482877b5a
2023-02-13 11:02:09 -08:00
Sunny Goyal 67e1e03913 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev am: a75105ef03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381944

Change-Id: Icb8819fae2b4fd21f76faea78e3e341a32a9508f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 18:40:24 +00:00
Brandon Dayauon 50878a997e Merge "Add featureFlag for icon in textheader" into tm-qpr-dev am: 0abe8af6a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074659

Change-Id: Ie6065bf56a8f6e4ef3a3cdb4a84f03ce2b6d9e4c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-13 18:40:06 +00:00
Sunny Goyal a75105ef03 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev 2023-02-13 18:12:43 +00:00
Brandon Dayauon 0abe8af6a6 Merge "Add featureFlag for icon in textheader" into tm-qpr-dev 2023-02-13 17:52:58 +00:00
Thales Lima 69166dd054 Create a DeviceProfileDumpTest for nonquickstep
This makes sure we are still testing non scalable grids as well

Bug: 241386436
Test: DeviceProfileDumpTest
Change-Id: I06b442cf1052a952ee834f98c5005ea8e950c2f0
2023-02-13 17:31:13 +00:00
Sunny Goyal 77e732a1c4 Moving widget background to xml, so that the same constantstate is
used for all entries

This helps reduce launcher memory by avoiding multuple duplicate
drawable generation

Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
2023-02-13 05:49:31 +00:00
Bill Yi a63e7d9036 Merge "Import translations. DO NOT MERGE ANYWHERE" 2023-02-11 17:17:53 +00:00
Bill Yi 60a01fa596 Merge "Import translations. DO NOT MERGE ANYWHERE" 2023-02-11 17:17:53 +00:00
Nicolò Mazzucato f907f4a00b Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev am: 5147b1d509 am: 8778426fa1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21298421

Change-Id: I1ef6c450692076c5af7032c60f518f8c01fdff11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-11 11:00:38 +00:00