Commit Graph

60459 Commits

Author SHA1 Message Date
Jagrut Desai 560b0eac62 Implement All Apps Icon upto the visual Specs.
Test: Visual
Bug: 267382941

Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
Jagrut Desai 0355c793c0 Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev 2023-02-24 23:34:56 +00:00
Alex Chau 2997c1f84f Merge "Set split button drawable to start instead of left" into tm-qpr-dev am: 346b970942 am: d56e6a6306
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21566803

Change-Id: Ib052ee1ce2c4f1e173cd247deb0343aaa7e84d3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 22:51:05 +00:00
Alex Chau 888bc47918 Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev am: a8c2ffc128 am: 2248a0e941
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549707

Change-Id: I09d435775d10fdd5bae2df06730560444081db02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 22:50:52 +00:00
Schneider Victor-tulias 501647451f Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: cd17310656 am: 4f4962fbc9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21542943

Change-Id: If92717381b6f7ae5b958098141edb3dfa43f91bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 22:50:35 +00:00
Alex Chau d56e6a6306 Merge "Set split button drawable to start instead of left" into tm-qpr-dev am: 346b970942
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21566803

Change-Id: I8c40f21252aedc829cab8de34f77b137ff8529cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:58:14 +00:00
Alex Chau 2248a0e941 Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev am: a8c2ffc128
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549707

Change-Id: Id3f5805bdda91219419b0a1b784dae6655d6d2bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:57:58 +00:00
Schneider Victor-tulias 4f4962fbc9 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: cd17310656
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21542943

Change-Id: I04412352aa7b773103cd08a9c7ce14fe75c2b789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:57:41 +00:00
Alex Chau 346b970942 Merge "Set split button drawable to start instead of left" into tm-qpr-dev 2023-02-24 21:44:02 +00:00
Alex Chau a8c2ffc128 Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev 2023-02-24 21:42:58 +00:00
Schneider Victor-tulias cd17310656 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev 2023-02-24 21:12:41 +00:00
Ats Jenk 3e3f308e60 Merge "Hide overview actions when desktop is focused" into tm-qpr-dev am: 8fc3a1df82 am: d12b90b711
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21568620

Change-Id: I889ec039a93b45eaac85b47f8eeb8e05cd40c876
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 20:24:05 +00:00
Ats Jenk d12b90b711 Merge "Hide overview actions when desktop is focused" into tm-qpr-dev am: 8fc3a1df82
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21568620

Change-Id: If4b3739c2f1aa855a33d1f721872851a60df9382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 19:46:22 +00:00
Ats Jenk 8fc3a1df82 Merge "Hide overview actions when desktop is focused" into tm-qpr-dev 2023-02-24 18:45:28 +00:00
Alex Chau aec9d3136f Remove focus task
- Focus task is only removed under ENABLE_GRID_ONLY_OVERVIEW, but many fixes/refactoring are generic and apply with the flag off
- Keep moving running task to front if go to overvied after quick switch, so live tile is always on top right

Grid calculation:
- Fixed some top/bottom calculation assumption that assume focus task is always present

Size calculation:
- With ENABLE_GRID_ONLY_OVERVIEW, taskSize == gridTaskSize, and task is aligned to top-right of gridRect (instead of focusTaskRect)

Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I6580a8ac6c2c2059c33c4daca05b7d0354513e74
2023-02-24 18:43:30 +00:00
Alex Chau 359ac14d13 Fix various animation issues when total width of grid tasks < screen width
Bug fixes:
- Unusual long scroll when only focus task left after split select
- Animation jump when tasks cannot fit screen width after dismiss or split select

To fix the above issue, generified calculations when total grid task width < screen width:
- Removed some special case handling when only focus task left (getSnapToFocusedTaskScrollDiff), and instead replace with generic logic that calculation that extra scroll position (shortTotalCompensation) needed when long row width is smaller than the grid size
- Fixed snapped task grid translation calculation to account for shortTotalCompensation
- Last task scroll calculation should account for shortTotalCompensation too
- Calculate the expected shortTotalCompensation after dismiss, and use that to adjust the close gap between clearAll distance

splitScrollOffset that we applied during split screen does not work well when shortTotalCompensation != 0. splitScrollOffset is not a good solution to handle split placeholder, as it allow tasks to scroll to weird position. I removed splitScrollOffset completely, and only apply split translation when split placeholder covers the tasks:
- Removed splitScrollOffset on TaskView/ClearAll, so scroll position of TaskView will not change while in split to splify things.
- When split placehodler will cover task's natural position (taskSize) in overview grid, apply split translation on all tasks similar to handheld
- Removed isSplitPlaceholderFirstInGrid/isSplitPlaceholderLastInGrid adjustments

Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I7689b5384845f03491041b6d910835c9ac4fab08
2023-02-24 18:42:13 +00:00
Alibek Manabayev e2f33d2f38 Merge "Extend tests to check Transient Taskbar Autohide" into tm-qpr-dev am: 4424f6636e am: b60e6b0e60
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21445185

Change-Id: I882804ff6a06c7e64c872bf4c2fdc91180664bd2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 15:54:27 +00:00
Alibek Manabayev b60e6b0e60 Merge "Extend tests to check Transient Taskbar Autohide" into tm-qpr-dev am: 4424f6636e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21445185

Change-Id: Iaec5904ced44f1ea776b986cfa798736da7ad0b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 15:18:30 +00:00
Helen Cheuk 599109b23f Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid
Originally folder row and column for 5x5 grid was 3x3. This change is to update it to 4x4 in config to increase the max number of cells displayed. It also adds corresponding test for 5x5 grid and includes numFolderRows and numFolderColumns in the dump string

Fix: 265139500
Test: DeviceProfileDumpTest
Change-Id: I09fe3eac8113a147cb895988e5424471e4e772e5
2023-02-24 14:40:50 +00:00
Alibek Manabayev 4424f6636e Merge "Extend tests to check Transient Taskbar Autohide" into tm-qpr-dev 2023-02-24 14:39:45 +00:00
Alex Chau 49863356e2 Set split button drawable to start instead of left
Fix: 269493214
Test: Check overview actions in regulard and RTL
Change-Id: Ice474294c482de8c552bda5e14efdce989fce4e7
2023-02-24 12:00:48 +00:00
Ling Wo 087c19a9ec Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 6d3658dd0c am: 4f9196c305
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21160354

Change-Id: I2d4c1b04e1f6fef0a0c075e8692a742f5a5bf2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 03:04:55 +00:00
TreeHugger Robot 621ddc1588 [automerger skipped] Merge "Adding bug number for each feature flag" into tm-qpr-dev am: 4e6cdff3bf am: c48bdc845b -s ours
am skip reason: Merged-In Ibe2d5b252c8c71dd0e6b77090b04e1a427a8c23c with SHA-1 eb8717d7cc is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21538246

Change-Id: Ic1ccb2e095e58486273ed46c494a92032a68e8d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 03:04:39 +00:00
Ling Wo 4f9196c305 Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 6d3658dd0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21160354

Change-Id: Ia523c1d77e5b7903c3fb3cee502b771fc9e9c9bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 02:44:54 +00:00
Ling Wo 6d3658dd0c Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev 2023-02-24 02:24:54 +00:00
TreeHugger Robot c48bdc845b Merge "Adding bug number for each feature flag" into tm-qpr-dev am: 4e6cdff3bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21538246

Change-Id: Ia7f30d45bcc5b41abbad14aedd715ccc3150ee06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 02:23:23 +00:00
TreeHugger Robot 4e6cdff3bf Merge "Adding bug number for each feature flag" into tm-qpr-dev 2023-02-24 01:48:10 +00:00
Brandon Dayauon 3d58117d76 Add logging to testDragAppIconToWorkspaceCell()
- add time logs to see what is taking up the most time

bug: 269555222
test: presubmit + manually
Change-Id: I36e763a42e0d8ebdcca108d9206418e05ab33e8f
2023-02-23 16:21:50 -08:00
Ats Jenk 560e494f29 Hide overview actions when desktop is focused
Use same logic for desktop as split screen is using. If focused task is
the desktop task, hide overview actions.

Bug: 269658609
Test: Enable desktop proto 2, have some apps on desktop, focus on a
  fullscreen app, open overview, observe actions visible
Test: have some apps on desktop, open desktop, open overview, observe
  actions are not visible
Test: open two apps in split screen, go to overview, observe no actions
  visible
Change-Id: I7de28ea7af93b58379bb539c5a1b1bcbf6d13b83
2023-02-23 16:02:30 -08:00
TreeHugger Robot 0aa1de56cd Merge "[Gesture Library Integration] Update the check for motion events on trackpad" into udc-dev 2023-02-23 23:15:59 +00:00
Jagrut Desai 3fbaaf9628 Prevent Taskbar from stashing in immersive mode overview.
Test: Visual, Video in Buganizer
Bug: 262589756
Change-Id: Ifbdfb3a4104817e5f50833c42c3c6fc5964388b7
2023-02-23 14:19:10 -08:00
Sunny Goyal c2e3a8afec Adding bug number for each feature flag
Bug: 270386012
Test: N/A
Change-Id: Ibe2d5b252c8c71dd0e6b77090b04e1a427a8c23c
Merged-In: Ibe2d5b252c8c71dd0e6b77090b04e1a427a8c23c
2023-02-23 22:05:10 +00:00
Charlie Anderson 712fd6e1bc Adds new motion animation for U popups am: 6259084496 am: 2010ea7b27
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21338099

Change-Id: I1516ae6ba070c2736971b333fedfb0220f3c0bdb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 22:03:19 +00:00
Charlie Anderson 2010ea7b27 Adds new motion animation for U popups am: 6259084496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21338099

Change-Id: I5709bd1af46af09f567ff2f23ab0a2165ade7683
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 21:26:04 +00:00
Tracy Zhou d248ee7507 [Gesture Library Integration] Update the check for motion events on
trackpad

The gesture library is ported and enabled, thus we are updating our
check for motion events on trackpad.

Bug: 254783214
Test: Swipe up and hold to go to overview; swipe up to go home
Change-Id: I4b74e88c7f8b6ef86c779391b0f8064ea828ed8f
2023-02-23 20:58:22 +00:00
Sunny Goyal eb8717d7cc Adding bug number for each feature flag
Bug: 270386012
Test: N/A
Change-Id: Ibe2d5b252c8c71dd0e6b77090b04e1a427a8c23c
2023-02-23 16:45:45 +00:00
TreeHugger Robot 93e3b7be9b Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev am: 01c1dff441 am: 9fc14b94cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539136

Change-Id: I283fc2baa17b5d75f1eb28bd95b39330d97bb61c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 16:43:31 +00:00
Charlie Anderson 6259084496 Adds new motion animation for U popups
Bug: b/247880037
Test: manually on tablet
Change-Id: I8677cef39a5dc4094cad38f42b9314ac37b95fc2
2023-02-23 15:38:26 +00:00
TreeHugger Robot 9fc14b94cd Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev am: 01c1dff441
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539136

Change-Id: Ic134a1cd2780c2f2ff5f294f33a1f8367b3b6eb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 15:10:37 +00:00
Alibek Manabayev 3b61863ba8 Extend tests to check Transient Taskbar Autohide
Bug: 260589084
Test: ab/I67000010134246487 on local device

Change-Id: Iad141fcbac54770810009e41082ab583cc3d260e
2023-02-23 14:26:44 +00:00
TreeHugger Robot 01c1dff441 Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev 2023-02-23 13:22:15 +00:00
Alex Chau facf8c05ca Merge "Revert "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile""" into tm-qpr-dev am: 8da1cac660 am: 0282b6f786
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539137

Change-Id: Icf19c6b80e9dd42ec42f417b7fc4f05450f11629
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 12:57:25 +00:00
Alex Chau 0282b6f786 Merge "Revert "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile""" into tm-qpr-dev am: 8da1cac660
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539137

Change-Id: Ic8cf8e6f1b29234c0b59c84dc3e181d33b652b15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 12:13:32 +00:00
Alex Chau 8da1cac660 Merge "Revert "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile""" into tm-qpr-dev 2023-02-23 10:51:55 +00:00
Sunny Goyal 5b1a6cc137 Merge "Removing some obsolete features" into tm-qpr-dev am: b3a95149f5 am: 51eb7b611b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537730

Change-Id: I861e29f63df948aca8a6b7c05fa1b31b612cdc7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 09:22:11 +00:00
Sunny Goyal 51eb7b611b Merge "Removing some obsolete features" into tm-qpr-dev am: b3a95149f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537730

Change-Id: Ia7fb81792677cbc3979f138dcea93a77cc44af14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 08:47:16 +00:00
Sunny Goyal b3a95149f5 Merge "Removing some obsolete features" into tm-qpr-dev 2023-02-23 08:01:55 +00:00
Tracy Zhou ee18c2cf6f Merge "Expose taskbar toggled signal to Launcher" into udc-dev 2023-02-23 07:27:21 +00:00
Tiger Huang 210c689996 Merge "Use insetsRoundedCornerFrame to check if taskbar is expanded or not" into udc-dev 2023-02-23 04:37:01 +00:00
Ling Wo d70c8a743d Revert^2 "Expose getSearchBox from the HomeAllApps class"
Reverted changes: /q/submissionid:21128652-revert-20714047-b_255390519-CAXVPNWYOY

Change-Id: I0e9680408e8b1db85600a226d808669c65ba4967
Bug: b/266169958
2023-02-23 02:42:09 +00:00