Brian Isganitis
f5dc57a910
Merge "Treat setup wizard default home as null." into tm-qpr-dev am: 5248b02080
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21690746
Change-Id: I51f0ca59c02cba6b44c38971be924dd9b0bb28f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-04 06:33:34 +00:00
TreeHugger Robot
a176ad060f
Merge "Sync overview scroll so that it ends before/at same time as taskbar animation" into tm-qpr-dev
2023-03-04 01:46:17 +00:00
Jeremy Sim
ad9bdcfd2d
Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev
2023-03-04 01:10:47 +00:00
Sunny Goyal
33c3e77411
Merge "Simplifying code around multiple translation components" into tm-qpr-dev
2023-03-04 00:59:54 +00:00
Sebastian Franco
e4c0345747
Decoupling the reorder logic from the CellLayout view
...
ReorderAlgorithm will now handle all the logic associated with the
reorder. Basically all the logic associated with a reorder in CellLayout
was copy and pasted into ReorderAlgorithm.java.
Test: atest TestReorderAlgorithm
Bug: 229292911
Change-Id: Ie096abc346bf705414e47452a42d1dec5be0a041
2023-03-03 16:57:02 -08:00
Sihua Ma
e0420ab2bc
Fix an issue with concurrent modification on widget holders list
...
This could happen when the QuickstepWidgetHolder is not initialized on the main thread, or destroy() is not called on the main thread, while a random widget is removed at the same time which iterates the widget holder list and calls the callbacks.
Also fixing an issue with memory leak that is caused by the strong reference in WeakHashMap
Test: Presubmit
Fix: 271362384
Change-Id: I621ffb29c167cef9842758c5fdefd6bb66dd487e
2023-03-03 16:34:47 -08:00
TreeHugger Robot
8fd957e323
Merge "Fix margins/padding in widget picker" into tm-qpr-dev
2023-03-04 00:20:53 +00:00
TreeHugger Robot
3dd1440520
Merge "Translate taskbar to hotseat without jump when swiping up from overview" into tm-qpr-dev
2023-03-04 00:18:16 +00:00
Brandon Dayauon
ffc7084b37
Correctly make to spec the color for "Turn on work apps" button and add stroke
...
- define color in base and quickstep
bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Brian Isganitis
d2d2913812
Merge changes from topic "running-in-test-camel" into tm-qpr-dev
...
* changes:
Expose IS_RUNNING_IN_TEST_HARNESS as static method.
Make isTooltipEnabled a getter due to its mutable dependencies.
2023-03-03 23:15:38 +00:00
Jon Miranda
8f2b50fdeb
Sync overview scroll so that it ends before/at same time as taskbar animation
...
Fixes: 267355260
Test: open overview, scroll to 'Clear all button', tap on blank space
Change-Id: Ia58683f7b167ff42443dda3d39368bf6aaa366e0
2023-03-03 13:34:55 -08:00
Vinit Nayak
f51426a6ee
Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev
2023-03-03 21:33:52 +00:00
Brian Isganitis
5248b02080
Merge "Treat setup wizard default home as null." into tm-qpr-dev
2023-03-03 21:11:18 +00:00
Sunny Goyal
c2cc5c57c4
Merge "Adding support for overriding flag values in test" into tm-qpr-dev am: f450476c7a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21733882
Change-Id: I2504ead8caa9c2db320872899167a4cef0b21e9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 19:44:09 +00:00
Vinit Nayak
fc155dd5b0
Merge "Fix quick switch in between two split pairs crash" into tm-qpr-dev am: 750009face
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21460191
Change-Id: I5ee197302979a7ee12198d783a6ab703fe9acde1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 19:43:10 +00:00
Ats Jenk
7e7f2ff07e
Merge "Hide desktop tile when choosing apps for split" into tm-qpr-dev am: 37d6a2be10
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21656508
Change-Id: I40adcf60f0628e8cf4e0c0d1198da7ad7ce975fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 19:41:48 +00:00
Alex Chau
46bbc462e3
Merge "Update OWNER file with current team members" into tm-qpr-dev am: b94d3e7d3e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21616049
Change-Id: Ie3fc8347550ebfe481dc14f2681e832f2852a413
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 19:41:32 +00:00
Schneider Victor-tulias
424d95ed87
Merge "Translate the TutorialStepIndicator to prevent overlapping skip and done buttons" into tm-qpr-dev am: 860b30e7ac
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527494
Change-Id: I49eefbde68bdd93aac103bdc5f6d2094036bf391
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 19:39:11 +00:00
Sunny Goyal
f450476c7a
Merge "Adding support for overriding flag values in test" into tm-qpr-dev
2023-03-03 19:38:38 +00:00
Vinit Nayak
750009face
Merge "Fix quick switch in between two split pairs crash" into tm-qpr-dev
2023-03-03 19:37:04 +00:00
TreeHugger Robot
b753941838
Merge "Set range of overlay for pending download app animation to 0-75% from 0-50%" into tm-qpr-dev am: 7cad8cfce0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21728407
Change-Id: Ic7a25baa67a72b6b1cae8466cd1854dcf1478fac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 19:36:40 +00:00
Ats Jenk
37d6a2be10
Merge "Hide desktop tile when choosing apps for split" into tm-qpr-dev
2023-03-03 19:32:13 +00:00
Alex Chau
b94d3e7d3e
Merge "Update OWNER file with current team members" into tm-qpr-dev
2023-03-03 18:34:01 +00:00
Schneider Victor-tulias
860b30e7ac
Merge "Translate the TutorialStepIndicator to prevent overlapping skip and done buttons" into tm-qpr-dev
2023-03-03 18:14:44 +00:00
TreeHugger Robot
7cad8cfce0
Merge "Set range of overlay for pending download app animation to 0-75% from 0-50%" into tm-qpr-dev
2023-03-03 18:11:55 +00:00
Sunny Goyal
b138ec9fc6
Adding support for overriding flag values in test
...
Bug: 270386012
Test: Verified on device
Change-Id: Ic1af9ca369c0cd2ec49d98875f7b97e90a0050ca
2023-03-03 09:29:42 -08:00
Nick Chameyev
fcf5d393eb
Merge "Do not use private APIs in unfold module" into tm-qpr-dev am: c7ab991818
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21523105
Change-Id: Ida34210a83f096beb2c2bb9346dbe864ac09d2df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 17:26:01 +00:00
Federico Baron
87d54d7003
Merge "Widget picker closes and reopens when switching orientation on phones when it's not necessary" into tm-qpr-dev am: 5c17f6b901 am: 30b5e78b3a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21732117
Change-Id: I7868cc8d836c179a47e2bb2704309429fe5a1820
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 16:57:07 +00:00
Sebastián Franco
612d2d26bf
Merge "Fix widget resize if it last for too long on Multipage CellLayout" into tm-qpr-dev am: 30425b18be am: ccb06b0184
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21680045
Change-Id: I7035e4341c207e364d3df97f2a91466435eb58bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 16:56:11 +00:00
Ats Jenk
ebd14d02a7
Merge "Support large desktop tile in grid only overview" into tm-qpr-dev am: 8e20d62034 am: e086649965
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21611657
Change-Id: I1aa8dfd348c9fc27597d3dbdb7884c4ed358dd57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 16:54:26 +00:00
Johannes Gallmann
f54b88d2d6
Add onEndCallback to ContainerAnimationRunner
...
Bug: 247121782
Test: Manual, i.e. tested that callback is invoked after launch animation
Change-Id: Ie52ffa1b76de01943dd16346560768b3ecced118
2023-03-03 16:55:07 +01:00
Nick Chameyev
c7ab991818
Merge "Do not use private APIs in unfold module" into tm-qpr-dev
2023-03-03 13:22:03 +00:00
Vinit Nayak
26c893603f
Add null check for recents when tapping on Taskbar icons
...
Fixes: 270669636
Test: Couldn't repro, but visually we have checks for
recentsView != null && OTHER_CONDITION, but in the else
case we don't check if recentsView being null is the reason
the if-block didn't get triggered
Change-Id: I72e7480bac56c7e7b7edb73edac4309e9923d302
2023-03-02 18:18:11 -08:00
Evan Rosky
b17c27e9f7
Merge "Part of recents transition wrap order" into udc-dev
2023-03-03 02:07:17 +00:00
Federico Baron
30b5e78b3a
Merge "Widget picker closes and reopens when switching orientation on phones when it's not necessary" into tm-qpr-dev am: 5c17f6b901
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21732117
Change-Id: I8fd694a4a9cd1a4eca26cefbb9bf44e846760a09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 01:45:46 +00:00
Sebastián Franco
ccb06b0184
Merge "Fix widget resize if it last for too long on Multipage CellLayout" into tm-qpr-dev am: 30425b18be
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21680045
Change-Id: I75288bce52bbb86900ca600693e9af6cde358d07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 01:41:34 +00:00
Ats Jenk
e086649965
Merge "Support large desktop tile in grid only overview" into tm-qpr-dev am: 8e20d62034
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21611657
Change-Id: I79ec0ad431543b9bbc86fc1c1b159a6925c969c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-03 01:27:42 +00:00
Federico Baron
5c17f6b901
Merge "Widget picker closes and reopens when switching orientation on phones when it's not necessary" into tm-qpr-dev
2023-03-03 01:21:52 +00:00
Sebastián Franco
30425b18be
Merge "Fix widget resize if it last for too long on Multipage CellLayout" into tm-qpr-dev
2023-03-03 00:59:16 +00:00
Jeremy Sim
03815e6c79
Create TAPL test suite for splitscreen
...
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.
testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.
Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
2023-03-02 16:35:54 -08:00
Brian Isganitis
473cfe0a1a
Implement light mode for persistent Taskbar.
...
NavbarButtonsViewController has been massaged to make sure the buttons
contrast well with the color of the Taskbar background that they are on,
if applicable.
Test: Manual
Fix: 268052229
Change-Id: I917a1a1be013c304910b0f674ae8a13abb8e47a1
Merged-In: I917a1a1be013c304910b0f674ae8a13abb8e47a1
2023-03-03 00:35:20 +00:00
Brian Isganitis
977a62fa41
Merge "Implement light mode for persistent Taskbar." into udc-dev
2023-03-03 00:34:02 +00:00
Brian Isganitis
fdd044e16e
Expose IS_RUNNING_IN_TEST_HARNESS as static method.
...
This variable is now mutable, making the uppercase format misleading.
For instance, users might assume they can use this value in other
immutable properties, when they really should be accessing the latest
value every time they need it.
Context: https://source.android.com/docs/setup/contribute/code-style#follow-field-naming-conventions
Test: Manual
Bug: 271160958
Change-Id: Iaaa51d9153cb8a7d686c72e1210b1948029dcfd5
2023-03-03 00:17:33 +00:00
Ats Jenk
55cb5fca91
Hide desktop tile when choosing apps for split
...
Bug: 269660657
Test: open overview, click on split screen action, observe desktop tile
is hidden
Test: on home screen, long press on app icon and choose split screen,
observe overview opens with desktop tile hidden
Change-Id: I60c06a8e2ef8fc13e741f8845254d22e9e430bb6
2023-03-02 15:14:34 -08:00
Schneider Victor-tulias
3146c5f6b4
Translate the TutorialStepIndicator to prevent overlapping skip and done buttons
...
On large fonts and display sizes, the TutorialStepIndicator can overlap the skip and/or done buttons. Adding some additional translation to account for this.
Fixes: 269588989
Test: tried the tutorial on the largest and default font and display sizes on a phone
Change-Id: I45a276bba3e9cb10336c6f3aa363b7a5c7a73543
2023-03-02 15:13:21 -08:00
Vadim Tryshev
990a32e7cf
Making Launcher3Tests "abtd atest"-compatible
...
Test: labtest
Bug: 187761685
Change-Id: I3e7ed63eb8cfa0d634d720a692e050deb8736906
2023-03-02 23:06:37 +00:00
Ats Jenk
8e20d62034
Merge "Support large desktop tile in grid only overview" into tm-qpr-dev
2023-03-02 22:45:38 +00:00
Federico Baron
b25d758827
Widget picker closes and reopens when switching orientation on phones when it's not necessary
...
Widget picker closes and reopens when switching orientation on phones when it's not necessary. We should only close and reopen widget picker if it's tablet since that's when we want to inflate either the regular widget picker or the two pane widget picker. When we're on a phone, we always want to inflate the regular widget picker, so closing and re-inflating is not needed.
Fix: 271474746
Test: Change orientation in phones vs tablets. Verify that both still work.
Change-Id: I6062b056c4e7675bc830b6884761ec1f2eb20b1d
2023-03-02 14:10:09 -08:00
Federico Baron
5f811c9dad
Set range of overlay for pending download app animation to 0-75% from 0-50%
...
The pending download app animation had an overlay that ranged from 0% to 50% opacity. With this CL we shift the range to 0-75%.
Fix: 271470372
Test: download an app and see the animation for pending download
Change-Id: Ib0332eca2dad37efa916a9410e9466cc63574b5a
2023-03-02 22:08:00 +00:00
Sunny Goyal
82dfc15037
Simplifying code around multiple translation components
...
Bug: 270759683
Test: Verified on device
Change-Id: I6c758c715828ae25e0e3c60b793cf85d70cb2487
2023-03-02 12:22:03 -08:00