Commit Graph

60459 Commits

Author SHA1 Message Date
Tony Wickham f497c59b5e Merge "Update folder leave-behind color for taskbar" into tm-qpr-dev am: 0165aa82c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21968430

Change-Id: Ifd652848a3006de0c975410623ed3f59c8f17023
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 18:04:28 +00:00
Saumya Prakash d3eadb74d3 Merge "Enable the redesigned gesture navigation tutorial" into udc-dev 2023-03-21 17:39:00 +00:00
Jon Miranda 3344ec7004 Add spring animation when stashing transient taskbar.
Bug: 273961611
Change-Id: I35a658a5e30a155094a48effdefc3895f45e0483
Flag: ENABLE_TRANSIENT_TASKBAR
Test: stash transient taskbar
2023-03-21 10:25:48 -07:00
Evan Rosky fa06c90dc4 Merge "Move recents animation controller to shell" into udc-dev 2023-03-21 17:19:25 +00:00
Jon Miranda aa08a59f92 Fix issue where two translation animations clobber each other.
Internal implementation of AnimatedFloat ensures only one
animation plays at a time.

Bug: 273961611
Change-Id: Idc86dba3ac0a085e7cb6b3a979d5b098b75b62b8
Flag: ENABLE_TRANSIENT_TASKBAR
Test: swipe from overview to home
2023-03-21 17:12:52 +00:00
Federico Baron ac978187a7 Turn on the flag for large screen widget picker
Bug: 256684299
Test: N/A
Change-Id: I8ccf962faab42c3ea012ddcf4650ded01cfaf7f2
2023-03-21 16:48:12 +00:00
Federico Baron c3ab820144 Add test for widget picker on landscape mode for tablets
When we added widget picker two pane layout, it broke some tests with the flag on. Here we fix those tests.
Bug: 256684299
Test: AddWidgetsTest and TaplTestsLauncher3#testWidget

Change-Id: I383c754016d82fba51fa0b7b0459cd7e83b274d8
2023-03-21 16:48:12 +00:00
Tony Wickham 0165aa82c6 Merge "Update folder leave-behind color for taskbar" into tm-qpr-dev 2023-03-21 16:38:46 +00:00
Jon Miranda 6e816aaf37 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev am: 149246f077 am: ce06cf89b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22141153

Change-Id: I919b45021c1fbc2a5d5c30c2d5eca71a672cd5be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 14:14:43 +00:00
Jon Miranda ce06cf89b0 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev am: 149246f077
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22141153

Change-Id: Ia0212c2829b01c5b0faf120d6303b7cf6d147ad6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 13:33:32 +00:00
Jon Miranda 149246f077 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev 2023-03-21 13:01:30 +00:00
Mike Schneider 7b410f24b4 Do not perform invisible transitions while the screen is off.
This change caches whether launcher was active at the time of the screen
off, and assumes this last state when the screen is actually off.

While trying to understand the code, I renamed a couple class-internal
methods and flags, plus added comments. If they are not accurate, its
due to a misunderstanding on my part, and I will gladly revisit and
check whether all the assumptions I made still hold.

Bug: 261418621
Test: manually

Change-Id: I2ad25caf478100781a063c356c5fd2d20d3e1917
2023-03-21 10:27:13 +00:00
Hyunyoung Song a38aab93b9 Revert "Revert "Hide the splash icon when launching with no view..."
Revert submission 21916962-revert-21447384-no-splash-UILAXIUPKJ

Reason for revert: Retry errorprone target

Reverted changes: /q/submissionid:21916962-revert-21447384-no-splash-UILAXIUPKJ
Flag: production issue. Not hidden behind flag
Bug: 269343536
Test: manual

Change-Id: Ia365f886d39d63472d72afc2033fc67e19109f57
2023-03-20 23:33:11 -07:00
randypfohl f977979374 Updating overview tutorial to new simple tutorial flow am: 1c0a27a28e am: 127329fe46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163527

Change-Id: I22b4cefb0ec8e241e04b1ceb70644e9ea17ea7bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 06:13:32 +00:00
randypfohl 127329fe46 Updating overview tutorial to new simple tutorial flow am: 1c0a27a28e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163527

Change-Id: I0658dc8bbb4d92d46f29c8851415de49164ea64d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 05:36:11 +00:00
Saumya Prakash 5a7a23bd3c Enable the redesigned gesture navigation tutorial
Bug: 270396257
Bug: 241813570
Test: N/A
Change-Id: I49a548b69da37aecf422c08b932592befc1a2cf8
2023-03-20 23:30:35 +00:00
randypfohl 1c0a27a28e Updating overview tutorial to new simple tutorial flow
test: built and tested on multiple devices. recorded videos and shared in chat.

bug: b/253520701, b/253521660, b/241813570

Change-Id: I57f88f5fb35c6a7b1219fac6e992bb84354b91ef
2023-03-20 23:16:10 +00:00
Schneider Victor-tulias dc25fca903 Add debug logs to help investigate view and activity leak test failures.
Flag: not needed
Test: MemoryTests
Bug: 260260325
Change-Id: Ie9ed8e607c574e81696a4246f701534c18cf0b7c
2023-03-20 15:54:47 -07:00
Evan Rosky 0602f8027e Move recents animation controller to shell
Since recents animation controller is moved to shell, we
no-longer package a RemoteTransition with the intent
options.

Bug: 269691848
Test: existing tests pass. This is mostly moving logic.
Change-Id: I37df892fbc81e6af91173af9b7e6b80825311b0f
2023-03-20 22:14:58 +00:00
Jon Miranda 4202d43e48 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449 am: 03bb5fe49c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: I0adde19b10d0bf6c25c5025453fd361a0804cf62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 22:12:54 +00:00
Sebastian Franco b0b6a212b8 Stop DeleteDropTarget from setting the containerId of items to NO_ID
When deleting items, the items wont get removed form the database right away to give time for the user to undo the operation if needed.

When rotating the screen the items get loaded again, even those items marked for deletion who hasn't been deleted yet, and because they have the container to NO_ID it cause Launcher to crash.

There is no need to set the containerId to NO_ID because the trigger to finally remove the items gets called when the toast to undo disappears and rotating the screen triggers the toast to disapear. It might be posible for the item to flash in the workspace if it gets render before deleting after rotation but it's so fast that I haven't seen that issue.

Fix: 262199032
Test: Manuall test: remove item from hotseat, rotate device before toast with undo button disapears.
Change-Id: Ia8726941dc81078b49b32565daa32fadf3ae45ba
2023-03-20 22:08:04 +00:00
Jon Miranda 03bb5fe49c Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: Iaa1d5cf3e030398c97841fe604ad923cce4e25e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:34:11 +00:00
Sunny Goyal 717072d1d5 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev am: d2a34a2d54 am: 92e392d55b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22139063

Change-Id: I5df3d13170ae2125f9113f0c3cd41d9c47b093a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:13:42 +00:00
Stefan Andonian 956b88e561 Stop enabling the Boot Aware Launcher prefs code during Tests after
running LauncherPref unit tests.

There is something in the LauncherPrefs code that interacts with the
boot aware shared preference data that is not compatible with the
Widgets.Reorder tests. A todo has been added to fix that before
releasing that feature. For now, implementing a simple fix to stop
enabling this feature for while doing post submit testing.

Bug: 271434610
Test: Used go/abdt to verify that this CL fixes the post submit tests.
They no longer fail like they did before this was pushed.

Change-Id: Id6bd94f5d0e0ee9afc2ccea3a4808cf723a4e688
2023-03-20 20:59:50 +00:00
Jon Miranda fad8c1c449 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev 2023-03-20 20:54:27 +00:00
Sunny Goyal 92e392d55b Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev am: d2a34a2d54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22139063

Change-Id: I9e77f805e0b3e198ef44a075f6176b9fcc8f6cd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 20:27:54 +00:00
Sunny Goyal d2a34a2d54 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev 2023-03-20 20:01:52 +00:00
Jagrut Desai d78b4ecbd0 Clear Accessibility Focus from Taskbar Icon after Shorcut Menu invoked
Test: Manual
Bug: 267698319
Flag: not needed
Change-Id: I2726504094af2abacf1c41089c7bcd4efb588099
2023-03-20 12:41:17 -07:00
Saumya Prakash 36095202d1 Merge "Redesign the gesture tutorial for the Back gesture" into tm-qpr-dev am: 60c419b9b7 am: 813a373212
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21779343

Change-Id: Icee872bf78260ec9aca83e86ad60b2d764ff69a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 19:28:42 +00:00
Jon Miranda c5d3518763 Merge "Taskbar motion polish to keep icons within taskbar bg bounds." into tm-qpr-dev am: 8a53e78f22 am: 9c2a40576e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22133846

Change-Id: Ia521c55b6ac46919fbf3f3fdc19c87ff755c6aa3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 19:25:33 +00:00
Saumya Prakash 813a373212 Merge "Redesign the gesture tutorial for the Back gesture" into tm-qpr-dev am: 60c419b9b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21779343

Change-Id: I00170b244f7e51be704d980b526c19b4980ed954
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 19:03:12 +00:00
Stefan Andonian 6da4ac41cc Merge "Revert "Revert "Enable CONTINUOUS_VIEW_TREE_CAPTURE FeatureFlag.""" into udc-dev 2023-03-20 19:02:12 +00:00
Saumya Prakash 60c419b9b7 Merge "Redesign the gesture tutorial for the Back gesture" into tm-qpr-dev 2023-03-20 18:48:34 +00:00
Jon Miranda 9c2a40576e Merge "Taskbar motion polish to keep icons within taskbar bg bounds." into tm-qpr-dev am: 8a53e78f22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22133846

Change-Id: I1ede6c749f24762727fbf7dc8ae1085a70ab0bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 18:42:46 +00:00
Jon Miranda 4235a94958 Merge "New taskbar thresholds." into tm-qpr-dev am: d95c511b2c am: 5ce4bd3412
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140107

Change-Id: I3a17fbf6d4969a2c991b30d8007bf1c33ddec8b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 18:22:49 +00:00
Jon Miranda c0c1c55c5d Add a way to fade out taskbar view when closing an app in the taskbar.
Prior to this change, if taskbar is showing and we are cloing an app
that is visible in the taskbar, the taskbar view would immediately
disappear.

Now we will fade out the view until the animation is 33% complete,
at which point the 'space' will be clear for the FloatingIconView
to settle at its final location.

Bug: 273961611
Test: open app in hotseat
      note that the taskbar view is gone immediately
      have taskbar visible, close app that is shown in taskbar
      note that the taskbar view fades out

Change-Id: I5589e2ce3033cfa19669d1bfaf568aef2a96015e
2023-03-20 18:21:42 +00:00
Jon Miranda 8a53e78f22 Merge "Taskbar motion polish to keep icons within taskbar bg bounds." into tm-qpr-dev 2023-03-20 18:04:39 +00:00
Jon Miranda 18c53ac26b Tune springs when app animates home into the hotseat on devices
with a taskbar.

Thought about using the Builder pattern here but the CL becomes
much larger due to SwipePipToHomeAnimator having its own
Builder.

Bug: 268026344
Test: swipe up to close app thats in hotseat
      swipe back to close app thats in hotseat

Change-Id: Idd0729224374579753fc91c7820f3b04a7d3e1a4
2023-03-20 10:56:43 -07:00
Jon Miranda 5ce4bd3412 Merge "New taskbar thresholds." into tm-qpr-dev am: d95c511b2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140107

Change-Id: Ia16e24ed47616868469f428638b999d20b5712b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 17:44:58 +00:00
Jon Miranda a479a6e3fd Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev am: ad94440c5f am: d0c8aa31bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140592

Change-Id: Iee4811dc9cef70e390514106cbc32ea618d1b759
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 17:23:17 +00:00
Sam Dubey ee75235a59 Merge "Revert "Move recents animation controller to shell"" into udc-dev 2023-03-20 17:19:13 +00:00
Jon Miranda d95c511b2c Merge "New taskbar thresholds." into tm-qpr-dev 2023-03-20 17:16:22 +00:00
Sebastian Franco 25423867af Fixing test that fail when FOLDABLE_SINGLE_PAGE is set to true
We need to change the result of REQUEST_IS_TWO_PANELS when the
flag is on because now we don't have two panels only 1.

Another of the issues is a rounding error when calling
getUnusedHorizontalSpace().

And lastly updating workspaceToBoards so that it maps the coordinate
of workspace items to their right position.

Bug: 270395274
Test: atest ReorderWidgets
Change-Id: I2620e5bf1ba132f984e00d2a6c21081953d259fd
2023-03-20 17:06:20 +00:00
Stefan Andonian 053a7e3743 Revert "Revert "Enable CONTINUOUS_VIEW_TREE_CAPTURE FeatureFlag.""
This reverts commit 17f7406a5e.

Reason for revert: To be submitted after the fix for b/273614966 is downstream merged into udc-dev (ag/22102493).

Change-Id: I3038b46776815069898829e46321885278b1caff
2023-03-20 16:59:29 +00:00
Jon Miranda d0c8aa31bd Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev am: ad94440c5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140592

Change-Id: I7c5c1c5f39906eb5e4f5caff4ec4a8c828e5300c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 16:45:42 +00:00
Sunny Goyal 19691f60f1 Merge "Fixing overscroll getting lost due to float point comparision" into udc-dev 2023-03-20 16:16:18 +00:00
Jon Miranda ad94440c5f Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev 2023-03-20 16:14:43 +00:00
Jon Miranda f23e2d1e16 Keep foreground drawable centered during app open/close animation.
For apps that use AdaptiveIcon, we used to animate the foreground
drawable independently from the background. This is sometimes
perceived as jank so we remove the animation since it is very subtle
in the best case scenario.

Bug: 268026344
Test: open/close apps/folders that use AdaptiveIcons
Change-Id: I500bf56e04823757d511d909a93d3b30703249a1
2023-03-20 16:13:02 +00:00
Sam Dubey 1c52543678 Revert "Move recents animation controller to shell"
Revert submission 21912191-recents_to_shell

Reason for revert: Testing b/274454574

Reverted changes: /q/submissionid:21912191-recents_to_shell

Change-Id: If1732c1f539a973a2ef0dc0f05302fcaaf366300
2023-03-20 16:11:02 +00:00
Jon Miranda f0e14ac7da Taskbar motion polish to keep icons within taskbar bg bounds.
Instead of making the icons themselves move faster, we change
the startDelay/duration of the taskbar bg alpha animation
so that the taskbar is only visible when the icons are within
the taskbar bounds.

This is still an approximation. For U+, we should support taskbar
width change to fit the icons when they are in the 'hotseat'
alignment.

Bug: 273961611
Test: home <-> overview
      home <-> app
      stash <-> unstash
      foldable/tablet
      RTL
Change-Id: I39bedafac4afd641d250f7c97abf1e2de070d646
2023-03-20 07:12:53 -07:00