Commit Graph

60459 Commits

Author SHA1 Message Date
Winson Chung 240b064cdb Fix case of gesture being stuck when the Launcher is stopped mid-gesture
- In rare cases, Launcher may be stopped mid-swipe up gesture which results
  in two issues:

  - it continues to register a page transition end callback, but because
    launcher is not drawing, the page will never scroll and the callback
    never happens
  - in the case where the calculated end target is RECENTS, we don't
    finish the recents animation (because of live tile), and since it's
    still running, subsequent gestures are interpreted as continuing the
    current gesture and it gets stuck

  Instead in these cases we can force the gesture to resolve to LAST_TASK
  (similar to the canceled gesture case), and not wait for the page to
  settle.

  Note, that we would prefer to fix the root issue of Launcher being
  stopped, but at least this change prevents Launcher from getting into
  the wrong state if so.

Bug: 246476942
Test: Repro steps from the bug
Change-Id: I59098229e5e37722e8017a2dfcb42eab6659643d
2022-09-13 06:59:34 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Andy Wickham 369c6e8be7 Reduces vertical padding of predicted apps in All Apps.
Rather than using the full allAppsCellHeight, manually construct
the icon + padding + text and add custom padding (8dp).

Screenshots: https://drive.google.com/drive/folders/1hgEE72PaTj60SxgfPUzQ8hGwnCOWx-Lp?resourcekey=0-TgrHKITyzIXmNAAMYpA_MA&usp=sharing

Fix: 242915342
Test: Manual inspection
Change-Id: Ic566e0f7ea7cf486054bb8fe2429ee5c53e8b174
2022-09-12 18:34:14 -07:00
Bill Yi b47585ce61 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours am: 771a57009d -s ours am: 90e1d38fd3 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: I2683cd987cae6b8f6f57824320cedcec4817df2b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:29:14 +00:00
Becky Qiu 1dce2a9394 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev am: a7be354913 am: d91561558d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890488

Change-Id: Ib07934c05c27c007823e3c0829f587a9cf4cf8c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:28:25 +00:00
Bill Yi 7009042d0d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours am: f58790063d -s ours am: ea6c8dfa2c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: If092526bda819fd714292da2a2b0f8b8ef172d57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:24:15 +00:00
Bill Yi 90e1d38fd3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours am: 771a57009d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: Ibdbaa26bd5044b40abbe7dad6acc8baec41025b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:22:57 +00:00
Becky Qiu d91561558d Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev am: a7be354913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890488

Change-Id: I4c5adf006ebf9c4707148a208b2c0208f04efdf5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:02:54 +00:00
Bill Yi ea6c8dfa2c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours am: f58790063d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: Ie9a419cd9ea9e52a5463edf1c879a890cada085f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 00:52:34 +00:00
Bill Yi 771a57009d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: I0e3ecc35d906ec049a744d60a903825a19d9328a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 00:40:31 +00:00
Becky Qiu a7be354913 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev 2022-09-13 00:33:26 +00:00
Bill Yi f58790063d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: I534816600fbcfef59adb17cfe5103ec10e499c3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 00:26:42 +00:00
Android Build Coastguard Worker fb59aa0c3b Snap for 9053530 from d581f40b30 to tm-qpr1-release
Change-Id: I3b6270f50cc77094c6a9f86b649d00ba5b555362
2022-09-12 23:29:11 +00:00
Sunny Goyal 42beb544e9 Removing UiThreadHelper and moving code to corresponding classes
This allows for better code organization based on the code logic

Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
TreeHugger Robot 5f65e29d27 Merge "Removing some unused code:" into tm-qpr-dev am: d581f40b30 am: e6f7559b8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914949

Change-Id: I47ac6650d9c5ba65aab59099662bf9e904a25101
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:32:21 +00:00
Brandon Dayauon cda6cd412a Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev am: f17c581165 am: 27b479a29b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914917

Change-Id: Ie7bb7cf03e573bc410a2df90a5793eeec2ca50ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:32:13 +00:00
TreeHugger Robot 7ef9220555 Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c am: 8563855387
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490

Change-Id: I47fd27284002803817d2bd3b549cac7a78ee23fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:31:37 +00:00
Vinit Nayak ebd04c4bc1 Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce am: 1f97ccf5e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686

Change-Id: I11d27495a0aaa09ebcd376fd38ad96721562eb63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 20:29:41 +00:00
TreeHugger Robot e6f7559b8c Merge "Removing some unused code:" into tm-qpr-dev am: d581f40b30
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914949

Change-Id: I176ca6e8d2cd780f9e470693a83908f90047e21e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:54 +00:00
Brandon Dayauon 27b479a29b Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev am: f17c581165
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914917

Change-Id: Ibeb53734770b3a854cb209e838fe06a6d3581ecd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:44 +00:00
TreeHugger Robot 8563855387 Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490

Change-Id: Ia6a7f74c9a7ede2a41164fe68a271e94dcb7b724
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:16 +00:00
Vinit Nayak 1f97ccf5e2 Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686

Change-Id: I40fbd2314fc02db46682e99057c365bae3973e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:58:44 +00:00
TreeHugger Robot 4b10da7f2e Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-09-12 19:33:00 +00:00
Sunny Goyal 20bbe95ddb Updating the scroll calculation from recyclerView to avoid view inflation
> Updating the LayoutManager's scroll calculation instead of a separate
  implementation to better support recyclerView's calculations
> Caching the view sizes during layout to avoid view-inflation for
  unknown types
> Fixing scrollbar jump during scroll when widget list is expanded
> Fixing scrollbar never reaching end when onboarding card is displayed
  in work tab

Bug: 240343082
Test: Verified on device that new views are not inflated
Change-Id: Ied11ccf65b053691c5c126c4bf8de306ec24786d
2022-09-12 12:24:34 -07:00
TreeHugger Robot d581f40b30 Merge "Removing some unused code:" into tm-qpr-dev 2022-09-12 19:24:20 +00:00
Brandon Dayauon f17c581165 Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev 2022-09-12 19:15:20 +00:00
TreeHugger Robot 7d8ba14b3c Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev 2022-09-12 18:30:47 +00:00
Vinit Nayak f5e5c8e1ce Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev 2022-09-12 18:29:22 +00:00
Sunny Goyal cae104baaf Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171 am: 5145e474d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471

Change-Id: Ia297ef33280ec46a6222781f43ae6dc1b813bd4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 18:00:45 +00:00
Sebastian Franco 5434c9d370 Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch
Now TestWorkspaceBuilder has the logic to add hotseat icons and
the operations to add items to the Workspace is done in batches
which is faster and more stable. To submit everything in batches
it uses the FavoriteItemsTransaction.

This improves the design because TestWorkspaceBuilder and
HomeScreenImageTest belong to the Test layer and they should
only deal with the logic to run a test and TestWorkspaceBuilder
is the Model layer and holds all the logic to interact with the
Launcher model/data, so this separates the concern of each class.

Also, chagned the name from CellLayoutBoardBuilder to
TestWorkspaceBuilder to make it clearer.

Bug: 243440737
Bug: 235518637
Bug: 242323136
Test: atest HomeScreenImageTest
Test: atest ReorderWidgets
Change-Id: I14eef064fade153b8362537743b061958bb3071d
2022-09-12 10:54:53 -07:00
Sunny Goyal 5145e474d6 Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471

Change-Id: I2958d9cd87323c5a3934904120d550fbb2d2f411
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 17:16:38 +00:00
Winson Chung 252ec11e4e Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-12 16:04:56 +00:00
Sunny Goyal 676d19c171 Merge "Removing back-button alpha animation code" into tm-qpr-dev 2022-09-12 16:04:34 +00:00
Luca Zuccarini ce03c9972b Fix issue with keyboard disappearing too late.
This seems to have been caused by a bad merge which removed the call
from outside the end listener. We reintroduce it for atomic animations
only, as for manual ones we want the keyboard to animate in sync with
All Apps (note that this is how it used to be, and doesn't depend on the
keyboard sync flag).

Fixes: 243632287
Fixes: 240116666
Test: manual
Change-Id: I9d226a4bd7cbde0692ae82b5a138b0d523fd5f25
2022-09-12 11:01:31 +00:00
Android Build Coastguard Worker 85b5ef43f7 Snap for 9050073 from 30c3552e7e to tm-qpr1-release
Change-Id: Icce95a4472b89d983e84a0c1f391ffb5dcfa1de7
2022-09-12 01:25:26 +00:00
Bill Yi 3600979da3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1b516c078cb6441705244d00210475a372fba4e7
2022-09-11 14:57:09 -07:00
Bill Yi b1360ad0d9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8e28cc8f62473fe165827b1c92c566b3ad4f1e0b
2022-09-11 14:56:37 -07:00
Bill Yi 20259afc32 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie6e6dd8081cf8b0bcbd23e13568b8d7c135c438e
2022-09-11 11:41:07 -07:00
Android Build Coastguard Worker 470e87dbe0 Snap for 9050009 from 69b9e736a8 to tm-qpr1-release
Change-Id: I695e33602c1ad09edb6ebeeb32e1e73c749b52cf
2022-09-10 21:24:53 +00:00
Qing Wang 67e22eff1f Add tests to Launcher P0 CUJ Homescreen navigation via TAPL. am: 30c3552e7e am: 46320961b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19773679

Change-Id: I4f1b1330c4084e09c6af077803c9abbc17d57d46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 20:39:36 +00:00
Qing Wang 46320961b9 Add tests to Launcher P0 CUJ Homescreen navigation via TAPL. am: 30c3552e7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19773679

Change-Id: Ic6c93ba67f635f6523487848665569e67d83c990
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 20:08:27 +00:00
Qing Wang 30c3552e7e Add tests to Launcher P0 CUJ Homescreen navigation via TAPL.
1. Implement API to help to get page count.
2. Add test add and delete page.

Bug: 241685418
Bug: 232584721
Test: android.platform.test.scenario.launcher.integration_tests.ScreenNavigationTests#testAddAndDeletePageAndFling
Change-Id: I2e04b9ef1f2ca65ba14d6939b7b51fead6b6f6ca
2022-09-10 17:46:24 +00:00
TreeHugger Robot a620d5276a [automerger skipped] Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev am: 69b9e736a8 am: 81209bb59f -s ours
am skip reason: Merged-In I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0 with SHA-1 4758ff0ae4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914922

Change-Id: I6bf9241758437f00bb5bfeb85c005783210cf83d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 05:54:46 +00:00
TreeHugger Robot 81209bb59f Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev am: 69b9e736a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914922

Change-Id: I42ce34aed46e52caa44246c9d026c3334948f79e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 05:25:36 +00:00
TreeHugger Robot 69b9e736a8 Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev 2022-09-10 05:03:23 +00:00
Sunny Goyal 8958a7078a Simplifying hideKeyboardAsync method
Bug: 246000321
Test: Presubmit
Change-Id: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
Merged-In: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
2022-09-10 04:01:48 +00:00
TreeHugger Robot 99972d2320 Merge "Simplifying hideKeyboardAsync method" 2022-09-10 02:10:44 +00:00
TreeHugger Robot 7389ee2f2f Merge "Support for animating A-Z <-> Search." into tm-qpr-dev am: 1c22b7e57c am: be89a7dec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19629606

Change-Id: Id75b1e316424734e67c293634c47c63de18c9561
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 02:00:03 +00:00
TreeHugger Robot be89a7dec5 Merge "Support for animating A-Z <-> Search." into tm-qpr-dev am: 1c22b7e57c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19629606

Change-Id: I929445576fd355da24385d95221a529be7fbf5d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 01:30:17 +00:00
Android Build Coastguard Worker 518a7b15bb Snap for 9048375 from 5d7aec8e03 to tm-qpr1-release
Change-Id: Ia87b6ab8c70ce96760b26e347228deb01ce99d84
2022-09-10 01:26:07 +00:00