Commit Graph

60459 Commits

Author SHA1 Message Date
Jeremy Sim 3ad08cd2b8 Merge "Fix issue with Overview thumbnails appearing blank in certain situations" into tm-qpr-dev 2022-09-19 19:56:57 +00:00
Jeremy Sim a4ba516797 Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition
This change updates the animation for confirming a split.

Includes:
- New timings
- A new interface, SplitAnimationTimings, that centralizes timing values for splitscreen animations

Fixes: 241126570
Test: Manual
Change-Id: I61339964a7254618b368b17f00fda8f5efb53de4
2022-09-19 12:04:33 -07:00
TreeHugger Robot 8eed4f30a9 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5 am: ab6be24eec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Ie607c03fb5aa6ca01648ebfeeba10cecf2d3bf80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 18:30:23 +00:00
Sunny Goyal e41c5b005f Fixing nullPointerException is RotationHelper
Bug: 247055735
Test: Verified on device
Change-Id: Ie73be138bdb616fb9db739b09c12794d61183657
2022-09-19 11:02:04 -07:00
TreeHugger Robot ab6be24eec Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Id7d92e7b4c432e8caafb92b62956387bd0c1e42e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 17:45:38 +00:00
Bill Yi 709fb169dd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I167d992ece381344cd5fcb40e4414cc17e77ccfa
2022-09-19 10:30:24 -07:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Luca Zuccarini be1a7a453c Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev am: 3fe8d2c9fa am: 62193df059
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852198

Change-Id: Ibd10956e50046cac860645460b15999af713542b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 17:07:59 +00:00
Luca Zuccarini 62193df059 Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev am: 3fe8d2c9fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852198

Change-Id: I282bad334d5768df896e54f1f5c4e6553ae993f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 16:11:36 +00:00
Luca Zuccarini 3fe8d2c9fa Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev 2022-09-19 15:36:59 +00:00
Nicolo' Mazzucato d2521bf843 Fix LauncherInstrumentation for OOP tests from gradle
The previous logic was assuming that if the test and target package were different, the target one was the launcher.

However, in the sysui-studio case, the packages are different despite none of the packages being launcher.

This detects if the test process is a gradle instrumentation, and if so selects the default launcher package name.

Test: locally with sysui-studio + presubmits
Bug: 234414088
Change-Id: Ie625e7d526f254f4b5f66b3a2b989d02eb95ac9c
2022-09-19 14:35:53 +00:00
Android Build Coastguard Worker 304dd1abc4 Snap for 9077201 from c528e7e818 to tm-qpr1-release
Change-Id: Ic3644bd3775e772fa0a274c05d97a71d804c2375
2022-09-18 00:45:00 +00:00
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
Jeremy Sim 85397e333f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818 am: 69a22b907f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: I807a208f233234a6dd35ac6de5546fb0b824ccc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:50:56 +00:00
Jeremy Sim 69a22b907f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: Ib408c5b8f113d13a63fd6071283cdf73f69af74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:18:53 +00:00
Jeremy Sim c528e7e818 Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev 2022-09-17 21:45:24 +00:00
Alex Chau cdf753f7c6 Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev am: 7c8ee4f8de am: 4773a10dc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886864

Change-Id: Icba9ad1d97653b379642bf1611b59cc65bd614eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 05:04:11 +00:00
Alex Chau 4773a10dc2 Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev am: 7c8ee4f8de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886864

Change-Id: I06694418da1b2d7c13fa5976b5780c2c7807ceca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 04:31:51 +00:00
Alex Chau 7c8ee4f8de Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev 2022-09-17 03:30:32 +00:00
TreeHugger Robot abda780906 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev am: 17c4741432 am: 4e758bfc23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19980314

Change-Id: I6a3e8e4479d9ac04a59b924ef5dc9e0264e27485
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 02:39:10 +00:00
Holly Jiuyu Sun 0efe4cf313 Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev am: a6f9b4b76b am: f0a4b7dfcd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956349

Change-Id: I782f141b023938d159c3f3a567ba2b0dd339f309
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 02:38:57 +00:00
TreeHugger Robot 4e758bfc23 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev am: 17c4741432
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19980314

Change-Id: I96b1a2b01dfeef76bd3a9ba74599823dd76d30a6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:53:11 +00:00
Holly Jiuyu Sun f0a4b7dfcd Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev am: a6f9b4b76b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956349

Change-Id: I171d868062472749de8955f4e4e6f857a36ec922
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:52:58 +00:00
TreeHugger Robot 17c4741432 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev 2022-09-17 01:47:48 +00:00
Holly Jiuyu Sun a6f9b4b76b Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev 2022-09-17 01:34:45 +00:00
Android Build Coastguard Worker 54fa8131eb Snap for 9075033 from 455c942fd2 to tm-qpr1-release
Change-Id: I5f91680b6970789cd7b1cd95efedb955380068cf
2022-09-17 01:25:41 +00:00
TreeHugger Robot ca5a1a6c60 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2 am: cd4951f54b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: I5f9c405e1bff93b3e96b051bcb9b6ad0a87eecb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:14:58 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot cd4951f54b Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: Ia1d1167c24cab50d1fca936c5e976fa85edcb853
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 23:46:44 +00:00
Vinit Nayak d887b56183 Reset TaskView transformations on orientationHandler change
* Transformations in the old orientation handler
(ex. translate X for portrait) aren't reset when
device changes to fake landscape (starts modifying translate Y).
The new translations are picked up correctly, this resets the
old ones.

Test: Bug no longer repros.
Rotated device while scrolling through tasks, no change in
behavior from before.
Can't think of other instances where tasks are in motion
and orientation handler can change.
Fixes: 233316942

Change-Id: Ie07340e69a2c93b71b1dabb8029c96ad05a4d4a1
2022-09-16 16:45:50 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sunny Goyal bb5ebb7f2d Updating the title of the Add to homescreen prompt to the requesting app
instead of the Launcher name

Bug: 239055068
Test: Verified on device
Change-Id: I1494d911565ddf3a598f9fbf372b8d784a4276e4
2022-09-16 15:54:53 -07:00
Jeremy Sim 7917ff31cc Fix two bugs with rotation in split select state
This CL fixes two bugs that were triggered by rotating in split select state:
1) Rotating in split select state will no longer cause a jittery animation to play
2) Initiating split from home, then rotating will no longer create extra split placeholders on screen

The bugs were present because handleSplitSelectionState() animated every state transition into SplitSelect, including SplitSelect > SplitSelect (which happens when rotating). This caused a jittery animation to play, and in certain cases, caused additional copies of FloatingTaskView and SplitInstructionsView to be created.

Fixed by auto-skipping animations for SplitSelect > SplitSelect, and by safely removing views when entering SplitSelect (to prevent duplicates).

Fixes: 242965515
Fixes: 243088958
Test: Verified visually on-device.
Change-Id: Iab813b1fe599bfdc550fe9a1d354b28cedb4b659
2022-09-16 15:28:33 -07:00
Yein Jo 40a0690301 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev am: dfaabbb499 am: f8804d8ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19934356

Change-Id: I5843a470ee7194f84899ad8fa3426c9c4af6d178
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 22:13:10 +00:00
Andy Wickham 05e2e266af Merge "Pivot search results scale around top of view." into tm-qpr-dev am: 455c942fd2 am: 92574a99f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956355

Change-Id: Ia4b2eb1478ac0159a87ed8a97c60c7c373926ea5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 22:12:31 +00:00
Yein Jo f8804d8ccd Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev am: dfaabbb499
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19934356

Change-Id: Ib3ac38f3706abc7763d176c8bc065472e8e07289
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 21:55:41 +00:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Andy Wickham 92574a99f5 Merge "Pivot search results scale around top of view." into tm-qpr-dev am: 455c942fd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956355

Change-Id: Ibb3581e52154d2f08929aeca604e9b25671e1a31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 21:42:29 +00:00
Holly Sun 98d6a4027a Clear the staled mFocusedView when toast surface is closed.
Test: manual
Bug: 224756660
Change-Id: Iadce94f9138ee375fa9b6e3ef8fb685847312045
2022-09-16 14:28:23 -07:00
Andy Wickham 455c942fd2 Merge "Pivot search results scale around top of view." into tm-qpr-dev 2022-09-16 21:17:26 +00:00
Hongwei Wang 2515a14429 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0 am: 334b1e0ee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: I964f5f6c6984a4d2b5e1fa85fd6c480ea3cf568c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 20:37:07 +00:00
Hongwei Wang 334b1e0ee6 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: Id300bb64efa51ca5956fea8bac36b653b732d1c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 20:08:46 +00:00
Hongwei Wang 93f650d3e0 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev 2022-09-16 19:26:33 +00:00
TreeHugger Robot 5a469bd163 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12 am: d7d05d1d7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: I3729ee399399d7bbea5e0569f132ce53690b45df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:21 +00:00
Sebastián Franco f1aa20d811 Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev am: 09a98dfdbd am: 47c78bed9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969101

Change-Id: I01ad05d37ca822f501e6f2520249734c7e9de167
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:11 +00:00
TreeHugger Robot d7d05d1d7a Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: Iddbb6898e4acecd61b10a30fefc3fe3134869205
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:22:10 +00:00
Sebastián Franco 47c78bed9b Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev am: 09a98dfdbd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969101

Change-Id: I5d72dfcfbdc14118dbf7bda37f4121b4d5d12421
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:21:21 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Sebastián Franco 09a98dfdbd Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev 2022-09-16 16:49:26 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00