Commit Graph

16456 Commits

Author SHA1 Message Date
Stevie Kideckel 47f935dbbe Add the DefaultItemAnimator, without change animations
Change animations cause the addition of another view to be able to
crossfade/interpolate the two. Disabling change animations prevents us
losing the focus when a header row changes due to expanding or
collapsing.

Test: verified locally
Bug: 183378651
Change-Id: I07837b41748b5206936321c08d376069fa81b363
2021-05-26 17:08:18 +00:00
Lais Andrade b1ef5e5c55 Add haptic feedback to Launcher recent apps scrolling
Add light LOW_TICK effects when the scrolling on RecentsView
snaps to a page, and a stronger TICK effect when the edges
absorb the scroll (by scrolling fast towards one of the edges).

Fix: 182382085
Test: manual
Change-Id: Ifb917ae499f73607707773f9870eb39cd6fe16ef
2021-05-26 13:37:30 +01:00
Stevie Kideckel 5d9704b8bd Merge "Remove intrinsic padding from widget previews" into sc-dev am: fa7c98ee45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14719550

Change-Id: Id26445a7f7d75d2258c8b2c888043a4e9e808df6
2021-05-26 09:40:53 +00:00
TreeHugger Robot af76459cc4 Merge "Update Gesture nav tutorial." into sc-dev am: 694b667138
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14669183

Change-Id: Ide38747f0b1a2bcf6f76921fb9650ee7d188dad7
2021-05-26 09:39:53 +00:00
Stevie Kideckel fa7c98ee45 Merge "Remove intrinsic padding from widget previews" into sc-dev 2021-05-26 09:27:11 +00:00
TreeHugger Robot 694b667138 Merge "Update Gesture nav tutorial." into sc-dev 2021-05-26 09:20:18 +00:00
Samuel Fufa 7c6515f59e Merge "[Search] Resolve afterimage when closing allapps" into sc-dev am: 53ec9a4e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14722826

Change-Id: I78761a5b262e7c182eeeab44aebdcb46e62a7c45
2021-05-26 00:46:06 +00:00
Samuel Fufa 53ec9a4e06 Merge "[Search] Resolve afterimage when closing allapps" into sc-dev 2021-05-26 00:42:58 +00:00
TreeHugger Robot a8c8b9d88d Merge "Crossfading splashscreen if icon is themed" into sc-dev am: 55060ca7ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14687100

Change-Id: I77a11e42d2704a07c2a3a9307c79dcab6cbdb69c
2021-05-26 00:31:04 +00:00
TreeHugger Robot 55060ca7ea Merge "Crossfading splashscreen if icon is themed" into sc-dev 2021-05-26 00:26:22 +00:00
TreeHugger Robot 89c8b063eb Merge "Overview - Remove the space withheld for proactive chips" into sc-dev am: d98a784d0e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14706422

Change-Id: Idaaa1ab0c829f0e65ca6131cceda25f502914b10
2021-05-26 00:16:14 +00:00
TreeHugger Robot d98a784d0e Merge "Overview - Remove the space withheld for proactive chips" into sc-dev 2021-05-26 00:11:18 +00:00
Vinit Nayak 3716f61615 Merge "TaskMenu in overview UI polish" into sc-dev am: b74b9d2966
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14604156

Change-Id: If7567a5c2639b03d95ffb1b34bf3466858d2f67d
2021-05-26 00:01:48 +00:00
Vinit Nayak b74b9d2966 Merge "TaskMenu in overview UI polish" into sc-dev 2021-05-25 23:56:00 +00:00
Steven Ng 1ef7e145d2 Fix add extra empty screen logic
The bug occurred when there are two widgets in a CellLayout. When
dragging one of the widget, ShortcutAndWidgetContainer#getChildCount
returns 1 rather than 2 because the LauncherAppWidgetHostView of the
widget in drag has been detached from its parent and reattached to
DragView (introduced in ag/14234627).

Test: Place only two widgets on the last page of the home screen. Drag
      one widget. The new page indicator on the right is shown.
Bug: 188494523
Change-Id: I8255dd1b72ad7f18f4cb35a9e14ac8e61804980c
2021-05-25 23:39:40 +01:00
Tony Wickham 8ac277ebd8 Taskbar drag starts internal pre-drag before system drag
- TaskbarDragController now extends DragController.
- Currently there is no pre-drag condition, so we immediately get onDragStart(), which starts the system global drag (which cancels the original internal drag).
- Make the original view invisible during the drag and drop operation, across both internal and system drag events.
- No longer handle onDragEvent() in TaskbarView, as TaskbarDragController handles all of it now.

Test: Drag and drop from taskbar still works (bonus: starts from the correct registration point that you touched down on). Locally added a PreDragCondition and verified a seamless handoff to system drag and drop when the pre drag end condition was met.
Bug: 182981908
Change-Id: I6bf48141a5eedfc6db6f461258e880ef8146e733
2021-05-25 15:35:58 -07:00
Tony Wickham c7cbf254f3 Let DragView use ActivityContext instead of Launcher
- Make DragView abstract and extended by LauncherDragView for the explicitly Launcher-specific parts.
- Some other methods like Utilities.getFullDrawable() now accept (Activity)Context rather than Launcher.

Test: Compiles and runs, manual drag and drop
Bug: 182981908
Change-Id: I77b7a2e48ce864dd711c3232217fdba4d60c546f
2021-05-25 15:35:55 -07:00
Samuel Fufa 41f15a107f [Search] Resolve afterimage when closing allapps
Preview: https://drive.google.com/file/d/1AM6WAY4kImCgHueNvH6eXUtnHgK3U6vo/view?usp=sharing&resourcekey=0-3mzBobzFuzQXCNZRUlToYA
Test: Manual
Bug: 184711608
Bug: 188556051
Change-Id: Ib43c71083460c236347dd1f340b1ad95d7d4aa15
2021-05-25 17:34:18 -05:00
zakcohen dad8a80d19 Overview - Remove the space withheld for proactive chips
Remove the space in the ui that was being used for chips.
Centralize some of the logic around calculating the action margins to aid
that.

Bug: 179922117
Test: Local build and flash and run
Change-Id: Icd2f894c858fab475c5411f3f7c412b899d5b220
2021-05-25 15:29:08 -07:00
Steven Ng 0bc0f10aac Merge "Fix tabs abruptly reset during swipe" into sc-dev am: 530f644788
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690878

Change-Id: I0fdaead265b85eac1221add68a0d1ca8ed20331f
2021-05-25 22:23:54 +00:00
Steven Ng 530f644788 Merge "Fix tabs abruptly reset during swipe" into sc-dev 2021-05-25 22:21:25 +00:00
TreeHugger Robot 9d308d0af0 Merge "Fix full widgets picker fast scroller height." into sc-dev am: 17385ce33e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14683794

Change-Id: I778e855c91ace63fc7386a6995056adf4fe9e228
2021-05-25 22:16:12 +00:00
TreeHugger Robot 17385ce33e Merge "Fix full widgets picker fast scroller height." into sc-dev 2021-05-25 21:43:40 +00:00
Vinit Nayak 063cb2d892 TaskMenu in overview UI polish
Bug: 188168717
Test: TaskMenuLooks closer to mocks.
Change-Id: I1560b66a48c4c70c7c79f7307b2b76f22e30c653
2021-05-25 14:42:35 -07:00
Schneider Victor-tulias 8a3a857668 Update Gesture nav tutorial.
- Seperated back left and right edge tutorial steps
- updated back left and right tutorial step strings
- Removed feedback view timeout
- Added accessibility focus on title when feedback view appears
- Added logic to show feedback when the tutorial fragment is stopped then resumed

Test: manual

Bug: 169687177
Fixes: 188116424
Fixes: 188115939
Fixes: 188124784
Fixes: 188555152
Fixes: 188972969

Change-Id: I97755a455bf3fa4674955d5cc91ed8b02f484b76
2021-05-25 14:16:41 -07:00
Winson Chung e6ba6cf940 Merge "Revert "Enable SplitSelect flag by default"" into sc-v2-dev 2021-05-25 20:27:49 +00:00
Winson Chung bdaa6036ec Revert "Enable SplitSelect flag by default"
This reverts commit 3f47826339.

Reason for revert: b/189245318

Bug: 189245318

Change-Id: I5e6704711cc7577102123ffc67c97a5644e7e86b
2021-05-25 20:26:01 +00:00
Samuel Fufa 880fc577c0 Remove AllApps prediction edu
Test: Manual
Bug: 183579072
Change-Id: Ibaffc5ac711e35df5256baed8be57159046fbdda
2021-05-25 14:48:14 -05:00
Sunny Goyal 6ba7479cf5 Merge "Using icon color for dot and halo" into sc-dev am: 47da5d628c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14684870

Change-Id: I4683179ba16afb819a7059ea3fa5f1f2321c72ff
2021-05-25 18:43:35 +00:00
Sunny Goyal 867aeb5436 Merge "Updating method for getting themed icon" into sc-dev am: a71269e372
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14682086

Change-Id: I5a328837285d1600dd80d0ff9a17cf577f546210
2021-05-25 18:43:23 +00:00
Sunny Goyal c4c3269206 Crossfading splashscreen if icon is themed
Bug: 188840653
Test: Manual
Change-Id: Ibd00bb1a94576a7512872eba39a936c174f9871d
2021-05-25 18:25:18 +00:00
Sunny Goyal 47da5d628c Merge "Using icon color for dot and halo" into sc-dev 2021-05-25 18:24:56 +00:00
Sunny Goyal a71269e372 Merge "Updating method for getting themed icon" into sc-dev 2021-05-25 18:24:38 +00:00
Alina Zaidi ba4eaf73b5 Merge "Add more education tips for widgets. (1/3)" into sc-dev am: e6521ad542
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14620021

Change-Id: I5f8e69315a7752ac2bf0484ec5729016ee1a5687
2021-05-25 17:56:30 +00:00
Alina Zaidi e6521ad542 Merge "Add more education tips for widgets. (1/3)" into sc-dev 2021-05-25 17:35:27 +00:00
TreeHugger Robot 1919443e37 Merge "Enable SplitSelect flag by default" into sc-v2-dev 2021-05-25 16:29:10 +00:00
Stevie Kideckel 43a6be4b82 Remove intrinsic padding from widget previews
Also, scale down the preview size if it's wider than the target cell.

The intrinsic padding prevents the corners of the preview from being
rounded correctly and can lead to clipping or no rounding, especially at
larger sizes.

Bug: 187141692
Test: verified locally
Change-Id: Ie57ad57ba7c102330324bd0439acc55ff4fd83ff
2021-05-25 16:26:32 +00:00
András Klöczl adbe369451 Merge "Add two panel home support for page binding logic" into sc-v2-dev 2021-05-25 12:04:55 +00:00
TreeHugger Robot 4cd5fee186 Merge "Adjust padding, margin of tabs in the WidgetsFullSheet" into sc-dev am: 1002981fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14602830

Change-Id: Iab84c81890bbcc9ee50507513f62e0e8cddd812a
2021-05-25 11:59:13 +00:00
Alina Zaidi 9d24de1353 Add more education tips for widgets. (1/3)
Show Arrow education tip on WidgetsBottomSheet. This tip is shown only
once either in widgets full sheet or bottom sheet.

Test: Tested manually
Bug: 185354491
Change-Id: I6d770ed0906a5cb0f5bcfe6ae0cd327b790cf164
2021-05-25 10:50:02 +01:00
Steven Ng 21979aca50 Fix tabs abruptly reset during swipe
The indicator position has already been updated by
PersonalWorkPagedView#onScrollChanged. The updateIndicatorPosition
call in setActiveMarker has abruptly reset the mScrollOffset to a page
index rather than a [0f, 1f] offset.

Test: On a work profile device, swipe left & right in the all apps.
      Then, swipe left & right in the full widgets picker. In both
      cases, I no longer observe an abruptly reset of the tabs
      transition animation.
Bug: 187704466
Change-Id: I53c4ed3a98219093f3d61dfa4de2fe21ec88851c
2021-05-24 23:57:28 +01:00
Schneider Victor-tulias b199e20acc Enable unpausing apps from the workspace.
Fixes: 188675002
Test: manual
Change-Id: I02715450016e9b91fff774525b5e32c337c74547
2021-05-24 21:44:29 +00:00
Andras Kloczl 55edfe55f7 Add two panel home support for page binding logic
There's a logic which prioritizes the binding for the
current page and defers the other pages' binding.
If two panel home is enabled, we want to bind both pages
together. LauncherPageRestoreHelper has been created to
contain the logic for persisting restoring and calculating
which pages to load immediately.

Test: manual + run LauncherPageRestoreHelperTest robo test
Bug: 174464691
Change-Id: I57ac3f7150303b95b272e922f44bda26f9d5ce2a
2021-05-24 23:22:06 +02:00
Alex Chau 960a2b2696 Always focus a task in overview
- Focus first task when applying load plan
- Focus the next task in shorter row when focused task is dismissed, scale the snapshot and translate the task into focused position
- Always show actions view as there is always a focused task. Update scroll alpha when toggling grid enabled
- In fallback recents, take into account that home task will be dismissed when determining rows for the grid, ensuring next focused task won't affect row balancing
- Bring back clearAllShortTotalCompensation as there isn't always a snappedTaskView (e.g. when snapped to ClearAllButton)
- Ensure that getFocusedTaskView is only used when showAsGrid is true

Bug: 187839470
Fixes: 188001858
Fixes: 189057812
Test: manual
Change-Id: I6f31ef469c58fda70d2dd8caa2ee7d8a80c7f03b
2021-05-24 18:13:04 +01:00
Steven Ng e90dddaaa0 Fix full widgets picker fast scroller height.
1. Fix the app title to one line.
2. Use the measured height of a header view to estimate the available
   fast scroll bar height.

Test: Open full widgets picker. Scroll to the bottom by scroll gesture.
      Observe the fast scroll bar indicator is correctly shown.
      Scroll back to top and then use the fast scroll bar to scroll to
      the end of the page. Observe the last app row is aligned to the
      bottom of the page.
Bug: 188914448
Change-Id: I57a2419d1fbfc8f946a932eebfefb67ae0c07eb6
2021-05-24 18:05:56 +01:00
Steven Ng ede641bd77 Adjust padding, margin of tabs in the WidgetsFullSheet
Also remove elevation set to tab to remove unwanted shadow.

Test: Set up a work profile. Then, open the full widgets picker.
      Observe padding & margin of the work / personal tabs.
Bug: 188221455
Change-Id: I761cb1c1410f87c80a5fdca3803fb8b099d499d6
2021-05-24 11:40:16 +01:00
TreeHugger Robot b841731a35 Merge "Fixing missing unlinktoDeath" into sc-dev am: eb0a14ad79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14684233

Change-Id: I3acf3f5c5a340b3686e41e67fb885b072de44ead
2021-05-22 01:25:26 +00:00
TreeHugger Robot eb0a14ad79 Merge "Fixing missing unlinktoDeath" into sc-dev 2021-05-22 01:05:05 +00:00
Sunny Goyal b5596f72e4 Fixing missing unlinktoDeath
Bug: 186712316
Test: Manual
Change-Id: If06737403c346c5ccca533dec647e3a0691f1bfa
2021-05-21 15:29:33 -07:00
Sunny Goyal 6755587219 Using icon color for dot and halo
Bug: 188839628
Test: Manual
Change-Id: I8a393cc7073d5a249619b4033ec860c55f17167a
2021-05-21 12:57:38 -07:00