Commit Graph

16456 Commits

Author SHA1 Message Date
Andy Wickham 02db569cad Enables Enhanced Smartspace by default.
Bug: 187428578
Test: BinderTests.java, MemoryTests.java, manual
Change-Id: Iffc6ae9b79db47d0585486529d2d8dfdf0a24692
2021-07-23 12:40:59 -10:00
TreeHugger Robot 6d9e866669 Merge "Update hotseat sizing for 4x5 grids." into sc-dev 2021-07-23 22:39:48 +00:00
Jonathan Miranda 28713afa00 Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf am: 74aecceafa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: I65624cc951d45d62d04c47ff94fc7f20ca5080cc
2021-07-23 22:15:37 +00:00
Jonathan Miranda 65a42b6b90 Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf am: 3491abbc28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: Iffd30d24df93cb8ba4ed3ee600fef9d44a2aaf16
2021-07-23 22:14:23 +00:00
Jonathan Miranda 6fbcbc7a4c Merge "Add more extra space to hotseat for taller devices." into sc-dev am: 0c7153bbdf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15363650

Change-Id: I3ff54d0d1559305b8e501abeba31ab3cec8c37f1
2021-07-23 22:02:13 +00:00
Jonathan Miranda 0c7153bbdf Merge "Add more extra space to hotseat for taller devices." into sc-dev 2021-07-23 21:41:27 +00:00
Jon Miranda 80cddbccb6 Add more extra space to hotseat for taller devices.
Bug: 192520231
Test: manual test on taller devices
Change-Id: I3eccada67f0ba07d01f823c4156f02c3feb97f84
2021-07-23 20:01:16 +00:00
Jon Miranda 069f8c5ac9 Update hotseat sizing for 4x5 grids.
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.

Bug: 194435265
Test: 4x5 grid
      multiple devices,
      with: gesture nav enabled
            3 button nav enabled

Merged-In: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
Change-Id: I711e7d168b80254e73df0d4e1854756d819a705b
2021-07-23 18:47:33 +00:00
Jon Miranda 374336a571 Update hotseat sizing for 4x5 grids.
If the qsb bottom margin is smaller than the bottom insets,
we'll fall back to centering the qsb in the available freespace.

Bug: 194435265
Test: 4x5 grid
      multiple devices,
      with: gesture nav enabled
            3 button nav enabled

Change-Id: I9fd4f0da3f2bc9f0b38a621ad1192533260379e3
2021-07-23 18:46:31 +00:00
TreeHugger Robot 749f913562 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev am: 3f062ab8b6 am: e172950463
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365040

Change-Id: I1da273b116173f9f41b15f13f94e7636a85a1839
2021-07-23 18:41:23 +00:00
TreeHugger Robot 2ed55ed9de Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev am: 3f062ab8b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365040

Change-Id: I0fccfe7fdf32f7bcbcddb3633e34acb1c7c979f6
2021-07-23 18:23:49 +00:00
Alex Chau c1a459f633 Clean up debug flags and add more screen record am: 261708ba00 am: 4f7129330e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15371934

Change-Id: I5a22605150e3a8001fbc6ebf61e5263fdc736cf5
2021-07-23 18:22:25 +00:00
TreeHugger Robot 3f062ab8b6 Merge "Folder polish: unbold folder title, ensure icons not cropped in folder." into sc-dev 2021-07-23 18:10:48 +00:00
Alex Chau 261708ba00 Clean up debug flags and add more screen record
Bug: 193440212
Bug: 194484556
Test: manual
Change-Id: I1b09ae74462c86afb8effb0a2635fd0e70a59bf8
2021-07-23 15:42:01 +01:00
Jon Miranda f33f5b3fc5 Folder polish: unbold folder title, ensure icons not cropped in folder.
- Ensure folder items are scaled to fit within the height/width in 4x5 mode.
- This bug surfaced now since  we increased the icon size.

Bug: 194356039
Test: set display to large, set font to large
Change-Id: Ie360ca67c3c91649a471bce920b2fc6a82fb9661
2021-07-22 17:19:28 -07:00
Adam Cohen ec049b019d Fix widget drop preview outline on 4x5 grids am: ed82e0daef am: 8e1908da59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351419

Change-Id: Id5931118c3a6c3795142e5f246ff03a43e8dd255
2021-07-22 23:08:33 +00:00
Adam Cohen 2a0516f6cc Fix widget drop preview outline on 4x5 grids am: ed82e0daef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15351419

Change-Id: I37f0cde316ac0a4c7b793ad25b23d5208ca90b65
2021-07-22 22:55:49 +00:00
TreeHugger Robot 7e7f595719 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev am: f2af895b20 am: 092efed8d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081296

Change-Id: I6091d6c30f9392cb15566ef6eab00c57505bf0ef
2021-07-22 21:51:11 +00:00
TreeHugger Robot f2af895b20 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev 2021-07-22 21:17:35 +00:00
Vinit Nayak 7903758d08 Animate SplitPlaceholderView when entering split from overview
Bugs tracked in b/181704764

Bug: 181704764
Test: Tested on phone and large screen in multiple orientations

Change-Id: I07509006ae3d1f4425dc5119d0c8ed52b41a3bc2
2021-07-22 20:12:26 +00:00
TreeHugger Robot 85b38729a8 Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev am: d327290762 am: 3694d653c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302087

Change-Id: I438361fe609dcfe38d5455ceb3139d5e5784ae06
2021-07-22 19:40:16 +00:00
Adam Cohen ed82e0daef Fix widget drop preview outline on 4x5 grids
=> We were not account for mBorderSpacing in the outline calculation
=> This was fine in most cases as this value is 0, but 4x5 appears to be the exception

Bug: 194227752

Test: manual, see video in bug.
Change-Id: Ib590bc142a0f65e75f92ee057f8b4f4b0f81521b
2021-07-22 12:31:21 -07:00
TreeHugger Robot a914d2d70a Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5 am: 268dd89cb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118

Change-Id: Ia8971a215762c5f9b9e1a0a4b97da5ed3359a400
2021-07-22 19:22:41 +00:00
TreeHugger Robot d327290762 Merge "Removing UI dependency from LauncherModel in case of 2-panel layout" into sc-v2-dev 2021-07-22 19:16:52 +00:00
TreeHugger Robot c48e4fa64d Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev am: 6a01fe49a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359118

Change-Id: I0004e2f55347e018fa553f8b56c26a754a93e0f1
2021-07-22 19:11:55 +00:00
TreeHugger Robot 6a01fe49a5 Merge "Measure WidgetsFullSheet before estimating the recommended table size" into sc-dev 2021-07-22 18:53:32 +00:00
Sunny Goyal 12e3f1f2f7 Removing UI dependency from LauncherModel in case of 2-panel layout
Bug: 175939730
Bug: 192431856
Bug: 185515153
Test: Manual
Change-Id: I8baa1cf9e5a8a04d5b8bc38c1f4b0755265cd8a9
2021-07-22 10:34:25 -07:00
TreeHugger Robot f3a387d731 Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev 2021-07-22 16:49:35 +00:00
Steven Ng a606d344a6 Measure WidgetsFullSheet before estimating the recommended table
size

Issue: The header view height was obtained before any measurement.

Test: On Pixel 5 4x5 gird with Photo widget shown in recommended
      table, make the device in landscape. Then open the full widgets
      picker. The widgets picker can be scrolled. Before this fix,
      scrolling is not possible.
Fix: 194172597
Change-Id: Ib30cf4b95d2ed23ff28f3d24e103f0e919b3a551
2021-07-22 16:08:15 +01:00
TreeHugger Robot 58d6237dae Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev am: b971baefe1 am: 841fc730ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15346899

Change-Id: I02a14ea7f818f35f64f4d663ec897543458d1802
2021-07-22 12:38:55 +00:00
TreeHugger Robot b971baefe1 Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev 2021-07-22 12:05:03 +00:00
Thales Lima a66ee1ddda Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev am: 496ca0081e am: 016ba91625
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15337415

Change-Id: Ibc5d0f65082b8130cbadb362d54272a21b714989
2021-07-22 10:24:45 +00:00
Steven Ng 2b90d043f6 Fix scaling on widget previews that have width / height set to
wrap_content

If the widget preview has width / height set to wrap_content, we should
set the layout param width / height to the exact dimension after
measurement. Otherwise, we will end up clipping the previews.

Test: manual
Fix: 193144010
Change-Id: I101f7c6d3dbd264fee448b85c54029d5650d6630
2021-07-22 11:19:25 +01:00
Thales Lima 496ca0081e Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev 2021-07-22 09:41:56 +00:00
Thales Lima e445774ab5 launcher: correct page spacing for multiple panels
This fixes 2 things:
- adding the correct space between pages as insets (eg camera) were
being discarded
- adding the space between pages instead of between panels as was before

This solution should work with more panels and don't create problems for
phones, where panels = 1.

Fixes 193194192
Test: manual testing in unfolded state in portrait and landscape, both
rotations

Change-Id: Ia3b148ceb773c6d5b6f8848ced07d7f9c1459e92
2021-07-22 09:41:43 +00:00
Jonathan Miranda c2a49ee2bc resolve merge conflicts of 46378eb881 to sc-v2-dev
Folder icon polish.

- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 194339057
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Change-Id: I09ce9ef59e340b1009de3d26eed430a0a8dc4b33
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-22 00:43:27 +00:00
Jonathan Miranda 46378eb881 Merge "Folder icon polish." into sc-dev 2021-07-22 00:15:29 +00:00
Brian Isganitis 0ce2954d2b Support overriding All Apps EDU animation on drag am: ec4a56a311 am: 419b61df54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ided55e5c6e6a14ec2dee8e1776f3973f48d757e4
2021-07-21 20:26:26 +00:00
Brian Isganitis a9b1814d42 Support overriding All Apps EDU animation on drag am: ec4a56a311
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ie0caf9308989d8f3ba0b23ffb68b0157c5d2c22e
2021-07-21 20:15:33 +00:00
Brian Isganitis ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
Jonathan Miranda 3e3fab457c Merge "Folder icon polish." 2021-07-21 01:08:36 +00:00
Vinit Nayak fc02d3cf4a Merge "Move NavButtons to end of taskbar" into sc-v2-dev am: 6d2dd7a9e4 am: ce6907de48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15329808

Change-Id: I512d85536566883829bd3345c216248b06e00303
2021-07-21 00:44:42 +00:00
Brian Isganitis d9d525236a Merge "Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"" into sc-dev 2021-07-21 00:37:36 +00:00
Vinit Nayak 6d2dd7a9e4 Merge "Move NavButtons to end of taskbar" into sc-v2-dev 2021-07-21 00:11:31 +00:00
Jon Miranda 92c1b5d3ab Folder icon polish.
- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
Change-Id: Ic3708bd402704f0a6f57ae5315ef602e2bbc6d82
2021-07-20 22:16:21 +00:00
Jon Miranda 2cc564c647 Folder icon polish.
- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Change-Id: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-20 22:13:56 +00:00
Vinit Nayak 8dcbde87c0 Move NavButtons to end of taskbar
* Layout hotseat icons from the end instead of the start
* IME down and system back arrow are now separate views

Bug: 191399224
Test: Tested w/ RTL + LTR in gesture
and 3 button nav w/ and w/o IME

Change-Id: I4d0ecd0bee0c519892c63eeefef45055b26d349b
2021-07-20 13:55:37 -07:00
Hyunyoung Song bfe32f7ad8 Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev am: 56c33c3cb8 am: 3e4bd6c3ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331688

Change-Id: Iacb2908d200f5ce8c0fa557cda7394db5ce04bd1
2021-07-20 19:48:10 +00:00
Hyunyoung Song 46255ad68e Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev am: 56c33c3cb8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331688

Change-Id: I103161ef85f4f546399793b40aa7054263e64c84
2021-07-20 19:36:14 +00:00
Hyunyoung Song 56c33c3cb8 Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev 2021-07-20 19:06:36 +00:00