Commit Graph

16456 Commits

Author SHA1 Message Date
Jon Miranda 26de7be984 Fix NPE when converting final screen to empty screen.
Bug: 194553613
Test: manual
Change-Id: Id29b8574964688f6f6aa96dd5b1b8a4d8b9110c0
2021-08-16 16:47:11 +00:00
Sunny Goyal 77acf12905 Fixing header jump
Linking header position to an empty entry in the recyclerView,
instead of calculating the vertical scroll position. This
allows the header to be in sync with the recyclerView scroll and
item animations

Other simplifications:
> Moving top collapse handle out of header view (it doesn't scroll)
> Removing background clipping logic from full-sheet
> Moving tab bar inside the header view

Bug: 196464142
Test: Verified on device
Change-Id: Iae5a0ae9af7ce258e1b391b8e85c5c270fe56197
2021-08-16 09:45:14 -07:00
Alex Chau f551c876e4 Merge "launcher: hide grid options for foldables" into sc-v2-dev am: 0cba30e990 am: 298db67fd8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472531

Change-Id: I82d22dcb706ca5ab2ba83a5994e801c3f369d022
2021-08-13 22:10:36 +00:00
TreeHugger Robot 219dff2349 Merge "launcher: correct the amount of padding for preview" into sc-v2-dev am: f952fd9256 am: 9f76d9d09a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15547452

Change-Id: I1dd9dd360249bdc6545e53498e632a5bad977586
2021-08-13 22:07:49 +00:00
Alex Chau 1e4484669d Remove widget panel
- Remove all usage of LEFT_PANEL_ID and fixed left panel code
- For preview renderer, load screen 0 + screen 1 instead
- Added a split display specific default workspace layout, with a placeholder app to pass test before we implement page pairing(b/196376162)
- Known issue: If screenId 1 is deleted, right panel will disappear from Wallpaepr & Style because there is no screenId 1. Will be resovled after page pairing(b/196376162)

Bug: 175939730
Test: manual and TaplTestsLauncher3#testWorkSpace
Change-Id: Icac1c94165c14a49c17897c45355b6cdc4d87e91
2021-08-13 21:48:35 +01:00
Alex Chau 0cba30e990 Merge "launcher: hide grid options for foldables" into sc-v2-dev 2021-08-13 20:44:34 +00:00
TreeHugger Robot f952fd9256 Merge "launcher: correct the amount of padding for preview" into sc-v2-dev 2021-08-13 19:19:18 +00:00
Thales Lima dab1b2922c launcher: correct the amount of padding for preview
The padding on left and right should be added only on the left for left
page and only on the right for right page.

Fixes: 195410512
Test: open Wallpaper & Style and check the space between the pages
Change-Id: Ib27c632d2fb07d4708bd101e555e14e31a26ff9d
2021-08-13 18:22:26 +01:00
Thales Lima 7ec8382044 launcher: hide grid options for foldables
Some grid options are too dense for foldables (those with 5 icons), so
we are hiding them on those devices.

This also move the parsing to be done on InvariantDeviceProfile only.

Fixes: 183140646
Test: open Wallpaper & style and change app grid options
Change-Id: I771571db02709db5d0f814236060c57ce0180cd1
2021-08-13 16:07:05 +00:00
TreeHugger Robot 21cb8f7bd0 Merge "Update two panel specific launcher home icon sizing" into sc-v2-dev am: 00d0ce9b3b am: 39a93b1d8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15472539

Change-Id: I4df81aeab62eb168bb6202b2a3f806e186349b00
2021-08-13 01:41:13 +00:00
Sunny Goyal 57e0866fdd Fixing ModelPreload cancelling existing load
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.

> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
  empty callbacks

Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
2021-08-12 21:33:33 +00:00
TreeHugger Robot 4e9ea58712 Merge "Clean up test logging and ScreenRecord" into sc-v2-dev am: 662af98956 am: 3c7c23aa02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15542317

Change-Id: I98e7524b37523af64d992768ee073293e748eb71
2021-08-12 18:35:46 +00:00
Andras Kloczl 30fe9152d5 Update two panel specific launcher home icon sizing
Test: manual
Bug: 191879424
Change-Id: I4f51616004d78036ad801298bb5ba72af8de3f30
2021-08-12 18:46:01 +01:00
TreeHugger Robot 662af98956 Merge "Clean up test logging and ScreenRecord" into sc-v2-dev 2021-08-12 17:26:48 +00:00
Alex Chau 542816f3ce Merge "Logging fist event not from test" into sc-v2-dev am: 592889d089 am: cdb651c248
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15534290

Change-Id: Ia052e6ea3a38231eff296941b80d0bdfd6a397bf
2021-08-12 12:00:40 +00:00
Alex Chau 592889d089 Merge "Logging fist event not from test" into sc-v2-dev 2021-08-12 10:41:10 +00:00
Alex Chau 2886a13d7a Clean up test logging and ScreenRecord
Bug: 194114179
Bug: 193125090
Test: manual
Change-Id: I086d011a39b74a24d5629d43dc74b741fcf5994e
2021-08-12 11:34:27 +01:00
Steven Ng 749f8c54cd Fix pending restore widget touch issue am: bdffb53843 am: 8facf46000
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15517689

Change-Id: I4ce17b8b2c3ac35d7cecc58813e148784869fda9
2021-08-11 23:58:04 +00:00
Steven Ng 237a1236d0 Fix pending restore widget touch issue am: bdffb53843 am: 95439ffdcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15517689

Change-Id: Ib92420ee6bf644413fda35febd94bc7dc5725fef
2021-08-11 23:57:24 +00:00
Steven Ng 638597aae1 Merge "Preview layout scaling for RemoteViews preview" into sc-v2-dev am: b014e9098b am: bf99115554
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15517677

Change-Id: Id9d70eb074dddadb306145d8ee6d0355f2e85d41
2021-08-11 22:46:30 +00:00
Steven Ng b014e9098b Merge "Preview layout scaling for RemoteViews preview" into sc-v2-dev 2021-08-11 21:59:45 +00:00
Steven Ng bdffb53843 Fix pending restore widget touch issue
After http://ag/14980850, we block updateAppWidget until app widget
is restored. However, PendingAppWidgetHostView constructor relies
on updateAppWidget(null) to trigger set listener in getDefaultView().
We should call super.updateAppWidget(null) in the constructor instead.

Test: manual
Bug: 14980850
Change-Id: I30af9778a636af2ad822e7abc152b6f0bfdea1bf
2021-08-11 22:40:06 +01:00
vadimt e7fbe56b74 Logging fist event not from test
Bug: 189874683
Test: I didn't test this
Change-Id: I6808d09ffa1700b02596b585f36dadbd5242e3ef
2021-08-11 12:54:47 -07:00
Nick Chameyev 41bbb285a7 Merge "Add unfold animation to launcher icons and widgets" into sc-v2-dev am: 02c0c924a6 am: 79690a5b74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15390834

Change-Id: I28062ec9243c25e44ae496647475d13da74fe239
2021-08-11 18:30:29 +00:00
Nick Chameyev 02c0c924a6 Merge "Add unfold animation to launcher icons and widgets" into sc-v2-dev 2021-08-11 18:04:03 +00:00
Steven Ng f64b08dcb9 Preview layout scaling for RemoteViews preview
RemoteViews may contain multiple layouts. The best fit layout is
picked after layout. Let's ensure the best fit layout is picked
before scaling a preview

Test: Manual
Fix: 196044656
Change-Id: I41b9f70040befaf96a9af95f9399a816eb0b71cb
2021-08-11 16:37:58 +01:00
Nick Chameyev 5e8dbe77e8 Add unfold animation to launcher icons and widgets
Adds unfold animation to launcher which translates
icons and widgets from the center to the sides on
foldable devices.

Bug: 193794541
Test: manual
Change-Id: I9d6e018a0451d342f02dddea47bc180781c31d43
2021-08-11 16:10:18 +01:00
Lucas Dupin d7780bfc1b Merge "Act on scrim visibility" into sc-v2-dev am: f006d37acf am: 5cb3be6139
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15506183

Change-Id: I3093cf40a13fcafe3188edd9f5b4bd61f3cb3132
2021-08-11 03:27:53 +00:00
Lucas Dupin f006d37acf Merge "Act on scrim visibility" into sc-v2-dev 2021-08-11 02:59:05 +00:00
Lucas Dupin e4a9469156 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
2021-08-10 14:18:50 -07:00
TreeHugger Robot c3252e6da1 Merge "Use target size to scale down a widget preview image" into sc-v2-dev am: 26b25c222c am: c873fb5ec8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15502874

Change-Id: I2be7f16308a41a85f747ff4dc0d680a64f70fedc
2021-08-10 19:31:14 +00:00
TreeHugger Robot 26b25c222c Merge "Use target size to scale down a widget preview image" into sc-v2-dev 2021-08-10 19:01:45 +00:00
Steven Ng caf2e5f350 Use target size to scale down a widget preview image
WidgetCells are being recycled in WidgetFullSheet. getWidth/getHeight
could be a recycled dimension. There is also no guarantee that measure
has taken placed before the scale down logic. Let's use the targeted
width for the scale down logic instead.

Test: Manual
Fix: 195417705
Change-Id: Idfb3cc485604d19658e210709bebde6f163003cf
2021-08-10 18:18:11 +01:00
Yogisha Dixit 922ef41323 Add logging when item not added due to insufficient space. am: 104d09f143 am: e7a47f334a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15328636

Change-Id: I3777b341359b458b05da3e0f813c7b449fa22bc9
2021-08-10 14:59:42 +00:00
Yogisha Dixit 104d09f143 Add logging when item not added due to insufficient space.
Bug: 194061824
Test: manual
Change-Id: Ib6f6b9ab4a8e1b59b1dbd1c7c137962efa3e880e
2021-08-10 13:57:47 +01:00
Brian Isganitis 60836a1634 Merge "Update folder pagination dot color to match mocks." into sc-v2-dev am: 47f0c5fba4 am: 129bbbbc25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15466621

Change-Id: I81079e657fedeb6817e5f28f875e1e86ad29ec98
2021-08-09 22:32:06 +00:00
TreeHugger Robot 273ccb1452 Merge "Add logs when runningTaskView after re-binding tasks is null." into sc-v2-dev am: 264f6a4b69 am: 7342783ba5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15463436

Change-Id: I328dcbc7d9fb80140fbdd554f7f17744d94a10dc
2021-08-09 22:31:58 +00:00
Brian Isganitis 47f0c5fba4 Merge "Update folder pagination dot color to match mocks." into sc-v2-dev 2021-08-09 22:08:18 +00:00
TreeHugger Robot 264f6a4b69 Merge "Add logs when runningTaskView after re-binding tasks is null." into sc-v2-dev 2021-08-09 22:07:51 +00:00
TreeHugger Robot 7ec6870d24 Merge "Use windowInsets for bottomGestureSize instead of gestureInsets" into sc-v2-dev am: 758faccca3 am: 798108f711
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15502311

Change-Id: If7c821a37cdf63cabbcfa62eab96adb2bf237320
2021-08-09 21:57:04 +00:00
Steven Ng 99b8aee749 Merge "Fix wallpaper parallax calculation for large screen devices" into sc-v2-dev am: f90ad3be22 am: 0df57648f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15463290

Change-Id: I1397bf9acccfe38c54debf0a64adf7c411f6b2ce
2021-08-09 21:56:56 +00:00
TreeHugger Robot 758faccca3 Merge "Use windowInsets for bottomGestureSize instead of gestureInsets" into sc-v2-dev 2021-08-09 21:38:18 +00:00
Steven Ng f90ad3be22 Merge "Fix wallpaper parallax calculation for large screen devices" into sc-v2-dev 2021-08-09 21:29:46 +00:00
Vinit Nayak 1a8f7120c1 Add logs when runningTaskView after re-binding tasks is null.
Bug: 195430732
Change-Id: If776c834bc2b06000230d853aeff58094e1fe88c
2021-08-09 13:42:40 -07:00
Brian Isganitis cbaf149f87 Update folder pagination dot color to match mocks.
Test: Folder page dot color matches mocks in light and dark mode.
Fix: 195045519
Change-Id: Ib485e51fbb903b1345ee865ddd8614f280e7608a
2021-08-09 16:03:54 -04:00
Alex Chau e9dbb0d952 Use windowInsets for bottomGestureSize instead of gestureInsets
- getTargetInsets will be reverted to its behavior before ag/15431427
- getBottomGestureSize will use the new getWindowInset call uses windowInsets instead of the max of windowInsets/gestureInsets, with the taskbar inset calibration

Bug: 195263971
Test: com.android.launcher3.ui.widget.AddWidgetTest#testDragCustomShortcut
Change-Id: I89368edee5252a404ef490db6540734ec4806f2b
2021-08-09 18:49:29 +01:00
TreeHugger Robot 0124f54c9c Merge "Add logs to MotionPauseDetector" into sc-v2-dev am: e649047f05 am: 27c8f0fa42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15479531

Change-Id: I0191e17de9a6de29612825ee13522c5f63b0505e
2021-08-09 17:38:58 +00:00
TreeHugger Robot e649047f05 Merge "Add logs to MotionPauseDetector" into sc-v2-dev 2021-08-09 17:13:26 +00:00
Alex Chau 1338dd7e71 Add logs to MotionPauseDetector
- Add logs to MotionPauseDetector to confirm if the current 700ms timeout is enough for tests

Bug: 194114179
Test: atest NexusLauncherOutOfProcTests:com.android.launcher3.memory.MemoryTests#testAppLaunchFromWorkspace
Change-Id: Ifc3e8a24c245b1877e3fae5d2cb96636c34e8e4b
2021-08-09 15:56:11 +01:00
TreeHugger Robot f145aa39b3 Merge "Diagnose when lab device sends fake touch screen events to test" into sc-v2-dev am: 0a39f6daec am: da4e9793bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15482523

Change-Id: I345353d5b08e8e9a9fd4eaaafd27d79b0125b485
2021-08-09 11:40:08 +00:00