Commit Graph

16456 Commits

Author SHA1 Message Date
TreeHugger Robot 82fc85f9b8 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev 2021-11-16 19:00:47 +00:00
TreeHugger Robot d8a1b5c366 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev 2021-11-16 16:48:14 +00:00
Tracy Zhou 36cd649a2b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585 am: 022c66327b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: I8d135ccf3b14de2e10384c365ce69d9313984347
2021-11-16 10:09:51 +00:00
Tracy Zhou 0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
Schneider Victor-tulias 5173fd8090 Add notification dots and popup menu notification support to the taskbar.
- Added support for notification dots
- Added support for notifications in popup menu
- Added support for dismissing notifications from the popup menu

Bug: 198438631
Test: long pressed launcher and taskbar icons, clicked notifications, clicked shortcuts
Change-Id: I7c981e60a82b4d6ce28332d804bbbfb5eb89c6a8
2021-11-15 14:47:36 -08:00
TreeHugger Robot 2f08212714 Merge "Deletes old feature flags." into sc-v2-dev am: 3d7084863a am: 2bf1f507d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15507535

Change-Id: I14fdae195d465fd9cb7faf4ca9711a45e244fe45
2021-11-15 17:13:38 +00:00
TreeHugger Robot 3d7084863a Merge "Deletes old feature flags." into sc-v2-dev 2021-11-13 00:38:07 +00:00
Andras Kloczl 953eb8041e Fix LauncherProvider newScreenId issue
Remove maxScreenId from LauncherProvider and whenever we need
a new screenId, query the database to calculate a new screenId.
Also converted and refactored AddWorkspaceItemsTaskTest
and added some extra test cases.

Test: manual & AddWorkspaceItemsTaskTest.kt
Bug: 199160559
Change-Id: I185f6823fed171d778af0130497f5ffaf89c0a70
2021-11-12 19:56:07 +00:00
Winson Chung 21d129de28 Removing logs
Bug: 201305599
Test: Builds
Change-Id: Ic480136ee6b158dc614d43beaed1dfce91b9ca8a
2021-11-12 17:18:11 +00:00
Hyunyoung Song 7515455cfb Merge "Add FeatureFlag to enable two line label inside all apps" into sc-v2-dev am: 3f14c80d4c am: 5401d47b53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16224885

Change-Id: I57a38e2015cf26b2c936c9105f29485f2fe91078
2021-11-11 21:56:43 +00:00
Hyunyoung Song 3f14c80d4c Merge "Add FeatureFlag to enable two line label inside all apps" into sc-v2-dev 2021-11-11 21:29:30 +00:00
Hyunyoung Song afe8fadc15 Add FeatureFlag to enable two line label inside all apps
Bug: 201388851
Test: screenshot on the bug
Change-Id: Id01d6f9f9e25b98cad8368ac0faf671addf793f8
2021-11-10 22:26:51 -08:00
Becky Qiu 9f586a7845 Merge "[AA+ Search] Add logging for header search icon tapping events." into sc-v2-dev am: c919e67a9b am: e03310b8b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223390

Change-Id: I86a58d5aed1c5dde8607f5a8305a72e3cb6f68f7
2021-11-11 01:42:50 +00:00
Becky Qiu c919e67a9b Merge "[AA+ Search] Add logging for header search icon tapping events." into sc-v2-dev 2021-11-11 01:11:00 +00:00
Brian Isganitis 99a6be39ca Merge "Allow overriding getOptionsPopup test method." into sc-v2-dev am: bc1b36344f am: 7e5e234668
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16215049

Change-Id: I59d603e5413c0a2b1f528fbfcef4d041c519502a
2021-11-10 20:29:16 +00:00
TreeHugger Robot cc4438ac0b Merge "launcher: use a different task menu for foldables" into sc-v2-dev am: 0aadbc6b37 am: 3945fd8f4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214330

Change-Id: Ife3cc0d3a23a048495d275b8225d64c32af7743b
2021-11-10 20:29:04 +00:00
Brian Isganitis bc1b36344f Merge "Allow overriding getOptionsPopup test method." into sc-v2-dev 2021-11-10 19:56:07 +00:00
TreeHugger Robot 0aadbc6b37 Merge "launcher: use a different task menu for foldables" into sc-v2-dev 2021-11-10 19:45:36 +00:00
Thales Lima c335ad28a2 launcher: use a different task menu for foldables
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.

This creates a working menu, the correct style will come in later CLs.

Bug: 193432925
Test: open Overview and tap the app icon

Fixes: 205298731
Test: atest NexusLauncherTests

Change-Id: I7a5c1fb4800a309f40fadb2df0f6c3a4c3f42679
2021-11-10 17:30:13 +00:00
Vinit Nayak 0061ab1f4d Merge "Shows AppPairs in previous tasks" into sc-v2-dev am: 524d6b83e9 am: d9d4ef59ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16134803

Change-Id: Icc5fa4343fa983b5b79c1f421f0410a500082bc7
2021-11-10 17:00:34 +00:00
Vinit Nayak 524d6b83e9 Merge "Shows AppPairs in previous tasks" into sc-v2-dev 2021-11-10 16:33:50 +00:00
TreeHugger Robot 903065a490 Merge "Fix wrong getIconBounds method inside BubbleTextView" into sc-v2-dev am: 31bd663332 am: c1d0a5a6fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16186109

Change-Id: If8a2b62b5f1166dd53905482c3ef139e4801b550
2021-11-10 10:09:58 +00:00
TreeHugger Robot 31bd663332 Merge "Fix wrong getIconBounds method inside BubbleTextView" into sc-v2-dev 2021-11-10 09:44:26 +00:00
Tracy Zhou e89a83b65d Track LauncherState, RecentsAnimation, resumed state for task bar in one place
TODO:
- Consider delaying animating task bar to stashed towards all apps state until user releasing their finger (tho in this change heuristic is applied for stashing and unstashing respectively)
- Further consolidate some animation logic

Bug: 204220602
Test: manual

Change-Id: I58b4d035fcf65a9f5c68e69c129eae95b89b1c4a
2021-11-09 23:46:03 -08:00
Becky Qiu 1fc202867e [AA+ Search] Add logging for header search icon tapping events.
Logging example for the search icon tapping event: https://paste.googleplex.com/4809431536631808

Bug: 198507048
Test: tested with AiAi apk with search icon sent as child of header.
Change-Id: Ibbaec61b93c30a99ea2ffef8d7342490ba37335d
2021-11-09 16:50:47 -08:00
Vinit Nayak 4d57e7091f Shows AppPairs in previous tasks
Fixes: 203006080
Change-Id: I63912a61e7617ec41f229c19cc267dc5a1857bae
2021-11-09 13:47:18 -08:00
Hyunyoung Song c2f024beb6 Fix wrong getIconBounds method inside BubbleTextView
Bug: 205065809
Test: screenshot on the bug

TL;DR;; created two variants depending on the layout direction

Change-Id: I9c5e74409c701b1f219ca450de0dca2291507045
2021-11-09 11:39:21 -08:00
Alex Chau c3a92ca2eb Merge "Remove gap between screenIds when restoring from single display device" into sc-v2-dev am: 048a8246fa am: 2ccecc1614
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16191338

Change-Id: Ia4a19dfe7d59ff7b71e1ca35c22493a371dc3723
2021-11-09 17:44:40 +00:00
Alex Chau ac038434f0 Remove gap between screenIds when restoring from single display device
- In RestoreDbTask.sanitizeDb, add extra step to fill all screenIds gaps so that no empty pages are left in between
  e.g. [0, 3, 4, 6, 7] -> [0, 1, 2, 3, 4]

Fix: 201085524
Test: RestoreDbTaskTest
Change-Id: If0b577bf789347cc490ada0b22f2cd39ee1a33bb
2021-11-09 17:01:01 +00:00
Lais Andrade f6e31b1d21 Fix overview scroll triggering haptics on swipe up gesture
Add an extra check to the PagedView, before triggering the haptic
callback, to avoid triggering this when the scroll happens
outside an actual scroll action (e.g. some setter methods that update
the scroll state).

This was triggered on some calls to setCurrentPage, that was
snapping the current scrolled page and triggering the
View.onScrollChanged method.

Fix: 201237536
Test: manual
Change-Id: I9b29981dba408493c78873aea42d8615ea7573a0
Merged-In: I9b29981dba408493c78873aea42d8615ea7573a0
(cherry picked from commit bff03e2d0f)
2021-11-09 10:26:42 +00:00
Brian Isganitis 149dbcb137 Allow overriding getOptionsPopup test method.
Test: TAPL
Bug: 205491724
Change-Id: Ib4adfa85df6aa9e52922f76479487c9459535fcd
2021-11-08 18:17:36 -05:00
Tony Wickham 1278490ac0 Update reorder and folder creation radii
- Before, dragging anywhere in the cell (including space between cells) would trigger a reorder. Now, we compute the radius to the closest cell edge
- For creating folders on icons, we split the difference between the reorder circle (above) and the icon size

Test: enable DEBUG_VISUALIZE_OCCUPIED and manually drag to ensure works as described above
Bug: 204406063
Change-Id: I368714634ed42a930fd16849f2bde1589df1aa63
2021-11-08 12:04:30 -08:00
TreeHugger Robot d580566074 Merge "Add popup menu and click handling to taskbar." into sc-v2-dev am: 68953fc693 am: 4afdfb4f7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16042092

Change-Id: I788326364e70659d1071f5e26acd1f61cc1feef5
2021-11-05 23:58:35 +00:00
Jonathan Miranda bccc19ba7e Merge "Testing to see if waiting for transition to end will fix flaky tests" into sc-v2-dev am: 58763e47d6 am: 45c6ef8f8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16200260

Change-Id: I13394c31ab097f58818d5d902389feda1eec425c
2021-11-05 23:24:11 +00:00
TreeHugger Robot 68953fc693 Merge "Add popup menu and click handling to taskbar." into sc-v2-dev 2021-11-05 23:22:59 +00:00
Jonathan Miranda 58763e47d6 Merge "Testing to see if waiting for transition to end will fix flaky tests" into sc-v2-dev 2021-11-05 22:53:17 +00:00
Schneider Victor-tulias 2bfbf3bffa Add popup menu and click handling to taskbar.
- Added popup menu support to taskbar icons
- Added item click handling for taskbar icon popup menu items

Bug: 198438631
Test: long pressed taskbar icons, pressed popup menu items, dragged taskbar icons to start multi-window mode
Change-Id: Ibc59c1eada50a877a863c075fbfd3e4accaae008
2021-11-05 13:07:09 -07:00
Jon Miranda a234a8ea85 Testing to see if waiting for transition to end will fix flaky tests
Test: presubmit
Bug: 202735477
Change-Id: Icf62003b9f422cf0e327365260c36f6d57b71aef
2021-11-05 12:31:15 -07:00
vadimt 41f99abeb5 Allowing OOP tests to enable home screen rotation.
Bug: 202567877
Test: local runs
Change-Id: Ifb711a3071a26e2d8e690e0378b6e74146ac722c
(cherry picked from commit 462fe7c007)
2021-11-05 18:19:01 +00:00
Greg Kaiser 5b4145e34b Merge "Revert "launcher: use a different task menu for foldables"" into sc-v2-dev 2021-11-05 16:19:43 +00:00
Greg Kaiser 24898d3be0 Revert "launcher: use a different task menu for foldables"
This reverts commit 10eb3cd98b.

Reason for revert: Root cause of P0 b/205278434
Bug: 205278434
Bug: 193432925
Test: Local reverted and now launcher works on wembley

Change-Id: I3605c01066a3ce383d45e0a938f1e00b3c7f7bb9
Merged-In: I5ee18d3ee1b671fcaedda633e7a268addd5c5c15
2021-11-05 16:19:05 +00:00
Greg Kaiser e755dc980a Merge "Revert "launcher: use a different task menu for foldables"" 2021-11-05 16:15:15 +00:00
Greg Kaiser 6f220d92b6 Revert "launcher: use a different task menu for foldables"
This reverts commit 238f630001.

Reason for revert: Root cause of P0 b/205278434
Bug: 205278434
Test: Local reverted and now launcher works on wembley

Change-Id: I5ee18d3ee1b671fcaedda633e7a268addd5c5c15
2021-11-05 16:12:47 +00:00
TreeHugger Robot 1c1c6f8202 Merge "Allowing OOP tests to enable home screen rotation." 2021-11-05 14:45:47 +00:00
Alex Chau 5544cd254e Merge "Update overview clear all button to be larger" into sc-v2-dev am: 67ddd0fefd am: 9184e1f3f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16183382

Change-Id: Ic9b9ca681e0030b3076f3607788c42b0f2a89019
2021-11-05 12:13:02 +00:00
Alex Chau 67ddd0fefd Merge "Update overview clear all button to be larger" into sc-v2-dev 2021-11-05 11:49:56 +00:00
Thales Lima ed7a7b23d4 Merge "launcher: use a different task menu for foldables" into sc-v2-dev 2021-11-05 10:13:38 +00:00
Samuel Fufa 3e2d4d3c1e Merge "[Search] Show search suggestions with in Recyclerview" into sc-v2-dev am: 4112ae6a5b am: 7f355ff178
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16172124

Change-Id: I4476210f378bdfe5e311ab8814db563524638880
2021-11-04 21:10:19 +00:00
Samuel Fufa 4112ae6a5b Merge "[Search] Show search suggestions with in Recyclerview" into sc-v2-dev 2021-11-04 21:00:15 +00:00
Tony Wickham 3cfa5edc93 Fix misaligned folder creation drag over target
Previously, the folder creation distance was based on the center of the cell, rather than the *visual* center, i.e. around the icon. Updated to use existing getWorkspaceVisualDragBounds() to handle this.

Test: with DEBUG_VISUALIZE_OCCUPIED=true, ensure green circles are centered around the app icons; manually drag and drop to check the drawn regions are correct
Bug: 204406063
Change-Id: I691a5cbbfc18c88436b88b7bda42f7920b9a5750
2021-11-04 13:40:05 -07:00