This is a follow-up code review to ag/1754638 to address a comment that was missed before the CR was pushed.
Bug: 227142635
Test: Folders still close when launcher is paused.
Change-Id: Ib6724dc3a6ba49e259ba7de655f6810d6a692d16
The width of the PopupContainer grows if there are multiple
SystemShortcuts and we where not updating the width of all the
options.
Fix: 227538975
Test: Long press an app like Google Maps on the HomeScreen to see
the menu. All the options should have the same width.
Change-Id: I25310d74aa1af17be37b53c27d2334f86bef325a
The text "Don't suggest app" is too long when the device language
is GE or JA, or if you make the text bigger in settings.
Before truncating the text completely we are going to try to make
the text smaller until it gets to a predefined value
(button_drop_target_min_text_size).
Test: Change the language to German (Deutch) and install a new app and drag it to the workspace to see the button "App nicht vorschlagen"
Test: Also, a nice way to test is to go to SecondaryDropTarget#setupUi and hardcode the option to always show "Don't suggest app"
Fix: 221480721
Change-Id: I99def4e23cd17109a297aecaa620cef7a0d137e7
Previously, folders wouldn't close after launching an app and quickly navigating back the launcher.
This is because the onStop state which contains a call to AbstractFloatingView.closeViews() wasn't being called.
This change adds an additional call to specifically close any open folders when the Launcher enters a paused state.
Bug: 227142635
Test: Verified that the issue is fixed after code change.
I logged the Launcher's lifecycle state to ensure my manual testing was reliable.
Change-Id: I838f992f83afdd754672ebbe85d0eb2a7e894417
- Various TAPL tasts are flaking because the taskbar is present when navigating home. Several TAPL taskbar tests are also flaking because the taskbar is missing when opening an app. Adding logging to catch when FLAG_IN_APP is being set and why it isn't being applied.
Bug: 227657604
Bug: 225205246
Test: manual
Change-Id: Ia976bb0a6c7764e571fab3ac98ee21ff22ef7674
Also fixing also-closing behavior for FloatingSurfaceView for Android S
Bug: 228260232
Test: Verified manually on device
Change-Id: I83f6417a756c1459533294d681e83abba6ea58aa
- Set mInsets with windowBounds.insets when initialized, and set windowBounds.insets when cloning DeviceProfile
- Added more bottom sheet / all apps in DeviceProfile dump
- Also dump taskbar's device profile in dumpsys
Fix: 226968237
Test: Taskbar AllApps should have correct top padding
Test: adb shell dumpsys activity com.google.android.apps.nexuslauncher
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: I7739c699fb16544b92dc820354a643f745694c25
Bug: 200841778
Test: Hard-coded the flag to be true, and verified that the snack bar
is shown with the correct text. Also verified that talkback announces
"Item Removed" properly and that the correct log event is produced by
the AppEventProducer which AiAi needs to process the user action.
Change-Id: Ifbb9cf7aecf26cd4bcebf48d4fb07fb3d5af46bb
This change fixes a bug where, after a user drags and drops a
predicted app from the all apps page once, dragging that item again
results in the "Remove" drop target being shown rather than the
"Do Not Suggest" drop target.
Bug: 221057278
Test: Verified correct drop down targets were present after fix when
dropping all apps prediction item on workspace multiple times in a row.
Change-Id: I95940eeebbd547861fcdfbb5d02769b82446184d
Fixes: 221075063
Test: wwlogcat shows right events,
new events show up on aster dashboard
Change-Id: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
Merged-In: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
For the 4x5 grid we add insets to the widget and the
animation wasn't accounting for it.
I'm using this shell function to quickly change the
animation speed
```
function anim-speed() {
adb shell settings put global window_animation_scale $1
adb shell settings put global transition_animation_scale $1
adb shell settings put global animator_duration_scale $1
}
```
anim-speed 1 # for regular speed
anim-speed 10 # for really slow speed
Fix: 194227752
Test: Put down a widget in 4x5 and the animation should match,
sometimes is to fast but you can slow the animations with adb and see
the difference
Change-Id: I182729de39c0d0b12231d07e337dddca6fccf5c0
This should make it more configurable, and be independent of the screen size set by the user.
Fix: 223726518
Test: atest Launcher3Tests:HotseatSizeTest
Test: atest Launcher3Tests:InlineQsbTest
Change-Id: If04f3fb0f556103f60b580c757a9fc06da561516
Stefan Andonian
Sebastián Franco
TreeHugger Robot
Schneider Victor-tulias
Luca Zuccarini
Alex Chau
Thiru Ramasamy
Sunny Goyal
Brandon Dayauon
Josh Tsuji
Pat Manning
Brian Isganitis
Thales Lima
Vinit Nayak
Jon Miranda
Jerry Chang
András Klöczl