Commit Graph

16456 Commits

Author SHA1 Message Date
Brandon Dayauon 7a8a9ed170 Fix issue where allAppsCellWidth is 0
when using secondary display on non-scalable grids causing allApps to be squished.
Bug: 234748862
Test: Manual

Change-Id: I2e92bce69438a17eccb0e4b2b2e3f2bdbfa7600e
2022-06-06 14:32:22 -07:00
Vinit Nayak 5424fca602 Rename split classes/variables for consistency
* Use "select" when in the split screen
invocation process
* Drop usage of "staged" except when defining
constants

Fixes: 233006032
Change-Id: I809f0e1e9742aa6b6b09ad8731896ad3f0c9deb0
2022-06-06 14:02:15 -07:00
James O'Leary ede514f275 Update notification dot from T90 to T80
Bug: 213314628
Test: work with UX to pick something darker than T80, present options
from T70 to T90, get feedback to use T80, verify at runtime via
screenshot dot is T80.

Change-Id: Ic5b47a419eb7697c22c4dd9ab849b8a00d73be9f
2022-06-06 16:01:45 -04:00
Hyunyoung Song 863ebce70b Merge "Fix IME hiding animation being delayed after unlocking the device" into tm-dev am: d4a79eb99b am: fb5d602a99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18725729

Change-Id: If4d9e903a2911ccad62a91b7bed9942e22deb707
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 05:43:43 +00:00
Hyunyoung Song f9d168f13e Merge "Fix IME hiding animation being delayed after unlocking the device" into tm-dev am: d4a79eb99b am: e153da358c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18725729

Change-Id: Id97cd2e9fac15799679560ed34a84d5d2c81aa2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 05:43:14 +00:00
Hyunyoung Song d4a79eb99b Merge "Fix IME hiding animation being delayed after unlocking the device" into tm-dev 2022-06-04 05:10:48 +00:00
TreeHugger Robot 13df7c439c Merge "Adds helper methods in SearchUiManager and OnboardingPrefs." into tm-dev am: dd053e79e2 am: 6b390b8c16
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18631233

Change-Id: Ib62c619c43e54b11d794a2222e31aeca2ac9f722
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 00:47:11 +00:00
TreeHugger Robot dae444b827 Merge "Adds helper methods in SearchUiManager and OnboardingPrefs." into tm-dev am: dd053e79e2 am: ddf7dfff31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18631233

Change-Id: I033fc551db30a45910900b3c544b065293c2fd3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 00:46:04 +00:00
hyunyoungs d7a02ec7ae Fix IME hiding animation being delayed after unlocking the device
Hide keyboard with WindowInsetsController if could. In case
hideSoftInputFromWindow may ignored by input connection being finished
when the screen is off.

Bug: 233158645
Test: manual as steps:
  1.  Launch AllApps.
  2.  Tap search bar to invoke IME.
  3.  Screen off.
  4.  Screen on.
And all other keyboard hide cases such as back gesture, swipe down, etc.

Change-Id: I4154f38f94b6760a430f7510a650422020d8f59a
2022-06-03 14:19:45 -07:00
TreeHugger Robot dd053e79e2 Merge "Adds helper methods in SearchUiManager and OnboardingPrefs." into tm-dev 2022-06-03 20:10:27 +00:00
Vinit Nayak 107f79a4a2 Merge "Refactor TaskShortcutFactory to return List of SystemShortcuts" into tm-qpr-dev am: dde2536a52 am: 54cdc33ca1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624822

Change-Id: Ia9e062b2e7ab1a86cdc703614fdbc44f01afb2df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-03 17:33:22 +00:00
Vinit Nayak dde2536a52 Merge "Refactor TaskShortcutFactory to return List of SystemShortcuts" into tm-qpr-dev 2022-06-03 16:39:11 +00:00
Andy Wickham 9899468884 Enables keyboard option by default.
This just enables the setting for this feature. The default
value of the setting itself is still false.

Bug: 231433168
Test: Manually verified the option worked as expected, including
showing the user education when typing directly in All Apps
without tapping the QSB. Also verified previous features like
the snackbar to enable keyboard by default worked as before.

Change-Id: If423ae49436d1bf71579d52a99aea5ca3f2407dc
2022-06-02 16:51:01 -07:00
Andy Wickham e20a35c7a3 Adds helper methods in SearchUiManager and OnboardingPrefs.
Bug: 233656600
Test: With topic change.
Change-Id: I9ddb910e94d389ec682617ce874fff6a2ce703c8
2022-06-02 16:44:16 -07:00
Jon Miranda f58db150af Play fallback animation if icon in All Apps is covered by header.
Bug: 230707341
Test: enter all apps
      scroll so icon is covered by header
      open app, swipe back to return to all apps
      confirm fallback animation plays

      repeat but scroll so icon is not covered by header
      confirm normal animation plays

Change-Id: I56cda07f3eccc11e8909f7fb28210f65cc6e0f1d
2022-06-02 16:06:37 -07:00
Jon Miranda 46ecc0ca08 Pause expensive view updates before setting hw/sw layers.
Prevents widgets from updating mid animation.
Also pauses view updates during app close animation.

Bug: 220939231
Bug: 230617085
Bug: 226171754
Test: manual

Change-Id: I0138d57e6a7b2c22fd9a029e971b3e27c7e9f22e
2022-06-02 12:21:01 -07:00
Sebastian Franco be7f84d5a1 Adding a case when there is only 1 system shortcut on the Popup Container
When there is only 1 system shortcut the Popup Container looks weird
because it shows the icon without text and it has a lot of space.

We already have a view to show the sorcuts with text and icons so I
reused that view and show it only if there is 1 system shortcut.

I also did a small refactor separating the sortcuts into
widgetShortcuts and nonWidgetShortcuts. The way I did it is not the
most efficient because it uses two passes, but I think it is easier to
read this way and we'll never have too many shortcuts.

Fix: 229356716
Test: Long press on the app icons in the workspace and in the
app drawer. Try different app some with one shortcut like the phone
app and some with multiple like.

Change-Id: Ie054af546758d0686914fc934772a76a3c690fe5
2022-06-02 11:59:17 -07:00
Brian Isganitis cd7cc294b8 Update download app icon treatment to latest mocks.
Demo: https://screenshot.googleplex.com/BfTvY2EaByJXwdw.png
Test: Manually using "start install session helper" in SupportApp.
Fix: 205714358
Change-Id: I3ec2fb776cbad974ae36f34b29f3081b3d073c83
2022-06-02 11:53:47 -07:00
Sunny Goyal 7f1b08672e Merge "Fixing wrong diffing logic in AdapterItem" into tm-dev am: c2c1fdad54 am: 3960374e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18701868

Change-Id: Ie0a5fd47908ddb962fbfacd7e058c76587ba9dcb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-02 17:17:52 +00:00
Sunny Goyal 13b5a16350 Merge "Fixing wrong diffing logic in AdapterItem" into tm-dev am: c2c1fdad54 am: 004fecba55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18701868

Change-Id: I8cffb398ec85945511ce0ca67fc6ac11e3324c46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-02 17:16:37 +00:00
Sunny Goyal c2c1fdad54 Merge "Fixing wrong diffing logic in AdapterItem" into tm-dev 2022-06-02 16:45:31 +00:00
Luca Zuccarini 8009c1d446 Add support for text color animations in PropertySetter.
Bug: 233223446
Test: manual
Change-Id: Id321ad7f21e804b1d1063fbe207fb783bb45f759
2022-06-02 16:11:12 +00:00
Stefan Andonian d67e47294e Merge "Give FloatingIconView a copy of, rather than, the original icon." into tm-dev am: 0c809bbe67 am: 9dd7aa50ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673699

Change-Id: If43a7b8fa1722abdc7d1c49a15cca1d7d5189bd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-02 16:10:04 +00:00
Stefan Andonian 0c809bbe67 Merge "Give FloatingIconView a copy of, rather than, the original icon." into tm-dev 2022-06-02 15:33:45 +00:00
Vinit Nayak 28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Sunny Goyal 959a9f5444 Fixing wrong diffing logic in AdapterItem
Bug: 232932442
Test: Verified on device
Change-Id: I87eae4c238a7b2d9749859307d253822916bb31c
2022-06-01 15:02:39 -07:00
Luca Zuccarini 42947ea17f Merge "Update the workspace and background scale interpolators." into tm-dev am: a6c36eb4d0 am: 2cc475dcf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18660446

Change-Id: Ia1e2cd5472bb0b423cf3446574984253019c6b4c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 17:41:31 +00:00
Luca Zuccarini 18fd235240 Merge "Update the workspace and background scale interpolators." into tm-dev am: a6c36eb4d0 am: 03a470116b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18660446

Change-Id: I1006f91629d54bfec2c73d7749ae85dc0a555733
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 17:41:01 +00:00
Luca Zuccarini a6c36eb4d0 Merge "Update the workspace and background scale interpolators." into tm-dev 2022-06-01 16:51:42 +00:00
Luca Zuccarini 728e234120 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I8cf3773dff04ced9335355f9f99311df1a9bd97f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:17:35 +00:00
Luca Zuccarini 5f78aeab5f Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: f518ba7289
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: Ib2697612f18adc60a7310f73f4cf1a391727244a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:16:54 +00:00
Luca Zuccarini 46338b09e3 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev 2022-06-01 09:35:20 +00:00
Jeremy Sim cc305437f6 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev am: 0183476559 am: 2e598e4859
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18422835

Change-Id: I6f966f9d33b1d769f8d4f3d2170f9f001fc5e4cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 03:38:13 +00:00
Jeremy Sim 0183476559 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev 2022-06-01 02:55:47 +00:00
James O'Leary 9c52973bb0 Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: e0ca1d1f12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: Ie52c8bb1f0581c7f65ac48f1f6d908a75be1c067
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 02:23:02 +00:00
James O'Leary 0ac64cba0f Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: b2919ce557
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: I9f92216f1db5331b450b750855213cc9fd642335
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 01:52:33 +00:00
James O'Leary 202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
Alex Chau 8c1fe8abac Avoid DisplayController.currentSize from being stuck at wrong value am: 80d36083c2 am: 578e4add2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18619540

Change-Id: I84e04e2c66f1b075aa7652d529a66e07757c037e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-31 22:23:44 +00:00
Jeremy Sim 3c2c3f1aea Remove deprecated verticalBar layout in Overview
Removes code that was intended for a now-deprecated layout style in Overview. See ag/18386646 for an example of an issue caused by this.

Bug: 232298587
Test: Manual on 3 devices
Change-Id: Icfd40e1e5a99cf5821b1c46357db58a31daaa835
2022-05-31 22:02:57 +00:00
James O'Leary dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
Stefan Andonian 2a7fbee0d4 Give FloatingIconView a copy of, rather than, the original icon.
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.

Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.

Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
2022-05-31 17:32:08 +00:00
Stefan Andonian 1644346e76 Merge "Give FloatingIconView a copy of, rather than, the original icon." 2022-05-31 17:31:45 +00:00
Luca Zuccarini a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
Alex Chau 80d36083c2 Avoid DisplayController.currentSize from being stuck at wrong value
- Update Info when perDisplayBounds has changed
- Add more detailed logging to displayInfo, realBounds and perDisplayBounds
- Add perDisplayBounds to dumpsys and replace supportedBounds

Bug: 233562339
Test: manual
Change-Id: I9a040e8465a8b0a2dcde61bab06c6ca1df3006da
2022-05-30 18:09:45 +01:00
Luca Zuccarini 7ee40a4190 Update the workspace and background scale interpolators.
The spec had a typo (EMPHASIZED_DECELERATE instead of
EMPHASIZED_ACCELERATE). In addition, we're now using LINEAR for the
background since the feel is smoother this way. Cleared with motion
(simonroberts@).

Bug: 232418544
Test: manual
Change-Id: I492dbe8008856d331836793177f1dd58c3265ca2
2022-05-30 09:47:40 +00:00
James O'Leary 71854432a9 Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 66ec297fea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I8448333160924d5a75627602b3fe0602e92cd65a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 23:09:51 +00:00
Stefan Andonian 15fd13470f Give FloatingIconView a copy of, rather than, the original icon.
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.

Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.

Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
2022-05-27 22:34:52 +00:00
James O'Leary ef64789d0a Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 5131a1a203
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I16cb7b30a5219d196427bedbbe0c3adbb66c1360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:29:31 +00:00
James O'Leary 2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
Winson Chung af5ac4984f Merge "Ensure page scrolls are initialized even for 0 children." into tm-dev am: 1e211e0c03 am: 0a3ef79f06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18625747

Change-Id: Ie10aeebc4e8f53f5c8882317e48a14b2b4fa8794
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 18:24:33 +00:00