Commit Graph

16456 Commits

Author SHA1 Message Date
Tony Wickham 788f8e09fe Merge "Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar" into tm-qpr-dev 2022-12-08 16:21:43 +00:00
Tony Wickham 5de5ac9008 Add IS_RUNNING_IN_TEST_HARNESS check for isTransientTaskbar
This avoids us trying to read FORCE_PERSISTENT_TASKBAR feature flag
which apparently crashes tests due to permission issues. Going forward,
when we support persistent taskbar better, we should update the tests
and this check as commented in the code.

Test: com.google.android.apps.nexuslauncher.TaplTestsNexus#testSearchNoInputs
Fixes: 261604544
Change-Id: I35c20825e8171766834f0f32be4f3818d02ab1df
2022-12-08 16:19:16 +00:00
Schneider Victor-tulias 673d6a01ed Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev am: ad48decd4f am: d132ad4393
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20664263

Change-Id: I13f6d462dc8fabc0010661aea379bcf2357f9a24
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 15:47:36 +00:00
Schneider Victor-tulias d132ad4393 Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev am: ad48decd4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20664263

Change-Id: Icfdd29ce44e4ff73bfb79b3150addca41b7517cc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 15:25:37 +00:00
Schneider Victor-tulias ad48decd4f Merge "Revert "Cancel gestures on launcher destroy"" into tm-qpr-dev 2022-12-08 14:55:15 +00:00
TreeHugger Robot 5c3146dab3 Merge "Simiplifying the Parner override definition so that it can be used for multiple overrides" into tm-qpr-dev am: 117865726f am: 4c44df1edb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470533

Change-Id: If020405c00ca1fdf00e58ea3d16de77babaa4a3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 07:15:09 +00:00
Sunny Goyal d954229d1a Adding support for generating manachrome icon from a colored icon
Bug: 261625158
Test: Verified on device
Change-Id: Ibda922fd2c9c0a856ea02a8e73f43af8573f2450
2022-12-07 22:57:24 -08:00
TreeHugger Robot 4c44df1edb Merge "Simiplifying the Parner override definition so that it can be used for multiple overrides" into tm-qpr-dev am: 117865726f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470533

Change-Id: I351d81002525189f3877fefeb75a5190482ad3df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-08 06:49:56 +00:00
TreeHugger Robot fab5b2d560 Merge "Remove feature flags and use search config flags." into tm-qpr-dev am: 1c744c996c am: d1409f220b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20624019

Change-Id: I4487b0f099275dbf00b659e68c7f6ad556a018ba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 23:52:07 +00:00
Sunny Goyal 3e58eea9da Simiplifying the Parner override definition so that it can be used
for multiple overrides

Bug: 257555083
Test: Presubmit
Change-Id: I14eb98edb19ccf109222d6806e27de707e485457
2022-12-07 23:35:18 +00:00
TreeHugger Robot d1409f220b Merge "Remove feature flags and use search config flags." into tm-qpr-dev am: 1c744c996c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20624019

Change-Id: I9bf3371ca4eb65c5dcec19466644fe8d1a9fbca4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 23:30:48 +00:00
TreeHugger Robot 1c744c996c Merge "Remove feature flags and use search config flags." into tm-qpr-dev 2022-12-07 22:58:39 +00:00
TreeHugger Robot b3a6340b50 Merge "Support right click to bring up app menu and actions" into tm-qpr-dev am: 13b432cd9d am: ededf539ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613963

Change-Id: I965ccd26e29dd1b6d3c3425146a6848a011a7b6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 20:49:59 +00:00
TreeHugger Robot ededf539ff Merge "Support right click to bring up app menu and actions" into tm-qpr-dev am: 13b432cd9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20613963

Change-Id: I2ef2a21fd627033e74532bfc0aa7c7d8878d4e27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 20:29:25 +00:00
TreeHugger Robot 13b432cd9d Merge "Support right click to bring up app menu and actions" into tm-qpr-dev 2022-12-07 20:00:33 +00:00
Schneider Victor-tulias f0de6cc2ca Revert "Cancel gestures on launcher destroy"
Revert "Refactor SchedulerCallback implementation"

Revert submission 20555112-launcher-destroy-gestures

Reason for revert: causes test failures
Reverted Changes:
Ib43cdd597:Refactor SchedulerCallback implementation
Ia8e936e26:Cancel gestures on launcher destroy

Change-Id: I2199e39237b7c9fe25784b46e16960cd5f17c46c
2022-12-07 19:46:00 +00:00
Andy Wickham dfe6791d0e Merge "Fixes for floating search bar (e.g. background protection)." into tm-qpr-dev am: abb18ea62a am: 83a06d68f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20518558

Change-Id: Ia295e75b3d584a035151fec5f46969e2dce9b25b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 19:43:31 +00:00
Andy Wickham 83a06d68f7 Merge "Fixes for floating search bar (e.g. background protection)." into tm-qpr-dev am: abb18ea62a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20518558

Change-Id: I07c5849c0371dd6e25ea435c810f25422bce4784
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 19:25:16 +00:00
Sihua Ma 1126f57441 Reducing the no-intercept area to widget picker recycler view
This allows drag-to-exit on the bounding area even if the scroll is not on top

Fix: 247121877
Test: Manual
Change-Id: Iebf7af195b717bad5e80ee34fec05fed58827699
2022-12-07 11:11:52 -08:00
Andy Wickham abb18ea62a Merge "Fixes for floating search bar (e.g. background protection)." into tm-qpr-dev 2022-12-07 19:08:53 +00:00
Jon Miranda 82b9fe0bcc Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev am: 6ba531d1aa am: 2645897b6e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590318

Change-Id: I64660cc9ef9cf8317e52f5aebd6756aeff006973
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 18:58:44 +00:00
TreeHugger Robot 9b610cadbf Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev am: 5e0d7ae019 am: 0a456b59ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20640160

Change-Id: I81aefb87ac4dddc632884a8748fab9d0d58d9fda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 18:57:44 +00:00
Jon Miranda 2645897b6e Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev am: 6ba531d1aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590318

Change-Id: Ice4e6728e8912bc9a2aa753944170765779dfee5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 17:55:09 +00:00
TreeHugger Robot 0a456b59ef Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev am: 5e0d7ae019
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20640160

Change-Id: I6efba3ac4543bd9b1f289de1f349edeaffdef3c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-07 17:54:48 +00:00
Jon Miranda 6ba531d1aa Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev 2022-12-07 17:33:53 +00:00
TreeHugger Robot 5e0d7ae019 Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev 2022-12-07 17:14:15 +00:00
Fengjiang Li 9f90efb39e Support right click to bring up app menu and actions
Test: https://b.corp.google.com/action/issues/250092449/attachments/40159735?download=true
Change-Id: I159005cc982478896d442bb2675ccb1bb7f0322e
2022-12-07 08:48:16 -08:00
Alex Chau 766cd2b4b9 Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute
- Can use deviceCategory to make grid specific to splitDisplay instead
- Update TwoPanelWorkspaceTest for new workspace items

Fix: 233736588
Test: Clear launcher and check the default
Test: TwoPanelWorkspaceTest
Change-Id: I6ad3a2d866d847af281e10b802edbd4bcc892c39
2022-12-07 15:18:28 +00:00
Luca Zuccarini 43e3d45042 Update timings for the Home <> All Apps transition.
Also updates some interpolators to make the manual and atomic
transitions more homogeneous.

Also also updates the commit point so it matches the transition point
between the two states exactly.

Note: the background scale is currently too much, and it needs to be 1/3
of the total distance to match the Workspace scaling. To do this, we
simply scale down the depth by a factor of 3 when calling the background
zoom-out API in the DepthController.

Bug: 254835725
Test: see videos in bug

Change-Id: I605546921e9ee4dfc852794c56495c72f0b916e1
2022-12-07 13:12:16 +00:00
Tracy Zhou 8905121b42 Turn on split from fullscreen with keyboard shortcuts flag
TODO: fix icon not showing in staged split view.

Bug: 261545797
Test: https://recall.googleplex.com/projects/f4cc906f-d337-414e-aea8-d5434a0c6e88/sessions/06cc05b5-c032-40f3-af8b-3b90860d2f37
Change-Id: I594b99afc2c282272a00608bb88c374aae36ab7d
2022-12-06 20:58:35 -08:00
Andy Wickham 0adad24408 Adds header protection on tablet all apps panel.
Removes background and manually draws it while drawing scrim. Then
draws header protection on top as needed.

Currently this only applies to all apps from Launcher, as Taskbar
doesn't seem to use the same scrim flow. So taskbar adds the same
static background that was previously used.

Demo videos: https://drive.google.com/drive/folders/11PyFsrLV6-QhU_E-zD3s5bfzZK2nOU87?resourcekey=0-E41uw5TP9xuqTifLAs71yw&usp=sharing

Test: Manually on phone and tablet with dark/light mode, floating
search bar on/off, work profile present/absent, taskbar/home entry
Bug: 240670050

Change-Id: I81dcc956d9dbbc7552c8a227a49741bcf71eed71
2022-12-06 18:31:33 -08:00
Andy Wickham 493831af1a Fixes for floating search bar (e.g. background protection).
- Adds background protection for the search bar
 - Views animating based on keyboard now support manual swipes.

Bug: 213954333
Bug: 259004115
Bug: 251460671
Test: Manual
Change-Id: I055766126fb46a8e8b48907e442c9e54aaa4badf
2022-12-06 17:59:53 -08:00
Sebastián Franco 8a1b517ad5 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev am: 9adbab96b7 am: a3ac407d85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20646376

Change-Id: I47537d6d811b1b3e4d723e2c7cc7efb387361e14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 20:31:24 +00:00
Tony Wickham 9672a48111 Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c am: c9740c89aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: I10bd52418d769a97521ab318fcf5c7328c073943
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 20:30:22 +00:00
Alex Chau 5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Holly Sun 581aa03806 Remove feature flags and use search config flags.
Bug: 210661150
Test: manual
Change-Id: I6aa176895f80f31840570ce2c0ecbfbfb11079a1
2022-12-06 11:31:31 -08:00
Sebastián Franco a3ac407d85 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev am: 9adbab96b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20646376

Change-Id: Icf0e9ddf86799e6fcffa74f47473013925af6a99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 17:48:51 +00:00
Sebastián Franco 9adbab96b7 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev 2022-12-06 17:17:26 +00:00
Tony Wickham c9740c89aa Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev am: ef8677169c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20622942

Change-Id: Ia758acdad42c8f95b9ee52d37d0bf7a3f2c63e80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-06 06:29:09 +00:00
Tony Wickham ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
Tony Wickham 7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
Sebastian Franco 5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot 036fe83e63 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069 am: f77ad4afd4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: Ia4e2a6627346fd949a7001c5bbdddbe3f41bb474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:46:08 +00:00
TreeHugger Robot f77ad4afd4 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev am: c4d6dee069
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20555112

Change-Id: I5907940eac2de90c913e1d8ed965b35f013815f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 21:13:20 +00:00
TreeHugger Robot c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
TreeHugger Robot 1d4c44ce07 Merge "Make grid size migration less confusing for users." into tm-qpr-dev am: 33c348f573 am: a44e9370f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388826

Change-Id: I5df1ed1b272876e6ce64b19cd42410b840c10688
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 19:22:22 +00:00
TreeHugger Robot a44e9370f0 Merge "Make grid size migration less confusing for users." into tm-qpr-dev am: 33c348f573
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388826

Change-Id: Ia19f19c57fa662098336bd05b1d34753c460cd97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-05 18:48:11 +00:00
TreeHugger Robot 33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Schneider Victor-tulias 65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Sihua Ma 6cf21e462a Merge "Replace title of system services with more specific ones" into tm-qpr-dev am: 7b467addea am: 57489b5c3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20592089

Change-Id: Iac15925302705a405e16abaebec8f106c8cf66c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-03 07:21:27 +00:00