Commit Graph

16456 Commits

Author SHA1 Message Date
Sunny Goyal f2b97f8cd8 Kill launcher when display size changes
Bug: 112876936
Test: Verified by changing display cutout overlay
Change-Id: I3ca13c7be873509334457e3484ac5604731adeae
2018-08-21 13:37:38 -07:00
arangelov e6627ebfed Don't call BottomUserEducationView#close() while running animation.
If while the work profile info card opening animation was
playing you pressed the Work tab repeatedly, close() was
called. That caused the animation to never complete
properly (onAnimationEnd() was never called). This CL
makes sure to not call close() if the animation is
still running.

Bug: 112471462
Bug: 112188042
Test: Manual
Change-Id: I2e62e0c5c6f1d6132ea359a85cb6aadf57639c30
2018-08-20 17:23:15 +01:00
Tony Wickham 2bcc9ba5ef Merge "Cancel badge scale anim when setting new badge scale" into ub-launcher3-master 2018-08-17 21:24:10 +00:00
Tony 4043b05cde Cancel badge scale anim when setting new badge scale
Otherwise it's possible the badge scale animation will override the
non-animated set value, which could mean a badge continues to show
even though it shouldn't:
- Animate badge scale to 1
- Before animation finishes, set badge scale to 0
- Badge scale ends at 1, since animation wasn't cancelled, so we
  continue to show it indefinitely

Also exported some properties in case a similar issue arises.

Bug: 111791593
Change-Id: Ia1a417239b909886adf9351e9bdc06a3b22d8b73
2018-08-17 13:47:39 -07:00
arangelov ad78305862 Highlight work tab when user already in All Apps after creating WP.
When a user created a work profile and was already in the All Apps
view, the work tab was not highlighted, because the logic for that
was only in AllAppsContainerView#onScrollUpEnd(). This CL
highlights the tab when the user has resumed and the All Apps view
is expanded.

Bug: 79242814
Test: Manual
Change-Id: I40af0d513c95f8084e21f4e276e9f56bcb06555e
2018-08-17 20:28:52 +01:00
Tony 977690e931 Make arrow feel more connected to popup
- Clip the arrow that is overlapped by the popup, so that it doesn't
  show when that part of the popup is highlighted
- Animate the arrow first instead of last. Now the animation feels
  like one continuous motion as the arrow grows into the popup.

Bug: 111159923
Bug: 111006276
Change-Id: I22fb3037d950d55fe6c8ed4dc5345279874f0a3a
2018-08-15 15:22:28 -07:00
TreeHugger Robot 9e26e26f00 Merge "Prevent the work mode switch thumb from being dragged." into ub-launcher3-master 2018-08-15 17:39:24 +00:00
arangelov 1502c673d0 Prevent the work mode switch thumb from being dragged.
When we normally press the work mode switch, it waits for the profile to
receive the ACTION_MANAGED_PROFILE_AVAILABLE broadcast before the button
UI actually toggles. The user never interacts directly with that switch.
However, dragging the switch thumb used to bypass that logic. This CL
makes sure dragging the switch thumb cannot happen in the first place.

Change-Id: Ib3b4ae7591136c35e6d02783387d752e246cfb5b
Fixes: 111211805
Test: Manual
2018-08-15 16:46:13 +01:00
Vadim Tryshev b6398a1eb8 Sharing protocol constants between Launcher and TAPL
Bug: 110103162
Test: TaplTests
Change-Id: I5b2a2b8576a7a6ea4a156f00858711496d6b5bba
2018-08-14 19:53:43 -07:00
TreeHugger Robot e1c4a90635 Merge "Migrating to android-x" into ub-launcher3-master 2018-08-14 22:53:40 +00:00
TreeHugger Robot d7f266fee1 Merge "Removing static launcher activity dependency from FirstFrameAnimationHelper" into ub-launcher3-master 2018-08-14 22:30:00 +00:00
Sunny Goyal d230307a95 Migrating to android-x
Change-Id: I9a774152d13a541e8496dd84f2469bfed407f86d
2018-08-14 15:22:12 -07:00
TreeHugger Robot a950d40d09 Merge "Started converting Launcher to be gesture-stable" into ub-launcher3-master 2018-08-14 19:18:46 +00:00
Lucas Dupin f3c4f77809 Merge "Respect night mode flag on Q and beyond" into ub-launcher3-master 2018-08-14 18:32:34 +00:00
Lucas Dupin eca08a10bd Respect night mode flag on Q and beyond
Test: manual
Change-Id: I01c51d02e787557717c12567adc8276943dbd1bc
Fixes: 110758454
2018-08-14 11:18:42 -07:00
Winson Chung 7debc53f93 Skip logic to find the dominant color when loading recent task icons
- Also move some allocations in ColorExtractor into thread locals to reduce
  allocations

Bug: 78777731
Change-Id: I8819106d476a9af02e864135a2f44b55fe9219cd
2018-08-14 10:30:33 -07:00
Vadim Tryshev dc755e718d Started converting Launcher to be gesture-stable
All tests keep passing.

WorkTabTest.workTabExists was made gesture-stable. There is no need to
use TAPL, as the point is not to check answering to gestures, but to
check presence of tabs, which is better to do using launcher internal
state. (It still fails if run as a part of all tests, presumably,
because after Launcher's start, changes in user configuration are not
recognized, so I've commented the failing part)

Bug: 110103162
Test: Run all tests
Change-Id: Ic30b8e8475d16cee3880332f12311a44ddfa26cb
2018-08-14 10:29:57 -07:00
Sunny Goyal f0b6db7fa8 Removing static launcher activity dependency from FirstFrameAnimationHelper
Static dependency does not work in the presence of multiple activities and
when the main activity is not Launcher (eg in fallback recents). Instead
creating FirstFrameAnimatorHelper on demand for individual animations.

Change-Id: I17bb69bbaaca92f0db994fb56fd784302c57d543
2018-08-13 16:10:18 -07:00
TreeHugger Robot b6ecb17356 Merge "Removing Launcher activity dependency on various animations" into ub-launcher3-master 2018-08-13 20:03:33 +00:00
TreeHugger Robot d6ba50412b Merge "Adding overscroll in recents view" into ub-launcher3-master 2018-08-10 22:53:49 +00:00
Sunny Goyal b7b0135c93 Adding overscroll in recents view
Bug: 109828536
Change-Id: I4fe94bd157c2b65f80604751e6f0f7d5d81d058d
2018-08-10 22:41:20 +00:00
Sunny Goyal 849c6a2b18 Removing Launcher activity dependency on various animations
(This cl reverts change-Id: I455edcd17bda83ab51c2c04fa40e66097a4d6975)

Various animations were marked for cancellation when launcher activity is
destroyed. This this does not work with multiple activities (Launcher,
fallback recents, shortcut confirmation). Also since launcher activity
handles configuration changes, the activity is not destroyed often.

Instead associating a target with various animations which automatically
cancels the animations when that target goes away.

Change-Id: I64cd095a28075561a9e20c9dcdeb9f90c18e1047
2018-08-10 13:31:46 -07:00
TreeHugger Robot 52b28f0926 Merge "Adjust notification dots" into ub-launcher3-master 2018-08-09 22:19:57 +00:00
Sunny Goyal 92526e27c3 Importing OverScroller.java from platform
Bug: 109828536
Change-Id: Idf33fcbc765a83d72503f1428af0d5414bde3ef3
2018-08-09 12:04:36 -07:00
Sunny Goyal 107dcf8d0a Merge "Fix overlapping FloatingViewType IntDef" into ub-launcher3-master 2018-08-08 19:24:54 +00:00
Sunny Goyal aad3359e8e Removing unused touch handling in PagedView so that it is similar to various platform class
Bug: 109828536
Change-Id: Ibaba3fb4298f2dc055d125acea5f4c47403bbef0
2018-08-08 12:12:46 -07:00
TreeHugger Robot 4e41486499 Merge "Removing requirement for no enabled accessibility services" into ub-launcher3-master 2018-08-08 18:57:12 +00:00
Vadim Tryshev 30ac987c56 Removing requirement for no enabled accessibility services
Now Launcher will talk to TAPL even if there are enabled accessibility
services.

This should fix some lab tests that presumably run with some
accessibility services enabled.

Bug: 110103162
Test: will check on lab tests
Change-Id: Ie11896441c2b2b7c16150cd3f2df28a5a5095d88
2018-08-08 11:46:19 -07:00
Sunny Goyal 7fee2a82e4 Merge "Launching last task when back button is pressed in overview" into ub-launcher3-master 2018-08-08 17:34:46 +00:00
Tobias Dubois 7b5834d9b1 Fix overlapping FloatingViewType IntDef
TYPE_DISCOVERY_BOUNCE and TYPE_QUICKSTEP_PREVIEW have the same value.
Make sure each flag has a unique value.

Test: manual
Change-Id: I0fec3f27ffc31bad80d3af7b3baa3631b61b2567
2018-08-08 10:19:52 -07:00
Rajeev Kumar 147320e64e Use equals for string comparison in ItemClickHandler.
Bug: 112325801
Test: Manual test
Change-Id: I1b57dadac392d5c7f5a7fb367ddbaf79beb7faed
2018-08-07 15:22:14 -07:00
Sunny Goyal 719fcb1561 Using proper checks for hardware bitmap usage
Change-Id: Ic8efef8ac54ee4c7887860c404060da3c00f4024
2018-08-06 17:00:55 -07:00
Rajeev Kumar 6e1f150c82 Merge "Make AsyncTask static to prevent memory leak in WorkModeSwitch class" into ub-launcher3-master 2018-08-06 21:04:42 +00:00
Rajeev Kumar 88a2391f1d Make AsyncTask static to prevent memory leak in WorkModeSwitch class
Bug: 112163931
Test: Manual testing
Change-Id: I17d0cb871103693d9e901758fba2abb2b73874fb
2018-08-03 12:16:10 -07:00
Vadim Tryshev 7acde48955 Enabling more checks in TAPL tests.
Hiding workspace from tests when in AllApps or Overview.

Also, we don’t need workspace_page_container.

Bug: 110103162
Test: Running TaplTests suite
Change-Id: I10875a1ce5d41a015c63034160676578f52d2e98
2018-08-03 10:29:36 -07:00
TreeHugger Robot e98aab058e Merge "Fixing scrolling up in App Apps." into ub-launcher3-master 2018-08-02 22:58:25 +00:00
Jonathan Miranda d9d4b5b2dc Merge changes from topic "am-b9751869-5607-4cac-8442-b1dba848150a" into ub-launcher3-master
* changes:
  [automerger] Update launcher grid for tablet devices. am: 5eacbb7fc1
  Update launcher grid for tablet devices.
2018-08-02 22:16:06 +00:00
Sunny Goyal 9331521b7d Merge "Exposing some private methods to easily customize widgets popup" into ub-launcher3-master 2018-08-02 21:55:52 +00:00
TreeHugger Robot ce15b325e8 Merge "Retiring some feature flags" into ub-launcher3-master 2018-08-02 21:48:54 +00:00
Sunny Goyal db6cdb07e8 Exposing some private methods to easily customize widgets popup
Change-Id: Ie7bd879200b1f14d472ff03fd64429930651a39f
2018-08-02 14:41:08 -07:00
Vadim Tryshev ff3fa34a7a Fixing scrolling up in App Apps.
Done by scrolling only when scroll position is not zero. This way, the
scroll gesture can't close All Apps.

Bug: 110103162
Test: TaplTests suite
Change-Id: Icfe47d2bcc0210ae221df169d6c35cd1be10ff86
2018-08-02 14:15:05 -07:00
Sunny Goyal e39690b218 Launching last task when back button is pressed in overview
Bug: 111158326
Change-Id: Ib38f12f177780d15dbee69e4a27c21aaa9a3e087
2018-08-02 13:35:38 -07:00
TreeHugger Robot 0b74a7fe5e Merge "Preventing state change duing the swipe up animation when the previous app transition is not complete" into ub-launcher3-master 2018-08-02 18:52:11 +00:00
TreeHugger Robot 1314fee74d Merge "Revert "Create new ShortcutInfo when dropping predicted deep shortcuts."" into ub-launcher3-master 2018-08-02 16:21:07 +00:00
TreeHugger Robot d598f60d91 Merge "Fix All-apps search box background pixelation" into ub-launcher3-master 2018-08-02 16:20:33 +00:00
Stan Iliev dbcb8674fd Fix All-apps search box background pixelation
Enable bitmap filter for search box background. This avoids
jagged line, when bitmap is translated by half screen pixel.

Bug: 77841258
Test: Ran launcher on a device
Change-Id: I9293669da5db8be16ebe55ce01ab0e9735932c12
2018-08-02 11:59:04 -04:00
Android Build Merger (Role) 36d5963b4a [automerger] Update launcher grid for tablet devices. am: 5eacbb7fc1
Change-Id: Ia3de5e3b9956047573cb1d09173021576bd8fa56
2018-07-31 18:15:13 +00:00
Jon Miranda 5eacbb7fc1 Update launcher grid for tablet devices.
* Number of hotseat icons matches number of workspace columns.
* Evenly space out the workspace icons.

Bug: 111617973
Change-Id: Ia80e6354c8d449f2a397db5fd432cebc9f23027f
2018-07-31 11:15:01 -07:00
TreeHugger Robot e5f7acf74a Merge "Stop DiscoveryBounce when user drags to home from Hotseat in Overview." into ub-launcher3-master 2018-07-31 18:07:44 +00:00
TreeHugger Robot 899c08aee8 Merge changes from topic "am-402aa8b3-7a45-468a-931d-83007cd71180" into ub-launcher3-master
* changes:
  [automerger] Increase max distance for folder creation for tablets. am: 5aab8703ee
  Increase max distance for folder creation for tablets.
2018-07-27 23:08:37 +00:00