Commit Graph

16456 Commits

Author SHA1 Message Date
Hyunyoung Song b3d739dfa9 Apply Silk/ colorBackground(Floating) to AllApps
Bug: 180020638
Test: adb shell setprop persist.sysui.monet 1 && adb shell am crash com.android.systemui
Change-Id: Ied508f3452a3e640495fff4d1567c3b094f54432
2021-02-11 10:52:06 -08:00
Steven Ng fa58bfa0b7 Merge "Refactoring before adding a new view type in the WidgetsListAdapter" into sc-dev 2021-02-11 01:06:11 +00:00
Adam Cohen 12e547f2a8 Merge "Draw the workspace scrim in the LauncherRootView instead of DragLayer" into sc-dev 2021-02-10 23:33:06 +00:00
thiruram 91d4f9f007 Fix to avoid NPE with LiveSearchManager.
Bug: 179911188
Test: manual
Change-Id: Ic7f8ae7f7e2795eb18569670e166310102b7ea02
2021-02-10 23:24:32 +00:00
vadimt 2b6d18230b Instrumenting swiping up to all apps for jank
Bug: 178656784
Test: manual
Change-Id: I2332f0f358dc7312dc7ad0b88bc51db5bfa8be6c
2021-02-10 15:24:02 -08:00
Jon Miranda 228877d37c Add border spacing and fixed cell height to grid.
- Border spacing is the spacing between the cells.
- Workspace cell height is now fixed, and we allocate
  all the "extra" space to three different variable height
  areas.

* Built behind ENABLE_FOUR_COLUMNS flag because it hinders the
default grid.

Bug: 175329686
Test: - set border spacing to 0 and confirm matches prior layout
      - test drag and drop still worked
      - test reordering
      - test widgets
      - test folders
      - test multiwindow

Change-Id: Ic6f3dff577d28ff214bda4b0a787ec7fd08c108b
2021-02-10 17:22:37 -05:00
Steven Ng 2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
Adam Cohen 501e139c6e Draw the workspace scrim in the LauncherRootView instead of DragLayer
=> The entire DragLayer is translated during the -1 transition which creates a janky looking edge at the top of the screen

=> By bumping the scrim up a level, we avoid this

=> Separated WorkspaceAndHotseatScrim into two separate scrims, since only part of the scrim needed to be bumped up to a level. Further, it was an overloaded class.

=> We had previously been implicitly relying on the fact that the scrim was rendered in the Workspace parent; we need to make sure to propagate workspace inavlidations to the container of the scrim. While things would still work without this change, it's more correct to leave it, as we no longer assume a hierarchy for functinoality.

Bug: 178215332

Test: manual verification. See video in bug.

Change-Id: I0a76ddf35ceea8c9635367f69380ef24f42e9479
2021-02-10 19:16:26 +00:00
thiruram 03f8dcb8a4 Add instanceId to LAUNCHER_FOLDER_CONVERTED_TO_ICON log event.
Bug: 179534152
Change-Id: I0e4cedbfc2310258ec83f5dd756f8eb71189206b
2021-02-10 10:31:24 -08:00
thiruram 7823402ec9 Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event.
Bug: 179532038
Change-Id: Idfa1b82c35338a7472ff80d94fb20c69e498a028
2021-02-10 10:30:03 -08:00
thiruram 9aac07e87d [AA+] Add LAUNCHER_ALLAPPS_SWITCHED_TO_WORK_TAB & LAUNCHER_ALLAPPS_SWITCHED_TO_MAIN_TAB events.
Bug: 178562918
Change-Id: I6ae1e034dc8fbbca6fa046104ab69c1ec9f4e6da
2021-02-10 18:02:46 +00:00
thiruram aafa8a44a3 [AA+] Add LAUNCHER_ALLAPPS_KEYBOARD_CLOSED event.
Also adds Launcher.allAppsLogger method to simplify AllApps specific user events logging.

Bug: 178562918
Change-Id: I57520fe1504079091f0ff2c4c74268f727ffe14f
2021-02-09 16:45:52 -08:00
Thiru Ramasamy 9012515fef Merge "Fixes NPE with LAUNCHER_ALLAPPS_EXIT log event." into sc-dev 2021-02-09 23:37:17 +00:00
Sunny Goyal 9fa3a07086 Merge "Removing released features" into sc-dev 2021-02-09 19:57:18 +00:00
thiruram 61620e7537 Fixes NPE with LAUNCHER_ALLAPPS_EXIT log event.
Bug: 179720471
Test: rnlt -until-error -t com.android.launcher3.ui.TaplTestsLauncher3
Change-Id: Ic8f91092aa060a2225c059a89a33b6877cf35f36
2021-02-09 10:52:11 -08:00
TreeHugger Robot 823c5f8bf6 Merge "Enable variable size thumbnail for large screen" into sc-dev 2021-02-09 11:26:33 +00:00
Alex Chau 7944ee5c79 Enable variable size thumbnail for large screen
- Introduced a feature flag
- Refresh TaskView size when thumbnail is refreshed or Recents resizes
- Disable edge scale down in large screens
- Added temp method to get task width/height ratio
- In fullscreen, scale down TaskThumbnailView and disable TaskView elevation
- Task boxing mechanism: http://screen/3NkePthAVUVH2Rv.png

Bug: 174464656
Test: Manually test overview and quickswitch for folded and unfolded, including with RTL.
Change-Id: I2ce24d588a246cc6a2408039a37d884021aa0800
2021-02-08 19:40:49 +00:00
thiruram 73821a9c6d [AA+] Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event.
Bug: 179529616

Change-Id: Id35c952c94d8a10743f147b194d3c27e22bc5062
2021-02-08 10:11:32 -08:00
TreeHugger Robot fd03d04ae0 Merge "Enable slice again" into sc-dev 2021-02-08 08:55:00 +00:00
TreeHugger Robot bcf2ecc9e5 Merge "After AA+Search Edu, bring up IME" into sc-dev 2021-02-08 01:19:33 +00:00
Sunny Goyal 3186fbaed4 Merge "Adding support for keyboard based drag and drop" into sc-dev 2021-02-06 02:55:06 +00:00
Sunny Goyal a4647b681f Adding support for keyboard based drag and drop
For keyboard DnD, we use Accessible DnD implementation.
A placeholder FloatingView draws the focus indicator
for the virtual views

Test: Visible
Bug: 178781566
Change-Id: I632fc7377dffa1e05e3f0a9c3ad18641deb5a1a4
2021-02-05 13:05:24 -08:00
Sunny Goyal ead22a5257 Removing released features
Bug: 179224463
Test: Presubmit
Change-Id: I6aa989fa8e52398112cca2c7f4bed0ae69881f7b
2021-02-05 11:36:08 -08:00
TreeHugger Robot 1508e062e8 Merge "Postponing registering widget listener" into sc-dev 2021-02-05 19:23:29 +00:00
Hyunyoung Song 681154e533 After AA+Search Edu, bring up IME
Bug: 179154570
Test: Manual

Change-Id: I2d010103dd37b84b3672ba0d6ff5897373991585
2021-02-05 00:29:06 -08:00
Hyunyoung Song da74a44511 Enable slice again
Bug: 179068415
Test: manual
Change-Id: Ib2e8d17d91488719eb439fd55c8b24e62338fc94
2021-02-04 20:57:59 -08:00
thiruram 4fc871f977 [AA+] Add LAUNCHER_ALLAPPS_ENTRY, LAUNCHER_ALLAPPS_EXIT events.
This would help us to define clear start and end events for AllApps sessions on the server side.

Bug: 178562918
Change-Id: I77f236c9bc1a21e868545b1309e47d91d6fc1d96
2021-02-04 16:48:07 -08:00
Sunny Goyal b0bff050f2 Merge "Moving slice loading on a background thread" into sc-dev 2021-02-04 23:29:42 +00:00
Sunny Goyal 79e52fc23b Moving slice loading on a background thread
> Also fixing slice icon loading, such that the request is cancelled
  if views are recycled quickly
> Loading widget label on dg thread and cancelling request if views
  are recycled quickly.

Bug: 179068415
Test: verified locally
Change-Id: Id5a524e2bf596862330a8170394aef9ffd708544
2021-02-04 13:03:33 -08:00
Schneider Victor-tulias 2fd2694b9c Merge "Fix icon flicker on transition from installing, to installed, to downloading incrementally." into sc-dev 2021-02-04 18:19:08 +00:00
Alex Chau 4e2c25a788 Ensure isTablet is only enable when simulated landscape is disabled
- Tablet UI (e.g. grid overview and two panel workspace) is built with assumption that simulated landscape is disabled, make sure this is the case in DeviceProfile
- This is usually true as swDPs is generally smaller than sw used to determine xml files

Bug: 174464656
Test: Try different combination of smallest width and Display Size, isTablet is only set when allow_rotation is true
Change-Id: I3ee1c76909f29b6f14c4032be812bb8c9ea7e827
2021-02-04 11:24:06 +00:00
Tony Wickham d10b587003 Merge "Add recent tasks to Taskbar" into sc-dev 2021-02-04 06:30:37 +00:00
Tony Wickham aaa42bd0e8 Add recent tasks to Taskbar
- Also adds a divider between Hotseat and Recents
- Dedupes Recents from Hotseat

Test: Open some recent tasks, ensure they are deduped
from Hotseat and also handle < 2 tasks.

Bug: 171917176
Change-Id: Ia782c6ccbcda94cfd844aad04dc3d25a3f072c2b
2021-02-03 18:54:58 -08:00
Schneider Victor-tulias 1b4d5034fb Fix icon flicker on transition from installing, to installed, to downloading incrementally.
When an app finished downloading, we assumed that its progress level was 100%. This caused flicker in apps that supported incremental downloads. Added a check for the total download progress on app installation.

demo: https://drive.google.com/file/d/11NwwhHj_4rmDFwpsb8gTX-uA5YSinjSj/view?usp=sharing

Fixes: 178745816

Test: manual

Change-Id: I08328296db2ce2c2242fc4fe87158ff4b911c659
2021-02-03 16:39:16 -08:00
vadimt 04ebcf4686 Postponing registering widget listener
For the swipe-to-home gesture, the call will happen
after the animation.

This fixes jank during swiping up from an ap
to home.

Also renaming some methods for clarity.

Bug: 175048504, 173072373
Test: tracing
Change-Id: I070b23edb633d2ac0985d5eb9f75c789f8569772
2021-02-03 23:37:53 +00:00
thiruram f4d19f4614 [AA+] Log app launches from DeviceSearchResultContainer with instance ID.
This InstanceId is used to recreate the AA+ session on the server side.

Bug: 178562918
Change-Id: I1bba94417d3a142351e2470bb6153707d2cadb11
2021-02-03 10:17:18 -08:00
thiruram cbeb13d6c7 [AA+] Log app launches from AA+ search result container.
This change will update westworld logs for app launches from AA+ search result. Updates log's container info from AllAppsContainer -> AllAppsPlusSearchResultContainer.

Bug: 178562918
Change-Id: I9ffca27fea42951a57640ef36717c04ff0251506
2021-02-03 10:08:57 -08:00
Hyunyoung Song aa793ff226 Merge "Support shorter height row layout / Disable ICON_SLICE" into sc-dev 2021-02-03 16:47:02 +00:00
Hyunyoung Song 7239df7258 Support shorter height row layout / Disable ICON_SLICE
Bug: 178815297
Bug: 178128837
Bug: 178823469

Test: manual, attached screenshot on the bugreport

Change-Id: Ie69c8928f5acc430320cfc5c85547195866e829e
2021-02-03 01:25:16 -08:00
Hyunyoung Song 351aea720f Merge "Logs stack trace when IME doesn't get attached when all apps swipes up" into sc-dev 2021-02-03 08:33:05 +00:00
Hyunyoung Song 50165042ed Logs stack trace when IME doesn't get attached when all apps swipes up
Bug: 178904132
Test: Manual

Change-Id: I3b62a1a8e927ca8bac4db07053f781260fbff515
2021-02-02 21:42:41 -08:00
Schneider Victor-tulias d0f5aa0dc6 Merge "Update PreloadIconDrawable colors when an app is not startable." into sc-dev 2021-02-02 21:30:15 +00:00
Schneider Victor-tulias 2e292b6343 Update PreloadIconDrawable colors when an app is not startable.
Updated the progress bar and progress track colors when the app is not startable to increase contrast.

Demo: https://drive.google.com/file/d/1iHYBeHgWsItY6edO3NT1RYuXjdKNlEKH/view?usp=sharing

Test: manual

Bug: 171005849

Change-Id: I97bc4e3299108b1e8ef47b498fb3431293f57ad2
2021-02-02 21:30:05 +00:00
Hyunyoung Song 5809a40f3e Fix issue of slice icon being rendered on non-UIthread
Bug: 178989579
Test: Manual

Change-Id: I23aa5055c8f07ee9877c1f3ce51cb280ac38a2b7
2021-02-02 01:25:45 -08:00
Andy Wickham ad1d1cfda0 Merge "Allows a plugin Settings activity to designate plugins it supports." into sc-dev 2021-02-02 08:57:51 +00:00
Tony Wickham 794fe4f58e Add Hotseat items to Taskbar
- Currently supports WorkspaceItemInfo (e.g. normal app icons
  including hotseat predictions and pinned deep shortcuts).
- Currently doesn't support Folders, Notification dots, or
  long press.

Some technical details:
- Always allow HotseatPredictionController updates given the
  Hotseat is always showing even when Launcher is stopped.
- Represent Taskbar Hotseat items as BubbleTextViews, to
  allow for normal click handling etc. When the hotseat is
  updated, we reuse the same BubbleTextViews that were
  initially inflated, and just reapply the new info.
- Add new BubbleTextView iconDisplay for Taskbar, to allow
  for different treatment such as icon size.

Bug: 171917176
Change-Id: I325eb39051f2dc69228b39b5c40ed0cbdad8e200
2021-02-01 18:29:06 -08:00
Andy Wickham 2b14f4bfd4 Allows a plugin Settings activity to designate plugins it supports.
The activity can add categories to its intent filter which
match the actions of the plugins it supports. The Settings
icon is only shown next to these plugins.

This is useful if an app (e.g. SupportApp) implements
multiple plugins which may each want their own settings.

Note: If any settings activity in an app specifies
categories of plugin it supports, any other settings
activities in the same app must also provide categories
of their plugins to disambiguate.

Test: Manually with SupportApp (including mix of plugins
with and without Settings activities) and AwarenessSpace
plugin (with a non-categorized settings activity).

Change-Id: If3ab7b5f7f916fd3f6b05b89cf1a22c9d21403cc
2021-02-01 15:57:00 -08:00
Schneider Victor-tulias 5f7f4cb35d State download information in content description whether or not there was an update.
Talkback wasn't announcing the incremental download/install progress if the progress wasn't updated. Updated BubbleTextView to update the content description with the incremental download/install info if the progress bar should be shown.

Fixes: 149444435

Test: manual
Change-Id: I3efe6e31cec389da4119a2179a341aedd074a0b7
2021-02-01 19:01:11 +00:00
Sunny Goyal 11b5f6053f Removing unused keyboard handling code
Bug: 178781566
Test: Presubmit
Change-Id: I997a7980f4ae2cef1e599ca2cadffc56df5f296e
2021-01-29 17:02:34 -08:00
TreeHugger Robot 80466c081a Merge "Support people search results" into sc-dev 2021-01-29 23:47:00 +00:00