Commit Graph

16456 Commits

Author SHA1 Message Date
Steven Ng f4fb4d9429 Fix corner radius for single item in the widgets tray.
If there is only one item, corner radius at 4 corners should be 28dp.

Test: Corner radius of one item is correctly shown in the widgets
      picker.

Bug: 183382610
Change-Id: Ief46af8c41ce944792d08212e93f7d68c6278d05
2021-03-22 16:30:57 +00:00
Jonathan Miranda 93e1e56675 Merge "Dump DeviceProfile to help with debugging grid changes Some of these internal values are not exposed in hierarchy viewer" into sc-dev 2021-03-22 15:48:46 +00:00
Steven Ng 267270e859 Align widgets previews top to the table layout
Test: Manual

Bug: 179797520
Change-Id: I0716432e72327b825619bc35d55cb74d9621ee6a
2021-03-22 15:26:13 +00:00
Steven Ng 6a2acfaa59 Add an 65% opacity for workspace elements drag over button drop target
Also remove the draggable item hover top button color change.

Test: Manual
Bug: 183193201
Change-Id: Id80622b8c0152180c47c0c9ebff8aa8bc2a5c2be
2021-03-22 13:20:48 +00:00
Yogisha Dixit 471922c5ac Do not allow widget to be resized beyond max size.
Test: manual
Bug: 179807199
Change-Id: I38e108a8db2c5f06c0922972efa334e3b2864046
2021-03-22 11:14:48 +00:00
Steven Ng f3814eea2d Merge "A11y fix for all widgets tray (Part 2 / n)" into sc-dev 2021-03-22 10:22:54 +00:00
Hyunyoung Song a22574aa66 Remove cursor when edit text no longer has focus
Bug: 180142918

Test: manual
Change-Id: I9a58ef605b145889e30cb42e99f0b98e16af1e46
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2021-03-21 15:59:34 -07:00
Samuel Fufa 7bcdaa13c7 Merge "[Search] Tie quick-launch and focus highlight" into sc-dev 2021-03-21 20:33:25 +00:00
Steven Ng e85b5565c6 A11y fix for all widgets tray (Part 2 / n)
Fix the focus change when expanding / collapsing an app in
the all widgets tray by adding stable ids and disable item
animator.

Item animator is also disable even accessibility isn't enabled
because the default item animator also disrupts the header
padding. It also makes the expansion / collapsing of widgets table
very unpredicible.

Test: Navigate all widgets tray with talkback on.

Bug: 183120145
Change-Id: Ib1e2ea4d543757248e635a834204db688532cbfa
2021-03-19 23:58:19 +00:00
Steven Ng 682af23651 Merge "Renders widget recommendations" into sc-dev 2021-03-19 23:18:22 +00:00
Jon Miranda 116e94e0a7 Account for children margins when orienting popup container.
Instead of recalculating the orientation after adding margins,
we account for the margins in the initial calls to orientAboutObject.

This ensures consistent mIsAboveIcon throughout calls to show the popup.

- Also updates the smaller radius to match the middle items.

Bug: 175329686
Test: long press on item where height and height without margins would
      result in differing mIsAboveIcon values
      eg. the 3rd item in a folder in the top middle of 5x5 workspace

Change-Id: I6132b544a89c7948339d17f219ad75c797233f55
2021-03-19 18:30:03 -04:00
Tony Wickham 9053b90751 Fix spring loaded scale when taskbar is present
Test: scaled workspace doesn't overlap QSB during drag and drop
Bug: 171917176
Change-Id: I56c7ee834e2c3ee2c796e88e83f75dbd24d28bd5
2021-03-19 15:13:24 -07:00
Steven Ng 4235fc129c Renders widget recommendations
Update the tapl test logic to scroll a smaller distance to avoid the
search bar blocking the target touch area.

Test: Open full widgets sheet and observe the widget recommendations
      shown at the top.
      Run AddConfigWidgetTest

Bug: 179797520

Change-Id: I6d53bbb46e2cb928ed7d015aaac604be17d33178
2021-03-19 21:11:32 +00:00
Jonathan Miranda 83c4b1fd72 Merge "Folder updates." into sc-dev 2021-03-19 20:40:49 +00:00
Samuel Fufa 147527229b [Search] Tie quick-launch and focus highlight
Highlight and quick-launch item should be determined by Search service pipeline based on quick_launch flag on SearchTarget

Bug: 183083807
Bug: 183083682
Test: Manual
Change-Id: I0191474653deca7e1ecd01fa92c90efcdbb9a8dc
2021-03-19 15:38:38 -05:00
Jonathan Miranda 48a2f09349 Merge "Add separate background colors to each popup container child." into sc-dev 2021-03-19 20:34:10 +00:00
Tony Wickham 4076cae87f Merge "Use taskbarSize as bottom inset when taskbar is present." into sc-dev 2021-03-19 18:15:52 +00:00
Samuel Fufa 9751c532e4 Merge "Move SearchWidgetInfoContainer to NexusLauncher" into sc-dev 2021-03-19 18:07:39 +00:00
Jon Miranda 2a58d13b9b Add separate background colors to each popup container child.
- Colors interpolate between the primary and secondary popup colors
- Removed condensed height and icon scale

Bug: 175329686
Test: visual, manual checking apps with different shortcut options
Change-Id: I064c329dc8ad3ae6f408056c74372cca3ce20b68
2021-03-19 13:41:07 -04:00
Tony Wickham ff78367361 Merge "Fix QSB and Hotseat positions when ENABLE_DEVICE_SEARCH is enabled" into sc-dev 2021-03-19 17:32:19 +00:00
Alina Zaidi 7358069a91 Merge "Fix bugs for Widgets picker Search UI." into sc-dev 2021-03-19 16:57:11 +00:00
Zak Cohen 02393204e6 Merge "Return empty, not null, a11y node in Workspace" into sc-dev 2021-03-19 16:56:02 +00:00
Jon Miranda 0369cd5470 Folder updates.
- 3 item folder preview has the first item on top of the other 2
- Skip first frame of the folder open animation as there is no
  visual change in that first frame.

Bug: 175329686
Test: visual
Change-Id: Ida9a55ee5093c49f230cdf22d7943b2a6a7ed42d
2021-03-19 12:07:19 -04:00
Alina Zaidi c4f3f49805 Fix bugs for Widgets picker Search UI.
- On orientation change, clear search bar.
- Change text and search bar color to make similar to mocks/ all apps search bar.
- Fix search recycler view visual bugs.
- If back is pressed in search mode, exit search mode instead of exiting widget picker.

Test: Manually seen widget picker on phone.
Bug: 183103133
Bug: 183103936
Bug: 183115050
Bug: 157286785
Change-Id: I056f089eada84d00133038f4a3d7b18bc51be564
2021-03-19 14:42:47 +00:00
Jonathan Miranda b0cb399d21 Merge "Update deep shortcut to new ui." into sc-dev 2021-03-19 13:31:08 +00:00
Steven Ng be73868634 Merge "Notify WidgetHostView drag content change only at onDraw" into sc-dev 2021-03-19 12:38:32 +00:00
TreeHugger Robot fd0a75e1fb Merge "Don't store Launcher as a class variable in CellLayout" into sc-dev 2021-03-19 12:28:46 +00:00
Zak Cohen f19300e479 Return empty, not null, a11y node in Workspace
It's not valid to return a null accessbilitynode.

Test: local
Bug: 182529089

Change-Id: I94245fb33128c68e33ce388284f64e5ac3bb23dc
2021-03-18 20:48:45 -07:00
Tony Wickham 72c15ef913 Fix QSB and Hotseat positions when ENABLE_DEVICE_SEARCH is enabled
Test: visual
Change-Id: I755de7552e2bb3f927f6be59c07f910ddfbc4650
2021-03-18 18:06:47 -07:00
Evan Rosky 16a713c450 Merge "Add rotation support to launch animations" into sc-dev 2021-03-18 23:24:50 +00:00
Steven Ng cc505b8ae4 Don't store Launcher as a class variable in CellLayout
CellLayout can be used by non launcher context, e.g. style &
wallpaper preview. To be safe, don't store Launcher as class
variable.

Test: Preview in style & wallpaper works fine
      Drag icons from hotseat.
      Drag widgets from workspace.

Bug: b/182282587
Change-Id: I9358eebce66ff1a46adbfb0602ae2bc970a921a6
2021-03-18 23:22:05 +00:00
Steven Ng 6f98e1ebd0 Notify WidgetHostView drag content change only at onDraw
Reapply RemoteViews can happen asynchronously. RemoteViews may
not finish reinflation right after setColorResource. Let's call
it onDraw.

Test: Manual

Bug: 182282587

Change-Id: I3653b4c64a5897637181f61096464b75945ab5f5
2021-03-18 22:01:18 +00:00
Tony Wickham b31d8fc379 Use taskbarSize as bottom inset when taskbar is present.
This was done in ag/13841736 but not included in ag/13821586

Test: QSB in correct position when taskbar present and not present
Bug: 171917176
Change-Id: I6aa220559afebe8710b5f01cdec9c2baa9f4c926
2021-03-18 13:57:20 -07:00
Mariia Sandrikova f7864feded Merge "Revert "Enable Live Tile"" into sc-dev 2021-03-18 19:18:34 +00:00
Mariia Sandrikova ea0d30de68 Revert "Enable Live Tile"
This reverts commit 56c0931e99.

Reason for revert: DroidMonitor: Potential culprit for Bug 183078688 - verifying through Forrest before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Fix: 183078688
Fix: 183091281
Change-Id: I050b3e26d35a7a1b60b5ccc58d371a7ab8efb0dc
2021-03-18 16:44:50 +00:00
Sunny Goyal fa699566f5 Merge "Adding an optional QSB in hotseat" into sc-dev 2021-03-18 16:07:45 +00:00
Jon Miranda c79316740b Update deep shortcut to new ui.
- Removed divider views, using margin to separate views
- Removed elevations
- Added a ViewGroup to hold all notification views, and applied an outline

Bug: 175329686
Test: visual
Change-Id: Iad70dcfdaeba6050c2b17c07f76bb7bfb728e544
2021-03-18 11:09:34 -04:00
Steven Ng 93c29bff5b Merge "Apply local color extraction during drag-n-drop" into sc-dev 2021-03-18 12:37:19 +00:00
Alina Zaidi 378ca5e920 Merge "Bug fixes for widget picker search." into sc-dev 2021-03-18 10:32:18 +00:00
Steven Ng 99060b30ca Merge "Adjust font, color, margin, corners for all widgets tray" into sc-dev 2021-03-18 10:25:00 +00:00
Tracy Zhou 7e7bab4cb6 Merge "Enable Live Tile" into sc-dev 2021-03-18 05:24:48 +00:00
Tracy Zhou 56c0931e99 Enable Live Tile
Fixes: 169694902
Fixes: 174866547
Fixes: 181937887
Test: manual
Change-Id: I5f2f304d4003e72ed2fb4ea0b0c74f06d2adfe4b
2021-03-17 18:34:52 -07:00
Steven Ng 08ef694509 Adjust font, color, margin, corners for all widgets tray
Test: manually
Bug: 179797520
Change-Id: Ib78aae05e021da272ef2f754c876d24a4c14bcb0
2021-03-17 22:43:12 +00:00
[1;3C a608d81359 Add rotation support to launch animations
This only adds support for launch animations. Recents
requires some auxiliar work.

Adds a rotation parameter to the animation targets that
only gets used by shell transitions. If this is non-zero,
launcher will transform it's coordinates relative to that
provide rotation.

Bug: 179308296
Test: Launch and exit apps with different orientation from
      default (portrait).
Change-Id: I7b52cbd37432bcd43e7155bcb07b30cc65c43186
2021-03-17 15:30:47 -07:00
Sunny Goyal c373e1c642 Adding an optional QSB in hotseat
Removing sections in all-apps during transition and treating
it as a single unit

Bug: 175137718
Test: Manual
Change-Id: I55a501d80b5903f1a9d92a26b3784784fd9e50fd
2021-03-17 12:21:44 -07:00
Steven Ng 30dd1d65f6 Apply local color extraction during drag-n-drop
Test: Drag a test widget around and observe local extract color
      is applied.

Bug: b/182282587, b/182816217
Change-Id: If63a9d91ceb2102d5d913bca85997b8be07b1adf
2021-03-17 18:10:51 +00:00
Jon Miranda 01554536a9 Snap to destination page before animating folder close.
This ensures the X page animation runs in the preview.

Bug: 175329686
Test: Scroll to 2nd page, and close folder before scroll finishes
Change-Id: Id4820a212dcc945b0134b79f3d42c68954b17275
2021-03-17 12:15:48 -04:00
Jon Miranda 58561d4fd7 Dump DeviceProfile to help with debugging grid changes
Some of these internal values are not exposed in hierarchy viewer

Bug: 175329686
Test: Take bug report and verify output
Change-Id: Ic39be510682fe5aeb03b7436858f6442895c796f
2021-03-17 11:50:08 -04:00
Alina Zaidi 2e732e95d9 Bug fixes for widget picker search.
SearchBarController
- Use Extended Edit Text to handle close keyboard action well.
- On press enter while search remove focus from bar and hide keyboard.
- On cancel button press hide keyboard and also reset search targets to empty so that on next search session the previous results dont flash (show for a short time before reflecting users query).

WidgetsFullSheet
- Make sure expanded header are reset when user leaves personal/work recycler views. Search recycler view resets its expanded header on every search already.
- Show 'no search results' view if no search result present.
- Update WidgetListBaseRowEntryComparator to show personal profile widgets first.

Test: Tested prototype locally.
Bug: b/157286785
Change-Id: Ibaa208c4091783e14ac0887caf559e867185df5a
2021-03-17 14:43:04 +00:00
Alex Chau 1e024358ad Merge "Two panel & two page swipe & currentPage fixes" into sc-dev 2021-03-17 13:47:01 +00:00