Commit Graph

14731 Commits

Author SHA1 Message Date
Sebastian Franco 91c37bbd09 Restrict the area for the input to unsatsh the taskbar
The input to unstash the taskbar should only be 48dp more than
taskbar_stashed_handle_width or 316dp for wich I created a new
variable.

Bug: 204166104
Test: Manually stashing and unstashing the taskbar.
Change-Id: I94e2e289fcd1169ed0e38a0c45abca6c0ae5c502
2022-02-28 15:52:08 -08:00
TreeHugger Robot 406bbb418c Merge "Removing some unnecessary layout calls in TaskView" into tm-dev am: 094a4bdd48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16991032

Change-Id: I127ada46ede783fb87da79272b5527327121f9b2
2022-02-28 22:29:57 +00:00
TreeHugger Robot 094a4bdd48 Merge "Removing some unnecessary layout calls in TaskView" into tm-dev 2022-02-28 22:16:30 +00:00
TreeHugger Robot ba297c19c2 Merge "Passing in the launch cookie for widget broadcast trampolines" into sc-v2-dev 2022-02-28 19:11:10 +00:00
vadimt b0e0f5f44a Adding better diags when SysUI crashes during Launcher test
Test: presubmit; sys ui tests where this rule is already used
Bug: 187761685
Change-Id: Ib4491e5c7ebbea0bb3b17fc8c4b3a6c59a3bdb2a
2022-02-28 18:59:25 +00:00
Pat Manning 2da28dcdc9 Refactor force visible nav bar into new secure setting.
Decouples force visible from kids mode setting.

Bug: 217668440
Test: manual
Change-Id: Ia8a2b30eab7633e3b686c9afebd7e683ef984deb
2022-02-28 14:55:47 +00:00
Hyunyoung Song 6e35e11dd5 Merge "Change the all apps atomic transition duration to 150 ms" into tm-dev am: fbdf40ff4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17006607

Change-Id: I9471167d0ca3c68b5078cd5cf3e0d67948a0efa2
2022-02-25 23:31:05 +00:00
Hyunyoung Song fbdf40ff4f Merge "Change the all apps atomic transition duration to 150 ms" into tm-dev 2022-02-25 22:59:56 +00:00
TreeHugger Robot 02f4062ca9 Merge "Dump DeviceProfile in TouchInteractionService dumpsys" into tm-dev am: cacb21cba9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17002613

Change-Id: I68a93c5b2206f989ec8b6fa47df4abd88a469389
2022-02-25 20:33:41 +00:00
Winson Chung d3a337609a Just return an empty list if the system returns null am: e479619836 am: 0f86fee612
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17008524

Change-Id: Ic0d36f7132e5afcfe35c0d23676ef1b75461c66a
2022-02-25 20:17:54 +00:00
TreeHugger Robot b95eef28c9 Merge "Passing in the launch cookie for widget broadcast trampolines" into tm-dev am: 2a431f4a79 am: e1d67bf12e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16940248

Change-Id: I8d0afbdbb64a1e1aad99949dc126a872408b65bd
2022-02-25 19:21:34 +00:00
Alex Chau 890e4a75c3 Dump DeviceProfile in TouchInteractionService dumpsys
- So DeviceProfile dumpsys will be available in bugreports, useful for debugging
- Only dump DeviceProfile in createdOverviewActivity if it's non-null

Fix: 221395133
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: Iaf7b7abd25771814be6cb918e96e042d1085debb
2022-02-25 12:46:27 +00:00
Nicolo' Mazzucato d986bbd0fa Register hinge angle sensor listener in a background thread
This was taking ~13ms on the ui thread

Bug: 221394115
Test: Manual
Change-Id: Ibadade5b1c3c8d33a292d36bb6a03dd8021861be
2022-02-25 12:37:44 +01:00
Winson Chung e479619836 Just return an empty list if the system returns null
Bug: 206648922
Test: Presubmit (unable to reproduce this)
Change-Id: I04a4759a1c237513ab314ece4acd542e1407edb1
2022-02-25 06:41:45 +00:00
TreeHugger Robot 2a431f4a79 Merge "Passing in the launch cookie for widget broadcast trampolines" into tm-dev 2022-02-25 00:21:27 +00:00
Hyunyoung Song d68872426c Change the all apps atomic transition duration to 150 ms
Test: manual

TL;DR;; this value is used for tap on qsb all apps container
atomic transition. 320 is value that used to be used in R
when all apps travel distance used to be entire window height.
In S, we reduced the travel distance to 1/3 of the height.

Change-Id: Ib66f8a4408fd77350c31c5b894d9f8b2c889159f
2022-02-24 20:33:23 +00:00
Sebastian Franco 5a9dce518e Combining the Thumbnail bitmap with the background to fix background spilling in the front.
What's happening is that we first draw a background,
on top of it, we then draw the Task and because we
have a curvature the corners have pixels with transparency,
and those pixels get combined with the background pixels.
Most tasks have a transparent background or background
of the same color as the task so we don't see this
but for example, Telegram has a white background and
you can see this in the corners.

Fixed by creating a bitmap, drawing the background on it
and then drawing the thumbnail on top of it then using
that bitmap to draw it on the canvas.

Test: Put Telegram in recent Task (shouldn't be the first one) and you won't see a white border. Also when a task was in multitask the backgroudn should be draw.
Fix: 146521490
Change-Id: Id02a64ef472eb07900b0c7c5522d931d5b08f94e
2022-02-24 19:11:55 +00:00
Winson Chung 871759483b 1b/ Replace removed shared lib calls with direct calls
Bug: 219861883
Test: Builds
Change-Id: I7831d0de14286c9fa39fed59b168535e0a70d94d
2022-02-24 18:04:02 +00:00
Sunny Goyal 8e5a164e05 Removing unnecessary AM.getTasks() call on every touch
Bug: 220906427
Test: Verified on device
Change-Id: I58ed22c4d6069f10198ec30ec02fa8c2f7c55cbe
(cherry picked from commit d2ec834fac)
2022-02-24 17:40:54 +00:00
Nicolo' Mazzucato 5a0a17f119 Fix scaling of workspace and hotseat with wrong pivots
Bug: 219962098
Test: Unfolded device
Change-Id: I7dd9f0579ea737cd67792e612657a043411ac70e
2022-02-24 17:53:40 +01:00
Alex Chau 98c5365a23 Merge "No longer stash taskbar when swiping up all apps" into tm-dev am: 21c63bc809
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16992837

Change-Id: I3964da2eeb546ff016e3e2f6c57a56b333267663
2022-02-24 14:16:56 +00:00
Alex Chau 21c63bc809 Merge "No longer stash taskbar when swiping up all apps" into tm-dev 2022-02-24 11:59:57 +00:00
Mady Mellor 4ce7e7362a Merge "Add a reason to the broadcast to collapse system dialogs" into tm-dev am: 57eab45996
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16940036

Change-Id: I011d6f76579efdf3868cd168ca981ec7dfe45bcb
2022-02-24 03:16:38 +00:00
Mady Mellor 57eab45996 Merge "Add a reason to the broadcast to collapse system dialogs" into tm-dev 2022-02-24 01:30:11 +00:00
TreeHugger Robot 355a5fa8df Merge "Removing unnecessary AM.getTasks() call on every touch" into tm-dev am: dde28b487e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16992834

Change-Id: Iddfb185ad56ff1a7f0d5211ef5b1bbf403b2939e
2022-02-24 00:41:18 +00:00
TreeHugger Robot dde28b487e Merge "Removing unnecessary AM.getTasks() call on every touch" into tm-dev 2022-02-23 23:38:14 +00:00
Tony Wickham 4fda59a0cc No longer stash taskbar when swiping up all apps
Instead, scale down hotseat behind all apps alongside workspace.

Test: Swipe up to all apps from home; all apps button in an app works as before
Fixes: 221094533
Change-Id: Ia6f1e7bac86849018dc8d0b1d95f0bab963835a8
2022-02-23 22:04:35 +00:00
Sunny Goyal d2ec834fac Removing unnecessary AM.getTasks() call on every touch
Bug: 220906427
Test: Verified on device
Change-Id: I58ed22c4d6069f10198ec30ec02fa8c2f7c55cbe
2022-02-23 13:35:25 -08:00
Sunny Goyal d4c4ad9212 Removing some unnecessary layout calls in TaskView
Bug: 221095750
Test: Presubmit
Change-Id: I277c1350109ce3bd0b29502c588482c737ab1e3d
2022-02-23 13:06:46 -08:00
TreeHugger Robot c089baa668 Merge "Remove Taskbar and Taskbar EDU flags." into tm-dev 2022-02-23 20:10:02 +00:00
Alex Chau a691a126f2 Merge changes from topic "allapps_bottomsheet_motion" into tm-dev am: d8f81e9bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16967984

Change-Id: I65849784b90c39780ba3ff95f57b1dcf9e86d0b9
2022-02-23 19:57:45 +00:00
Alex Chau d41a60cbed Merge "Disable flakey fallback recents test" into tm-dev am: 82166fa6d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16984327

Change-Id: I81229ca746c4bba6db9e43e837f65796542f0114
2022-02-23 18:23:41 +00:00
Vinit Nayak 58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
TreeHugger Robot 9f7ceb1c91 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev am: 49cb99a420
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16967985

Change-Id: I05ccfa5901e84dd103348ae16dad28cb1edb2408
2022-02-23 18:14:14 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Brian Isganitis a1370bfc5f Put taskbar all apps in separate overlay window and stash taskbar.
All apps should display below system UI components such as the
notification tray and power menu, so an overlay window is more
appropriate. As a result, all apps has a separate window activity
context, but some properties are delegated to the taskbar activity
context. Taskbar should also be stashed while all apps is open.

Change-Id: I593457708779d84a0ab8b949a966d247d0a2e1b7
Test: Manual
Bug: 216843189
Fix: 217383817
(cherry picked from commit 473b980bf9)
2022-02-23 15:06:56 +00:00
TreeHugger Robot 0f3b6511aa Merge "Fix Launcher icons not animated during unfold" into tm-dev 2022-02-23 14:03:39 +00:00
TreeHugger Robot 48eb613faa Merge changes from topic "presubmit-am-ddc50923f526483b85e0fd6e691a1b93"
* changes:
  [automerge] Fix Launcher icons not animated during unfold 2p: d4a5bb244a 2p: faca3573ea
  [automerge] Fix Launcher icons not animated during unfold 2p: d4a5bb244a
  Fix Launcher icons not animated during unfold
2022-02-23 14:03:39 +00:00
Alex Chau 82166fa6d8 Merge "Disable flakey fallback recents test" into tm-dev 2022-02-23 10:58:26 +00:00
wilsonshih a8fe8b448e Cancel recents animation when touch home key(2/2)
There should send an opening task transition to remote transition
handler to finish the recents animation. For now there is no opening
transition send to Shell because the exist home activity won't be
collected while start home activity.

To collect the home activity, do not set transient launch when start
recents animation if the top activity is home, so the home activity
would be paused. Then when user touch home key to cancel recents, the
home activity will be resumed so it can be collect to the transition.

When receive opening home activity while recents is running, enter
home and dismiss recents.

Bug: 207297486
Test: 1. Enable shell transition.
      2. Setup 3rd-party launcher as default home.
      3. Entering Recents from home.
      4. "adb shell input keyevent KEYCODE_HOME", verify recents
	 animation will be dismissed.
Test: atest NexusLauncherTests:com.android.quickstep.FallbackRecentsTest
Change-Id: I689032d1fa18aa9a923aaf89077dbd73c09721b7
2022-02-23 16:07:59 +08:00
Winson Chung 4c2e3310e6 Disable flakey fallback recents test
- Seems to be an existing failure in the recents animation not
  finishing, should disable to unblock folks

Bug: 218403080
Test: Presubmit
Change-Id: Ia42009666c67c29c1a78a2fe197bdce53dcb2ec8
2022-02-23 06:44:55 +00:00
Brian Isganitis 97e6318bd8 Merge "Put taskbar all apps in separate overlay window and stash taskbar." 2022-02-23 03:46:04 +00:00
TreeHugger Robot 49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Brian Isganitis 473b980bf9 Put taskbar all apps in separate overlay window and stash taskbar.
All apps should display below system UI components such as the
notification tray and power menu, so an overlay window is more
appropriate. As a result, all apps has a separate window activity
context, but some properties are delegated to the taskbar activity
context. Taskbar should also be stashed while all apps is open.

Change-Id: I593457708779d84a0ab8b949a966d247d0a2e1b7
Test: Manual
Bug: 216843189
Fix: 217383817
2022-02-22 17:03:17 -08:00
Mady Mellor 411e862175 Add a reason to the broadcast to collapse system dialogs
Test: manual - see other CL in topic
Bug: 218517365
Change-Id: I9aa686bb95f11b4eeab0139833876abaf8b80cad
2022-02-22 14:14:34 -08:00
Jordan Demeulenaere 705bb55a0c Enable back gesture when a SyUI dialog is showing (2/2) am: 78ef3a5348 am: 35de1e5e2e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16976103

Change-Id: I57cfeb051f9bd48e469a0e532ccb8d36bea8e083
2022-02-22 18:14:43 +00:00
Nicolo' Mazzucato 5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
Presubmit Automerger Backend 8be05707b4 [automerge] Fix Launcher icons not animated during unfold 2p: d4a5bb244a 2p: faca3573ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16968686

Bug: 197834977
Change-Id: Ibdb5584f1671e181c9d57882dad3815d6e0315ce
2022-02-22 12:49:45 +00:00
Nicolo' Mazzucato d4a5bb244a Fix Launcher icons not animated during unfold
If icons are re-bound during the animation, they were not moved. I was able to reproduce this case 100% of times by folding, restarting launcher and unfolding. From a perfetto trace it seems that in this case `finishBindingItems` was called after the animation already started, therefore not registering any view.

With this cl, items are animated also after they are rebound.

Bug: 197834977
Test: folded -> restarted launcher -> unfolded -> verified icons are now moving towards the center
Change-Id: I5b001c502860c17d6ea5d54d099f04b2ddf1820a
2022-02-22 13:48:35 +01:00
Jordan Demeulenaere 78ef3a5348 Enable back gesture when a SyUI dialog is showing (2/2)
Test: Manual
Bug: 210270549
Change-Id: I8fbf9a90287cbd8d9ddad354e24bbc4d074bd0ef
2022-02-22 11:09:03 +01:00