Commit Graph

14731 Commits

Author SHA1 Message Date
Jerry Chang 37d39619fa Merge "Fix Flicker of inner corners in split screen when quick switching to" into tm-qpr-dev 2022-06-07 00:55:51 +00:00
TreeHugger Robot ed08b449e7 Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev am: 9307776597 am: 1a339394af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18759197

Change-Id: I9917b5370bc0b53c1ebca71870185c60d323fa2b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 22:42:10 +00:00
Vinit Nayak 368d4276f4 Prevent showing divider if launcher was never shown
* With stashing recents animation gets cancelled
almost instantly, so there's no point trying to
"show" the divider bar if it was never hidden
* We can use launcher showing as a good enough
proxy for whether the divider bar was ever hidden
to begin with

Fixes: 230825541
Test: Stashing/unstashing didn't cause crash
Change-Id: I3abc4ecf3605a66e67db971ae14aa6ec493d8f32
2022-06-06 15:30:27 -07:00
Winson Chung 29c68e73dc Revert changes waiting for launcher to resume when transitioning to home
- This was added for Go when they had their own recents implementation
  and isn't necessary for the default implementation

Bug: 229668039
Test: Follow steps using test apk from the bug
Change-Id: I0c36f98683e1bf9a3dc11cde2d1113ed1c4d6448
2022-06-06 22:28:09 +00:00
TreeHugger Robot 1a339394af Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev am: 9307776597
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18759197

Change-Id: I19a2a12de503313067a5516ce401dbbd0fb6c894
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 21:59:54 +00:00
TreeHugger Robot 9307776597 Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev 2022-06-06 21:36:43 +00:00
Vinit Nayak bd5784bade Merge "Remove old split screen overview related code" into tm-qpr-dev am: 2aa5a816e9 am: 7b3916c550
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638742

Change-Id: I619a2f040cd43c7b09e40a40b34aef803c0a663d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 21:30:51 +00:00
Vinit Nayak 7b3916c550 Merge "Remove old split screen overview related code" into tm-qpr-dev am: 2aa5a816e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638742

Change-Id: Ie15ebcfbe2c1e5dada52b475511278a928beff9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 21:12:54 +00:00
Vinit Nayak 5424fca602 Rename split classes/variables for consistency
* Use "select" when in the split screen
invocation process
* Drop usage of "staged" except when defining
constants

Fixes: 233006032
Change-Id: I809f0e1e9742aa6b6b09ad8731896ad3f0c9deb0
2022-06-06 14:02:15 -07:00
Vinit Nayak 2aa5a816e9 Merge "Remove old split screen overview related code" into tm-qpr-dev 2022-06-06 20:49:45 +00:00
Vinit Nayak da9213791e Ensure null elements aren't added to TaskView shortcut list
Bug: 234874147
Change-Id: I5ed84fdc64128264e5808b7d3b019c47e3740469
2022-06-06 09:18:42 -07:00
Jeff Chang 5ee83f3b5e Show split option without consider the "Lock task mode"
wm-core supports split-screen and lock-task mode work together now.
This CL enables the split-option to allow users to enjoy the
split-screen experience.

Bug: 199342537
Test: Options show up as expected
Change-Id: I38f58dec2985eaaabdbed1fdeeeece2d6e59945f
2022-06-06 14:47:47 +08:00
TreeHugger Robot 71311797b6 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919 am: 5b765189e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: I3a54c582097c75b9d643b2c2063f02186ad4837a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:42:28 +00:00
TreeHugger Robot 5b765189e2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: If494d52f37fd556dca2fd6960bb69490c812e5fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:26:26 +00:00
TreeHugger Robot 3d662872c2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: abbb482160
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: I61e3083d3d6a348dcd09d33fb43d1a592147e3fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:25:45 +00:00
TreeHugger Robot abbb482160 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: I7abe815c7ca7801d7172663ff8370a84ff8cc973
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:00:37 +00:00
TreeHugger Robot 3ecc8654a6 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: Ida20af0c835cb08a070d450f37a8c3c5eb54ad18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 01:59:41 +00:00
TreeHugger Robot c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Ats Jenk f5098d95c4 Merge "Enable bubbles home gesture by default" into tm-qpr-dev am: e048af300b am: d2082c8c65
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18720602

Change-Id: Ie1704232532c9f6700ebf18f709d290da174efb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 00:16:28 +00:00
Tony Wickham 8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Ats Jenk d2082c8c65 Merge "Enable bubbles home gesture by default" into tm-qpr-dev am: e048af300b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18720602

Change-Id: I902285c63d03346e4edbdfc8863357fc4acc939b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-03 19:38:37 +00:00
Ats Jenk e048af300b Merge "Enable bubbles home gesture by default" into tm-qpr-dev 2022-06-03 18:46:20 +00:00
Vinit Nayak 107f79a4a2 Merge "Refactor TaskShortcutFactory to return List of SystemShortcuts" into tm-qpr-dev am: dde2536a52 am: 54cdc33ca1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624822

Change-Id: Ia9e062b2e7ab1a86cdc703614fdbc44f01afb2df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-03 17:33:22 +00:00
Vinit Nayak 54cdc33ca1 Merge "Refactor TaskShortcutFactory to return List of SystemShortcuts" into tm-qpr-dev am: dde2536a52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624822

Change-Id: I6248b81a30447c2634a325cd5543e74129630d36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-03 17:02:01 +00:00
Vinit Nayak 690645b62e Remove old split screen overview related code
Bug: 233006032
Change-Id: I294dcde586da135af3bb33400e65d5f47edca3d8
2022-06-03 16:39:49 +00:00
Vinit Nayak dde2536a52 Merge "Refactor TaskShortcutFactory to return List of SystemShortcuts" into tm-qpr-dev 2022-06-03 16:39:11 +00:00
Ats Jenk daccf18be1 Enable bubbles home gesture by default
Update feature flag for bubbles home gesture handling to be on by
default.

Bug: 170163464
Test: manually verified that home gesture feature is enabled on a a fresh build
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble
Change-Id: Ie6bdea919dfaf6448b3c57756cd06993a6a60ce7
2022-06-02 17:05:36 -07:00
Jon Miranda 46ecc0ca08 Pause expensive view updates before setting hw/sw layers.
Prevents widgets from updating mid animation.
Also pauses view updates during app close animation.

Bug: 220939231
Bug: 230617085
Bug: 226171754
Test: manual

Change-Id: I0138d57e6a7b2c22fd9a029e971b3e27c7e9f22e
2022-06-02 12:21:01 -07:00
Tracy Zhou 768f33f96f Merge "Tune floating rotation button size" into tm-qpr-dev am: 064f3ef103 am: 436fcdc4ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18661670

Change-Id: I3be71128ef1ce18c9d19a8dd070cefed6dcf35dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-02 08:35:54 +00:00
Tracy Zhou 436fcdc4ff Merge "Tune floating rotation button size" into tm-qpr-dev am: 064f3ef103
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18661670

Change-Id: I430b349515af32159a92b553572680d27cb1995c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-02 08:02:18 +00:00
Tracy Zhou 064f3ef103 Merge "Tune floating rotation button size" into tm-qpr-dev 2022-06-02 07:59:46 +00:00
TreeHugger Robot ff2b6f3525 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-06-02 04:23:47 +00:00
Jerry Chang 202f45166d Fix Flicker of inner corners in split screen when quick switching to
Update divider bar visibility immediately when quick switching to split
pair

Fix: 234609814
Test: manual check quick switch with split pair
Change-Id: I4fc36302763bc0a7de9caca0ab370e3cedc18076
2022-06-02 03:53:19 +00:00
TreeHugger Robot fe6bcabac2 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-06-02 00:49:45 +00:00
Vinit Nayak 28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Winson Chung 28e662a6ba Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: d419e40223 am: adc420d419
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I8f7c176797247e68a6ddfc466630818c64307227
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 23:03:45 +00:00
Winson Chung c9e64b3c47 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 95afbb9982
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I276ce54df65697b0778c29864a8620733b6e0cbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:55:52 +00:00
Winson Chung b7fc43dd0d Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 9f5d1568bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: Ie2a5d9cfe2fe736736dff557d94652380384cbab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:39:08 +00:00
Winson Chung 95afbb9982 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I81ecdda6bdc41f52ef4cb4be6344b519b742190a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:24:31 +00:00
Winson Chung 9f5d1568bc Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I8afff3488f55a2bd94b1d6adbf412aab9a63cf2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:23:34 +00:00
Winson Chung d419e40223 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I8feccb2f5ec58799bb82c5e5c5550061cd35bbed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:23:11 +00:00
Winson Chung 238f380853 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev 2022-06-01 22:06:48 +00:00
Luca Zuccarini 836437ff0d Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade am: 8f82b3096f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: Ifde8d5fd950b8223141ead43417512e717d333ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:31:25 +00:00
Luca Zuccarini 728e234120 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I8cf3773dff04ced9335355f9f99311df1a9bd97f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:17:35 +00:00
Luca Zuccarini 8f82b3096f Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: Iff893cc38a30b7b6d56ce974bed9c5de05601028
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:17:27 +00:00
Luca Zuccarini 5f78aeab5f Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: f518ba7289
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: Ib2697612f18adc60a7310f73f4cf1a391727244a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:16:54 +00:00
Luca Zuccarini 9e50fc0ade Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I277d4b7db2bb80899d4053e0fbe721cccc560c03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 09:54:22 +00:00
Luca Zuccarini f518ba7289 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I3369902633ced33389b31f04916222cfe714c7d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 09:53:14 +00:00
Luca Zuccarini eb49ab04c8 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I24c475f36abe82a7be97334832a3820837619410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 09:52:47 +00:00
Yunfan Chen 972b1051e6 Modify the way of providing insets per WM change
The WM provides a new way to provide insets, modified the code to
reflect that change.

Bug: 161689946
Test: m
Change-Id: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
2022-06-01 09:25:54 +00:00