Commit Graph

14731 Commits

Author SHA1 Message Date
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
Jeremy Sim 85397e333f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818 am: 69a22b907f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: I807a208f233234a6dd35ac6de5546fb0b824ccc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:50:56 +00:00
Jeremy Sim 69a22b907f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: Ib408c5b8f113d13a63fd6071283cdf73f69af74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:18:53 +00:00
Jeremy Sim c528e7e818 Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev 2022-09-17 21:45:24 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
Vinit Nayak d887b56183 Reset TaskView transformations on orientationHandler change
* Transformations in the old orientation handler
(ex. translate X for portrait) aren't reset when
device changes to fake landscape (starts modifying translate Y).
The new translations are picked up correctly, this resets the
old ones.

Test: Bug no longer repros.
Rotated device while scrolling through tasks, no change in
behavior from before.
Can't think of other instances where tasks are in motion
and orientation handler can change.
Fixes: 233316942

Change-Id: Ie07340e69a2c93b71b1dabb8029c96ad05a4d4a1
2022-09-16 16:45:50 -07:00
Jeremy Sim 7917ff31cc Fix two bugs with rotation in split select state
This CL fixes two bugs that were triggered by rotating in split select state:
1) Rotating in split select state will no longer cause a jittery animation to play
2) Initiating split from home, then rotating will no longer create extra split placeholders on screen

The bugs were present because handleSplitSelectionState() animated every state transition into SplitSelect, including SplitSelect > SplitSelect (which happens when rotating). This caused a jittery animation to play, and in certain cases, caused additional copies of FloatingTaskView and SplitInstructionsView to be created.

Fixed by auto-skipping animations for SplitSelect > SplitSelect, and by safely removing views when entering SplitSelect (to prevent duplicates).

Fixes: 242965515
Fixes: 243088958
Test: Verified visually on-device.
Change-Id: Iab813b1fe599bfdc550fe9a1d354b28cedb4b659
2022-09-16 15:28:33 -07:00
Hongwei Wang 2515a14429 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0 am: 334b1e0ee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: I964f5f6c6984a4d2b5e1fa85fd6c480ea3cf568c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 20:37:07 +00:00
Hongwei Wang 334b1e0ee6 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev am: 93f650d3e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969480

Change-Id: Id300bb64efa51ca5956fea8bac36b653b732d1c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 20:08:46 +00:00
Hongwei Wang 93f650d3e0 Merge "No auto-pip animation if SysUI is not available" into tm-qpr-dev 2022-09-16 19:26:33 +00:00
TreeHugger Robot 5a469bd163 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12 am: d7d05d1d7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: I3729ee399399d7bbea5e0569f132ce53690b45df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:21 +00:00
TreeHugger Robot d7d05d1d7a Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev am: af2fe7fd12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967481

Change-Id: Iddbb6898e4acecd61b10a30fefc3fe3134869205
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:22:10 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
TreeHugger Robot 1508328e72 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev am: 9fb4802a67 am: 3d021d46d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19975454

Change-Id: Ifa5a7419ff4a314b3ac1aaa9a90da6eb63d814df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 08:38:55 +00:00
TreeHugger Robot 3d021d46d9 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev am: 9fb4802a67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19975454

Change-Id: I8c15a562ab54163907e0b6306280950512fdf923
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 07:55:43 +00:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00
Stefan Andonian 5df305fed6 Moving ViewCapture to Quickstep level to use hidden apis.
Bug: 242867462
Test: Compilation succeeded while using private flags.
Change-Id: I9b15967b594963c5573ea1a0000b60f7c705da95
2022-09-16 03:36:15 +00:00
TreeHugger Robot cee4a9b588 Merge "Revert "Using Transaction directly instead of building surface p..."" into tm-qpr-dev am: 3187928c51 am: c3f2fcea3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971330

Change-Id: I0d5f920d02125a61380c32007b01956a0baa9a54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 01:42:14 +00:00
TreeHugger Robot c3f2fcea3e Merge "Revert "Using Transaction directly instead of building surface p..."" into tm-qpr-dev am: 3187928c51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971330

Change-Id: Ia3038d05fa61cb4de901e0a0fd53354b3da2c9ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 01:14:41 +00:00
Schneider Victor-tulias 8e2781fa9a Merge "Remove redundant start recents animation logs" into tm-qpr-dev am: 03732ff0f8 am: cb7e57bd5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956393

Change-Id: Ia173460b0a2d2723830895230fffc659a1c83266
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:43:10 +00:00
Schneider Victor-tulias 53a54000ec Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev am: ff7e5382b5 am: ab78301082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944062

Change-Id: I0ae0146e1a117c05ce50b2df73f4072013762298
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:43:09 +00:00
Schneider Victor-tulias fe71f79735 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev am: 11507173a1 am: 3e6519bab1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944061

Change-Id: I3ddb22630ea12b21ab461835b85cc678acb76319
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:43:07 +00:00
Schneider Victor-tulias cb7e57bd5a Merge "Remove redundant start recents animation logs" into tm-qpr-dev am: 03732ff0f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956393

Change-Id: I277f89b48d88d29ee52978b34e56587be9fcea6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:12:52 +00:00
Schneider Victor-tulias ab78301082 Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev am: ff7e5382b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944062

Change-Id: I72f3a3bfc3f990e0e0bbc602ea7a4ba78acb8dbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:12:51 +00:00
Schneider Victor-tulias 3e6519bab1 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev am: 11507173a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944061

Change-Id: Ia0241d2c06fbba9a25e400bfb92e8d6768b70c9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 21:12:49 +00:00
Sunny Goyal 9925bbd147 Revert "Using Transaction directly instead of building surface p..."
Revert "Removing unused surface transaction wrappers"

Revert submission 19933596-tcompat

Reason for revert: b/246899728
Reverted Changes:
I31123dff7:Using Transaction directly instead of building sur...
I2e2526d21:Removing unused surface transaction wrappers

Change-Id: I63d1d8bb723b7bd05d345fb21a67f88e5fb36bc1
2022-09-15 14:07:51 -07:00
Schneider Victor-tulias 03732ff0f8 Merge "Remove redundant start recents animation logs" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
Schneider Victor-tulias ff7e5382b5 Merge "Reuse log IDs when a GestureState is being reused" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
Schneider Victor-tulias 11507173a1 Merge "Update ActiveGestureLog to print logs from oldest to newest" into tm-qpr-dev 2022-09-15 20:23:46 +00:00
TreeHugger Robot 97ad678adc Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev am: 7532df84c5 am: 2d061d279f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944101

Change-Id: I2b96bf5e7510a9cc44eca665fc90ce6a8e19073a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 20:20:52 +00:00
TreeHugger Robot 2d061d279f Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev am: 7532df84c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944101

Change-Id: Ib0f0babe2fc3d023c713a6cdf7b23725e0d7f7e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 19:50:24 +00:00
Hongwei Wang 7da9a38669 No auto-pip animation if SysUI is not available
The Launcher crash in the bug is a consequence of SysUI being stopped
due to ANR. In this rare case, we should not start the auto-pip
animation to further crash the launcher.

Bug: 245947669
Test: N/A
Change-Id: I2e99a82d4dccf302788fdb0752f70091fe5a18a3
2022-09-15 12:49:29 -07:00
TreeHugger Robot 7532df84c5 Merge "Update secondary task menu check to explicitly check for phone" into tm-qpr-dev 2022-09-15 19:12:38 +00:00
Pat Manning e0a7478fde Refresh taskbar apps show on DeviceProfile change.
Fix: 244269456
Test: manual
Change-Id: Ie95813c77b45b03a824542a25d1349675b1825c0
2022-09-15 14:42:57 +01:00
TreeHugger Robot f6b9723bd6 Merge "Add metrics sources for split invocation" into tm-qpr-dev am: e58e123bd7 am: 1c46220a98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19820319

Change-Id: I1b7e2debef2cbe78f110403f7ce80e8873b28708
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 10:00:15 +00:00
TreeHugger Robot 1c46220a98 Merge "Add metrics sources for split invocation" into tm-qpr-dev am: e58e123bd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19820319

Change-Id: Ic52f6edd2b25282d0d5b79d1b9d57d7d7cc53dcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 09:44:00 +00:00
TreeHugger Robot e58e123bd7 Merge "Add metrics sources for split invocation" into tm-qpr-dev 2022-09-15 09:35:12 +00:00
Zimuzo Ezeozue d6bf600aee Merge "Disable Launcher AIDL_TAG tracing special case" 2022-09-15 07:29:07 +00:00
Alex Chau ced04032fb Merge "Convert make to bp" 2022-09-15 06:40:53 +00:00
Tony Huang 8b44e3a53c Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev am: ade8b9d753 am: 2bf9faa538
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19903469

Change-Id: I636366ff6ac6adc9be0f0ae563aff68f28d0493e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 05:34:49 +00:00
Tony Huang 2bf9faa538 Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev am: ade8b9d753
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19903469

Change-Id: Ic450af25bf003bced928f761e4709f4a8fed5fed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 05:03:48 +00:00
Jeremy Sim 1ccec2e53a Update animations for TM-QPR: Overview > OverviewSplitSelect transition am: 21a5b12b6f am: 7439620808
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19728187

Change-Id: If7323b12cc2653bf914d8345a123e00c1aadee9d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 04:55:16 +00:00
Tony Huang ade8b9d753 Merge "Fix split divider flash if swipe again quickly" into tm-qpr-dev 2022-09-15 04:46:26 +00:00
Jeremy Sim 7439620808 Update animations for TM-QPR: Overview > OverviewSplitSelect transition am: 21a5b12b6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19728187

Change-Id: I2265c49567d0807e4e9e20cb755180df15e102cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 04:24:24 +00:00
Schneider Victor-tulias 2c76db1d4d Merge "Add onTaskAppeared error detection." into tm-qpr-dev am: 56c92899f1 am: 86b01d948e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19936975

Change-Id: I87765df4d2eff0506923d3f8922fb5387503b5f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 02:09:21 +00:00
Jeremy Sim 21a5b12b6f Update animations for TM-QPR: Overview > OverviewSplitSelect transition
This change updates the Overview > OverviewSplitSelect animation to the latest spec. This is a re-upload of a previous change, ag/19464657, but no longer will cause the b/241165022 issue.

Includes:
- New timings
- Task thumbnails slide in with an "overshoot" animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet. Made sure the b/241165022 issue is fixed.
Change-Id: Ia22f6b6d7b9474b782e693fae2320a34a2985b18
2022-09-14 18:06:05 -07:00
Winson Chung 9023848984 Merge "Update Launcher for removed shared wrappers" into tm-qpr-dev am: d2db9167a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915464

Change-Id: I4523beea62144a58ec03126f9a0bd4517d0f5f0f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 22:15:02 +00:00
Winson Chung d2db9167a8 Merge "Update Launcher for removed shared wrappers" into tm-qpr-dev 2022-09-14 22:03:05 +00:00