9297483eef
Merge "Prevent rotating TaskMenuViewWithArrow for large screen" into tm-qpr-dev
2022-11-08 23:08:28 +00:00
93fc0f3a7c
Allow user to select second split app from Taskbar
...
This patch makes it so that (when we enable Taskbar in Overview) users will be able to select their second app for splitscreen by tapping the Taskbar icon, or the icon in AllApps.
This was done by performing a check to SplitSelectStateController when a taskbar icon is hit. If we are currently in split select mode, Taskbar/AllApps icons will no longer launch their respective fullscreen apps, but instead confirm the split attempt. The confirmed app will either be an already-running instance of the app, or a fresh instance of the app (if none is currently running). The split confirmation function is located in TaskbarUIController, where it is accessible to both LauncherTaskbarUIController (for 1P Launcher) and FallbackTaskbarUIController (for 3P launchers).
Also cleans up ~2 lines of unused code from the old splitscreen instructions toast.
Outstanding issues:
- When selecting a second app from within AllApps, the AllApps shade does not animate away in a satisfying way
- When selecting a second app and launching a fresh instance of that app, the animation appears to come from the wrong location
- Intent + Intent splitting does not currently work
- If the selected app is already running with multiple instances, it picks the oldest instance. Ideally, the newest instance is preferred.
Bug: 251747761
Test: Manual testing with Taskbar in Overview flag enabled
Change-Id: I302dc092740bb880f9134ba8e2e587c4f2c29d01
2022-11-08 14:38:05 -08:00
e7011d2b87
Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
...
This reverts commit d5a6b5f688
2022-11-08 21:56:52 +00:00
29e71bdd72
Improve Split portrait gesture animation
...
* Crop out taskbar from bottom thumbnail for vertical split
* TODO: Need to re-calculate thumbnail sizes if taskbar
is stashed. There's also a very slight rounding error
somewhere even in the unstashed case that needs to be
revisited
Bug: 219411750
Test: Start gesture animation in split in potrait
Change-Id: I35f2415e13af7467e0735ac8865cee0e3e3d27f8
2022-11-08 11:33:08 -08:00
4c88969413
Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev am: 98f400397b am: 269c56df92
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20187724
Change-Id: I79602295bb72072c804bffd6e3d6f753babc43c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 18:59:18 +00:00
c00b037650
Merge "Have responsive taskbar UI during swipe up gesture." into tm-qpr-dev am: caa398ed35 am: b71037c58b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20333665
Change-Id: Ia711d47f8c4d6cd3cd2c9a5201bde2f92ace9f6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 18:58:44 +00:00
269c56df92
Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev am: 98f400397b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20187724
Change-Id: I83f29014f6bd50a3bcb3fc2ebf964163438bbcbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 18:26:53 +00:00
b71037c58b
Merge "Have responsive taskbar UI during swipe up gesture." into tm-qpr-dev am: caa398ed35
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20333665
Change-Id: Id96043e6aa186eb04bc5d171fdb72159ae7e4c42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 18:26:43 +00:00
98f400397b
Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev
2022-11-08 18:14:55 +00:00
caa398ed35
Merge "Have responsive taskbar UI during swipe up gesture." into tm-qpr-dev
2022-11-08 17:53:05 +00:00
12cdc89c7e
Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev am: 881588bfb5 am: 416680d8f0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391679
Change-Id: Ibcc62df1f17de580c3c6f2b18749d5ef6e3be933
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 17:10:33 +00:00
416680d8f0
Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev am: 881588bfb5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391679
Change-Id: I46efa448ae986d2fd723e2f98faa09a562cfe98f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 16:38:36 +00:00
881588bfb5
Merge "Add TaskbarModeSwitchRule to test both transient/persistent taskbar." into tm-qpr-dev
2022-11-08 16:13:07 +00:00
e1100b904d
Unstash taskbar when transitioning to fallback overview.
...
Update LauncherInstrumentation taskbar visibility check to include assertions in fallback launcher using OverviewObject instead of LauncherObject.
Fix: 253042501
Test: manual
Change-Id: I9f2aa228e8aa97ef8ca1a4535b7f8fcded8a4572
2022-11-08 15:07:12 +00:00
29f7474056
Have responsive taskbar UI during swipe up gesture.
...
- Makes taskbar threshold an absolute Y threshold
instead of a distance threshold.
- Moves handle, taskbar view, and taskbar background
during the swipe up gesture
Next CL will address transforming the nav handle <-> taskbar
and ensuring that there's a clean handoff
Bug: 246631059
Test: swipe up on taskbar, release. see bounce
swipe up on taskbar to go home, proper icon alignment
swipe up on taskbar, pause for overview, see bounce
-> further movement should not move taskbar
test launcher3
Change-Id: I141236fd72428cda7edd0ff116de1d478d18c722
2022-11-08 14:50:02 +00:00
e444ffb124
Make multi-instances split opt-in based
...
Remove appending MULTIPLE_TASK flag when starting an intent and a task
into split screen and leave it to wm-shell to decide whether to append
the flag or not.
Bug: 255224696
Test: atest WMShellFlickerTests
Test: manual check the start intent and task flow
Change-Id: I3d887f8dcea67b12a7e94cef55850d52a79a8d2d
2022-11-08 08:59:35 +00:00
f09a4c2658
Merge "Stash taskbar if user touch down above the gesture height." into tm-qpr-dev am: 92564539d2 am: 97198b03f7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391178
Change-Id: I6b555c7ea0e473c6e05c7714fcf96120d4b5fdcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 01:56:26 +00:00
97198b03f7
Merge "Stash taskbar if user touch down above the gesture height." into tm-qpr-dev am: 92564539d2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391178
Change-Id: I7e55d23264446cdb747682acbf01468a1487535f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-08 01:24:00 +00:00
92564539d2
Merge "Stash taskbar if user touch down above the gesture height." into tm-qpr-dev
2022-11-08 01:00:46 +00:00
9ad16b317f
Revert^4 "Enable Shell Transitions"
...
4de41de461
2022-11-08 00:13:56 +00:00
d4a389038c
Merge "Revert^3 "Enable Shell Transitions""
2022-11-08 00:01:33 +00:00
d5a6b5f688
Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
...
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
We can address testing this functionality in a separate CL
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
4de41de461
Revert^3 "Enable Shell Transitions"
...
985f7de915
2022-11-07 22:07:17 +00:00
6ff73f35f5
Merge "Refactor recents attached to window animation to keep state handling synchronized." into tm-qpr-dev am: cd587212a2 am: aa631328c5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388919
Change-Id: Ie0b35fe29926e559a7087188ea848d39e2027496
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-07 19:20:47 +00:00
60f7f4a03e
Merge "Change taskbar corner roundness when entering overview" into tm-qpr-dev am: 3cf779270b am: 6d18d1a974
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311858
Change-Id: I7548f873b58db1e19f2af257fa9ce3de7fa09e38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-07 19:18:54 +00:00
c8ecbe2dda
Merge "Revert^2 "Enable Shell Transitions""
2022-11-07 19:13:21 +00:00
aa631328c5
Merge "Refactor recents attached to window animation to keep state handling synchronized." into tm-qpr-dev am: cd587212a2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20388919
Change-Id: I1a6f8f2191d2b9a01f89279c6a04f101c72a1611
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-07 18:48:15 +00:00
6d18d1a974
Merge "Change taskbar corner roundness when entering overview" into tm-qpr-dev am: 3cf779270b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311858
Change-Id: I938abff8fcd1c435724d26d884a3546e87ba08c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-07 18:46:49 +00:00
b0523697c6
Stash taskbar if user touch down above the gesture height.
...
Bug: 252905206
Test: open taskbar, tap in gesture area, confirm no stash
open taskbar, tap on taskbar item, confirm no stash
open taskbar, tap to the side above gesture area, confirm stash
Change-Id: Ide030840440b5f0541d0ccfb055b8a8a7e851657
2022-11-07 10:37:28 -08:00
cd587212a2
Merge "Refactor recents attached to window animation to keep state handling synchronized." into tm-qpr-dev
2022-11-07 18:21:53 +00:00
3cf779270b
Merge "Change taskbar corner roundness when entering overview" into tm-qpr-dev
2022-11-07 18:08:22 +00:00
2370406efb
Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
...
Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while going to recents
Change-Id: If33daaa22f904c928f5d4a561a7ac1a03d82b7eb
2022-11-07 16:52:32 +00:00
68e7fe6b7d
Change taskbar corner roundness when entering overview
...
- Roundness will be 0 in Launcher, and 1 in an app
Bug: 250645563
Test: With and without taskbar in overview, switch between home/overview/app and observe the round corners above taskbar
Test: Ensure corner above taskbar is correct in overview and in app when chat bubble is active
Change-Id: I1f4911626c8e79fce8d81a76a9bd0d0670d111da
2022-11-07 12:58:47 +00:00
5bb69206a3
Refactor recents attached to window animation to keep state handling synchronized.
...
Bug: 244593270
Bug: 243471493
Test: went from from app, launched overview from app/home, started overview, then swiped to home from app/home
Change-Id: If3ce8d5d145941af3fac936be28c0fc59c18932b
2022-11-04 15:14:54 -07:00
a16380e0f9
Merge "Improve RecentsModel log dump for ease-of-use and readability." into tm-qpr-dev am: 345ef9ffba am: 924e673804
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20290151
Change-Id: I27b2fa87fd86b516ff955db5f512eed88dd32e79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 18:59:28 +00:00
9f9931cbc1
Merge "Clean up bubbles home gesture flag" into tm-qpr-dev am: 70d8a12c60 am: 60e0de347b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20377785
Change-Id: Ica3d759fd8436eb99e0706913f205afade66276b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 18:58:24 +00:00
469b0ca163
Merge "Update all set page navigations settings button callback" into tm-qpr-dev am: 0994f74f76 am: 626bb9fded
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20376505
Change-Id: I984c3ea38ac3f2599fa374a18441a244db68ca38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 18:57:50 +00:00
924e673804
Merge "Improve RecentsModel log dump for ease-of-use and readability." into tm-qpr-dev am: 345ef9ffba
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20290151
Change-Id: I67b5b9c1f60a4c1b2af44d16b6c20d34b4314fed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 18:26:58 +00:00
345ef9ffba
Merge "Improve RecentsModel log dump for ease-of-use and readability." into tm-qpr-dev
2022-11-04 18:17:51 +00:00
60e0de347b
Merge "Clean up bubbles home gesture flag" into tm-qpr-dev am: 70d8a12c60
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20377785
Change-Id: I7cef413766ad64bddd45b0803ce148799e4d43ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 18:13:35 +00:00
626bb9fded
Merge "Update all set page navigations settings button callback" into tm-qpr-dev am: 0994f74f76
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20376505
Change-Id: I7b290597981453166f4cf7d957038876987a4464
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 18:13:00 +00:00
70d8a12c60
Merge "Clean up bubbles home gesture flag" into tm-qpr-dev
2022-11-04 17:56:17 +00:00
0994f74f76
Merge "Update all set page navigations settings button callback" into tm-qpr-dev
2022-11-04 17:16:09 +00:00
321cdf1f4e
Merge "Relying on the controller state instead of animator state for icon alignment" into tm-qpr-dev am: eeaba0903a am: e869850fa6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20291844
Change-Id: I48c8e2eab58edf988aad7aaac732adc484670813
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 16:41:56 +00:00
3d0a8c551d
Merge "Update insets for transient taskbar" into tm-qpr-dev am: 71370c58eb am: 264e97feea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307069
Change-Id: I14bcc2c87524b241f008586cd869ee78fab52332
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 16:40:38 +00:00
e869850fa6
Merge "Relying on the controller state instead of animator state for icon alignment" into tm-qpr-dev am: eeaba0903a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20291844
Change-Id: I95c2a079a8cc41f1a2592704f5f1ea0ca2baad6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 15:52:49 +00:00
eeaba0903a
Merge "Relying on the controller state instead of animator state for icon alignment" into tm-qpr-dev
2022-11-04 15:40:17 +00:00
264e97feea
Merge "Update insets for transient taskbar" into tm-qpr-dev am: 71370c58eb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20307069
Change-Id: I46bdfbf96ca0b0be53f04c0c4aef8f07e1a56297
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 15:37:15 +00:00
c2d79ed34e
Merge "Adding support for multiple overlay callbacks" into tm-qpr-dev am: 8d3241b359 am: d5bb6459f0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20362704
Change-Id: Ic27caf598e09cd5fc8f5d13fc547398d8faf3d85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-04 15:10:35 +00:00
71370c58eb
Merge "Update insets for transient taskbar" into tm-qpr-dev
2022-11-04 15:09:12 +00:00
TreeHugger Robot
Jeremy Sim
Jon Miranda
Vinit Nayak
Pat Manning
Jerry Chang
Evan Rosky
Schneider Victor-tulias
Alex Chau
Nicolo' Mazzucato
Ats Jenk
Sunny Goyal