Commit Graph

14731 Commits

Author SHA1 Message Date
Alex Chau adbbc2f7fa TaskbarViewController should only translate on rotation if icon is aligned with hotseat
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
2022-12-15 22:04:16 +00:00
Sunny Goyal 37dd2e6691 Merge "Unifying multiple all-apps implementations" into tm-qpr-dev am: 09fab7ee7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713205

Change-Id: I1bd905e44924ec55f8f7cb254d66f9f751357590
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 17:28:53 +00:00
Alex Chau a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal 09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Bill Yi ac3930bede Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-15 14:08:52 +00:00
Schneider Victor-tulias fa854bd707 [DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds. am: 80b25c756a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: I546f4a2c97c5dd18f55993cfb528fe2e76aef095
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 10:29:01 +00:00
Schneider Victor-tulias 887b56ce1b Merge "Log gesture velocity to help debug and help direct future gesture nav thresholds." 2022-12-15 09:42:20 +00:00
Schneider Victor-tulias 85127b4f47 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev 2022-12-15 09:42:15 +00:00
Jeremy Sim 768e9ec8c0 Fix bug with Taskbar second-app-selection animation
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.

Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.

Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.

Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
2022-12-14 17:48:14 -08:00
Bill Yi 78ea5bd253 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie78d4416033cc14e78a40771e66524517e2e7d28
2022-12-14 14:15:06 -08:00
Bill Yi e9b7c15e95 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I61ee5cd3d8384e48c03f7f1682bdb325e94defaa
2022-12-14 14:14:32 -08:00
Brian Isganitis 73d270bf51 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528 am: 4aa2644629
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I82869bb9d8f264bea5f43bff7c652bfdd2c85ee4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 21:34:09 +00:00
Brian Isganitis 4aa2644629 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I0184935622d8892842af29629ed96eff65e9507b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:50:23 +00:00
Brian Isganitis f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Jon Miranda a965d14c42 Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c am: 80f6ece5ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Id066aeb46d61d892ce6e30688e1b215d958206db
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:11:38 +00:00
Brian Isganitis 1e37aae1dc Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe am: 71f9faded9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: I8917a9a3f4ceb856cf1fecf8699e61fb5a0bf459
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:10:06 +00:00
Jon Miranda 80f6ece5ad Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Ib3ff9ebcfd645a6f929e17e17aec4f14b070b7ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:33:23 +00:00
Brian Isganitis 71f9faded9 Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: Ic5f32fca6c7f56c9e17cdc68bc0416c0881e2fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:32:50 +00:00
Sunny Goyal adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Jon Miranda a0743cf62c Merge "Taskbar All Apps button visual updates" into tm-qpr-dev 2022-12-14 19:00:18 +00:00
Brian Isganitis 8216a26bfe Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev 2022-12-14 18:54:42 +00:00
Alex Chau c92b91c579 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev am: 5c1eb61391 am: 881b7f2d55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20691430

Change-Id: I083054a14d61a8ebd212c1d1dde5ee210eb84fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 18:12:34 +00:00
Alex Chau 881b7f2d55 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev am: 5c1eb61391
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20691430

Change-Id: Ife649f8b410276b2cfd84826132fbe00f4835493
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 17:37:24 +00:00
Alex Chau 5c1eb61391 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev 2022-12-14 17:15:21 +00:00
Brian Isganitis 338fa3e9ab Delay hiding Taskbar EDU until entering home or overview.
EDU will now end up hiding due to
TaskbarLauncherStateController#onStateChangeApplied closing all AFVs if
we are going to home or overview.

This is a quickfix to make it harder to accidentally close the EDU when
testing out the transient taskbar. We will eventually be moving to a
lighter EDU UI where having gestures occuring behind it will be less
awkward.

Test: Manual
Bug: 260769010
Change-Id: I477abe9339ed10cb3aed8d1a0fbe0e22ac14c7ab
2022-12-13 20:16:29 -05:00
Jon Miranda e7417ce2ae Taskbar All Apps button visual updates
- Moved to new position
- Using 3x3 icon
- New Colors

Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.

Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models

Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
2022-12-13 15:16:01 -08:00
Bill Yi 99d8e6c7a4 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-12-13 21:48:34 +00:00
Brian Isganitis 47da4167ea Assign taskbar EDU same interpolator as all apps.
This polishes closing both at the same time when they are on top of each
other.

Test: Manual
Bug: 217261955
Change-Id: Iecb8658b98debb0225d3b59da99ecb34d008971a
2022-12-13 16:43:36 -05:00
Brian Isganitis 2a2f1b6cd3 Polish all apps taskbar unstash behavior for transient and persistent.
- During gestures from taskbar all apps, unstash immediately in
  transient.
- Overlay closes sooner if all apps is open (still done later for EDU).
- Taskbar stashes in overview when All Apps is opened.
- Transient app-window threshold is ignored if All Apps is opened.

Test: Manual
Fix: 262076812
Change-Id: I46b2dcdc75ee0cc15c1b47da2139ff8c20cf618a
2022-12-13 16:24:35 -05:00
TreeHugger Robot e6cb5467c8 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-13 19:49:16 +00:00
Pat Manning f5240c1538 Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev am: 59c4fff67c am: 2eca15a02f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643015

Change-Id: Idc04b9118bab3ab633ee3f3b1b84e33e1d462f40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 19:35:40 +00:00
Jeremy Sim 45241914cd Merge "Use already-running app instances when splitting" into tm-qpr-dev am: 538281db37 am: 8ccaa6a33d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20625907

Change-Id: I6364fe358bf9438b5483e7ec3675bbd6464f045f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 19:33:20 +00:00
Pat Manning 2eca15a02f Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev am: 59c4fff67c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643015

Change-Id: Id044d04b165d334931afb3cfc3754c5b4e0f4abf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:59:11 +00:00
Jeremy Sim 8ccaa6a33d Merge "Use already-running app instances when splitting" into tm-qpr-dev am: 538281db37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20625907

Change-Id: If7edcfa37908409a48c6a4db9031fab0fe2414a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:57:59 +00:00
Pat Manning 59c4fff67c Merge "Include taskbar cropped insets in thumbnail aspect ratio difference calculation." into tm-qpr-dev 2022-12-13 18:29:27 +00:00
Brian Isganitis 2478619202 Merge "Move forward initial frame for suggestions asset." into tm-qpr-dev am: 97db609701 am: 5315688415
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20708959

Change-Id: I5e19ffe7929ac3b529ba12c77d4742fdc6d68196
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 18:22:54 +00:00
Jeremy Sim 538281db37 Merge "Use already-running app instances when splitting" into tm-qpr-dev 2022-12-13 18:21:12 +00:00
Brian Isganitis 5315688415 Merge "Move forward initial frame for suggestions asset." into tm-qpr-dev am: 97db609701
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20708959

Change-Id: I7edee6d6c08beca923da50772d73e92e72c85bad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-13 17:47:10 +00:00
Brian Isganitis 97db609701 Merge "Move forward initial frame for suggestions asset." into tm-qpr-dev 2022-12-13 17:36:49 +00:00
Alex Chau be753137a2 Don't scale iconSize and textSize in non-default display size
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space

Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
2022-12-13 16:30:14 +00:00
Pat Manning 0333ec1d21 Include taskbar cropped insets in thumbnail aspect ratio difference calculation.
Bug: 260861673
Test: manual.
Change-Id: I3abed4dfab5dccf99ae81e0f2d0ae840a3aabed5
2022-12-13 11:45:05 +00:00
Andy Wickham 67e171a872 Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev am: 29b95b58ba am: a89df1e47f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546292

Change-Id: I9614ee34df20a367907c9d9860e2f085690e93b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12 20:03:44 +00:00
Brian Isganitis 3ac3a8a3b4 Move forward initial frame for suggestions asset.
The assets were starting with remnants of the previous step.

Bug: 217261955
Test: Manual
Change-Id: Ibf9194afba97def051334a85d172396fb6659213
2022-12-12 14:30:25 -05:00
Andy Wickham a89df1e47f Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev am: 29b95b58ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20546292

Change-Id: I09030c24485b7b25a2eb72d90e4515d6e9ea3960
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12 19:29:48 +00:00
Andy Wickham 29b95b58ba Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev 2022-12-12 19:08:37 +00:00
Bill Yi b0c55e8ca3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I43015720f42267d1028be4592081997d9798d7c6
2022-12-12 08:40:40 -08:00
Bill Yi 4fcaced7e0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If8443530a05b53ebe6fb9ddd0f7919255c854672
2022-12-12 08:40:05 -08:00
Jon Miranda c77d4e0715 Merge "Better support transient and persistent taskbar in taskbar's overlays." into tm-qpr-dev am: a76222d209 am: e34202df54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20693438

Change-Id: I6b7bef257cd1553c6a2e79e99c52926b2b3f3012
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12 12:25:55 +00:00
Brian Isganitis 262d9e3269 Merge "Add logging to investigate updateOverviewTargets state." into tm-qpr-dev am: 570c5146d3 am: 3030ccf26b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680311

Change-Id: I320ca78da94f9a57d9304a44df06fd916f06e6b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-12 12:25:43 +00:00
Bill Yi bafb04f1e2 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-12-10 04:36:10 +00:00