Commit Graph

14731 Commits

Author SHA1 Message Date
Vinit Nayak f47ba402c8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5798568fcfc64ef8d7ce3a5175e45f249c53e08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:14:59 +00:00
Vinit Nayak f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Jeremy Sim 6872bc1236 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71 am: 2bc8635b0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ida4e65f9c12d412ba176dc950219b4c19697877d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 00:27:28 +00:00
Sunny Goyal 00e3c1ace4 Using AnimatedFloat for maintaing TaskbarInAppDisplayProgress instead of a float array
Bug: 265352919
Test: Verified on device
Change-Id: I603a817c18720d5f18fe0c2be7bdfd8cf2d6defc
2023-01-12 16:02:42 -08:00
Jeremy Sim 2bc8635b0a Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ie382a53ed107537f52e8bc8777468f52a4288ae9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:50:52 +00:00
Ats Jenk 5299847a64 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1 am: a39ff80885
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: I4df52bf0788546e48499894283b8196e748a8af6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:17:38 +00:00
Ats Jenk d5315c5b94 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1 am: 8df2f4748a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I73fb5a3819793ada1983ff3766aa9012e67b1ff8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:17:15 +00:00
Jeremy Sim 9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk a39ff80885 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: If52b473eb05dca4e0b4dcbdc3c9416b4f0abb53f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:56:36 +00:00
Tracy Zhou 53fb97468b Merge "Update onOverviewShown interface to get signal of whether it should be iterated in forward or backward direction" 2023-01-12 22:43:15 +00:00
Ats Jenk 1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Ats Jenk 8df2f4748a Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I01acb423b0ea3934b2e63779ba8cb3ff3a7ccf03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:37:42 +00:00
Alex Chau f4269f01d7 Revert "Add debug logs for hotseat disapperaed bug"
This reverts commit 04658bcd42.

Reason for revert: root cause found
Bug: 260135164

Change-Id: I809662780d042923de015ff4cb810b3da5169f83
2023-01-12 22:21:07 +00:00
Ats Jenk 984a37d1b1 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev 2023-01-12 22:11:12 +00:00
Sebastián Franco f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
Christophe Pinelli 2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
TreeHugger Robot cadcf8d07a Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522 am: 318da8ce22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: I55318b382a572047400085c45a3ea6c1475f966c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:59:22 +00:00
Luca Zuccarini 675c1b997e Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493 am: 7495d0f873
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I8c7aa28deccf93c25f4df6d1e2a5ceed63c038d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:49:53 +00:00
Christophe Pinelli ab2c2d9576 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: I251cb1edf4e02cd919225d25c05e2e49f820208d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:08:49 +00:00
randypfohl 9c5fa66d2f Cleaning up UI jank while quick switching
Moving a few calls into the UI helper executor thread, as per the associated bug. duplicated the lines so the synchronous nature of clearing previous state wouldn't affect potential timings.

Test: local testing, rotating screen. quick switching apps.

Bug: 257470365
Change-Id: I59abad9ba51c0b19d467646752aa34ae7ef3ec1d
2023-01-12 19:06:04 +00:00
Christophe Pinelli 3cd6cbe6b4 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev 2023-01-12 18:15:31 +00:00
Ats Jenk ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot 318da8ce22 Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: Ib53aa807f447aeba483f6a4a10f078a5b39bf660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 17:50:42 +00:00
TreeHugger Robot 944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Tony Wickham 7d192c0e71 Remove extra overview threshold if the transient taskbar is already open
Test: Swipe to overview when taskbar is already opened vs not
Fixes: 264555943
Change-Id: Ib4c31b085ca51e50fd7442ff9a27a5f47822c242
2023-01-12 16:48:35 +00:00
Chavi Weingarten 80995574bd Updated SurfaceSyncGroup API definition.
Test: Builds
Bug: 237804605
Change-Id: I0c1ebefb123d73df797fe6a6ee9eda456f1f0ccc
2023-01-12 16:12:10 +00:00
Luca Zuccarini 7495d0f873 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I3629ade53ed1be9d596a158e0f71efd999428aa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 14:51:20 +00:00
Luca Zuccarini 51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Nicolo' Mazzucato 696238e086 Provide single threaded executor to UnfoldUnfoldTransitionFactory
This fixes a concurrency issue where HingeSensorAngleProvider was being stopped and started at the same time in a thread-pool after a fast fold/unfold, despite not providing concurrency guarantees.

In sysui, the background executor provided was already single threaded, so no issue arisen. From Launcher, THREAD_POOL_EXECUTOR was provided.

In a follow up cl, I'll add a @SingleThreadBackground annotation to the executor used in the unfold lib.

Bug: 261320823
Test: manually stress tested fold/unfold.
Change-Id: Iccf1f1f7246d8592d4d80a032479aa75f0050655
2023-01-12 09:19:48 +00:00
Johannes Gallmann 031fbcc564 Prevent workspace enter animation for predictive back
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
2023-01-12 10:06:18 +01:00
Tracy Zhou 6fb8b3cec4 Update onOverviewShown interface to get signal of whether it should be
iterated in forward or backward direction

For more information, check out the change in the same topic.

Bug: 258854035
Test: manual
Change-Id: Id4a201c1979645ec319478f634039a4e9e495a35
2023-01-12 07:17:58 +00:00
Vinit Nayak 1d7e050bc6 Respect nav button tinting in SUW
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
2023-01-11 21:29:37 -08:00
Christophe Pinelli 9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Shan Huang 6677aeab1d Merge "Add background protection for back to home animation." 2023-01-12 01:03:49 +00:00
Stefan Andonian 53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:55 +00:00
Stefan Andonian 167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:16 +00:00
Fengjiang Li e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00
Stefan Andonian fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Tracy Zhou f1963f7e86 Merge "Swipe-up from the bar area on the home screen should pull up overview" 2023-01-11 22:06:58 +00:00
Shan Huang a0fb0bf717 Add background protection for back to home animation.
Bug: 238475118
Test: Swipe back on Settings in light theme. Switch to dark theme and
try again. Make sure scrim looks nice in both cases.

Change-Id: Ic099d7b8e84a04105712f13c94d0c6f82863e844
2023-01-11 13:57:33 -08:00
Jagrut Desai cc96cf3345 Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2 am: 9ef3dff40d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: Ic564353b9e1b992d0647dcafdfbbb91d07094fbc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 20:06:02 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Jagrut Desai 9ef3dff40d Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: I886944c8f9a8ad2083cd84f2cc29cf9c41497b75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 19:09:20 +00:00
Miranda Kephart aaa77b8035 Update ImageActionUtils to construct a ScreenshotRequest
Bug: 264457397
Test: atest
Merged-In: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
Change-Id: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
2023-01-11 12:44:07 -05:00
Alex Chau 7351218fab Update overview actions top margin
Bug: 260596114
Test: manual
Change-Id: Ic5f51a8d0505571272e5ad03bd16db2b903fd697
2023-01-11 15:41:52 +00:00
Sebastian Franco a955403ba9 Change the access of cellX/Y of CellLayoutLayoutParams to private
Cherry pick needed for changes on workspace lily

Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-11 15:25:23 +00:00
Tony Huang f1a43efa0b Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578 am: 9898e5cc44
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: I9e780abb3987bf8c40f24fafb5f906ff659ddee8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 04:58:05 +00:00
Tony Huang 9898e5cc44 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: Ifbd4ea9766123d4c5943f0ea75600416a6b39312
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 04:17:34 +00:00
Jagrut Desai 50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height.
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
2023-01-11 04:16:07 +00:00
Tony Huang d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00