Commit Graph

14731 Commits

Author SHA1 Message Date
TreeHugger Robot 1cc0010eba Merge "Persist prediction cache on every update" into ub-launcher3-rvc-dev 2020-07-08 05:03:03 +00:00
TreeHugger Robot 4c40be975c Merge "Fixes the issue Launcher state propagation is slower than onDeferredResume." into ub-launcher3-master 2020-07-08 00:27:35 +00:00
Sunny Goyal 52f2392405 Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-08 00:24:29 +00:00
Sunny Goyal 141c231d2f Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
2020-07-07 19:50:34 +00:00
Sunny Goyal f16456f686 Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
2020-07-07 18:22:37 +00:00
TreeHugger Robot 289aca6a0e Merge "Guard swipe to notification gesture with system settings preference" 2020-07-07 02:02:11 +00:00
Sunny Goyal 451b09ea75 Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
2020-07-06 11:12:53 -07:00
Sunny Goyal 0d213ebb79 Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
2020-07-06 17:17:12 +00:00
Jerry Chang 779efaca91 Guard swipe to notification gesture with system settings preference
Bug: 154080211
Test: make and install, check the gesture works as expectedly
Change-Id: Ibd6bbd595d2fba5d68e66eb54e4a7fec160b9bf8
2020-07-01 11:44:02 +08:00
Pinyao Ting 3bf889a02f Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
2020-06-30 17:00:24 -07:00
TreeHugger Robot b89ff05fdf Merge "Fix all apps edu in landscape." into ub-launcher3-master 2020-06-30 17:14:31 +00:00
Jon Miranda 84b848ad5d Fix all apps edu in landscape.
* Fix bug where All Apps not visible during hint animation.
* Fix bug where All Apps is empty after hint animation.

Bug: 160122854
Change-Id: Id4106a6200df2845b3c041d5aae14fb83c94b4d4
2020-06-29 17:39:42 -07:00
Thiru Ramasamy 91ee0a6e37 Merge "Fixes NPE with system shortcuts." into rvc-dev am: 6f5d4bb8ab am: fc49c2c54a am: 31cfe34963 am: adf1fe59b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12035575

Change-Id: I4a070ef7f9c53faebba42cd1e2744f8479ebe9aa
2020-06-30 00:37:03 +00:00
Thiru Ramasamy 6f5d4bb8ab Merge "Fixes NPE with system shortcuts." into rvc-dev 2020-06-29 23:35:59 +00:00
Zak Cohen 1562c3de18 Thumbnail Cache - check canceled status on the right thread. am: 19797b419b am: 987ba0261f am: 4163325b9c am: c01ab27bce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12029198

Change-Id: Ib5e004cae554832050f1a3efff5276bf3399d126
2020-06-29 22:59:17 +00:00
TreeHugger Robot d0c11689d3 Merge "Fixes NPE with system shortcuts." into ub-launcher3-rvc-dev am: 24ce95124e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12035570

Change-Id: Ifb267c2202b94d8d4c30f0485538ce3f7e6101d0
2020-06-29 19:52:08 +00:00
thiruram 43bf883841 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
(cherry picked from commit 53925ff9c6)
2020-06-29 19:44:28 +00:00
thiruram 53925ff9c6 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
2020-06-29 12:04:32 -07:00
TreeHugger Robot c67625411f Merge "Using original taskInfo to create the taskKey instead of fake data" into ub-launcher3-master 2020-06-29 18:06:16 +00:00
Zak Cohen 8063fe0e68 Thumbnail Cache - check canceled status on the right thread. am: a3629bd52c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12029197

Change-Id: I1b99714506e408d145b6d03a49cea621ef290781
2020-06-29 04:52:22 +00:00
Zak Cohen 19797b419b Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-29 04:11:04 +00:00
Zak Cohen a3629bd52c Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-28 21:10:07 -07:00
Sunny Goyal fabfb3ae90 Using original taskInfo to create the taskKey instead of fake data
Change-Id: Ie4e35b35484e0f6cb939febe6357b37381d81682
2020-06-26 17:14:16 -07:00
TreeHugger Robot 879ba9803d Merge "Add NPE check for prediction controller" into rvc-dev am: f8e12b78bf am: 53c7ddd7fd am: 39e1af9a27 am: 4585f9f3c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12001481

Change-Id: I18caa4806f4933059fb1bdc5165e5aa80b5bd605
2020-06-26 20:45:18 +00:00
Jon Miranda 54003963d8 Fix velocity in StaggeredWorkspaceAnimation.
* Velocity should match the direction of the spring values.
  (Swipe direction is upwards, but icons move downwards on screen).
* Remove additional conversion to pxPerS since getDimension already does that.

Bug: 160003774
Change-Id: I12912edb2354c4a30c538da6ca3789c46d82b94d
2020-06-26 18:16:13 +00:00
TreeHugger Robot fe6d3c6221 Merge "Add NPE check for prediction controller" into ub-launcher3-rvc-dev am: f59922d0d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12000756

Change-Id: I7ecfc4c45bbc60fc29181ac81606e26d06196392
2020-06-26 08:06:49 +00:00
TreeHugger Robot f59922d0d7 Merge "Add NPE check for prediction controller" into ub-launcher3-rvc-dev 2020-06-26 07:42:38 +00:00
Tony Wickham 3d6bfc2905 Merge "Fix tracking window being slightly off when swiping from an app" into ub-launcher3-master 2020-06-25 22:18:32 +00:00
Samuel Fufa 0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
Samuel Fufa 514df92bcf Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 13:08:55 -07:00
Tony Wickham f0a1b2ccd8 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
2020-06-25 11:51:28 -07:00
TreeHugger Robot d9dd5cec0f Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: 40483a5399 am: 4073796ff7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: Ic1582747cd4d16c5df22ce4e6d0e5716d17aebfd
2020-06-25 18:07:35 +00:00
TreeHugger Robot ccf588d36b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev 2020-06-25 16:38:47 +00:00
Andy Wickham 3b98451394 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d am: 98f26d1a15 am: 5cf822dff3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I2769af25a543a8860d7533f8e677e958d2b4b0ef
2020-06-25 03:21:00 +00:00
Tony Wickham 072e4c276d Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into ub-launcher3-rvc-dev am: 9d69370095
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11990144

Change-Id: I0b8a7052caf6352f4505a4327385332f2a6ef934
2020-06-25 02:28:27 +00:00
Tony Wickham 9e84745e4b Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
(cherry picked from commit c6a56ef7a2)
2020-06-25 02:11:04 +00:00
Tony Wickham 9d69370095 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into ub-launcher3-rvc-dev 2020-06-25 02:10:54 +00:00
Andy Wickham 646f2ab0d9 Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev am: fce6be550b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11989960

Change-Id: Iac670fc5f6cfdb0bb38a571c96136858f1b14f1a
2020-06-24 22:43:38 +00:00
Andy Wickham d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
Andy Wickham fce6be550b Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev 2020-06-24 22:29:45 +00:00
Andy Wickham 4b531b972d Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
2020-06-24 21:23:35 +00:00
Tony Wickham c6a56ef7a2 Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
2020-06-24 11:59:10 -07:00
TreeHugger Robot bd053698af Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev am: ca493d1426 am: 3af603f240 am: 39d753dfff am: ebce67c523
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978215

Change-Id: Ieeca4b86744eedcfc400b31884839c271a77fd8e
2020-06-24 07:50:35 +00:00
TreeHugger Robot ca493d1426 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev 2020-06-24 06:52:16 +00:00
TreeHugger Robot cb0bd36e79 Merge "Remove hotseat edu flag" into rvc-dev am: d6cd14d179 am: e65a33134d am: 373d9f4d88 am: fc8bfcf97f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11979630

Change-Id: Iac5479c15d9f5562c0af9c1f73bdfb2244bec308
2020-06-24 05:27:12 +00:00
Zak Cohen b9c83bb854 Merge "Fixing TaskMenu positioning." into rvc-dev am: b2b0d4d478 am: c588af043c am: c943b2ed54 am: 202319be61
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978354

Change-Id: Iec16e12df3fd8ac0f32b96f353cc419adaa03222
2020-06-24 04:53:12 +00:00
TreeHugger Robot d6cd14d179 Merge "Remove hotseat edu flag" into rvc-dev 2020-06-24 04:43:52 +00:00
TreeHugger Robot 44035d9d17 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev am: 738b1af342 am: f7897465e3 am: 808a7c1920 am: dde7797ec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975976

Change-Id: Ifdd13981f0e61d248e89a1f10eec3b51369840f4
2020-06-24 04:26:33 +00:00
Sreyas 20024f4447 Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:11:05 +00:00
Sreyas 2bbce930cb Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:10:29 +00:00