Commit Graph

14731 Commits

Author SHA1 Message Date
Winson Chung 5290db66a8 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev am: 550dc8dc69 am: 1c0bced602
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308385

Change-Id: I0a5e8451e1f415bcf92e31b8428c293f10e25b88
2021-11-22 17:43:01 +00:00
Winson Chung 1c0bced602 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev am: 550dc8dc69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308385

Change-Id: Iebab222d49fec6fc8d427890b247692921ae54b4
2021-11-22 17:27:41 +00:00
Winson Chung 550dc8dc69 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev 2021-11-22 17:22:16 +00:00
Alex Chau a0aa9ac6e4 Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev am: 3c2298668a am: 0c59f1ac7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307753

Change-Id: I2c49271d01922df710d53f1d52090ed0c1593880
2021-11-22 11:35:51 +00:00
Alex Chau 0c59f1ac7b Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev am: 3c2298668a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307753

Change-Id: I9cf958a545f24c5ce609dac73166dbaf830a413c
2021-11-22 11:23:22 +00:00
Alex Chau 3c2298668a Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev 2021-11-22 11:12:23 +00:00
Winson Chung e2074f01c0 Skip scheduling frame callback if view root is already detached
- Also remove references to deprecrated compat class

Bug: 206932656
Test: Presubmit
Change-Id: I1add65b0fe03dedea872d162e51095bf9c648acf
2021-11-20 00:58:43 +00:00
Winson Chung c2a84d887f Clear ref after animation if visual stashing not supported
Bug: 206814323
Test: Presubmit
Change-Id: Ia38bd2707edbddf1b1f2ad98b3cdac4c8c62a6d3
2021-11-19 23:52:18 +00:00
Winson Chung 87b70a6915 Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev am: 5e49df2bbe am: 616f181857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307006

Change-Id: I0be97fe98b93085d7a1cc5bc145d17045a8c0989
2021-11-19 22:53:13 +00:00
Winson Chung 616f181857 Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev am: 5e49df2bbe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307006

Change-Id: Iec12b5058211a8fd49badcfc85fd656a03e2a00f
2021-11-19 22:40:54 +00:00
Winson Chung 5e49df2bbe Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev 2021-11-19 22:24:13 +00:00
Jonathan Miranda 2a1dc00688 Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev am: 2d9ac4e67f am: 1b7ffc9b2b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307200

Change-Id: Ie97e5779a725271b5bc83d786b6482dfa111c518
2021-11-19 22:17:16 +00:00
Vinit Nayak 1c1dc23d9b Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev am: 54baaae0ab am: 01eab872ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307108

Change-Id: I463b401308cd90be532c6419fe4a72990dcb19ea
2021-11-19 22:17:08 +00:00
Jonathan Miranda 1b7ffc9b2b Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev am: 2d9ac4e67f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307200

Change-Id: I58ee7c72effc3445abc104e2d863df0235516cf9
2021-11-19 22:10:38 +00:00
Jonathan Miranda 2d9ac4e67f Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev 2021-11-19 22:05:07 +00:00
Vinit Nayak 01eab872ad Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev am: 54baaae0ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307108

Change-Id: I3ee7c10880f722243485d5082c4c25ba3b013f94
2021-11-19 22:04:35 +00:00
Vinit Nayak 54baaae0ab Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 21:51:03 +00:00
Zak Cohen d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Alex Chau af43216f0d Merge "Use only current density to check isTablet" into sc-v2-dev am: 7ba828c1a9 am: 8d3d6b1961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306379

Change-Id: I66dd05d8c193cebfafa2095f986d8ea2bc3f9c57
2021-11-19 20:58:15 +00:00
Alex Chau 8d3d6b1961 Merge "Use only current density to check isTablet" into sc-v2-dev am: 7ba828c1a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306379

Change-Id: Iedfc2c003c52d7061a80a45dc477a7f888d53349
2021-11-19 20:41:00 +00:00
Jon Miranda 1f2b9b1c36 Use empty intent instead of null when creating stub TaskKey
Bug: 199027804
Test: manual
Change-Id: Ie66c8740453088791e026fa51a2842f59c6c67fd
2021-11-19 12:06:42 -08:00
Vinit Nayak a59835214f Open taskMenu based on TaskIdAttributeContainer
* We were always passing in the same task no matter
which task icon was clicked.
* Use TaskIdAttributeContainer to associate
IconViews with their respective tasks

Fixes: 206154715
Test: Correct menu opens for split and fullscreen
tasks

Change-Id: I5f264bb69828532bdefffb7ec4b9ff1e501de086
2021-11-19 11:38:31 -08:00
Winson Chung a5960223cf Set sync applier on the transform params for the glued targets
Bug: 199043513
Test: Swipe up with split task and scroll really quickly
Change-Id: Ie10b27457903d8db4d4c973ab5b7e669da2c4998
2021-11-19 19:33:54 +00:00
Jonathan Scott 0efebc0fc4 Merge "Revert "Open taskMenu based on TaskIdAttributeContainer"" into sc-v2-dev am: 6547721d8c am: 91faa6bb06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306389

Change-Id: I26f93df322dfd2945f09be35a5b61b90eab27edc
2021-11-19 17:17:17 +00:00
Jonathan Scott 91faa6bb06 Merge "Revert "Open taskMenu based on TaskIdAttributeContainer"" into sc-v2-dev am: 6547721d8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306389

Change-Id: I47bd18e86c48b5b28614fe18728c4dba48762284
2021-11-19 16:59:03 +00:00
Jonathan Scott 6547721d8c Merge "Revert "Open taskMenu based on TaskIdAttributeContainer"" into sc-v2-dev 2021-11-19 16:44:30 +00:00
Jonathan Scott ec79eb9cbc Revert "Open taskMenu based on TaskIdAttributeContainer"
This reverts commit c1ec2d4260.

Reason for revert: broken build b/207126572

Change-Id: I0908e8e6579bc54c6ce1dff88bddf8b030f336d9
Fixes: 207126572
2021-11-19 16:43:45 +00:00
TreeHugger Robot fb139eb8eb Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev am: 988a87526e am: 552a72fb28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16287141

Change-Id: Idbe8c6e45b30a3b40c2e66dd31b06048ae1a0ab9
2021-11-19 16:35:02 +00:00
TreeHugger Robot 552a72fb28 Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev am: 988a87526e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16287141

Change-Id: I363880d20c3c62bb75b4c2a597a5172be557808c
2021-11-19 16:24:31 +00:00
TreeHugger Robot 988a87526e Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 16:06:30 +00:00
Alex Chau 2998307cd6 Use only current density to check isTablet
- Removed DeviceProfile.allowRotation and use DeviceProfile.isTablet instead, which only uses current density to calculate its value
- Reverted default allow_rotation preference handling to before ag/14234761

Fix: 203817448
Test: isTablet is set correctly in different screen sizes
Change-Id: Ic6c8dfc774e7787f62d489ad27720a7644c1e8c7
2021-11-19 15:27:01 +00:00
Alex Chau 6499e83c57 Consider launching task's position on screen in pivot calculation
- Instead of using RecentsViewScroll, put task's position offset versus current scroll as TaskRect calculation, so it's considered when calculating for putting task to full screen
- Revert back RecentsViewScroll to apply before RecentsViewScale
- Added new property in PagedOrientationHandler to apply both primary/secondary param without clearing the other, and renamed an existing method

Fix: 206972618
Test: Quick switching
Test: Launch task from grid, launch side task from carousel overview
Change-Id: I5977975ed1e930ad70b81d83513d8f3a00c0aed4
2021-11-19 14:42:20 +00:00
Fedor Kudasov dff1bee0cb Merge "Move FloatingTaskInit set up into init method" into sc-v2-dev am: 039501f41f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279510

Change-Id: If7370a7be6941e51f6559d79e824838ce2e601ac
2021-11-19 10:40:30 +00:00
Fedor Kudasov 039501f41f Merge "Move FloatingTaskInit set up into init method" into sc-v2-dev 2021-11-19 10:26:46 +00:00
Vinit Nayak 93d37ee334 Launch GroupedTaskView from thumbnails am: 788821ec4e am: 0c567f0c41
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16288752

Change-Id: Ie39a68bfe04f40ea63070018b68dc7d97fe08274
2021-11-19 09:35:28 +00:00
Vinit Nayak 0c567f0c41 Launch GroupedTaskView from thumbnails am: 788821ec4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16288752

Change-Id: I8bb7d6df11a4eee0bd80ca4e73bbeb3f29ac69b8
2021-11-19 09:17:31 +00:00
Vinit Nayak f957244b88 Show multiple App Info A11y options for split app icons
* AccessibilityNode actions are required to have a
unique resourceId to show as an action in A11y dialog.
For now, only AppInfo option is shown for each app in split,
but moving forward we'll need to add resourceIDs for
each option that can show up for either app.

Fixes: 200609838
Test: Saw multiple options for App Info for each app
come up in talkback mode

Change-Id: I92b349347354ac639537021d775eea814c866a0e
2021-11-18 23:22:46 -08:00
Vinit Nayak 788821ec4e Launch GroupedTaskView from thumbnails
* Previously when starting the remote animation
we were relying on SplitPlaceholderViews to
animate into the proper place since we weren't
launching from the TaskView itself
* Now when launching from a GroupedTaskView,
we use the existing animation that handles that
animation in addition to showing the new split tasks

Fixes: 206608786
Test: Thumbnails animate from home -> overview -> launch
Change-Id: I1499ead7d90cd41e285ed0f4df66ea31f0dfbc95
2021-11-18 22:58:53 -08:00
TreeHugger Robot 4077d5a326 Merge "Reset split selection state when RecentsView resets" into sc-v2-dev am: 84b64d7910 am: 6b818deec1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16299751

Change-Id: I38d14c7e1b2d63a91dfba495d769e74067966720
2021-11-19 00:17:12 +00:00
TreeHugger Robot 6b818deec1 Merge "Reset split selection state when RecentsView resets" into sc-v2-dev am: 84b64d7910
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16299751

Change-Id: Id2bb37c56201df52da0be8749970b3ecd05eafdb
2021-11-19 00:04:16 +00:00
TreeHugger Robot 84b64d7910 Merge "Reset split selection state when RecentsView resets" into sc-v2-dev 2021-11-18 23:51:47 +00:00
Vinit Nayak 97f9bd575a Reset split selection state when RecentsView resets
* We weren't calling reset on the views
involved in split selection when recents view gets
a reset call (oops)
* Use device theme for split placeholder theme instead
of hardcoding to white

Fixes: 206155455
Change-Id: I3768fd574cb21eec9562d89c1a93eaa3f53d5ff1
2021-11-18 14:06:27 -08:00
TreeHugger Robot a55a23fdd6 Merge "Check if ThumbnailData's bitmap is null in TaskThumbnailCache" into sc-v2-dev am: 39aceb6dc7 am: cf2f085d23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282756

Change-Id: I02a126667b4efd487354db335c9f82482d7e7d17
2021-11-18 21:53:18 +00:00
TreeHugger Robot cf2f085d23 Merge "Check if ThumbnailData's bitmap is null in TaskThumbnailCache" into sc-v2-dev am: 39aceb6dc7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282756

Change-Id: I4d87bc4180dba56d48b14320711c5d69a59aaa78
2021-11-18 20:23:53 +00:00
TreeHugger Robot 39aceb6dc7 Merge "Check if ThumbnailData's bitmap is null in TaskThumbnailCache" into sc-v2-dev 2021-11-18 19:46:50 +00:00
Thales Lima 29df4a92de Merge "open grid task menu to the right of icon" into sc-v2-dev am: bd1aec6721 am: 86f23841c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16248618

Change-Id: Ic2fa8bd603abd46f1fcf5d9a1234f1e2ff798e61
2021-11-18 18:42:11 +00:00
Thales Lima 86f23841c2 Merge "open grid task menu to the right of icon" into sc-v2-dev am: bd1aec6721
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16248618

Change-Id: I5552cc4a7222a22191553f1b88ad23fc3ef3f25c
2021-11-18 18:26:40 +00:00
Thales Lima bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
Alex Chau 4670d37e55 Check if ThumbnailData's bitmap is null in TaskThumbnailCache
- This makes sure TaskThumbnailCache fetch for thumbnail when its Bitamp is null

Fix: 206959035
Test: See steps in b/206959035
Change-Id: I03b574b0f8cc7390a8cad618bd810f44f0dee279
2021-11-18 15:57:28 +00:00
Thales Lima 45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00