Commit Graph

11841 Commits

Author SHA1 Message Date
Samuel Fufa efa5df380c Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev 2021-06-17 18:48:49 +00:00
Stevie Kideckel 10d4edade1 Merge "Refresh widgets in the model when packages change" into sc-dev 2021-06-17 15:04:01 +00:00
Stevie Kideckel 69af278f8a Refresh widgets in the model when packages change
Fix: 191163748
Test: local sample app
Change-Id: Ic09ad11cabf6efa471fb6e685cb255c4a17493ee
2021-06-17 13:08:53 +00:00
Steven Ng 6ce6922c14 Merge "Deduct padding from widget size only if padding has been inset" into sc-dev 2021-06-17 11:00:33 +00:00
Yogisha Dixit 3287dd9fa7 Merge "Center drop target icons in landscape mode." into sc-dev 2021-06-17 09:34:42 +00:00
Steven Ng 1184a03b08 Merge "Modify AT_LEAST_S check to include SDK int" into sc-dev 2021-06-17 09:09:21 +00:00
Steven Ng e8772c1659 Merge "Fix PendingWidgetHostView overlapping UI" into sc-dev 2021-06-17 09:08:15 +00:00
TreeHugger Robot ea95f88361 Merge "Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events." into sc-dev 2021-06-17 06:08:09 +00:00
TreeHugger Robot 4f257655bd Merge "Add logging for tapped on 'Turn on/off work apps' button in all apps" into sc-dev 2021-06-17 05:25:49 +00:00
TreeHugger Robot 3115a4380b Merge "Fix broken app icon on restart during install." into sc-dev 2021-06-17 01:11:53 +00:00
Thiru Ramasamy 95b09f9067 Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events.
Bug: 178562918
Test: Manual
Change-Id: Id32b621c0f506bba4378f6f6b81d7cfece3cb373
2021-06-17 00:05:56 +00:00
Thiru Ramasamy 6f0e75740f Add logging for tapped on 'Turn on/off work apps' button in all apps
Bug: 190050582
Test: Manual
Change-Id: Ib83fba6dc9199ba40a500e0743c0e64cc4d4d0a0
2021-06-16 17:03:49 -07:00
Schneider Victor-tulias bcd72a7b32 Fix broken app icon on restart during install.
Fixes: 186610233
Test: manual with backup/restart and restart during install
Change-Id: Ic64bd98758bc2e1a2a1562579cb25de02faa624c
2021-06-16 16:47:45 -07:00
TreeHugger Robot 3a37543fb9 Merge "Prevents a ConcurrentModificationException in Widget" into sc-dev 2021-06-16 23:43:29 +00:00
TreeHugger Robot 0bf000104f Merge "Fix bug where preview item icon fades/disappears for a frame during" into sc-dev 2021-06-16 23:24:58 +00:00
Steven Ng 71cefb593f Deduct padding from widget size only if padding has been inset
Test: Set the grid to 4x5 (without padding) and verify the min / max
      size sent to Conversation widget is expected.
Bug: 190498032
Change-Id: I8ef6e5d897ebd0e2ea9af4497b00059c8dfad70a
2021-06-17 00:15:52 +01:00
Steven Ng 7e31e9b267 Modify AT_LEAST_S check to include SDK int
BuildCompat.isAtLeastS() in Launcher dependency only checks if the
code name is "S". In the recent version of Android, the code name has
changed to "REL".

Test: Open Widgets picker, expand Conversations and observe a preview
      layout is shown.
Fix: 191239040, 191216821
Change-Id: I6a6e647d4cb327d251bde3484ea2d2e79c0f86f5
2021-06-16 23:56:38 +01:00
Samuel Fufa d04a92d1ed Refactor FolderInsetAnimationCallback to be used with any view
- Update ic_corp_off icon to outline
- Remove shadow from work toggle
- Translate work fab when keyboard is shown

Screenshot: https://screenshot.googleplex.com/593tEg7bE4kSS4y

Bug: 191251404
Bug: 191250785
Test: local
Change-Id: Ie7dddfd17eb90575a1e1f67e281070dd8d268f8d
2021-06-16 17:25:53 -05:00
TreeHugger Robot 4176cb33bb Merge "Reattach LauncherAppWidgetHostView to its parent after canceling drag" into sc-dev 2021-06-16 22:25:41 +00:00
Pinyao Ting 9cd63c97ce Prevents a ConcurrentModificationException in Widget
InvariantDeviceProfile.supportedProfiles can be modified in respect to
configuration changes. This CL ensures the list was cloned before access
to prevent ConcurrentModificationException

Bug: 191231591
Test: manual
Change-Id: I123458dcfe99af4babca2cf73733e3d2af0fad3c
2021-06-16 21:02:48 +00:00
Jonathan Miranda 28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Hyunyoung Song d2ad97989c Merge "All apps motion" into sc-dev 2021-06-16 20:14:46 +00:00
Yogisha Dixit 58c5e65763 Center drop target icons in landscape mode.
Spec: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187376586
Change-Id: I2025ba75061a5ca3a004dfef2b33cdbcc17a1408
2021-06-16 20:55:56 +01:00
Yogisha Dixit de268a51a1 Merge "Fix drop target icons being truncated." into sc-dev 2021-06-16 19:48:08 +00:00
Hyunyoung Song 54a44d4c44 All apps motion
Bug: 189970327
Test: manual

TL;DR;;

equation: settleVelocity = releaseVelocity + interpolator 2nd deritive * t

Change-Id: I86fec339523fbc3bb347dec4affbd2d1c063d13d
2021-06-16 11:17:59 -07:00
Jon Miranda b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
TreeHugger Robot 29dba38119 Merge "Add work toggle to work apps paused message" into sc-dev 2021-06-16 15:57:49 +00:00
Yogisha Dixit ed052ab212 Fix drop target icons being truncated.
The icons were being truncated due to incorrect viewport width/height
values for the vector drawable.

Test: manual
Bug: 187036287
Change-Id: Ie2d0ffe815501d2e943146a79cb4ede379ce0ecf
2021-06-16 14:07:38 +01:00
Steven Ng 19bc880a5f Fix PendingWidgetHostView overlapping UI
* Only show launcher set up UI if a pending widget has not finished
set up.
* Update configuration string

Test: manual inspection
Bug: 190037003
Change-Id: I3b9fb39da21ea557f97e9ca7b05a3b52f3ec3452
2021-06-16 11:22:49 +01:00
Stevie Kideckel 358411a96a Merge "Use drawable states for list positions instead of swapping drawables" into sc-dev 2021-06-16 09:34:21 +00:00
Jon Miranda 229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Jon Miranda 9d41499a33 Fix bug where preview item icon fades/disappears for a frame during
- Remove fade since we no longer clip icons.
- Ensures a clean handoff between drag view and folder icon preview item.

Bug: 175329686
Test: create folder / add items to folder
Change-Id: Iaab592410734b0b5239dbbddbb9b2ed5a9f5d8b0
2021-06-15 21:14:47 +00:00
Schneider Victor-tulias e00d88e32a Merge "Skip item infos that fail session info verification." into sc-dev 2021-06-15 20:54:23 +00:00
Thiru Ramasamy 640fc8b84d Merge "Enable logging for 'Themed icons' setting." into sc-dev 2021-06-15 20:47:23 +00:00
Samuel Fufa dfc274364e Add work toggle to work apps paused message
This also fixes scrolling issues in landscape

Bug: 186857875
Bug: 161929312
Bug: 189983516
Bug: 190567199
screenshot: https://screenshot.googleplex.com/BCjcyJFqJo6W4Tr
Test: local
Change-Id: I7bcf23cc4be2fca936eba41342731789eb8f3292
2021-06-15 14:58:05 -05:00
Schneider Victor-tulias 12e9345f4f Skip item infos that fail session info verification.
trichromelibrary.canary is failing session info verification, but is still being added as blank icon on the workspace in some cases. Added logic to skip apps that fail this verification until the root cause can be found.

Bug: 168788486
Test: none

Change-Id: I8a7fe76f321de493b2c6c67ba6922eae23067ff3
2021-06-15 12:12:07 -07:00
Samuel Fufa 1bd6fdb6e3 Merge "Fix home settings landing page" into sc-dev 2021-06-15 18:32:36 +00:00
Winson Chung 1b369c4763 Merge "Don't rely on intent to call back from activity tracker" into sc-dev 2021-06-15 18:04:52 +00:00
TreeHugger Robot 9c25a4dd07 Merge "Remove IME visibility check before closing the keyboard" into sc-dev 2021-06-15 18:00:48 +00:00
Thiru Ramasamy 74a6d2ea55 Enable logging for 'Themed icons' setting.
Eldar: http://eldar/510864786
Bug: 191161241
Test: local - http://gpaste/5934701681311744 & http://gpaste/6715297709948928
Change-Id: I18ad97f68b372997e222f06dabf8bbe83f15d92f
2021-06-15 10:48:43 -07:00
Alina Zaidi b5459c9ba5 Merge "Update bottom widget picker and pin widget dialog layout in landscape mode." into sc-dev 2021-06-15 17:23:02 +00:00
Stevie Kideckel 803927bdae Use drawable states for list positions instead of swapping drawables
Replacing drawables interrupts touch feedback of ripples. Implementing
custom state lists allows altering the corner radius without cutting off
ripples and also means we reduce unnecessary object creation.

Fix: 190467676
Test: locally
Change-Id: I10eec042aae57d278f8254327d42df945767c7ac
2021-06-15 16:32:36 +00:00
Santhosh Thangaraj 4d61c56200 Merge "Fix the page number based Seen impression." into sc-dev 2021-06-15 15:20:40 +00:00
Alina Zaidi dfa6aa828c Update bottom widget picker and pin widget dialog layout in landscape mode.
Bug: 189726613
Test: Manually tested
Change-Id: I048740f949571423ab53bbb01e7128d9981b1ce7
2021-06-15 14:27:57 +01:00
Hyunyoung Song 0ba45e4d5e Remove IME visibility check before closing the keyboard
Bug: 185890446
Test: manual

TL;DR;;
In racy condition, keyboard is not visible when the check happens
but in next frame, it becomes visible.

Change-Id: I3336f3c967804e5ccdea9110c363e92d83b7bc02
2021-06-14 23:15:52 -07:00
Winson Chung 1c2d522d1b Don't rely on intent to call back from activity tracker
- The intent is not updated in certain cases which means that the
  callback may not be made if Launcher gets recreated. Instead
  have the tracker manage the set of registered callbacks.
- This change allows AbsSwipeUpHandler to continue to receive
  onActivityInit calls even if Launcher restarts, and also to
  handle a case where restarting while waiting for a page-settling
  callback will continue to finish the gesture.

Bug: 183962705
Test: Force recreate at various points in the gesture

Change-Id: Ib5ead8c868e798e26e56776f57bd715c79d087cd
2021-06-14 20:57:40 -07:00
Jonathan Miranda bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda 0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00
Hyunyoung Song 8c0f8fba9c Merge "Fix NPE inside REcyclerViewFastScroller" into sc-dev 2021-06-14 23:18:22 +00:00