Commit Graph

11856 Commits

Author SHA1 Message Date
Stevie Kideckel e99f3c9666 Fix bug in equals implementation for search headers
Fix: 191626327
Test: verified locally
Change-Id: I8103059a2759a8533581ff86cb57b28913cf5731
2021-06-21 10:42:16 +00:00
Jonathan Miranda 1bfd350ead Merge "Update notification popup UI." into sc-dev 2021-06-19 03:52:23 +00:00
Jon Miranda 313b2c2d28 Update notification popup UI.
- Update UI to match specs.
- Only shows one notification (removed footer, animation code)

Bug: 175329686
Bug: 190402054
Test: open popup, dismiss notification from shade,
      open popup, click on notification
      checked RTL

Change-Id: I92672f94233d986ae5b5c54979980967308cb156
2021-06-18 22:42:44 +00:00
Stevie Kideckel dd19a24769 Merge "Load widget preview images before adding the rows to the adapter" into sc-dev 2021-06-18 22:37:32 +00:00
Jonathan Miranda 576179199a Merge "Fix bug where ripple extends out of bounds in pop up container." into sc-dev 2021-06-18 22:27:45 +00:00
Jon Miranda f13ddbd333 Fix bug where ripple extends out of bounds in pop up container.
Bug: 186820908
Test: test apps with diff. pop up container arrangements
      test prefs in all apps

Change-Id: I4d3e26871416835ab2a851fcc6fe2c4f70235b62
2021-06-18 20:58:14 +00:00
Stevie Kideckel a093523299 Load widget preview images before adding the rows to the adapter
This allows for smooth animations as the items will have their full
height resolved

Bug: 190892517
Test: verified locally
Test: CachingWidgetPreviewLoaderTest
Change-Id: I86afc6951a4cc82ae45e63795791d259a3bb3cda
2021-06-18 19:18:29 +00:00
Samuel Fufa f44a9ca6f0 Merge "Allow AllApps to restore current selected tab on activity recreate" into sc-dev 2021-06-18 17:57:08 +00:00
TreeHugger Robot 2af9d27116 Merge "Revert "Deduct padding from widget size only if padding has been inset"" into sc-dev 2021-06-18 11:11:20 +00:00
Steven Ng 21780405ac Merge "Log widget dimensions before deleting a widget violating min size" into sc-dev 2021-06-18 10:21:32 +00:00
Steven Ng 54b5424548 Revert "Deduct padding from widget size only if padding has been inset"
This reverts commit 71cefb593f.

Reason for revert: The default padding is added by the framework not the launcher. We really need to subtract padding from the size.

Bug: 190498032
Change-Id: If7f164da34aec3d8e022ef2c752b72292cca0489
2021-06-18 09:37:44 +00:00
Steven Ng be397e85e8 Merge "Use relative bounds for app widget color extraction" into sc-dev 2021-06-18 09:01:25 +00:00
Steven Ng 058308098b Use relative bounds for app widget color extraction
Fix 2 bugs in this CL
1. Before this CL, getBoundsForViewInDragLayer returns absolute bounds
   for widgets. What we want is the bounds of a widget when it is
   visible in the drag layer. ViewGroupFocusHelper#viewToRect has
   taken PagedView into account. This makes it a prefect candidate to
   calculate relative bounds of a widget.
2. requestLayout at the end of endDrag is problematic due to the drop
   animation. If the drop animation is still in progress when onLayout
   is called, the bounds of the widget isn't final. Since the color of
   app widget right before is already the final color. We don't really
   need to update the color extraction.

Test: Set the wallpaper and clock widget according to the bug. Then,
      reboot the device. The clock widget color shown right after
      reboot is the expected color. Long pressing the widget doesn't
      cause a color change.
Fix: 191114337
Change-Id: I466c8102dba0e5b207b3768e0935472cbd523235
2021-06-17 23:25:57 +01:00
Samuel Fufa e79b469986 Allow AllApps to restore current selected tab on activity recreate
This CL also fixes:

- Wrong tab selection on RTL
- Fixes header protection hydraulic scroll issue
- Work toggle button text background contrast

Bug: 186005219
Bug: 191250799
Bug: 191227662
Bug: 191349226
Test: Manual
Change-Id: I3777474c954ed0d542ac38ff552367904be147d3
2021-06-17 16:59:56 -05:00
Steven Ng b50d747d20 Log widget dimensions before deleting a widget violating min size
Test: N/A
Bug: 191223844
Change-Id: Id909ee19be1a1c7d70a09643422d9ed62a2d82a9
2021-06-17 21:13:17 +01:00
Samuel Fufa efa5df380c Merge "Refactor FolderInsetAnimationCallback to be used with any view" into sc-dev 2021-06-17 18:48:49 +00:00
Stevie Kideckel 10d4edade1 Merge "Refresh widgets in the model when packages change" into sc-dev 2021-06-17 15:04:01 +00:00
Stevie Kideckel 69af278f8a Refresh widgets in the model when packages change
Fix: 191163748
Test: local sample app
Change-Id: Ic09ad11cabf6efa471fb6e685cb255c4a17493ee
2021-06-17 13:08:53 +00:00
Steven Ng 6ce6922c14 Merge "Deduct padding from widget size only if padding has been inset" into sc-dev 2021-06-17 11:00:33 +00:00
Yogisha Dixit 3287dd9fa7 Merge "Center drop target icons in landscape mode." into sc-dev 2021-06-17 09:34:42 +00:00
Steven Ng 1184a03b08 Merge "Modify AT_LEAST_S check to include SDK int" into sc-dev 2021-06-17 09:09:21 +00:00
Steven Ng e8772c1659 Merge "Fix PendingWidgetHostView overlapping UI" into sc-dev 2021-06-17 09:08:15 +00:00
TreeHugger Robot ea95f88361 Merge "Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events." into sc-dev 2021-06-17 06:08:09 +00:00
TreeHugger Robot 4f257655bd Merge "Add logging for tapped on 'Turn on/off work apps' button in all apps" into sc-dev 2021-06-17 05:25:49 +00:00
TreeHugger Robot 3115a4380b Merge "Fix broken app icon on restart during install." into sc-dev 2021-06-17 01:11:53 +00:00
Thiru Ramasamy 95b09f9067 Fixes duplicate logging for LAUNCHER_ALLAPPS_KEYBOARD_CLOSED events.
Bug: 178562918
Test: Manual
Change-Id: Id32b621c0f506bba4378f6f6b81d7cfece3cb373
2021-06-17 00:05:56 +00:00
Thiru Ramasamy 6f0e75740f Add logging for tapped on 'Turn on/off work apps' button in all apps
Bug: 190050582
Test: Manual
Change-Id: Ib83fba6dc9199ba40a500e0743c0e64cc4d4d0a0
2021-06-16 17:03:49 -07:00
Schneider Victor-tulias bcd72a7b32 Fix broken app icon on restart during install.
Fixes: 186610233
Test: manual with backup/restart and restart during install
Change-Id: Ic64bd98758bc2e1a2a1562579cb25de02faa624c
2021-06-16 16:47:45 -07:00
TreeHugger Robot 3a37543fb9 Merge "Prevents a ConcurrentModificationException in Widget" into sc-dev 2021-06-16 23:43:29 +00:00
TreeHugger Robot 0bf000104f Merge "Fix bug where preview item icon fades/disappears for a frame during" into sc-dev 2021-06-16 23:24:58 +00:00
Steven Ng 71cefb593f Deduct padding from widget size only if padding has been inset
Test: Set the grid to 4x5 (without padding) and verify the min / max
      size sent to Conversation widget is expected.
Bug: 190498032
Change-Id: I8ef6e5d897ebd0e2ea9af4497b00059c8dfad70a
2021-06-17 00:15:52 +01:00
Steven Ng 7e31e9b267 Modify AT_LEAST_S check to include SDK int
BuildCompat.isAtLeastS() in Launcher dependency only checks if the
code name is "S". In the recent version of Android, the code name has
changed to "REL".

Test: Open Widgets picker, expand Conversations and observe a preview
      layout is shown.
Fix: 191239040, 191216821
Change-Id: I6a6e647d4cb327d251bde3484ea2d2e79c0f86f5
2021-06-16 23:56:38 +01:00
Samuel Fufa d04a92d1ed Refactor FolderInsetAnimationCallback to be used with any view
- Update ic_corp_off icon to outline
- Remove shadow from work toggle
- Translate work fab when keyboard is shown

Screenshot: https://screenshot.googleplex.com/593tEg7bE4kSS4y

Bug: 191251404
Bug: 191250785
Test: local
Change-Id: Ie7dddfd17eb90575a1e1f67e281070dd8d268f8d
2021-06-16 17:25:53 -05:00
TreeHugger Robot 4176cb33bb Merge "Reattach LauncherAppWidgetHostView to its parent after canceling drag" into sc-dev 2021-06-16 22:25:41 +00:00
Pinyao Ting 9cd63c97ce Prevents a ConcurrentModificationException in Widget
InvariantDeviceProfile.supportedProfiles can be modified in respect to
configuration changes. This CL ensures the list was cloned before access
to prevent ConcurrentModificationException

Bug: 191231591
Test: manual
Change-Id: I123458dcfe99af4babca2cf73733e3d2af0fad3c
2021-06-16 21:02:48 +00:00
Jonathan Miranda 28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Hyunyoung Song d2ad97989c Merge "All apps motion" into sc-dev 2021-06-16 20:14:46 +00:00
Yogisha Dixit 58c5e65763 Center drop target icons in landscape mode.
Spec: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187376586
Change-Id: I2025ba75061a5ca3a004dfef2b33cdbcc17a1408
2021-06-16 20:55:56 +01:00
Yogisha Dixit de268a51a1 Merge "Fix drop target icons being truncated." into sc-dev 2021-06-16 19:48:08 +00:00
Hyunyoung Song 54a44d4c44 All apps motion
Bug: 189970327
Test: manual

TL;DR;;

equation: settleVelocity = releaseVelocity + interpolator 2nd deritive * t

Change-Id: I86fec339523fbc3bb347dec4affbd2d1c063d13d
2021-06-16 11:17:59 -07:00
Jon Miranda b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
TreeHugger Robot 29dba38119 Merge "Add work toggle to work apps paused message" into sc-dev 2021-06-16 15:57:49 +00:00
Yogisha Dixit ed052ab212 Fix drop target icons being truncated.
The icons were being truncated due to incorrect viewport width/height
values for the vector drawable.

Test: manual
Bug: 187036287
Change-Id: Ie2d0ffe815501d2e943146a79cb4ede379ce0ecf
2021-06-16 14:07:38 +01:00
Steven Ng 19bc880a5f Fix PendingWidgetHostView overlapping UI
* Only show launcher set up UI if a pending widget has not finished
set up.
* Update configuration string

Test: manual inspection
Bug: 190037003
Change-Id: I3b9fb39da21ea557f97e9ca7b05a3b52f3ec3452
2021-06-16 11:22:49 +01:00
Stevie Kideckel 358411a96a Merge "Use drawable states for list positions instead of swapping drawables" into sc-dev 2021-06-16 09:34:21 +00:00
Jon Miranda 229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Jon Miranda 9d41499a33 Fix bug where preview item icon fades/disappears for a frame during
- Remove fade since we no longer clip icons.
- Ensures a clean handoff between drag view and folder icon preview item.

Bug: 175329686
Test: create folder / add items to folder
Change-Id: Iaab592410734b0b5239dbbddbb9b2ed5a9f5d8b0
2021-06-15 21:14:47 +00:00
Schneider Victor-tulias e00d88e32a Merge "Skip item infos that fail session info verification." into sc-dev 2021-06-15 20:54:23 +00:00
Thiru Ramasamy 640fc8b84d Merge "Enable logging for 'Themed icons' setting." into sc-dev 2021-06-15 20:47:23 +00:00