Commit Graph

2035 Commits

Author SHA1 Message Date
Vadim Tryshev 8cfd3f699d Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev am: af91a58659 am: c7f9e903bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20009128

Change-Id: Icc1ff73190b117b1f1560daca9c8e2f9e147827f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 06:27:23 +00:00
Vadim Tryshev af91a58659 Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev 2022-09-22 16:25:06 +00:00
TreeHugger Robot 2d180a5439 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev am: 4298b36ef4 am: 84959297d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19865266

Change-Id: I70a93b0455820766f8c97b853e80b5db1c8d7b35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 00:27:30 +00:00
vadimt 592b3f9885 Verifying a theory that sometimes a leak disappears while saving an object dump
Bug: 241585675
Test: presubmit
Change-Id: If9c559619507002ed7ec4b1a8b96a5f62e2dbe41
2022-09-21 10:56:04 -07:00
TreeHugger Robot 4298b36ef4 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev 2022-09-21 03:50:08 +00:00
TreeHugger Robot 9ec505fb2c Merge "Adding a comment for goHome()" into tm-qpr-dev am: 0dec527aae am: 67d76fa9b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19994601

Change-Id: I8c13a6eff4822b6fb0d4b41d72baf8812fb17e0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 09:44:06 +00:00
vadimt f132bd7d3f Adding a comment for goHome()
Bug: 187761685
Test: presubmit
Change-Id: I2917daa90f22cc0da0169c287b02cc4cf37a8f4b
2022-09-19 19:08:43 -07:00
TreeHugger Robot 8eed4f30a9 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5 am: ab6be24eec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Ie607c03fb5aa6ca01648ebfeeba10cecf2d3bf80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 18:30:23 +00:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Nicolo' Mazzucato d2521bf843 Fix LauncherInstrumentation for OOP tests from gradle
The previous logic was assuming that if the test and target package were different, the target one was the launcher.

However, in the sysui-studio case, the packages are different despite none of the packages being launcher.

This detects if the test process is a gradle instrumentation, and if so selects the default launcher package name.

Test: locally with sysui-studio + presubmits
Bug: 234414088
Change-Id: Ie625e7d526f254f4b5f66b3a2b989d02eb95ac9c
2022-09-19 14:35:53 +00:00
Alex Chau cdf753f7c6 Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev am: 7c8ee4f8de am: 4773a10dc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886864

Change-Id: Icba9ad1d97653b379642bf1611b59cc65bd614eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 05:04:11 +00:00
Alex Chau 7c8ee4f8de Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev 2022-09-17 03:30:32 +00:00
TreeHugger Robot ca5a1a6c60 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2 am: cd4951f54b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: I5f9c405e1bff93b3e96b051bcb9b6ad0a87eecb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:14:58 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Yein Jo 40a0690301 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev am: dfaabbb499 am: f8804d8ccd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19934356

Change-Id: I5843a470ee7194f84899ad8fa3426c9c4af6d178
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 22:13:10 +00:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Sebastián Franco f1aa20d811 Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev am: 09a98dfdbd am: 47c78bed9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969101

Change-Id: I01ad05d37ca822f501e6f2520249734c7e9de167
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 17:52:11 +00:00
Sebastián Franco 09a98dfdbd Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev 2022-09-16 16:49:26 +00:00
Andras Kloczl 0a37f2b90e Trying to fix flaky TAPL test on CF
For some reason the drag gesture gets canceled during drag,
and it might be because the pointer goes out of bounds.

Test: run TwoPanelWorkspaceTest on CF
Bug: 241587421
Change-Id: I9a57548d5b03c3a3d7bd0da6e7e7f79688f5ac90
2022-09-16 07:55:13 +00:00
Sebastián Franco a798be2ff5 Revert "Prevent dragging widgets to another page in tests when starting a drag."
This reverts commit 749b2b8493.

Reason for revert: Causing tests to fail b/246972374

Change-Id: I9fc1f6d2e924f4ac5484c6674fd0adf49d04536f
2022-09-15 21:19:12 +00:00
Sebastián Franco b35ae4fc42 Merge "Prevent dragging widgets to another page in tests when starting a drag." into tm-qpr-dev am: 610db4fc94 am: 0eaacbc644
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19945446

Change-Id: Id8e822bf084248c7618cd23837ccb1f558eedc64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 18:22:33 +00:00
Sebastián Franco 610db4fc94 Merge "Prevent dragging widgets to another page in tests when starting a drag." into tm-qpr-dev 2022-09-15 17:19:42 +00:00
Alex Chau 019f5c4324 Remove ScreenRecord for a test
- ScreenRecord might have increased flankiness of a test, reverting to verify

Bug: 242163855
Bug: 243688989
Change-Id: I6578a5ce2498f68e9b0102a2d9cb5bce91422f85
2022-09-15 05:12:08 +00:00
Yein Jo dc1b3660fe Migrate Launcher to use the new OnBackInvokedCallback
Bug: b/238475344
Test: Tapl & manual
Change-Id: Ieab329873f82890d95136e490086cc2cffff7ba8
2022-09-14 19:45:41 +00:00
Winson Chung 3f649ef892 Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-14 17:14:32 +00:00
Winson Chung d51fdaa573 Merge "Update Launcher for removed shared wrappers" 2022-09-14 16:30:42 +00:00
TreeHugger Robot fb77b34d1d Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee am: 9c43626a36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193

Change-Id: Ie17c03949c3ac30156129182fec88f19cfb46e1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 23:38:23 +00:00
Sebastian Franco 749b2b8493 Prevent dragging widgets to another page in tests when starting a drag.
The function Launchable.startDrag it's supposed to grab and icon or widget
and start the dragging by moving it only in the verticall position but
because it uses the coordinates of the object before entering the
SPRING_LOADED_STATE_ORDINAL state then the coordiates where it moves
are outisde of the cell layout and it moves to a new page. This only happens
if the phone is too slow and it triggers the page change, otherwise it would
be too fast.

To fix it, I'm moving the icon/widget to the center of the screen minus
getStartDragThreshold() to ensure the drag is always triggered.

Fix: 242323136
Fix: 244224955
Fix: 241019568
Fix: 241583798
Test: atest ReorderWidgets
Change-Id: I0e431b994aa4a3d5c8be45b6c73263732553b36c
2022-09-13 15:54:58 -07:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
Sebastián Franco 7ec80322bb Merge "Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch" into tm-qpr-dev am: 5587ef3262 am: 1163c5ea7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19759371

Change-Id: I9a9f63c26ce8184f0c0cc1f8b4073f17e8b21726
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 18:09:10 +00:00
Sebastián Franco 5587ef3262 Merge "Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch" into tm-qpr-dev 2022-09-13 16:53:36 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Sunny Goyal 20bbe95ddb Updating the scroll calculation from recyclerView to avoid view inflation
> Updating the LayoutManager's scroll calculation instead of a separate
  implementation to better support recyclerView's calculations
> Caching the view sizes during layout to avoid view-inflation for
  unknown types
> Fixing scrollbar jump during scroll when widget list is expanded
> Fixing scrollbar never reaching end when onboarding card is displayed
  in work tab

Bug: 240343082
Test: Verified on device that new views are not inflated
Change-Id: Ied11ccf65b053691c5c126c4bf8de306ec24786d
2022-09-12 12:24:34 -07:00
Sebastian Franco 5434c9d370 Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch
Now TestWorkspaceBuilder has the logic to add hotseat icons and
the operations to add items to the Workspace is done in batches
which is faster and more stable. To submit everything in batches
it uses the FavoriteItemsTransaction.

This improves the design because TestWorkspaceBuilder and
HomeScreenImageTest belong to the Test layer and they should
only deal with the logic to run a test and TestWorkspaceBuilder
is the Model layer and holds all the logic to interact with the
Launcher model/data, so this separates the concern of each class.

Also, chagned the name from CellLayoutBoardBuilder to
TestWorkspaceBuilder to make it clearer.

Bug: 243440737
Bug: 235518637
Bug: 242323136
Test: atest HomeScreenImageTest
Test: atest ReorderWidgets
Change-Id: I14eef064fade153b8362537743b061958bb3071d
2022-09-12 10:54:53 -07:00
Winson Chung 252ec11e4e Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-12 16:04:56 +00:00
Qing Wang 67e22eff1f Add tests to Launcher P0 CUJ Homescreen navigation via TAPL. am: 30c3552e7e am: 46320961b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19773679

Change-Id: I4f1b1330c4084e09c6af077803c9abbc17d57d46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 20:39:36 +00:00
Qing Wang 30c3552e7e Add tests to Launcher P0 CUJ Homescreen navigation via TAPL.
1. Implement API to help to get page count.
2. Add test add and delete page.

Bug: 241685418
Bug: 232584721
Test: android.platform.test.scenario.launcher.integration_tests.ScreenNavigationTests#testAddAndDeletePageAndFling
Change-Id: I2e04b9ef1f2ca65ba14d6939b7b51fead6b6f6ca
2022-09-10 17:46:24 +00:00
TreeHugger Robot 7389ee2f2f Merge "Support for animating A-Z <-> Search." into tm-qpr-dev am: 1c22b7e57c am: be89a7dec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19629606

Change-Id: Id75b1e316424734e67c293634c47c63de18c9561
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 02:00:03 +00:00
TreeHugger Robot 1c22b7e57c Merge "Support for animating A-Z <-> Search." into tm-qpr-dev 2022-09-10 01:11:36 +00:00
Andy Wickham 94d5d3cb6c Support for animating A-Z <-> Search.
Demo videos (1/5 speed) and APK: https://drive.google.com/drive/folders/1qQNzcoibiFMzxYhvXc7UEHCaBhJg6SjN?resourcekey=0-OWD06iLXg3wf_eWce4rUPA&usp=sharing

Bug: 234882587
Bug: 243688989
Test: Manually tested a bunch of cases at 1/10 animation speed.
Such as work profile or not, suggested apps enabled/disabled,
typing during the animation, going back during the animation,
web results injected above apps, etc.

Change-Id: Id4f1a858d387bf3a7f9cf2d23564a276544abef1
2022-09-09 15:37:57 -07:00
Brandon Dayauon 1b1f7e4141 Merge "Added extra check to CLI command that was not checked for" into tm-qpr-dev am: 5d7aec8e03 am: f52626345e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19801569

Change-Id: I8ef7ff361fbe30147342cd2befa86004cd8272cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 21:48:07 +00:00
Brandon Dayauon 5d7aec8e03 Merge "Added extra check to CLI command that was not checked for" into tm-qpr-dev 2022-09-09 20:53:14 +00:00
Hui Kang 4420babf45 Merge "Add launch assistant method." into tm-qpr-dev am: 0b44854718 am: f6142422af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19822904

Change-Id: I6109c36d79d523b61edf2725da66521d859194cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 18:55:40 +00:00
Hui Kang 0b44854718 Merge "Add launch assistant method." into tm-qpr-dev 2022-09-09 17:53:06 +00:00
c af5017c6cc Add launch assistant method.
Test: manual atest

Local test with atest on cf_x86_64_phone: 100/100 PASS.
ABTD 100/100 PASS: https://android-build.googleplex.com/builds/abtd/run/L71100000956341271

Change-Id: Ib9276d1cc395f134d77ba0237d94f4f23a3485b3
2022-09-09 03:30:43 +00:00
Brandon Dayauon e4c4e2043f Added extra check to CLI command that was not checked for
check if work profile is indeed set up

 - after workProfile setup, added log of profile ID for each test..
 - added CLI check for "start-user"
 - Investigating where flakiness occurs because of failed
 work profile account set up or test just fails

bug: 243688989
test: Tested where there is no shell command in setup and all tests were skipped
Change-Id: I131b62c1a929c2e550be111a3840fd93c7435860
2022-09-07 10:00:56 -07:00
Alex Chau f2b58fe68d Merge "Revert "Add screen recording to flaky test"" 2022-09-03 11:46:58 +00:00
Alex Chau e609d3ee5e Revert "Add screen recording to flaky test"
This reverts commit c9037cd887.

Reason for revert: Screen record seems to have caused test to fail: https://android-build.googleplex.com/builds/tests/view?invocationId=I48500010087317917&testResultId=TR41028244871043649
Bug: 241587421

Change-Id: I4392d9944ea86f3f923d81d14d906ffc280c57f6
2022-09-03 09:29:32 +00:00
Sebastián Franco 6cea4aa0c4 Merge "Adding support to add icons in the workspace for tests" into tm-qpr-dev am: 8236313204 am: 0b2d6da850
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19701339

Change-Id: I5cd3a9993baa46727c5e27aae077d7e1659cd349
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 18:19:24 +00:00