Commit Graph

13259 Commits

Author SHA1 Message Date
Randy Pfohl def579a82f Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd am: f763efa527
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: Ib63c994382afea82b05815a210079a2c924fafaa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 00:08:06 +00:00
Randy Pfohl f763efa527 Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: I7a302c76532621837b54fbf38dd153fb15f975b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 23:28:30 +00:00
Randy Pfohl dcd79bd6cd Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev 2023-01-13 23:02:41 +00:00
Alex Chau 958b8da658 Merge "Update overview actions top margin" into tm-qpr-dev am: 6367188b33 am: 7018435763
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20859638

Change-Id: I299772359dc374519b226ca46f375027a295787d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:49:11 +00:00
Johannes Gallmann c047a8885c Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7 am: f2709309bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: I13c25d2e87498a6a28dd018dacf6451cbaabb092
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:49:01 +00:00
TreeHugger Robot ec59c7b9c5 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29 am: 2618fcf11c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ic56fd8e629f376893eb10fd21d39384cb3299d0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:48:52 +00:00
TreeHugger Robot 021877cbb4 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147 am: dda983334f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I55e5316bdfc7a004f31b44a0fadc54d97695ea2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:48:32 +00:00
Alex Chau 7018435763 Merge "Update overview actions top margin" into tm-qpr-dev am: 6367188b33
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20859638

Change-Id: Iae04cd9d776e25d9665e005af237b260d7967621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 18:15:09 +00:00
Alex Chau 6367188b33 Merge "Update overview actions top margin" into tm-qpr-dev 2023-01-13 18:05:01 +00:00
Johannes Gallmann f2709309bb Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: Ia1e8d8830a99268870f4c9f3cf59ca5d32a731b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 17:55:35 +00:00
Johannes Gallmann 4aa135f3c7 Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev 2023-01-13 17:28:42 +00:00
TreeHugger Robot 2618fcf11c Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ica6895eddd30abb925ce9b87322711213ae14f68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 16:01:52 +00:00
TreeHugger Robot 60c7dfec29 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev 2023-01-13 15:49:07 +00:00
TreeHugger Robot dda983334f Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I4a77261e41700023d6f3c8856db040b9369a013f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 13:46:23 +00:00
TreeHugger Robot 5f3784d147 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev 2023-01-13 13:01:03 +00:00
Vinit Nayak 07cccd161f Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8 am: f47ba402c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5ea97c57ae8e590da7c963c52ec3307b536f410b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:18:32 +00:00
Vinit Nayak f47ba402c8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5798568fcfc64ef8d7ce3a5175e45f249c53e08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:14:59 +00:00
Vinit Nayak f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Jeremy Sim 6872bc1236 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71 am: 2bc8635b0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ida4e65f9c12d412ba176dc950219b4c19697877d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 00:27:28 +00:00
Jeremy Sim 2bc8635b0a Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ie382a53ed107537f52e8bc8777468f52a4288ae9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:50:52 +00:00
Ats Jenk 5299847a64 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1 am: a39ff80885
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: I4df52bf0788546e48499894283b8196e748a8af6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:17:38 +00:00
Ats Jenk d5315c5b94 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1 am: 8df2f4748a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I73fb5a3819793ada1983ff3766aa9012e67b1ff8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:17:15 +00:00
Jeremy Sim 9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk a39ff80885 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: If52b473eb05dca4e0b4dcbdc3c9416b4f0abb53f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:56:36 +00:00
Tracy Zhou 53fb97468b Merge "Update onOverviewShown interface to get signal of whether it should be iterated in forward or backward direction" 2023-01-12 22:43:15 +00:00
Ats Jenk 1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Ats Jenk 8df2f4748a Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I01acb423b0ea3934b2e63779ba8cb3ff3a7ccf03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:37:42 +00:00
Alex Chau f4269f01d7 Revert "Add debug logs for hotseat disapperaed bug"
This reverts commit 04658bcd42.

Reason for revert: root cause found
Bug: 260135164

Change-Id: I809662780d042923de015ff4cb810b3da5169f83
2023-01-12 22:21:07 +00:00
Ats Jenk 984a37d1b1 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev 2023-01-12 22:11:12 +00:00
Sebastián Franco f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
Christophe Pinelli 2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
TreeHugger Robot cadcf8d07a Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522 am: 318da8ce22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: I55318b382a572047400085c45a3ea6c1475f966c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:59:22 +00:00
Luca Zuccarini 675c1b997e Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493 am: 7495d0f873
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I8c7aa28deccf93c25f4df6d1e2a5ceed63c038d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:49:53 +00:00
Christophe Pinelli ab2c2d9576 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: I251cb1edf4e02cd919225d25c05e2e49f820208d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:08:49 +00:00
randypfohl 9c5fa66d2f Cleaning up UI jank while quick switching
Moving a few calls into the UI helper executor thread, as per the associated bug. duplicated the lines so the synchronous nature of clearing previous state wouldn't affect potential timings.

Test: local testing, rotating screen. quick switching apps.

Bug: 257470365
Change-Id: I59abad9ba51c0b19d467646752aa34ae7ef3ec1d
2023-01-12 19:06:04 +00:00
Christophe Pinelli 3cd6cbe6b4 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev 2023-01-12 18:15:31 +00:00
Ats Jenk ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot 318da8ce22 Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: Ib53aa807f447aeba483f6a4a10f078a5b39bf660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 17:50:42 +00:00
TreeHugger Robot 944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Luca Zuccarini 7495d0f873 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I3629ade53ed1be9d596a158e0f71efd999428aa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 14:51:20 +00:00
Luca Zuccarini 51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Nicolo' Mazzucato 696238e086 Provide single threaded executor to UnfoldUnfoldTransitionFactory
This fixes a concurrency issue where HingeSensorAngleProvider was being stopped and started at the same time in a thread-pool after a fast fold/unfold, despite not providing concurrency guarantees.

In sysui, the background executor provided was already single threaded, so no issue arisen. From Launcher, THREAD_POOL_EXECUTOR was provided.

In a follow up cl, I'll add a @SingleThreadBackground annotation to the executor used in the unfold lib.

Bug: 261320823
Test: manually stress tested fold/unfold.
Change-Id: Iccf1f1f7246d8592d4d80a032479aa75f0050655
2023-01-12 09:19:48 +00:00
Johannes Gallmann 031fbcc564 Prevent workspace enter animation for predictive back
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
2023-01-12 10:06:18 +01:00
Tracy Zhou 6fb8b3cec4 Update onOverviewShown interface to get signal of whether it should be
iterated in forward or backward direction

For more information, check out the change in the same topic.

Bug: 258854035
Test: manual
Change-Id: Id4a201c1979645ec319478f634039a4e9e495a35
2023-01-12 07:17:58 +00:00
Vinit Nayak 1d7e050bc6 Respect nav button tinting in SUW
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
2023-01-11 21:29:37 -08:00
Christophe Pinelli 9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Shan Huang 6677aeab1d Merge "Add background protection for back to home animation." 2023-01-12 01:03:49 +00:00
Stefan Andonian 53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:55 +00:00
Stefan Andonian 167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:16 +00:00
Fengjiang Li e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00