Commit Graph

19293 Commits

Author SHA1 Message Date
Treehugger Robot 11e4b589f6 Merge "Remove heuristic that determines whether to shift cells down or not" into main 2025-01-22 23:55:00 -08:00
Federico Baron 8d3883def3 Remove heuristic that determines whether to shift cells down or not
We decided to always shift the cells down, so that the new row always
shows up at the top

Bug: 391697719
Test: GridMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id093e0d64e437bf218f942bfdf6d2f14ee875776
2025-01-22 23:19:43 +00:00
Liana Kazanova (xWF) 9b0a007ae3 Merge "Revert "Migrating RecentsAnimationDeviceState and dependent obje..."" into main 2025-01-22 14:05:04 -08:00
Liana Kazanova (xWF) fa30e3fc0e Revert "Migrating RecentsAnimationDeviceState and dependent obje..."
Revert submission 31332401-recents-device-state

Reason for revert: DroidMonitor: Potential culprit for http://b/391684419 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31332401-recents-device-state

Change-Id: I3986328ee3aa8ebb822f7ef05b9f80ef68872aef
2025-01-22 13:50:08 -08:00
Treehugger Robot 906aa39c47 Merge "Cleanup leftRightSplitInPortrait flag" into main 2025-01-22 12:29:12 -08:00
Vinit Nayak 56234dbfe1 Cleanup leftRightSplitInPortrait flag
Bug: 291018646
Change-Id: I2c801378c33ee62b5f6eabf2e9122dd7ae1a5ee0
Flag: EXEMPT removing flag
2025-01-22 08:28:40 -08:00
Sunny Goyal d7bfa76bcc Migrating RecentsAnimationDeviceState and dependent objects to Dagger
Bug: 361850561
Flag: EXEMPT dagger
Test: Presubmit

Change-Id: I2c45ec49a913abb0532e83b09e797012e06eb8c4
2025-01-21 23:53:02 -08:00
Charlie Anderson ad8b2ec13b Update usages of icon shapes in Launcher
Bug: 387546051
Test: manual
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I33725259b3480f6e3a2976c227ccdffcfd7d6f83
2025-01-22 02:37:08 +00:00
Vinit Nayak e7753eb796 Merge "Remove and cleanup AppPairs flag" into main 2025-01-21 12:20:55 -08:00
Treehugger Robot 399ca5a6f4 Merge "Add kill switch for ViewPool.initPool." into main 2025-01-21 02:22:21 -08:00
Treehugger Robot fd726c7ce8 Merge "Add logging for RDeps lifecycle and ViewPool.initPool to help debugging." into main 2025-01-21 02:20:38 -08:00
Uwais Ashraf 6322c00b70 Add kill switch for ViewPool.initPool.
This fixes an issue where, in fast E2E tests, the test can complete before initPool is completed. This results in the ViewPool continuing to create TaskViews and therefore TaskThumbnailViews after RecentsDeps is destroyed. Doing this causes a crash.

Stopping the ViewPool.initPool thread before destroying RecentsDeps fixes this.

Bug: 390156722
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: fast E2E tests in presubmit e.g. AllAppsImageTest
Change-Id: I0f8801ca75cda383df8ed96077cf1b7178771cb6
2025-01-21 08:06:23 +00:00
Uwais Ashraf e545182223 Add logging for RDeps lifecycle and ViewPool.initPool to help debugging.
Bug: 390156722
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: none - logging only change
Change-Id: I657194e79023598c17ca8b1885f98457f3d773a9
2025-01-21 08:03:54 +00:00
Schneider Victor-Tulias f8fa42be84 Fix test Dagger initialization deadlock in RecentsDisplayModel
WallpaperColorHints is a MainThreadInitializedObject that was causing a deadlock in RecentsDisplayModel initialization. Converting WallpaperColorHints to a dagger singleton.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: Ib5b4eab27b4e28baf1208915fa7cf6dbd36bc1f5
2025-01-20 08:08:40 -08:00
Adam Cohen ea1c34bdcb Merge "Fix issue with AutoInstallsLayout Parser and user profile" into main 2025-01-18 11:56:09 -08:00
Adam Cohen dcc2e5d21f Fix issue with AutoInstallsLayout Parser and user profile
=> the profileId was only being added from the root workspace parser
=> instead, the profileId should be added at the individual item parser level

Flag: NONE small bug fix
Issue: 390674545
Test: manually verified using import / export

Change-Id: I76187b1210f282d1a0f8f4652a499d2472461d87
2025-01-17 13:27:00 -08:00
Jagrut Desai 6971afcd0b Merge "Fix Taskbar icon Accessibilty Focus on hovering" into main 2025-01-17 13:17:41 -08:00
Liran Binyamin e96bd71f50 Merge "Pass the user id for intent app bubbles" into main 2025-01-17 12:29:50 -08:00
Jagrut Desai 625b78ae13 Fix Taskbar icon Accessibilty Focus on hovering
The problem: ArrowTipView was TypeAccessible hence taking a focus away from taksbar icon. The hover event was getting consumer by onHover of the listener and not getting passed to view. Upon passing the hover event we see icon scale up. We don't want both icon to scale up and show
tootip when hovering.

The Solution: pass motion event to onHoverEvent for icon view and mark ArrowTipView to be not included as Accessible View. For disabling hove
ring for taskbar icon we introduced new field to track if hovering is enabled for display type for that icon.

Test: Manual, Presubmit
Bug: 284081291
Flag: EXEMPT bugfix
Change-Id: Ie02d17856b26f82887fd178ccf0a7351416cc43e
2025-01-17 09:57:38 -08:00
Sihua Ma 0413cfc05c Merge "Fix work badge theme issue" into main 2025-01-16 19:16:59 -08:00
Treehugger Robot 47b4339df5 Merge "Fix Talkback Announcement for Workspace Pages" into main 2025-01-16 17:21:33 -08:00
Sihua Ma 4a3aa354b8 Fix work badge theme issue
The work badges are being themed even though themed icon is disabled

Test: Manual
Bug: 390031380
Flag: EXEMPT bug fix
Change-Id: Ia25a58631d416face0bd1ca2e5f086324b579834
2025-01-16 16:39:56 -08:00
Adnan Begovic 3c4c268b4c Merge "launcher3: Add one grid edu to floating view." into main 2025-01-16 15:27:01 -08:00
Stefan Andonian e73541c30c Fix Talkback Announcement for Workspace Pages
Bug: 379649357
Test: Verified manually that the fixes work for announcements.
Flag: EXEMPT bug fix
Change-Id: I0a2e989eb34adbd975a7211d8334d264d64b3933
2025-01-16 15:19:04 -08:00
Mady Mellor f7f4c3c7ac Merge "Update code guarded by bubble anything flag to use the helper method" into main 2025-01-16 13:36:38 -08:00
Vinit Nayak 3456fcbe03 Remove and cleanup AppPairs flag
Test: Launcher compiles and runs
Bug: 274835596
Flag: EXEMPT cleanup
Change-Id: Iab8f17d444753df303ed1a09d6547917545e66f5
2025-01-16 14:02:55 -05:00
Treehugger Robot 22df0f9d20 Merge "Adding some source hints when generating theme icons" into main 2025-01-16 00:11:10 -08:00
Liran Binyamin 96dc022401 Pass the user id for intent app bubbles
When creating a new app bubble by long pressing on launcher icons,
pass the user id to wm shell so the bubble is created for the correct
user context.

Bug: 361173339
Flag: com.android.wm.shell.enable_bubble_anything
Test: atest BubbleAnythingTest
Test: manual
       - create work profile
       - long press on a work profile app icon -> Bubble
       - observe new bubble opens in the work profile context
Change-Id: Idb980bc6f74e85e85a9777f0d39e772b84feeb9c
2025-01-15 21:35:54 -05:00
Mady Mellor 7d97e96550 Update code guarded by bubble anything flag to use the helper method
Also adds a dependency on shared shell lib so launcher can use this.

Flag: com.android.wm.shell.enable_create_any_bubble
Test: manual - enable the create flag and check that bubble anything still
               works; same with bubble anything flag
Bug: 389737359
Change-Id: I18322512c9d9883ee5cf473b72df565adea85879
2025-01-15 17:04:10 -08:00
Adnan Begovic aacbfce7d1 launcher3: Add one grid edu to floating view.
Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 388311172

Change-Id: I0ea819d266af443d71ed22f5394b41a51202fa0b
2025-01-15 15:23:17 -08:00
Pat Manning 75769b7696 Start collecting task dismiss CUJ on dismiss animation start.
Bug: 385698952
Bug: 389653070
Test: OverviewTaskDismiss#dismissTask (Functional & microbenchmark test)
Flag: EXEMPT adding CUJ for existing recents
Change-Id: I8f68d05d2b701291e17ece5b38d2267adcbabae4
2025-01-15 13:30:53 +00:00
Sunny Goyal 01a976f210 Adding some source hints when generating theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ief779bb04cd69372ec3acd4501e283f09de41b4d
2025-01-14 16:00:46 -08:00
Treehugger Robot bc3995222b Merge "Moving DisplayController to dagger" into main 2025-01-14 13:39:19 -08:00
Sunny Goyal 55dc2d1c31 Moving DisplayController to dagger
Separating various overrides to individual modules so that they can be reused in tests

Removing ContextualEduStatsManager and directly using SysUiProxy as all the usescases
are only in quickstep/
This avoids additional Module definition and delegation

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I096459d638553991ed01766002b874589c6b976e
2025-01-14 11:40:35 -08:00
Vinit Nayak 75d7e07844 Merge "Remove and cleanup splitContextual flag" into main 2025-01-14 09:39:59 -08:00
Charlie Anderson 3799932a38 Add ability to preview and apply shapes from Picker
Bug: 372887760
Bug: 372887555
Bug: 388579538
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Manually change icon shapes

Change-Id: Ie423306e3ae5ae8176898ff5ffc59b4b576c20f4
2025-01-14 07:24:52 -08:00
Vinit Nayak 3815a095f1 Remove and cleanup splitContextual flag
Bug: 276361926
Flag: EXEMPT removing flag
Change-Id: I6f567a8aae5b962f36ec2bc96b7fb05906b4ff2f
2025-01-14 10:23:59 -05:00
Treehugger Robot 3196197f41 Merge "Removing shape detection in icon loader lib" into main 2025-01-13 23:55:12 -08:00
Adnan Begovic 8d3eaf1a36 Merge "launcher3: Introduce onGridMigrationComplete callback." into main 2025-01-13 15:22:18 -08:00
Mykola Podolian fc8db9afc3 Merge "Shift transient taskbar to ensure 12dp distance with the bubble bar." into main 2025-01-13 12:52:21 -08:00
Adnan Begovic 4b9b9d7e40 launcher3: Introduce onGridMigrationComplete callback.
onGridMigrationComplete is invoked when grid migration
  successfully completes.

  ModelDelegate's can choose to observe this by overriding
  the callback.

Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 386802204

Change-Id: Iaca2e61a95c3d3decc12b2cc54461dba441202a0
2025-01-13 09:52:16 -08:00
Adam Cohen 8d4669a620 Merge "Add LauncherProvider interface to get and set current workspace layout via xml" into main 2025-01-10 16:36:25 -08:00
Sunny Goyal 0b01527d9a Removing shape detection in icon loader lib
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Iedec7bbcb8388e292050bbc0a94b21e74109def6
2025-01-10 14:02:00 -08:00
Treehugger Robot ce9ea2caef Merge "Simplifying IconShape" into main 2025-01-09 18:14:30 -08:00
Sunny Goyal 1138f5fe59 Simplifying IconShape
Removing various custom shapes and replacing it with a generic shape implementation. This works with any valid svg path.

Bug: 366237794
Flag: EXEMPT refactor
Test: atest IconShapeTest
Change-Id: I4665bc657b8bffc4d4efa30cebe00341b3140c55
2025-01-09 15:04:46 -08:00
Adam Cohen 295c520bcb Add LauncherProvider interface to get and set current workspace layout via xml
=> For prototyping purposes only. The method is protected by system|signature permission.
=> Uses the AutoInstall layout xml specification to allow for getting and setting the current launcher layout.

Test: manual via prototype apk
Flag: EXEMPT prototyping interface

Change-Id: I04dd29ee69db642095dfb5f6c4965cdb8509b05e
2025-01-09 12:28:42 -08:00
Sihua Ma e9f1c33f04 Merge "Add debug logs to folder open anim" into main 2025-01-09 09:27:08 -08:00
Alex Chau cb50273ad0 Merge changes Ic571a506,I0877cff7 into main
* changes:
  Reland "Introduce `mTaskViewCount` inside the RecentsView"
  Run the given callback only inside `runOnPageScrollsInitialized`
2025-01-09 02:49:23 -08:00
Treehugger Robot b49023dc3b Merge "Move all db calls for grid migration inside a SQLiteTransaction" into main 2025-01-08 16:56:24 -08:00
Sihua Ma a5d096b922 Add debug logs to folder open anim
Bug: 383526431
Flag: EXEMPT logs only
Test: None
Change-Id: Ib18d63e7f8ab194f8fda74aa99d99c9aa27f5f19
2025-01-08 22:53:53 +00:00