Commit Graph

15423 Commits

Author SHA1 Message Date
Treehugger Robot 4dc9893028 Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev 2023-08-21 19:41:19 +00:00
Treehugger Robot e207075bdc Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev 2023-08-21 18:56:40 +00:00
Pat Manning bd4e77ccf7 Merge "Check taskbar stash state for hover only on hover events." into udc-qpr-dev 2023-08-21 18:18:10 +00:00
Andreas Agvard 31689cad69 Merge "Prevent long press nav handle invocation when quick switching between apps." into udc-qpr-dev 2023-08-19 09:16:13 +00:00
Mateusz Cicheński cdb5f1036b Merge "Remove fling gesture related flags for PiP and Bubbles" into udc-qpr-dev 2023-08-19 01:52:27 +00:00
Treehugger Robot fae0011590 Merge "Fix crash if Launcher destroyed before AbsSwipeUpHandler invalidated" into udc-qpr-dev 2023-08-18 23:10:55 +00:00
Tony Wickham 7e9cfdf254 Fix crash if Launcher destroyed before AbsSwipeUpHandler invalidated
Test: manually call finish() in onActivityInit(), no crash when
handler is subsequently invalidated (did crash before this change)
Flag: None
Fixes: 295796661

Change-Id: I2dac7ca87bcdb700da2387309d5ad1d2f4ef43d7
2023-08-18 21:44:52 +00:00
Andreas Agvard 96beb83bee Prevent long press nav handle invocation when quick switching between apps.
Bug: 296616400
Test: Manual
Change-Id: Ic393014e0eb834e60414d6ce9fcdf3d91cb1667a
2023-08-18 22:06:20 +02:00
Treehugger Robot 14223c8fb6 Merge "Revert "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit"" into udc-qpr-dev 2023-08-18 19:10:12 +00:00
Vadim Tryshev 8b5edb3c29 Revert "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit"
This reverts commit 120b5876da.

Reason for revert: The leak simply moved to the next test method. So, looks like the leak originated in the previous test.

Change-Id: Ia24e31338af7eb1902a945fa92e0aa19aaddcd83
2023-08-18 17:36:17 +00:00
Pat Manning 3447016c66 Check taskbar stash state for hover only on hover events.
Fix: 293419351
Test: TaplTestsTransientTaskbar.
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I86d166d71dc5d41a7c4e450584e8948db96bf199
2023-08-18 14:45:48 +00:00
Jagrut Desai 8d326473a6 Remove Change Navigation Mode option for Taskbar Divider Popup Menu
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Merged-In: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
2023-08-17 21:35:09 -07:00
Jagrut Desai d34fe6d60c Merge "Correcting Taskbar Icon Layout bounds when Taskbar Divider is present" into udc-qpr-dev 2023-08-18 04:16:36 +00:00
Jagrut Desai 6341a7e31c Merge "Refactor taskbar divider view to IconButtonView" into udc-qpr-dev 2023-08-18 04:16:13 +00:00
Treehugger Robot 8de2a75513 Merge "Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit" into udc-qpr-dev 2023-08-18 00:18:34 +00:00
Matt Sziklay 370db6f198 Merge "Create IconView for generated TaskIdAttributeContainers." into udc-qpr-dev 2023-08-17 23:32:15 +00:00
Vadim Tryshev e0e26bef0a Demoting testQuickSwitchToPreviousAppForTablet from presubmit
It flakes in 100% of runs on certain targets

Bug: 286084688
Flag: N/A
Test: presubmit
Change-Id: I92cebe019c7f14fb50049cf2f18f2afd64fc9910
2023-08-17 16:10:24 -07:00
Vadim Tryshev 120b5876da Demoting testLaunchAppInSplitscreen_fromTaskbarAllApps from presubmit
It flakes in 100% of runs on certain targets

Bug: 295225524
Flag: N/A
Test: presubmit
Change-Id: I0204ee315b126c7819c00fa28fa9781fef4dc504
2023-08-17 15:59:58 -07:00
Mateusz Cicheński 437d3fbe15 Remove fling gesture related flags for PiP and Bubbles
Bug: 296239686
Bug: 296239159
Test: verify that fling to dismiss bubble still works
Change-Id: Ib9ad3df26dc4295493510dd8dbbcfbc939924a72
2023-08-17 21:38:23 +00:00
Mateusz Cicheński 4573658e7b Merge "Remove enable_pip_keep_clear_algorithm flag" into udc-qpr-dev 2023-08-17 18:27:21 +00:00
Wei Sheng Shih e6866f3f32 Merge "Fix NPE crash when using MockProperties" into udc-qpr-dev 2023-08-17 06:34:03 +00:00
wilsonshih 6df52eb6f9 Fix NPE crash when using MockProperties
Override the setShow method in MockProperties as it is used for invalid
surface.

Bug: 295775097
Test: build
Change-Id: Id601fa3ce7408f236c77e41ccd60b7d8359c2e8c
2023-08-17 12:09:33 +08:00
Sunny Goyal c480860744 Merge "Using CUJ_APP_CLOSE_TO_HOME_FALLBACK when fallback animaiton is playing" into udc-qpr-dev 2023-08-16 23:36:10 +00:00
Jagrut Desai e6a895ed6c Correcting Taskbar Icon Layout bounds when Taskbar Divider is present
- Breakout CL part 2
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of change to correct the icon layout bound calculation when taksbar divider line is present in taskbar view.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I259faf2cc0aa302b83337d104c4820885b925a6a
2023-08-16 13:50:08 -07:00
Jagrut Desai 579188aee0 Refactor taskbar divider view to IconButtonView
- Breakout CL part 1
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist refactoring of Taskbar Divider Line to be using IconButtonView.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I6719dd568986dce7cf9cdf0f287c3f079fd35ba6
2023-08-16 13:11:14 -07:00
Treehugger Robot 12cd6076d3 Merge "Revert "Prevent setting mIsStashed in TaskbarStashController"" into udc-qpr-dev 2023-08-16 20:03:00 +00:00
Sunny Goyal 57a83b5732 Using CUJ_APP_CLOSE_TO_HOME_FALLBACK when fallback animaiton is playing
Bug: 281873427
Test: N/A
Flag: N/A
Change-Id: I7745b8b7d7b48fa5a4f58e8db7e99865226e81d5
2023-08-16 12:30:27 -07:00
Vinit Nayak a725e48879 Revert "Prevent setting mIsStashed in TaskbarStashController"
This reverts commit 51a210d787.

Reason for revert: test may have been fixed before this got merged, will merge revert to confirm

Change-Id: Ib26b94af971eceb02e6bf58f39a578ee04eb72e8
2023-08-16 18:45:51 +00:00
Mateusz Cicheński 23ed054a6d Remove enable_pip_keep_clear_algorithm flag
Bug: 296239520
Test: presubmit, removing flag
Change-Id: I135d4b5fedaf094dd136924655d55c70616fa838
2023-08-16 17:55:14 +00:00
Treehugger Robot 08cd533f79 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-08-16 17:29:47 +00:00
Hongwei Wang 3ca497b646 Merge "Cleanup ENABLE_PIP_APP_ICON_OVERLAY" into udc-qpr-dev 2023-08-16 16:45:33 +00:00
Bill Yi 04ba1ae0c4 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iacec47b52312748f25f5e416b821ece95cd308a1
2023-08-15 19:49:21 -07:00
Hongwei Wang 7aded94e94 Cleanup ENABLE_PIP_APP_ICON_OVERLAY
Bug: 296125301
Test: manual, enter PiP from Google Maps
Change-Id: I571fd5450ccf00232c450d82d32783beb99cfecf
2023-08-15 15:44:39 -07:00
mattsziklay 56329b03cf Create IconView for generated TaskIdAttributeContainers.
When creating a TaskIdAttributeContainer for a desktop task, creates an
IconView to avoid an NPE when picking a desktop app as the second split
target (see TaskBarUIController#triggerSecondAppForSplit).

Test: Select an app open in Desktop Mode as the second split target.
Bug: 279586624
Change-Id: I1949d923523b6e9e6112b3e909edf1e8d632b3e2
2023-08-15 10:06:05 -07:00
Treehugger Robot 173cf33ac1 Merge "Adding TaplTestsSplitscreen to OOP tests" into udc-qpr-dev 2023-08-15 06:17:05 +00:00
Sunny Goyal 12bf58feb9 Merge "Removing some unused overrides in Launcher" into udc-qpr-dev 2023-08-14 20:40:28 +00:00
Treehugger Robot 1c4cb11662 Merge "Add relayout debug support in Launcher" into udc-qpr-dev 2023-08-14 09:43:51 +00:00
Nicolo' Mazzucato 93e7e4b1c0 Add relayout debug support in Launcher
This adds support for measure/layout tracing in Launcher (in sysui it has already been enabled in T)

When enabled, traces for each class measure and layout are output in
a perfetto trace. This adds some overhead, so it's disabled by default, but extremely useful for testing and debugging long doFrames.

To enable request layout tracing for a specific class X, the following helper can be used:

trace_class_layouts() {
        adb shell setprop persist.debug.trace_request_layout  1
        adb shell setprop persist.debug.trace_request_layout_class $1

        adb shell am force-stop com.google.android.apps.nexuslauncher
        adb shell am force-stop com.android.systemui
}

Then, use `trace_class_layouts X` and record a perfetto trace
e.g. `trace_class_layout BubbleTextView`

To just see class breakdown of measure/layout setting `persist.debug.trace_request_layout` is sufficient.

Test: record a trace after enabling options
Bug: 266090955
Change-Id: I4f621ebaaec6a07cd7c0693aa8876158cc60e208
2023-08-14 08:18:27 +00:00
Vadim Tryshev 053f476376 Moving stress tests to postsubmit
They don't consistently fail, but have flakes.

Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I07db69259d86093d81ab65a52a8e839269a3dd80
2023-08-12 02:14:55 +00:00
Vadim Tryshev 8c764a0870 Merge "Revert "Revert "Re-enabling a couple of tests""" into udc-qpr-dev 2023-08-12 01:51:46 +00:00
Vadim Tryshev 401cde8d99 Adding TaplTestsSplitscreen to OOP tests
It's a nice addition to our OOP tests, which serve as a kind-of ssmoke check for the system, as well a a test for a proguarded Launcher.

Bug: 187761685
Flag: N/A
Test: presubmit

Change-Id: I196cf0047f0df6cf843615e48252035f216597a0
2023-08-11 18:34:01 -07:00
Vinit Nayak 8488a7e757 Merge "Animate Split invocation with shell transitions" into udc-qpr-dev 2023-08-11 22:29:59 +00:00
Vinit Nayak 6458c11699 Animate Split invocation with shell transitions
* SplitRoot1/2 and the split left/right roots, but
they also have a parent that's the top-most split root.
* We have to explicitly set the alpha on top most parent
for animations on children to be visible
* This path wasn't being used even w/ shell transitions
enabled but became active after ag/24346391

Test: Launch split from overview and workspace
Flag: None
Bug: 276361926
Change-Id: I267dccbf3402af9b0972371b856a79b7785f986c
2023-08-11 12:59:18 -07:00
Sunny Goyal c1d1e68a82 Removing some unused overrides in Launcher
> Changing AddItemActivity to use RemoteAnimation directly
  to avoidTransitionManager override

Bug: 273828110
Test: Manual
Flag: N/A
Change-Id: I49777e7eeba00319476b0a239bc1cdac37833457
2023-08-11 12:31:49 -07:00
Vinit Nayak f49367cd96 Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev 2023-08-11 18:32:43 +00:00
Brian Isganitis c4247d85b4 Merge changes from topic "taskbar-search-ime" into udc-qpr-dev
* changes:
  Support customizing open-close PendingAnimation for Taskbar search.
  Animate AbstractSlideInView translation shift with PendingAnimation.
2023-08-10 16:10:39 +00:00
Schneider Victor-tulias 087990668b Merge "Update All Set page vibrations on large screens" into udc-qpr-dev 2023-08-10 13:49:17 +00:00
Brian Isganitis a7ee532d47 Support customizing open-close PendingAnimation for Taskbar search.
Test: Manual
Bug: 289290185
Flag: No
Change-Id: I9f076875c4bd13c98a3ace8c02d512defa013fdf
2023-08-09 22:23:43 +00:00
Brian Isganitis 0a036e9c15 Animate AbstractSlideInView translation shift with PendingAnimation.
The PendingAnimation gives us more flexibility than the AnimatorSet.

Test: Manual
Bug: 289290185
Flag: No
Change-Id: I3156a659098c44ce9e6b20e5e79e88742add629a
2023-08-09 22:23:41 +00:00
Vinit Nayak 51a210d787 Prevent setting mIsStashed in TaskbarStashController
* Partial revert of ag/24139629
* Taskbar showing up where it shouldn't in gesturenav,
this change isn't behind the flag

Bug: 295047555
Change-Id: Ib36b1fed5e25c667e396291a30a68730e1daa517
2023-08-09 12:28:44 -07:00