4cb9af12e9
Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev am: 7c9055fc6b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261572
Change-Id: I1bff143ada51bc1de8d8981120fac8384980c4cc
2021-11-17 21:21:14 +00:00
7c9055fc6b
Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev
2021-11-17 21:02:16 +00:00
aba6c9296e
Merge "Refine when to move live tile app below recents view" into sc-v2-dev am: a37f8baa1d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16280383
Change-Id: I2d30f89603216b27354668d28bb178127c483dce
2021-11-17 19:54:47 +00:00
b73106e5b3
Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev am: 0e1cd933ba
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282083
Change-Id: I64b43cfa8d18266d7d58a3aff53450569a09df45
2021-11-17 19:53:53 +00:00
a37f8baa1d
Merge "Refine when to move live tile app below recents view" into sc-v2-dev
2021-11-17 19:53:14 +00:00
0e1cd933ba
Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev
2021-11-17 19:42:53 +00:00
228f1ef97b
Merge "Add some more @Nullable annotations" into sc-v2-dev am: e65c47e60f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279499
Change-Id: I2c201837c2ff2bb9938103f5d5a3243e3c501aab
2021-11-17 18:58:04 +00:00
9304879387
Fix issue with grouped task rects being calculated slightly off
...
- This was causing bleed through between split tasks and perhaps
some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
in case the dismiss gesture is canceled. This doesn't fix the
issue with bleed through between the task views (to be fixed
separately), but makes sure it isn't permanently set on the task
Bug: 206739664
Test: Split tasks, swipe up and check the bounds
Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
3256e1e744
Add some more @Nullable annotations
...
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I6d2f269c4ec5f6cdee31ad68545c2720fbf1d8fc
(cherry picked from commit 9385170c1b
2021-11-17 08:40:17 +00:00
a4edc07ec8
Refine when to move live tile app below recents view
...
- We will still need to figure out why, but currently the overview scrim blocks the cut out during transition. To go around this, we need to move live tile app after the overview transition animation is over
- Some of the logic in RecentsView is no longer necessary since we are no longer reusing live tile params and simulator, but assign new targets each time
Fixes: 205587164
Test: manual
Change-Id: Icadf26182112bba544a4103b626effa37d4028b5
2021-11-16 21:17:19 -08:00
a4157b6afe
Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev am: b797ca77b2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16275817
Change-Id: Ia3cb4b2db5a8dc0bd5cef901259fab01aa2cee34
2021-11-16 21:55:37 +00:00
b797ca77b2
Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev
2021-11-16 21:34:52 +00:00
38b671d602
Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev am: 36705e6039
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16273821
Change-Id: I07a1681b8d5ba1a5699537e4f6e5f981ae09718b
2021-11-16 20:39:18 +00:00
36705e6039
Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev
2021-11-16 20:25:06 +00:00
1fdea66f16
Fix memory leak in TaskbarLauncherStateController
...
mIconAlphaForHome.setConsumer(null) in onDestroy()
Test: Run BinderTests#testSwitchToOverview locally
Bug: 206633573
Change-Id: I912cd66097b113ee84197f23a5862e333d7e63f2
2021-11-16 11:31:15 -08:00
0f38629826
Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev am: 1c4871298e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166972
Change-Id: Icf8e6992c6b76fddca4ae25c81a66f6424d9554e
2021-11-16 18:57:56 +00:00
04309940c0
If hometask is last task to be dismissed, show empty recents instead of home screen
...
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set
Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
1c4871298e
Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev
2021-11-16 18:40:31 +00:00
b7abf7e96d
Fix launch animation from bottom row and end of grid
...
- Apply gridTranslationY when calculating taskRect so it's used to calculate RecnetsView pivot
- Moved recentsViewScroll to RecentsView group and applied after recentsViewScale
- Before: http://dr/file/d/1-Nrqa80J4FRbjcdZ3GZSeKwfQF8fN9a1/view?resourcekey=0-gYT9z1HA0YksW5Ujbzsmeg
- After: http://dr/file/d/1-DpZrg5_nFeUKS-8APnLvG8SJVvke9BU/view?resourcekey=0-p59hm-abzpU7Y7tqWyneTQ
Fix: 200813202
Test: Launch task from grid from top/bottom/left/right/focus
Test: Launch task from left/middle/right in small screen
Change-Id: I814512c02611f59a5a6d1f53411d42cf4f0f26b3
2021-11-16 13:55:38 +00:00
b807d92aa7
Merge "Annotate RecentsView with @Nullable" into sc-v2-dev am: 72c8e71e06
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261398
Change-Id: Ic382d5886aa2df5c1bb8f981cbe626f031fd9c51
2021-11-16 10:44:07 +00:00
72c8e71e06
Merge "Annotate RecentsView with @Nullable" into sc-v2-dev
2021-11-16 10:26:23 +00:00
022c66327b
Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781
Change-Id: Ie9ca6ecdd77ac76b5b93461b6c5d7d6e670b71a6
2021-11-16 09:57:38 +00:00
0200636585
Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev
2021-11-16 09:41:58 +00:00
acf07f338e
Simplify getTaskViewAt call am: 9d6fb64f45
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16249427
Change-Id: If52c26a38fab17d294b08a34a3e41fd5f88cef27
2021-11-15 20:50:06 +00:00
3a0f8a90bd
Annotate RecentsView with @Nullable
...
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I44a4f7ce4258e54d43ca2c5a3937c81a4a686f80
(cherry picked from commit ac9cee5a7c
2021-11-15 20:39:07 +00:00
9d6fb64f45
Simplify getTaskViewAt call
...
RecentsView getTaskViewAt method is nullable and is safe
to call for an out of bound index.
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I7709d63ad4490fd756a50caaf42ba70c4fad4d06
(cherry picked from commit 41edede1ee
2021-11-15 20:37:12 +00:00
913c8aee24
Merge "Add @Nullable annotations for simple cases" into sc-v2-dev am: ba47b591c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16246987
Change-Id: I4fe20700452492680e0ea1e30577ed04ecda0e4f
2021-11-13 09:17:31 +00:00
ba47b591c4
Merge "Add @Nullable annotations for simple cases" into sc-v2-dev
2021-11-13 09:00:32 +00:00
16d6010418
Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev am: ea77e49524
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16245857
Change-Id: Icad379bd6b9302e1dd2903e3e7f8d468f8d87718
2021-11-12 21:08:27 +00:00
ea77e49524
Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev
2021-11-12 20:51:15 +00:00
45bb7b48ec
Fix launch animation from grid am: f75725830a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240053
Change-Id: I6815036c3d3916a4378340c089a35339a52206d4
2021-11-12 18:13:10 +00:00
f75725830a
Fix launch animation from grid
...
- Fixed calculateGridTaskSize to algin to taskRect instead of gridRect
- Extracted end of grid's scroll diff calculation to getOffsetFromScrollPosition to accurately calculate end of grid task's offset between its scroll and visual position (End of grid task's scroll is all the same at the position where ClearAllButton is just invisible)
- Extracted isGridTask in TaskView so TaskViewSimualtor can use the correct task size depedning if it's grid task or not
Bug: 200813202
Test: manual
Change-Id: I11a980345aee2680abf1c2563baadd9718a40192
2021-11-12 16:13:47 +00:00
2ca545c387
Add @Nullable annotations for simple cases
...
Add @Nullable annotations for the fields that are expected
to be null at arbitrary lifecycle time and are their usage
is protected by null checks.
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I9c31e1dc0d01cdd68dfff0a005ba1f40c257f8ea
(cherry picked from commit 920dc2f28f
2021-11-12 10:01:33 +00:00
820f8b6da4
Merge "Annotate AttributeSet with @Nullable" into sc-v2-dev am: 6c7c91fe86
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16233502
Change-Id: I44b3c235304572fc034a38584324a7f275fd24d9
2021-11-12 08:32:14 +00:00
6c7c91fe86
Merge "Annotate AttributeSet with @Nullable" into sc-v2-dev
2021-11-12 08:17:55 +00:00
9dfc2ba0a3
Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev am: 664f685336
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16235837
Change-Id: I015c3a22684a74c93241287dbcd27651fdf36ac3
2021-11-12 08:03:20 +00:00
664f685336
Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev
2021-11-12 07:46:23 +00:00
d0e6c8b2e7
Freeze task list if requested when launching split tasks
...
Bug: 206000278
Test: Quickswitch from app pair and back
Change-Id: I76af1396145e121e7f66f9e6b97f21a85c075e8e
2021-11-12 06:27:26 +00:00
1e5b621a50
Address AppEventProducer to correctly send search-result location on AppTargetEvent
...
Bug: 191362091
Test: logcat printout
11-10 20:27:02.290 32215 32237 D QuickstepModelDelegate: notifyAppTargetEvent action=1launchLocation=search-results
Change-Id: I16ef7679116e397a8a108cc291f5741febf2e453
2021-11-11 21:27:01 -08:00
215a79a150
Merge "Update corner radius of both snapshot in app pair" into sc-v2-dev am: 916873e7ab
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240047
Change-Id: I20fb777687eb54d7710c59f875951946501b0350
2021-11-11 21:18:00 +00:00
80836f637f
Update corner radius of both snapshot in app pair
...
Fix: 206002609
Test: manual
Change-Id: I6af28c6948769eac53326d61e84ac39196bd840f
2021-11-11 19:40:42 +00:00
b498b648ae
Annotate AttributeSet with @Nullable
...
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: Ib8584e1bbcc7061aef2eb4813a8f6aa41d3c7362
(cherry picked from commit 96f8792c04
2021-11-11 08:16:08 +00:00
f9ed2a09d1
Merge "Finish recents animation for app-icon tap" into sc-v2-dev am: 185da72e98
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223705
Change-Id: Icfaddc538c171f09a65efd0d82bb869228518c44
2021-11-11 06:22:34 +00:00
185da72e98
Merge "Finish recents animation for app-icon tap" into sc-v2-dev
2021-11-11 06:03:47 +00:00
29cb975748
Merge "Fix the cutout of magnification border" into sc-v2-dev am: b6e3caeb7a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214743
Change-Id: I8f9abdbee71c100dde4c6403158732922a809c56
2021-11-11 02:01:39 +00:00
b6e3caeb7a
Merge "Fix the cutout of magnification border" into sc-v2-dev
2021-11-11 01:56:21 +00:00
3945fd8f4c
Merge "launcher: use a different task menu for foldables" into sc-v2-dev am: 0aadbc6b37
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214330
Change-Id: I46f180584f6abb122adbb290e6a128151509c07c
2021-11-10 20:17:36 +00:00
0aadbc6b37
Merge "launcher: use a different task menu for foldables" into sc-v2-dev
2021-11-10 19:45:36 +00:00
2db58f68ee
Finish recents animation for app-icon tap
...
* There is a layering issue w/ live tile
* Also, order tasks for app-pair when binding
Bug: 205354856
Change-Id: I4fb5b9ed070e96299fd4b58d172ebba93789d009
2021-11-10 10:21:02 -08:00
c335ad28a2
launcher: use a different task menu for foldables
...
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.
This creates a working menu, the correct style will come in later CLs.
Bug: 193432925
Test: open Overview and tap the app icon
Fixes: 205298731
Test: atest NexusLauncherTests
Change-Id: I7a5c1fb4800a309f40fadb2df0f6c3a4c3f42679
2021-11-10 17:30:13 +00:00
Alex Chau
Tracy Zhou
Winson Chung
Fedor Kudasov
TreeHugger Robot
Hyunyoung Song
Vinit Nayak
Ryan Lin
Thales Lima