Commit Graph

15031 Commits

Author SHA1 Message Date
Ajinkya Chalke 4be13eb311 Remove obsolete TODO
- From b/399089118#comment2 "On external dispalys, RecentsViewContainer is always RecentsWindowManager, so onOverviewTargetChanged will never be called on external displays". So we we only need to track OverviewTargetChange for default display.

Fix: 399089118
Test: m
Flag: EXEMPT comment only change
Change-Id: Ica0527e45da6f0079bae5b69e9100b9f74d7f7ad
2025-05-29 08:01:51 -07:00
Pat Manning 4de1791bd0 Merge "Finish recents animation when dragging to launch non-live tile." into main 2025-05-29 03:06:21 -07:00
Daniel Andersson f9afe843dc Merge "desktop-exploded-view: Adding keyboard navigation to DesktopTaskView" into main 2025-05-28 20:35:48 -07:00
Treehugger Robot baacf9f4df Merge "Converting StatsLogManager to kotlin" into main 2025-05-28 18:29:53 -07:00
Treehugger Robot 6facece986 Merge "Adding dagger subcomponent for activity context scope" into main 2025-05-28 16:11:00 -07:00
Matthew Mourgos 4ddf9f1df1 Merge "Disable swipe up on workspace when launcher is not the top task" into main 2025-05-28 14:26:33 -07:00
Sunny Goyal bb0f554148 Converting StatsLogManager to kotlin
This is make it easier to create factory classes for individual when adding more injected parameters

Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: Ie68e9e24aae801b7fed14d1b03df760e5b67c183
2025-05-28 14:12:13 -07:00
Daniel Andersson 04066346c2 desktop-exploded-view: Adding keyboard navigation to DesktopTaskView
This CL makes TaskContentView focusable and adds a focus border to it
that is shown when it has focus. There are some caveats currently:

* Recents has a bug where it starts to eat TAB inputs (b/403292849).
  This means that the tab navigation is currently quite shaky and
  often just works the first time entering recents.
* Activating a window (with enter) is currently disabled because of
  another existing bug (b/413378320).

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353949138

Change-Id: I1c9c7e437f2e131c4ead1d750952ee9ff77c17f4
2025-05-28 13:54:59 -07:00
Sunny Goyal 182dbd609d Adding dagger subcomponent for activity context scope
Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: I2d2e556fc1c81eaac74e2a1a2a1c5526505f7a56
2025-05-28 13:33:22 -07:00
Pat Manning ca656fb54a Finish recents animation when dragging to launch non-live tile.
Fix: 396255976
Bug: 299060584
Bug: 359117837
Test: Manual.
Flag: EXEMPT Bugfix
Change-Id: I3ada253a88119cebc49c8f173bcc9347c1421bed
2025-05-28 20:12:32 +01:00
Treehugger Robot 43acf1593b Merge "Switch to desk rather than home on background click if we're in desktop mode" into main 2025-05-28 11:38:04 -07:00
Treehugger Robot 6e3d6d0a69 Merge "Moving bottom sheet variables to their own class" into main 2025-05-28 11:11:40 -07:00
Matthew Mourgos eca91f8de6 Disable swipe up on workspace when launcher is not the top task
When freeform windows are shown on top of launcher, disable the swipe up
to open all apps, which would open behind these windows. This change is
inteded for the desktop form factor.

Bug: 419565477
Flag: com.android.window.flags.show_home_behind_desktop
Test: Manually swipe up on home screen with freeform windows shown.
Change-Id: I795e9e05fe39b0cf8033b51ce4369340d49ef812
2025-05-28 10:55:16 -07:00
Eghosa Ewansiha-Vlachavas f899589251 Merge "Use desktop specific launch from taskbar in external displays" into main 2025-05-28 10:01:29 -07:00
Liran Binyamin 0e6923dce4 Merge "Fix bar state when overflow is selected initially" into main 2025-05-28 09:33:19 -07:00
Will Osborn 38d6c3398b Switch to desk rather than home on background click if we're in desktop mode
Bug: 419533193
Flag: EXEMPT bugfix
Test: locally tested
Change-Id: Icf0e06ef9158d86e1c4d3d785c0d5e96d19054d8
2025-05-28 16:06:06 +00:00
Will Osborn fb1e460fa4 Merge "Only cleanup DEFAULT_DISPLAY WindowManager on new Intent" into main 2025-05-28 07:11:04 -07:00
Pat Manning f23b7b07f6 Merge "Check for modal state in 3p Launcher overview." into main 2025-05-28 07:00:27 -07:00
Pat Manning 5d822e00fc Merge "Update spring constants for expressive dismiss." into main 2025-05-28 06:59:52 -07:00
Sebastian Franco 6dcdd67e23 Moving bottom sheet variables to their own class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: Ibaee4e94e54dbeb2f79ea5c1b6e73415ae219251
2025-05-28 13:48:44 +00:00
Schneider Victor-tulias 501df2edca Merge "Refactor BaseContainerInterface and subclasses to better support 3P and Recents in window" into main 2025-05-28 06:16:14 -07:00
Will Osborn 20c8e17553 Only cleanup DEFAULT_DISPLAY WindowManager on new Intent
Bug: 418915817
Flag: com.android.launcher3.enable_overview_on_connected_displays
Test: locally tested on comet
Change-Id: Iea4f56de63736502b3c81d0e7867229fcf28b276
2025-05-28 09:43:10 +00:00
Shamali Patwa 3b04cf3155 Merge "Extract widget picker intent extras in WidgetPickerActivity" into main 2025-05-27 20:09:52 -07:00
Simon (Qiong) Sun be9eea8f23 Merge "Support multiple tasks per split screen via SplitRemoteTargetHandles" into main 2025-05-27 18:11:37 -07:00
Sebastián Franco 6488138490 Merge "Moving Overview variables to OverviewProfile class" into main 2025-05-27 18:01:38 -07:00
Shamali Patwa 021c13c172 Extract widget picker intent extras in WidgetPickerActivity
This change refactors activity to move base activity to launcher3

This is to prepare for using it for launching widget picker for
homescreen and use compose.

Bug: 408283627
Flag: EXEMPT independent module
Test: Manual
Change-Id: I271748fb73b3691ba4d046ac8aceb51c4c8aea55
2025-05-27 17:21:31 -07:00
Sebastian Franco 3bd77e2aae Moving Overview variables to OverviewProfile class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I01644a546a5ce867d1dced1521deb798d6fc3a19
2025-05-27 15:07:38 -07:00
Treehugger Robot cbd27663e6 Merge "[owners] Remove sukeshram@google.com from quickstep/src/com/android/quickstep/OWNERS" into main 2025-05-27 13:20:03 -07:00
Schneider Victor-Tulias 4510a25fda Refactor BaseContainerInterface and subclasses to better support 3P and Recents in window
BaseContainerInterface.deferStartingActivity and BaseContainerInterface.shouldCancelCurrentGesture were methods that didn't need to be delegated down to LauncherActivityInterface. This delegation was excluding some crucial functionality from 3P launchers and recents in window.

This fixes the incorrect triggering of OtherActivityInputConsumer when using the taskbar and dragging taskbar icons to splitscreen. These fixes mainly affect the persistent taskbar

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: TaplTestsTaskbarSearch
Change-Id: I5f17c1868b0669ef6436d0c3aa36e6eaf8ce69ef
2025-05-27 13:16:47 -07:00
Treehugger Robot 97594d1e94 Merge "Unregister AbsSwipeUpHandler's ContextInitListener on launcher destroy" into main 2025-05-27 11:45:32 -07:00
Schneider Victor-Tulias 8f88cb272d Unregister AbsSwipeUpHandler's ContextInitListener on launcher destroy
- Unregister the init listener on launcher destroy to unblock the home button
- This also exposes a crash in AbsSwipeUpHandler.onRecentsAnimation start since the home bounds aren't available. So, also adding handling to reload the launcher on night mode change

Flag: EXEMPT bug fix
Fixes: 384423890
Fixes: 416536400
Test: changed dark theme then swiped/pressed home and overview buttons.
Change-Id: Ic26192e8d0e4e6b226fb9af6dba596aa78a09e96
2025-05-27 11:39:53 -07:00
Treehugger Robot e70ea33de1 Merge "Make displaylib handler and coroutine scope singletons" into main 2025-05-27 10:37:42 -07:00
Owner Cleanup Bot 14793b51a8 [owners] Remove sukeshram@google.com from quickstep/src/com/android/quickstep/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the
OWNERS file tidy. We ask that you do not ignore this change and either
approve it if the OWNER is no longer active or deny it if the OWNER is
continuing to review CLs (including under a different affiliation).
This CL can always be reverted if the understanding changes.

If this change is in error, vote the lowest CR value (i.e. reject the
CL) and the bot will abandon it.

See the owner's recent review activity for context:
https://googleplex-android-review.googlesource.com/q/sukeshram@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Id0437de6d5a33c4988eee13d91fc0d197241a679
2025-05-27 10:15:35 -07:00
Xiaoqian (Daisy) Dai d108ef020b Merge "desktop-exploded-view: Fix various values for Task windows in desktop tile." into main 2025-05-27 09:25:51 -07:00
Saumya Prakash a272ff81ad Merge "Report lower insets for SUW if expressive theme enabled" into main 2025-05-27 08:57:52 -07:00
Will Osborn ef04a08427 Make displaylib handler and coroutine scope singletons
Bug: 407205884
Test: locally tested
Flag: EXEMPT bugfix
Change-Id: Ic4d8fd429d0f647c8a4d6a3dcf5ec16fa8014455
2025-05-27 14:55:43 +00:00
Pat Manning f6e27c97ed Check for modal state in 3p Launcher overview.
Fix: 419008742
Test: Manual.
Flag: EXEMPT Bugfix.
Change-Id: I41c3c99f5a62f0d6e8478b8a1e484028acf21f25
2025-05-27 11:41:42 +01:00
Pat Manning a0b7dde91c Update spring constants for expressive dismiss.
- Add separate horizontal spring constants for tablets.

Fix: 391101706
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I689b44697be3e5d7909f9f1238359ca529e917f0
2025-05-27 11:26:40 +01:00
Cosmin Băieș 6396824a0c Merge "Remove unused imeDownButton in taskbar" into main 2025-05-26 02:59:59 -07:00
Tony Wickham 84cd5182ba Merge "Migrate some logs to OverviewCommandHelperProtoLogProxy" into main 2025-05-23 22:44:08 -07:00
Treehugger Robot d5b20e3940 Merge "Add recents animation start timeout handling to TaskAnimationManager" into main 2025-05-23 19:10:36 -07:00
Treehugger Robot 52608ce7cb Merge "pin-shortcut: Use unpin option for AllApps apps that are pinned" into main 2025-05-23 18:27:54 -07:00
Sebastián Franco aeab3c0d79 Merge "Revert "Revert "Moving DeviceProfile properties into DevicePrope..."" into main 2025-05-23 17:03:18 -07:00
Treehugger Robot 1d9cb00059 Merge "Fix a crash on home with autostashed taskbar" into main 2025-05-23 16:56:18 -07:00
Wen-Chien Wang 9942721299 pin-shortcut: Use unpin option for AllApps apps that are pinned
For the apps in All apps view, if the app is already pinned in the
taskbar, we should show the unpin option for users to unpin it
instead of a pin option that is no-op.

Bug: 375648361
Bug: 418058610
Test: manual + TaskbarPopupControllerTest
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I770afcf3abd6cb08c574230d27c4cbcbb83b29a6
2025-05-23 23:00:30 +00:00
Xiaoqian (Daisy) Dai a66268c9fc desktop-exploded-view: Fix various values for Task windows in desktop tile.
To match with the UX spec, this CL updates the insets based on the
number of tasks within a tile. It also sets a maximum height to the
task window when multiple apps are available.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: OrganizeDesktopTasksUseCaseTest
Bug: 414614454
Change-Id: Icfecc1e41dfd0b95bae10b495adae95fe10dfef2
2025-05-23 14:09:05 -07:00
Sebastián Franco e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF) 1bec329180 Merge "Revert "Moving DeviceProfile properties into DeviceProperties da..."" into main 2025-05-23 14:03:53 -07:00
Priyanka Advani (xWF) 7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Treehugger Robot becba58cff Merge "Use expressive dismiss for clear all." into main 2025-05-23 13:43:53 -07:00