Commit Graph

4943 Commits

Author SHA1 Message Date
vadimt 4b77e83a42 Not using blocking call to populate task title for logging
For now, passing null title

Bug: 175048504, 173072373
Test: presubmit
Change-Id: Ia2ed5433be9490d71786c98b8244f1c76e4e3088
2020-12-10 23:47:12 +00:00
Tracy Zhou 2268a7cb27 Merge "Render animation for launching settings in live tile mode" 2020-12-09 18:16:35 +00:00
Tracy Zhou f985f13ec1 Render animation for launching settings in live tile mode
Right now the animation is pretty basic. Will need to fine tune it.

Fixes: 172626326
Test: manual
Change-Id: Ibc64f6a988e1c7ad3f32732e1db2f0f29489e3f9
2020-12-09 00:18:00 -08:00
Schneider Victor-tulias e5764199de Merge "Add the ability to control the mock app thumbnail and app icon to TutorialControllers." 2020-12-07 17:43:04 +00:00
Schneider Victor-tulias 7f66dde4de Add the ability to control the mock app thumbnail and app icon to TutorialControllers.
Giving the gesture nav tutorial sandbox environment a more accurate look and feel requires the ability to inject mock drawables. The choice of drawables should go to TutorialControllers.

Bug: 175019879

Change-Id: Ie5b03b3fa07b017c0596a58dedf65d3e866a0727
2020-12-07 16:27:37 +00:00
Vadim Tryshev 2fe8e76bd1 Merge "Jank: not blocking UI thread when starting a task" 2020-12-03 23:40:23 +00:00
Jon Spivack 446daa2678 Merge "Add the Share App system shortcut to the Go Launcher" 2020-12-02 23:29:33 +00:00
Tracy Zhou 620c249929 Merge "Log grid size change" 2020-12-01 16:50:43 +00:00
Jon Spivack a89a5084f2 Add the Share App system shortcut to the Go Launcher
This shortcut allows users to initiate peer-to-peer app sharing from an app's long-press menu on the home screen. It does so by passing an intent to the specified component. In this base implementation, that specification in config.xml is left blank, and the button will not appear. In GMS Launchers such as LauncherGoGoogle, the config should be set to point to Nearby Sharing.

This also establishes Launcher3QuickStepGo as a distinct subclass of QuickstepLauncher instead of merely a build configuration.

Bug: 157515296
Bug: 174286192
Test: Manual (tested on local wembley devices)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I826bd03721d2e7e963b15d5958e9a18a1cc16f1d
2020-11-30 18:53:56 -08:00
Jason Chang e08dd5861e Fix abnormal flicking when swiping up to exit OHM
Defer the action of onStopGestureDetected() from ACTION_MOVE
to ACTION_UP in OneHandedInputConsumer.

Bug: 171307756

Test: manual
Change-Id: Ie4a3cb0ba4477c131191a7ed1cf4daec2d364285
2020-11-27 18:03:33 +08:00
vadimt 6b193434ee Jank: not blocking UI thread when starting a task
This created jank at the end of quick switch.
Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db

Change-Id: I96f821013d900ef57d61c462f897cba17f106bb8
2020-11-20 19:48:45 -08:00
Tracy Zhou 5b468d252f Log grid size change
Test: manually make sure that the correct path is fired
Fixes: 173481818
Change-Id: I7dc2143eb9c0527287398590d46fc2408bc47e44
2020-11-20 17:15:30 -08:00
vadimt 6c1fa64a1d Fixing jank in launching app from recents
Moving expensive actions from the last
frame's rendering.

This reduces the max frame time from > 16 ms
to <= 8 ms, which is good for now.

Test: Trace, metrics
Bug: 173640772
Bug: 173072373
Change-Id: I6d06a129f68d9b26f52c773b817558c77604ae5e
2020-11-21 00:09:42 +00:00
Tiger Huang 2f4654ee04 Merge "Replace the system UI visibility with appearance (Launcher)" 2020-11-18 13:30:06 +00:00
Sreyas 0da8d424e8 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
(cherry picked from commit ed5e43bd25)
2020-11-17 18:46:48 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 2cd8dd6282 Merge "Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON" into ub-launcher3-master 2020-11-13 19:24:40 +00:00
vadimt 4dd0fb173b Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON
This is a part of Blue Chip de-janking effort and is
a P0 item in our CUJ list.

In the last frame of the app-open animation, we have
a
android.view.IRemoteAnimationFinishedCallback$Stub$Proxy.onAnimationFinished call
which is blocking and prone to lock contention in WindowManager.

Moving the call to after the animation.

Bug: 173072373
Change-Id: If5eb6469900d1892b861eda6d6b4807d90630b6b
2020-11-12 18:42:20 -08:00
Schneider Victor-tulias 64154ead74 Fix hotseat predicted app update regression.
Hotseat predicted app updates were only being allowed then the hotseat was invisible or when the workspace was loading. This was too strict. Changed the logic to ignore hotseat visibility when the workspace is loading, when there are empty spots in the hotseat and when the predicted items are unchanged. This ensures the hotseat always has the intended number of icons and that icons can be updated in-place.

Fixes: 172597819

Demo: https://drive.google.com/file/d/100svnqX048Da7vues2p-vvQNN6sIF8v4/view?usp=sharing
Change-Id: I2f93ff44618c0282a6411918c34d70f75ec73b73
2020-11-12 11:22:53 -05:00
Sunny Goyal 6f1bc72fda Merge "Fixing animation cancelled not called if gesture was not initiated" into ub-launcher3-master 2020-11-12 04:33:07 +00:00
Sunny Goyal 986ea0da60 Fixing Robolectic model tests
Some tests were broken because of refactoring in LauncherModel.

Change-Id: I55aa32d75a4d16338796a1b1765717fd72ba4b33
2020-11-12 01:01:55 +00:00
Sunny Goyal 0112a3d434 Fixing animation cancelled not called if gesture was not initiated
Previously, in case of a tap in the gesture region, swipeHandler was not
explicitly cancelling the launcher state animation. It was getting reset
bucause launcher gets onStop immediately after that.
But in some cases, it may not get onStop (if the top activity finishes),
which leaves the Launcher UI in a broken state

Bug: 172842997
Change-Id: Iff7b1e5b8f67b2f4dd8096b88c4cd97115ec912a
2020-11-11 12:23:47 -08:00
TreeHugger Robot 1a7e371214 Merge "Refactoring DigitalWellbeing Banner to not use footers." into ub-launcher3-master 2020-11-11 01:42:19 +00:00
Sunny Goyal 1cd6a5f30e Fixing app-to-overview animation in 3 button mode
Instead of copying orientation state information from RecentsView
to taskViewSimulator, using the same state object, so that new
properties (like RecentsRotation and flags) are automatically covered

Bug: 162881482
Change-Id: I02d0a710a6ecc4a3cebd0fcc4c49032127df1ce3
2020-11-09 15:52:29 -08:00
Sunny Goyal cff31d8281 Merge "Removing separate Cancel and End callbacks and using AnimationListener instead" into ub-launcher3-master 2020-11-06 01:29:39 +00:00
Sunny Goyal ff9e7d6aa9 Removing separate Cancel and End callbacks and using AnimationListener instead
This removes the additional step of invoking these callbacks separately

Change-Id: I0b60047a44f179ba725f15b1e791e336884869c9
2020-11-05 16:35:11 -08:00
Tracy Zhou 3260bc51cb Merge "Handle the animation when restarting apps" into ub-launcher3-master 2020-11-06 00:05:49 +00:00
TreeHugger Robot e2c3a8f657 Merge "Using UI_HELPER_THREAD for various activity manager interactions" 2020-11-05 23:12:36 +00:00
Sunny Goyal ffa21961bf Using UI_HELPER_THREAD for various activity manager interactions
Bug: 170648272
Change-Id: Iec36389be5d747c5dc4d2bb2a8138758d48efa53
2020-11-04 22:36:21 +00:00
Sunny Goyal 8cadc1281f Using UI_HELPER_THREAD for various activity manager interactions
Bug: 170648272
Change-Id: Iec36389be5d747c5dc4d2bb2a8138758d48efa53
2020-11-04 14:29:59 -08:00
Tracy Zhou ae567f96f6 Merging from ub-launcher3-master @ build 6952418
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6952418.html

Change-Id: Id8ec665ff7be486b794807f6524e385728ea7717
2020-11-04 12:33:10 -08:00
Sreyas 6dcba89581 Refactoring DigitalWellbeing Banner to not use footers.
Removing use of footers as they are no longer necessary. Refactoring DWB code to a separate class to be cleaner. Also fixes bug with DWB animating in twice.

Bug: 171317883
Bug: 171317874
Tested:Manual

Change-Id: I78c4e541e7afa76301c3afc373ab3fa251a2c3b0
2020-10-30 11:55:48 -07:00
Tracy Zhou fbfccf9e2d Handle the animation when restarting apps
Fixes: 170338921
Test: manual

Change-Id: I5a5722cb62fb53a68d140621ad79ed97f4d98571
2020-10-29 10:01:34 -07:00
Tiger Huang 1e042652a8 Replace the system UI visibility with appearance (Launcher)
The system UI visibility has been deprecated.

Bug: 149813814
Test: atest TaskSnapshotControllerTest TaskSnapshotPersisterLoaderTest
Change-Id: Ic4ed6f6ea693bb9c484062a35bf4292e0edff0e5
2020-10-29 21:05:06 +08:00
Joshua Trask b0f897cda8 Merging from ub-launcher3-master @ build 6934851
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6934851.html

Change-Id: Ie082cfabfc07e26db9d0bbb563376291b2b30491
2020-10-28 12:13:40 -04:00
TreeHugger Robot 426f6ac276 Merge "Use event time of app side for latency metrics" into ub-launcher3-master 2020-10-28 10:40:27 +00:00
Riddle Hsu b30adcb232 Use event time of app side for latency metrics
There are 2 reasons not to use MotionEvent#getEventTime:
1. There is an existing TouchEventReported metric for touch latency.
2. In instrumentation test, the event time is set when creating
   the motion event for injection. It may cause the results to be
   5 times slower than the real case. That may lead to miss the
   cost from app to system.

Bug: 166614700
Test: Enable statsd log: "adb shell cmd stats print-logs"
      Touch gesture navigation bar or launch app from launcher.
      adb logcat | grep statsd | grep "(48)"
Change-Id: Ica5e7df685fe737bbc3ac60c3ec35bad15466726
2020-10-28 09:13:48 +00:00
Tracy Zhou 55940ecfc7 Render and track live tile position when launching another app from Overview
Fixes: 165394366
Fixes: 170338328
Test: Manual
Change-Id: Idfcd423cbe062af33564eaa9e83ec21fbac0cdf9
2020-10-27 15:45:01 -07:00
TreeHugger Robot ceb8618f09 Merge "Finishing recents task before starting share screenshot flow" into ub-launcher3-master 2020-10-27 20:41:54 +00:00
TreeHugger Robot a48f6efbe1 Merge "Integrating snapshot logging in Launcher" into ub-launcher3-master 2020-10-27 19:08:01 +00:00
Sunny Goyal b694a69f53 Integrating snapshot logging in Launcher
> Workspace snapshot is logged when the workspace loads (at most once a day)
> Removing unnecessary thread jumping when logging folders
> Preference snapshot is logged on process start and whenever something changes

Change-Id: I93767de89b11522d843c0e8300d1f108c78f6d90
2020-10-27 11:25:43 -07:00
Sunny Goyal 54aae4f95d Finishing recents task before starting share screenshot flow
Bug: 170338559
Change-Id: Ieccdc492c7d1a60b47b90c6683e60e8a143ca80d
2020-10-26 16:02:17 -07:00
Tony Wickham 2c956a4651 Merge "Add null check between calling onMotionPauseDetected() and Changed()" into ub-launcher3-master 2020-10-26 22:08:00 +00:00
Winson Chung 6f4e65f62f Updating pip transition calls with shared lib
Bug: 143965596
Change-Id: I761726ca9666689d4359240b065997e3342eab65
2020-10-25 22:26:55 -07:00
Hongwei Wang 5b5f3c6609 Improve PIP enter transition w/ gesture nav (3/N)
Directly transition Activity to PiP mode in launcher if the Activity
claims auto-pip support. Video is taken by commenting out the
requirement of setting the auto-pip flag.

Note that we need app to actively push up-to-dated
PictureInPictureParams to the framework, otherwise we won't be get
- PictureInPictureParams on first entering
- Staled PictureInPictureParams if the aspect ratio is changed

Video: http://rcll/aaaaaabFQoRHlzixHdtY/abenIxLFI1pZzF2O8t4TbS
Bug: 143965596
Test: see demo videos
Change-Id: Iea9a6ff39a79431ac1afa14aea812c500b3ca3b2
2020-10-25 21:14:10 -07:00
TreeHugger Robot e6239cebd0 Merge "Fixing robo test compilation" into ub-launcher3-master 2020-10-23 18:13:03 +00:00
Tony Wickham c1a785914a Add null check between calling onMotionPauseDetected() and Changed()
Some listeners such as ScreenPinnedInputConsumer only care about the
first pause detection and thus clear the MotionPauseDetector in
onMotionPauseDetected(). Because clear() sets mOnMotionPauseListener
to null, we need a second null check before onMotionPauseChanged().

Fixes: 169329910
Change-Id: I4fc30d67ad808a5b0c8feb10cc5392d7cae042b1
2020-10-23 11:02:05 -07:00
Sunny Goyal 84acb18dc2 Fixing robo test compilation
Change-Id: I1b1192f4cbf1ea1916f2ec4cd607743b3483250a
2020-10-23 10:35:35 -07:00
Tony Wickham 9d2466418c Merge "End the attaching animation early when we settle on the end target" into ub-launcher3-master 2020-10-23 17:21:16 +00:00
Winson Chung 87f2b09072 Merging from ub-launcher3-master @ build 6925377
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6925377.html

Change-Id: I928b100c8f41abff34047df69d988622123f9939
2020-10-23 10:16:50 -07:00