Commit Graph

1334 Commits

Author SHA1 Message Date
Hui Kang 1a2733b003 Merge changes from topic "Annotate Platinum Test" into udc-dev am: 879d746de7 am: 97207cec9d am: e921afc681
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23404501

Change-Id: I53fe53efb5de1812824f0ba8d6eafad4d0e0d47b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:52:13 +00:00
Hui Kang 3bcb77a6ae [4/7]Add PlatinumTest annotation to tests am: 5bde3f8573 am: 8ae87ec2b7 am: c9c1829cc7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23395253

Change-Id: Icf6c00a2847088b7ec3ad273b00bdaae9a09a0af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:52:09 +00:00
Hui Kang 8ae87ec2b7 [4/7]Add PlatinumTest annotation to tests am: 5bde3f8573
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23395253

Change-Id: I80a394187285aab7bcbde1590b6673d25070fa4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 16:26:14 +00:00
Hui Kang 879d746de7 Merge changes from topic "Annotate Platinum Test" into udc-dev
* changes:
  [3/7]Add PlatinumTest annotation to tests
  [4/7]Add PlatinumTest annotation to tests
2023-05-25 16:04:10 +00:00
Hui Kang 0928ab0811 [3/7]Add PlatinumTest annotation to tests
These tests already have IwTest annotation. The IwTest tests will be merged with platinum tests using the PlatinumTest annotation. The IwTest annotation will be deprecated and removed.

Test: make
Bug: 283409062
Change-Id: Idee826a228070bdad26e9520c7b59c4df970f717
2023-05-24 01:21:46 +00:00
Hui Kang 5bde3f8573 [4/7]Add PlatinumTest annotation to tests
These tests are in the audited platinum suite (go/platinum-audit-flake)

Test: make
Bug: 283409062
Change-Id: Id438fde00b2a6e31694bef125d20637af514b9da
2023-05-24 01:17:18 +00:00
Winson Chung 024ea10965 Merge "Removing legacy launcher winscope tracing for tests" into udc-dev am: 883871e280 am: 395ed225a2 am: b94ac3aef8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23384355

Change-Id: Ib35fa77abbac2fb26c2219e078efed196e8542ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 20:19:47 +00:00
Winson Chung cc96740534 Removing legacy launcher winscope tracing for tests
Bug: 279924453
Test: Presubmit
Change-Id: I9ed7c3669dad5c20d0fa760b2fe2a50308f10be8
2023-05-23 06:14:54 +00:00
Treehugger Robot 966ad639a1 Merge "Detach ViewCaptureRule onDrawListener on the main thread." into udc-dev am: 17164414ca am: 137bcd60e0 am: 797b22360d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23357371

Change-Id: I634a9210d7959b85e2070d3d894eece19d3e6b39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 21:04:35 +00:00
Treehugger Robot 17164414ca Merge "Detach ViewCaptureRule onDrawListener on the main thread." into udc-dev 2023-05-22 19:23:52 +00:00
Vinit Nayak 43c2396050 Merge "Install test app for work profile user" into udc-dev am: 47ab6f8ba2 am: 4d331b6fbe am: f494ba1ad4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331908

Change-Id: I29e6ce8eabfb1fcd62a0dd40622a26c4d4e81116
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19 23:11:53 +00:00
Stefan Andonian c7c507c362 Detach ViewCaptureRule onDrawListener on the main thread.
This should avoid an IllegalStateException in instrumented tests.

Bug: 283313972
Test: Post-submit test succeeded.
Change-Id: I5302cfc089d91b044baaac75b5d7c69e763a1847
2023-05-19 22:39:30 +00:00
Vinit Nayak a3e139c68a Install test app for work profile user
Bug: 243688989
Change-Id: I3ecd0c9eefdbd84d2b9da45680b9efb078c3fb67
2023-05-18 17:49:04 -07:00
TreeHugger Robot e607fdb2a2 Merge "Removing support for lagacy shortcuts" into udc-qpr-dev 2023-05-17 19:25:45 +00:00
Sunny Goyal e274d97fe5 Removing support for lagacy shortcuts
> Addition/removal of  shortcus is already removed. This just
  cleans up the unused code path

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I8ab7f57b693f996920e50e8beecafcffab5167e9
2023-05-17 09:20:45 -07:00
Thales Lima 52fbedf2f1 Merge "Calculate sizes for responsive grid" into udc-dev am: d282d5956e am: dc7d900708
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22764617

Change-Id: I29151c20fb9a05163a0f17b0317bff1ebf14588e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17 15:36:07 +00:00
Thales Lima c98b7815c6 Calculate sizes for responsive grid
This shouldn't change anything in the grids, only calculate the sizes of the grid.

Bug: 277064708
Test: CalculatedWorkspaceSpecTest
Test: WorkspaceSpecsTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Id1f90ef44f5b869113d063bad17589e7e88d1d20
2023-05-17 10:33:36 +00:00
Alex Chau 7af659da9e DisplayController should deep compare mPerDisplayBounds
- In CHANGE_SUPPORTED_BOUNDS check, it uses Map.equals, but as the value is a primitive array WindowBounds[], equals check does not deep compare the arrays and may result in false negative
- One example is when fontScale changes, DisplayController re-create bounds from WindowManagerProxy, result in new WindowBounds[] created, and the shallow compare results in unexpected CHANGE_SUPPORTED_BOUNDS

Fix: 282736623
Test: DisplayControllerTest
Change-Id: I3897595c58559192b951ecfee7c9f62a07dafe1f
2023-05-17 09:40:46 +00:00
Stefan Andonian e3b06996c3 Merge "Added ViewCapture to all tests which implement AbstractLauncherUiTest." into udc-dev 2023-05-15 22:06:37 +00:00
Sebastián Franco c6ebf62ae7 Merge "Stopp Cell height from changing when running ReorderUnitTest" into udc-dev 2023-05-15 19:57:27 +00:00
Andrew Cole 5929e8aec0 Merge "Updating isTextClippedVerticallyTest" into udc-dev 2023-05-15 15:03:29 +00:00
Sunny Goyal 7bc6cdee56 Revert "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""""
This reverts commit 09905cfa90.

Reason for revert: Fixed the crashing issue

Change-Id: Ibcfc28a89356d262e67e8842d6bae37e230a70f5
2023-05-13 01:59:19 -07:00
Stefan Andonian fa8091661a Added ViewCapture to all tests which implement AbstractLauncherUiTest.
This enables developers to watch failed tests in classes like
TaplTestsQuickstep in the go/web-hv tool.

Bug: 242867462
Test: Failed a test and verified that the TimeLapse bugreport entry
showed up properly in the go/web-hv tool.

Change-Id: Ic89af2a0e7102db52c52ddc668607a81c4809ed6
2023-05-12 21:15:14 +00:00
Andrew Cole f9b87e3907 Updating isTextClippedVerticallyTest
Updating the isTextClippedVertically test to accomodate a different aspect ratio for raven devices

Bug: 279464742
Test: isTextClippedVerticallyTest
Change-Id: I4a4b740513914f1e76db18a00b65e4f881535d4a
2023-05-12 16:55:41 +00:00
Vinit Nayak f68f1fa3cc Cleanup SettingsChangeLogger onClose()
* Correct name for San*d*box

Bug: 280463854
Flag: none
Test: v2/gnl-eng/unbundled/launcher/nexus_unit_test_multi_device_platform
Change-Id: I2446871c8ea0b146ccfa2ea7caa1727aec42dd42
2023-05-11 16:32:27 -07:00
Sunny Goyal c110587dba Merge "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""""" into udc-dev 2023-05-11 22:24:45 +00:00
Sunny Goyal 09905cfa90 Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""""
This reverts commit bca4e694f0.

Reason for revert: post submit broken

Change-Id: I8afc63b5aa67ee14127f79e2245ef543bff8cf31
2023-05-11 22:22:16 +00:00
Sunny Goyal 04a6211120 Merge "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""" into udc-dev 2023-05-11 20:22:51 +00:00
Sebastian Franco d3f6522ebb Stopp Cell height from changing when running ReorderUnitTest
Fix: 280683994
Test: atest ReorderAlgorithmUnitTest
Change-Id: Iee6336e11387a637e3fe52722d4f30a15e58aca9
2023-05-11 13:12:55 -06:00
Jagrut Desai fe5234fd86 Remove Screen Record for the test
We no longer need the screen record as test is stable and passing.

Test: Pre-Submit
Bug: 281722118
Flag: not needed
Change-Id: I4fa59968c58355068deee8429753b28120048eeb
2023-05-10 11:55:23 -07:00
Sunny Goyal bca4e694f0 Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""
This reverts commit 3772b246c2.

Reason for revert: Fixed the test failure

Change-Id: Ibdc9e184fcb32c7caa4ab25d8753a46fa322b703
2023-05-10 17:49:16 +00:00
Thales Lima ec5abba93b Add feature flag and attribute for responsive grid
This shouldn't change anything in the grids, only support the creation of responsive grids in the future. For now, to check that the flag works, turn it on and check the dumpsys. There is also a dump test created for this.

Fix: 277064696
Fix: 277064702
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I1bef87043a100234bd661cd6ac00007fdc654116
2023-05-09 12:06:18 +01:00
Sunny Goyal 356aa61fe4 Merge "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""" into udc-dev 2023-05-06 18:19:13 +00:00
Sunny Goyal 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Sunny Goyal 2185f6f420 Loading widget description on the background thread
Bug: 281074741
Test: Varified on device
Flag: N/A
Change-Id: I6b9b13e712534bdc582b98dbfb7bdfcc40d2f19d
2023-05-05 23:15:41 +00:00
Sunny Goyal 8d9e468dbb Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""
This reverts commit 30bb3a247a.

Reason for revert: Fixed original issue

Change-Id: I02d85d604631795d96f0379eb94b7b6789102ea9
2023-05-05 16:00:49 +00:00
Charlie Anderson 178802d35c Merge "Revert "Changing GridMigrationTask to use ModelDbController directly"" into udc-dev 2023-05-04 17:58:01 +00:00
Treehugger Robot c2dca5fec4 Merge "Always insetting the widget by a minimum of 6dp" into udc-dev 2023-05-04 17:48:48 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Jagrut Desai 8818b17337 Revert to Fix AddConfigWidgetTest
- we were checking the widget being valid and bound after we are accepting the config
- solution is to revert back to test before and check post result after be check if widget is valid and bound.

making sure that ShellCommandRule is checking for success,
refactor for AddConfigWidgetTest with extra launcher wait condition.

Test: none
Bug: 276794291
Flag: not needed
Change-Id: I4a6caf0851a947da03711b2a5d5bc9f736a47f95
2023-05-03 18:03:33 -07:00
Sebastián Franco db982003b2 Merge "Adding unit test to ReorderAlgorithm" into udc-dev 2023-05-03 20:13:15 +00:00
Sunny Goyal 6c304b157d Always insetting the widget by a minimum of 6dp
Removing default widget padding logic. Also widget padding it applied
at ShortcutAndWidgetContainer so that the widgetView always has the
correct size.

Bug: 274826296
Bug: 257589413
Test: Verified using screenshots
Flags: N/A
Change-Id: Id4b5e94db6ec7b2aa3dca87b1e9ccc831b608cac
2023-05-03 12:18:33 -07:00
Sebastian Franco 45b39b50e5 Adding unit test to ReorderAlgorithm
Adding 100 different test cases for the ReorderAlgorithm.
The test cases are randomly generated using generateRandomTestCase()
the boards are generated once and then written in the file
reorder_algorithm_test_cases. I will leave the code to generate
the boards in the Test even though is not used anymore in case
we need to generate more boards later on.

Also, I found that the ReorderAlgorithm was not deterministic,
meaning that it could generate two different results with the same
inputs (views positions and view being drag positions), because
it was traversing a map whose has was the object id which is
random. So I sort the views before traversing them.

Bug: 229292911
Test: atest ReorderAlgorithmUnitTestCase

Change-Id: I196eb8f1dafcb57d5259969268c458129ae4f46b
2023-05-03 11:22:09 -06:00
Sunny Goyal 9ef41413e0 Changing GridMigrationTask to use ModelDbController directly
instead of using content uris

Bug: 277345535
Test: Updated tests
Flag: Presubmit
Change-Id: Ib62db3334c01d9e7d27ae7b02ea703d046e2bcaa
2023-05-03 08:54:14 -07:00
Fengjiang Li 5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Schneider Victor-tulias 8c1bffb24f Merge "Remove unused debug logs" into udc-dev 2023-04-27 17:44:42 +00:00
Vinit Nayak af55572713 Merge "Add logs for PackageUpdatedTask" into udc-dev 2023-04-26 23:05:42 +00:00
Vinit Nayak 6106ae9ac7 Add logs for PackageUpdatedTask
* That's the bit that updates new packages for work profile,
at least from command line.
* There is variability in how long it could take work profile
apps to show up, from 2-8 seconds.

Bug: 243688989
Change-Id: I710befc5f17b4a16bff523eb03f1e88975cafd43
2023-04-26 13:21:57 -07:00
Schneider Victor-tulias fff7cef9f1 Remove unused debug logs
Removing debug logs for bugs that have already been closed. These logs are filling up the logcat buffer and impeding in other test investigations.

Flag: not needed
Test: Tapl tests
Bug: 260260325
Change-Id: I4d69b904f2ea79d758cf6bef7d90d172f2eb2a91
2023-04-25 11:00:37 -07:00
Vadim Tryshev ff056355c2 Merge "Saving bugreport for the first failed test." into udc-dev 2023-04-25 04:04:11 +00:00