Commit Graph

3551 Commits

Author SHA1 Message Date
Vinit Nayak 4ae95beb9b Merge "Override Rect#contains() to include bottom right" into ub-launcher3-rvc-dev 2020-05-18 22:21:55 +00:00
TreeHugger Robot d5315f8c29 Merge "Using taskView simulator for animation a task to recentsView" into ub-launcher3-rvc-dev 2020-05-18 19:02:30 +00:00
Vinit Nayak 08619f8600 Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev 2020-05-17 23:32:00 +00:00
Vinit Nayak 23681083b2 Hide shelf in 2-Button Landscape
Disable overview rotation in 2-Button.

Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.

Change-Id: Ic22c791c7a93460840d54aaf0bf32884cc110e19
2020-05-17 15:17:11 -07:00
TreeHugger Robot 04f476dcb0 Merge "Log last appeared task id instead of target" into ub-launcher3-rvc-dev 2020-05-15 22:22:43 +00:00
Tony Wickham 39f2f1029b Log last appeared task id instead of target
Might be slightly more useful (e.g. if we
need to compare against last started task id)

Change-Id: I3617be270bec6841fbd943e681de78ada549ff84
2020-05-15 16:32:04 -05:00
Sunny Goyal b9abae9f0f Using taskView simulator for animation a task to recentsView
Also applying transform params in DeviceLockedInputConsumer directly
instead of going through AppWindowAnimationHelper

Bug: 156398988
Bug: 155816922
Change-Id: I791e1a9feb07c4fb787130f8d040a4f404faf734
2020-05-15 14:07:29 -07:00
TreeHugger Robot 9027a04514 Merge "Deference mAppPredictor on destroy" into ub-launcher3-rvc-dev 2020-05-15 20:17:42 +00:00
TreeHugger Robot 2d78b783cc Merge "Remove debug logs, root cause found." into ub-launcher3-rvc-dev 2020-05-15 19:03:06 +00:00
Samuel Fufa 4dd6ab3ca1 Deference mAppPredictor on destroy
+ Also remove PredictionModel.mCachedComponentKeys

Bug: 156747920
Bug: 156041043
Test: Manual

Change-Id: I56dac1c6ac0a1bb93363342006232fc1ba42a3b4
2020-05-15 11:33:27 -07:00
Vinit Nayak 9c62e18660 Remove debug logs, root cause found.
Bug: 146964271
Change-Id: I38ed3b4b1a90fa1ff9a3aa4bb5547300ddd92358
2020-05-15 10:04:51 -07:00
TreeHugger Robot e241f6c243 Merge "Prevent all apps prediction update while visible" into ub-launcher3-rvc-dev 2020-05-15 10:31:56 +00:00
TreeHugger Robot 63cbfc6118 Merge "Switch to new protocol for hybrid hotseat" into ub-launcher3-rvc-dev 2020-05-15 08:25:50 +00:00
Samuel Fufa 6793dae692 Prevent all apps prediction update while visible
Test: Manual
Bug: 156418702
Change-Id: Iaa5468d7c600e6568ac1e35108c586752d6658b6
2020-05-14 23:13:19 -07:00
Samuel Fufa d12d6ab98a Switch to new protocol for hybrid hotseat
- create predictor from items in bgModel instead of scanning views
- Launcher no longer checks for duplicates before sending pin/unpin events
- sending cached items from last prediction to reduce UI shuffle
- Switch to using UserCache to persist and read ComponentKey

Bug: 148814143
Bug: 156413231
Bug: 156200931
Change-Id: Ide6330bed8eb7f0c6fbec1d1ac21e7f67a9b2be2
2020-05-14 17:27:34 -07:00
Vinit Nayak c40352ef8c Override Rect#contains() to include bottom right
In landscape, the lowest coordinate touch registered
is the actual lowest pixel possible by the screen.
For portrait/seascape the lowest coordinate
is (lowest pixel possible - 1). The difference of the
one pixel makes Rect#contains() return false since
only top left Rect points are inclusive and bottom
right points are exclusive.

Fixes: 156333291
Test: Always able to smoothly go to overview from
landscape.

Change-Id: I6beddad99ae076a167d2a5f5e5acc6e466bff544
2020-05-14 17:26:15 -07:00
James O'Leary 4cb77a60aa Merge "Compose gesture integrated fully into Launcher" into ub-launcher3-rvc-dev 2020-05-14 20:20:13 +00:00
Adam Cohen 1682d0d71b Merge "Don't require the center task id to adjust status bar when swiping up" into ub-launcher3-rvc-dev 2020-05-14 20:15:51 +00:00
Adam Cohen 18aa37ca68 Don't require the center task id to adjust status bar when swiping up
b/155029378

Change-Id: I3cb65e82ab192b63d54291aad9e2395fa8dedaef
2020-05-14 11:31:28 -07:00
James O'Leary 74a2746b35 Compose gesture integrated fully into Launcher
- Support dismissing Compose via the reverse gesture from the appear
gesture
- Use Tony Wickham's ag/10204761 with some glue code to enable the
app below Compose panning in the same direction as the gesture as
Compose peeks in
- Add feature flag to use Compose hosted in a window (permits underlying
app panning)
- Use InterpolatingVelocityTracker to fix OtherActivityInputConsumer
processing swipes in the wrong direction ~20% of the time due to a bug
in VelocityTracker (see go/quirky-bubbles)

Change-Id: I3adbaee1763f21557fb628b60d03b0a03e7079ab
2020-05-14 14:18:19 -04:00
Winson Chung 034ce6fd94 Update shelf offset earlier when in gesture nav
- Provide a hint to Launcher to indicate it will be resumed when
  swiping home, which allows us to notify sysui before any potential
  pip invocation, reducing the likelyhood of two conflicting animations
  when entering pip

Bug: 156637223
Change-Id: Iae773e1aac88bbea6f74e1d1332417b448126471
2020-05-14 10:55:14 -07:00
Winson Chung 1801d19bcd Remove LockscreenRecentsActivity
- This activity would create another task (no longer in the same
  stack since we don't have activity type stacks) which was causing
  the camera to be occluded sometimes, which then cancels the recents
  animation
- Tweaking the animation slightly to match the movement of the closing
  the activity back to the lockscreen

Bug: 156514461
Test: Launch camera on the lockscreen and swipe up to dismiss (repeatedly)
Change-Id: I8aaac22767288d7fbf183683276c50acaaf831d2
2020-05-14 10:51:44 -07:00
Sunny Goyal d9c0349c1a Merging WindowSizeStrategy with BaseActivityInterface
Also converting BaseActivityInterface to an abstract class instead of interface
so that it can hold member variables

Change-Id: I04cab934137eb1d6f470c6a7618c50a2ed2c71c1
2020-05-14 01:22:25 -07:00
thiruram f95f152971 Add LAUNCHER_FOLDER_LABEL_CHANGED events for folder label updates.
Sample Logs for all update combinations: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.7y1p8n2dz8ge

Bug: 155410872
Bug: 152978018
Change-Id: I296b124b16aa07878f2cf7b74ab91f13b8e6cfbf
2020-05-13 17:36:10 -07:00
thiruram b9080c2a15 Add support to log LauncherEvent without ItemInfo.
Change-Id: I145a9500b0442c2b5d9f7f691460465b2bb13a07
2020-05-13 22:58:23 +00:00
Vinit Nayak bdd6522661 Merge "Update recents child views RTL handling" into ub-launcher3-rvc-dev 2020-05-13 21:41:09 +00:00
Sunny Goyal f190fd2d4e Build fix. Unifying task size calculation code.
Change-Id: Iaed3a28a9e74c39da8d01aa42b30c96bdb69a661
2020-05-13 14:06:07 -07:00
TreeHugger Robot 650da4bbd1 Merge "Keep Predicted icon same size when dragging" into ub-launcher3-rvc-dev 2020-05-13 19:18:28 +00:00
TreeHugger Robot e0fef877e4 Merge "Changing RecentsView layout based on the split screen task size" into ub-launcher3-rvc-dev 2020-05-13 18:35:05 +00:00
TreeHugger Robot d893a478a3 Merge "Adds Settings button back to Back gesture tutorial." into ub-launcher3-rvc-dev 2020-05-13 18:34:37 +00:00
Becky Qiu dc48fc4f84 [Overview Actions] Adjust the select mode taskview UI.
It will have a 30dp horizontal paddings and vertically in the middle of the screen.

Test: local
Bug: 155444014

Change-Id: I4f3d627008b2c114cc4921bf683919c6044926e4
2020-05-13 18:23:28 +00:00
Samuel Fufa 167210a323 Keep Predicted icon same size when dragging
-> In addition, this also prevents the drawing of ring effect for predicted icon when view is about to be copied to drag bitmap. Icon will scale to full size (without ring) when dropped.

Video attached to bug report

Bug: 152325754
Test: Manual
Change-Id: Ibd1a5dbf76c41bdc30ae851ad914a4d0e32703c8
2020-05-13 11:22:27 -07:00
Andy Wickham ee1203e436 Adds Settings button back to Back gesture tutorial.
Uses a simpler Intent which actually works :)

Fixes: 149348244
Bug: 148542211
Change-Id: I5e28c63d1eec93b4642e398c7532e7ec4809d6e2
2020-05-13 10:48:38 -07:00
Andy Wickham 65381300f2 Minor cleanup in RecentTasksList.java
Change-Id: I8a496300c936e4d3f2bcd6b0c6c482e5bbb0452d
2020-05-13 09:34:49 -07:00
Vinit Nayak 08a8327b1d Update recents child views RTL handling
Fixes: 154928106
Test: AppIcon and clear all button
shows up as expected in LTR and RTL
configuration.

Change-Id: Idcf367b8aff53002e63a03b64b96e3602127707e
2020-05-12 22:24:26 -07:00
TreeHugger Robot 75dcd82a67 Merge "Don't handle task appeared during second quick switch transition" into ub-launcher3-rvc-dev 2020-05-13 03:35:23 +00:00
TreeHugger Robot 7c604edf92 Merge "[Overview Actions] Put the taskview in the middle of the screen." into ub-launcher3-rvc-dev 2020-05-12 23:01:25 +00:00
Tony Wickham f6be443eb4 Don't handle task appeared during second quick switch transition
Instead of using shared gesture state, use the swipe handler's
internal state. This ensures that only the handler that started
the new task can finish the controller for it (i.e. starting a
new gesture, which creates a new handler, will ignore the
onTaskAppeared() that the previous handler initiated).

Test: Quick switch to delayed task A, then quick switch to B right
before onTaskAppeared() such that we get onTaskAppeared() during
the transition (easier to repro if you increase animation durations
with springs off). Before this change, A appeared on top.

Bug: 156412706
Change-Id: Ic7d3cd43399005095b2e7c7382218edffefdc27b
2020-05-12 17:46:02 -05:00
Becky Qiu 073cbca370 [Overview Actions] Put the taskview in the middle of the screen.
Using horizontal padding 48dp to adjust the scale of the taskview and put it in the middle of the vertical space.

Test: local
Bug: 155444014
Change-Id: Iee6096baf18ae1106c24c83b4675abd4d3ff4d4f
2020-05-12 15:00:54 -07:00
Sunny Goyal b78ea4b4fc Changing RecentsView layout based on the split screen task size
Bug: 155816922
Change-Id: I33f69d72f8a27e3621d029c6ee4045c3664f3ac9
2020-05-12 14:04:19 -07:00
Sunny Goyal 3f948e3f42 Adding state manager to fallback recents activity
Bug: 156398988
Change-Id: Id0a106ef888ade5223940ac8243108c39b4d6b98
2020-05-12 13:31:48 -07:00
TreeHugger Robot 7dcd4d6ed6 Merge "Simplifying animation creating logic for app-to-overview" into ub-launcher3-rvc-dev 2020-05-12 18:42:22 +00:00
TreeHugger Robot 2830c99bee Merge "Even more additional logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-12 17:35:42 +00:00
vadimt 60bc43d0cc Even more additional logging for pause non-detection
Bug: 156044202
Change-Id: I7c1a8a9ef4149bd64597908c0b6797cfe33fd4b6
2020-05-12 09:51:24 -07:00
Sunny Goyal 4888790bde Simplifying animation creating logic for app-to-overview
Removing optional 'shouldAnimate' flag. This was false only in 3-button mode but
the code was also handling animation, leading to inconsistent expectations. Instead
always assuming animation and finishing the animation promptly.

Change-Id: Ic56476dc5ea64c9a7d7e9744f3e33cd61dfde9e8
2020-05-12 16:37:27 +00:00
TreeHugger Robot b8759f9b26 Merge "Fixing pullback factor not initialized after launcher process death" into ub-launcher3-rvc-dev 2020-05-12 03:06:29 +00:00
TreeHugger Robot 3d3c41a3a6 Merge "Make educational half-sheet black in dark mode" into ub-launcher3-rvc-dev 2020-05-12 01:07:21 +00:00
TreeHugger Robot eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
Sunny Goyal 35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Tony Wickham a57000c33d Restart running task if another task was started but not appeared
If we just finish the controller to resume the running task like
we normally would, the delayed task will appear on top when it's
ready. Instead, we need to start the original task in this case.

- Move mLastStartedTaskId to GestureState, shared between swipe
  handlers when continuing the gesture.
- Update logic to change LAST_TASK to NEW_TASK if a task was
  started (but not appeared) during the same gesture; likewise,
  only change NEW_TASK to LAST_TASK if no task was started.
- Finish the controller when successfully starting the task
  that already appeared, since we won't get onTaskAppeared().

Bug: 156132424
Change-Id: I1e9af297840745ab3d5e90214425f10a2616d90a
2020-05-11 18:26:06 -05:00