Commit Graph

2779 Commits

Author SHA1 Message Date
TreeHugger Robot 4a96a6c74e Merge "Handle transitining out of overview more gracefully for 3P launchers" into sc-dev am: 9bb040ec6d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14142323

Change-Id: Ib306c3b2b8a9da494a75111a57ef37512774ccc9
2021-04-12 23:21:32 +00:00
TreeHugger Robot 9bb040ec6d Merge "Handle transitining out of overview more gracefully for 3P launchers" into sc-dev 2021-04-12 22:41:36 +00:00
Vinit Nayak 58dfd4d209 Handle transitining out of overview more gracefully for 3P launchers
Bug: 183897242
Test: Tested with Pixel Custom Launcher, as suggested on the bug
Change-Id: I46ceddb9f5eed6b16b7e66406dd68d94e7a30aee
2021-04-12 10:21:14 -07:00
Evan Rosky 58b9f701bf Merge "Changes to use new startTasks API" into sc-dev am: 5ecf5717b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13833147

Change-Id: I0c44645d555536c55bd5cf88253bf9d33a5ca154
2021-04-12 17:15:18 +00:00
Vinit Nayak b1bbc0f78d Changes to use new startTasks API
When shell transitions is enabled, this will use the
newer multi-task-launch api and control the animation.

There is no actual animation yet, this just adds the
infrastructure.

Bug: 182002789
Test: enable developer option and enter split via recents
Change-Id: If5be104a86e7b5f743f85efed20b0d2bf1b8bfd1
2021-04-09 12:09:28 -07:00
Vinit Nayak f2ca9076d1 Merge "Iterate over all swipeable regions when calculating quickswitch gesture bounds" into sc-dev am: 34148dc6b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14129535

Change-Id: Ibf73b13291a931bc91525741ca6268fcf9643ce6
2021-04-09 17:49:05 +00:00
Vinit Nayak 34148dc6b4 Merge "Iterate over all swipeable regions when calculating quickswitch gesture bounds" into sc-dev 2021-04-09 17:31:26 +00:00
Vinit Nayak 84b3ee4f28 Iterate over all swipeable regions when calculating quickswitch gesture bounds
Previously when creating a new CurrentDisplay, we would
never get the correct OrientationRectF from the hashmap
because the size field of CurrentDisplay would be incorrect
for a given rotation.
Ex. Rotation 0 and Rotation 1 would have inverted display sizes
Thus hashcode would return different values and we would only
ever see if a point is contained in the current rotation's
OrientationRectF.

Bug: 183897242
Test: Tested swiping from portrait to landscape app, was
able to swipe continuously

Change-Id: I6de625389956f55cfc2142dcb7aeef2e90c157ac
2021-04-09 17:31:15 +00:00
shawnlin 65b6cec480 Attached the navigation bar to app for launching from Launcher am: ffb976c404
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14031674

Change-Id: I34179afef340560360767322bd7e1150b2069fe5
2021-04-09 07:58:49 +00:00
shawnlin ffb976c404 Attached the navigation bar to app for launching from Launcher
- Play the nav bar fade-out animation at the same time when the app
  launching animation starts and make the fade-in animation ends at the
  same time when app launching animation ends.
- To make the nav bar fade-in animation looks like it's attached to the
  app, apply crop rect and translation that the app targets apply to the
  nav target.

Bug: 181638132
Test: manual: click app icon on launcher to launch an activity and
observe the navigation bar animation.

Change-Id: If7e610eca5fccbb747a76c87335a600b018195a6
2021-04-09 04:04:42 +00:00
Alex Chau 6622fa5a51 Merge "Calculate ClearAllButton's scroll offset after it's laid out" into sc-dev am: 21784eaf08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14112622

Change-Id: I2222de7a9d72fe0b276bb374735c1e22bb0180e4
2021-04-08 21:08:48 +00:00
Alex Chau f92128f177 Merge "Check showAsGrid when applying secondary translate on TaskViewSimulator" into sc-dev am: 6c01b3b088
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14113495

Change-Id: Ia60d2c2c118615d85adb78dcb1c8bc8b956ebf88
2021-04-08 21:06:34 +00:00
Alex Chau 21784eaf08 Merge "Calculate ClearAllButton's scroll offset after it's laid out" into sc-dev 2021-04-08 20:44:45 +00:00
Alex Chau 5fee81233b Calculate ClearAllButton's scroll offset after it's laid out
- ClearAllButton's width is 0 before it's laid out, making the calcualtion incorrect

Bug: 184570027
Test: Restart device or change screen size, ClearAllButton is in correct position
Change-Id: I2cefccbe18925cb3d9dac705b333400639b7049e
2021-04-08 17:22:12 +00:00
Alex Chau f7df816a8a Check showAsGrid when applying secondary translate on TaskViewSimulator
Bug: 184566209
Test: manual
Change-Id: I53d78553a67c8cd056a9cafad0f163e2c6401550
2021-04-08 17:21:58 +00:00
Winson Chung 3b85860fb2 Merge "Reset force-minimized split state when in live tile mode" into sc-dev am: 01b5d5e332
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14098020

Change-Id: Iae66943d109331cf277efdacc730bd9064a49ee4
2021-04-08 17:04:02 +00:00
Winson Chung 01b5d5e332 Merge "Reset force-minimized split state when in live tile mode" into sc-dev 2021-04-08 16:30:28 +00:00
TreeHugger Robot b3dfb3cb8f Merge "Some cleanup in RecentsView" into sc-dev am: 63c169561c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14106036

Change-Id: I90749bc0c39124e4d2be5af93ba4a11ab4ae386c
2021-04-07 21:10:54 +00:00
TreeHugger Robot 63c169561c Merge "Some cleanup in RecentsView" into sc-dev 2021-04-07 21:06:55 +00:00
Sunny Goyal c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
Winson Chung fc540e8be1 Merge "Fix noisy log from sysui flag changes" into sc-dev am: 7cf7c31e46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14098021

Change-Id: I67ff6c8c39d6ba579e7b3c7186ebde4f92950a39
2021-04-06 22:23:43 +00:00
Tony Wickham 0fa98f86fb Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev am: 029e930751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14103181

Change-Id: I6d871e1715644325455c5e6a4a635c17ca21d44e
2021-04-06 22:23:37 +00:00
Winson Chung 7cf7c31e46 Merge "Fix noisy log from sysui flag changes" into sc-dev 2021-04-06 21:48:43 +00:00
Tony Wickham 029e930751 Merge "Consolidate two different onTransitionCancelled implementations" into sc-dev 2021-04-06 21:44:53 +00:00
TreeHugger Robot e3f96639fc Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev am: c07ad47255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14104581

Change-Id: Idee949dd793e04b5b9416e52ba00151ac0281e56
2021-04-06 21:30:10 +00:00
TreeHugger Robot c07ad47255 Merge "Fix HINT_STATE not tracking the entire height of the screen" into sc-dev 2021-04-06 20:58:26 +00:00
Tony Wickham 655bf5ade9 Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev am: fc3bc6098f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094841

Change-Id: I216a2a826d6d6d2ddc1c2bfebf4e764bd43d2981
2021-04-06 20:34:02 +00:00
Tony Wickham d054d06099 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev am: 0b0c173ec0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096849

Change-Id: Icf9a904ddc34a8a474fdaad94de9b247ce16f3c5
2021-04-06 20:32:24 +00:00
Tony Wickham fc3bc6098f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev 2021-04-06 19:37:18 +00:00
Tony Wickham 0b0c173ec0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev 2021-04-06 19:35:38 +00:00
Tony Wickham b77fa8da52 Consolidate two different onTransitionCancelled implementations
There was previously two different onTransitionCancelled(), one in
BaseActivityInterface and one in AnimationFactory. They are pretty
similar and the differences seem subtle and not necessary. In this
bug, the AnimationFactory version was going to mStartState instead
of StateManager#getRestState() (which is the same, unless mStartState
disables restore). Instead, always use the mActivityInterface
implemenation, which seems more robust.

Test: Open app A, open app B, quick switch from B to A, swipe home
during that transition, then touch nav region during home transtion;
ensure we don't goToState(BACKGROUND_APP) in the subsequent
onTransitionCanceled().

Fixes: 184583037

Change-Id: I315a5087b12413d88c3ccc1e3245a55a76a73e62
2021-04-06 12:16:00 -07:00
Tony Wickham 721a89d93a Merge "Cleanup taskbar touchableInsets" into sc-dev am: c9846dc6e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096731

Change-Id: I5331b56137d960f1d5eea3622e8255bcf5f64937
2021-04-06 19:08:24 +00:00
Tony Wickham c9846dc6e7 Merge "Cleanup taskbar touchableInsets" into sc-dev 2021-04-06 18:36:05 +00:00
Samuel Fufa 06702c00b9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev am: 50c6a37ea9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14102304

Change-Id: I7e4b49d72b7d4fadacaeba5a372b0305908c34aa
2021-04-06 17:57:57 +00:00
Zak Cohen be66b43c9f Merge "Overview - update Clear All and Empty message drawing" into sc-dev am: fd9af2f017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14096074

Change-Id: I8cef2fa1301f7faa0e70a12978da3724aaa7397d
2021-04-06 17:57:52 +00:00
Samuel Fufa 50c6a37ea9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev 2021-04-06 17:56:51 +00:00
Zak Cohen fd9af2f017 Merge "Overview - update Clear All and Empty message drawing" into sc-dev 2021-04-06 17:42:05 +00:00
Tony Wickham fbdb50aa48 Fix HINT_STATE not tracking the entire height of the screen
Explicitly use DeviceProfile#heightPx instead of getShiftRange(),
which might be less depending on AllAppsTransitionController

Test: swipe up from bottom on home, ensure workspace scales down
as the gesture goes all the way to the top of the screen

Change-Id: I9c2988d361c22d437c7eb9bea8ed715d06054c59
2021-04-06 10:09:44 -07:00
Samuel Fufa 5461089baa [Search][Layout] Fix blank space when predictions are disabled
This regression is caused due to getExpectedHeight relying on view visibility state while AlphaUpdateListener.updateVisibility was reseting the views visibility.

Bug: 184211402
Test: local
Change-Id: Ib756f5eb8f6356a18a025626008b97fd7c77fec9
2021-04-06 04:05:20 -05:00
TreeHugger Robot 18210721e7 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev am: ce271c1067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094674

Change-Id: Ib625be5cb0a041e476bc84cc9097d0e7367daa7c
2021-04-06 06:49:45 +00:00
TreeHugger Robot ce271c1067 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev 2021-04-06 06:18:56 +00:00
Winson Chung 7700bffc47 Fix noisy log from sysui flag changes
Bug: 144854916
Test: Logcat after sysui flag changes, ensure no tracing change logs
Change-Id: I36b6b71bae08303787508ab6eb63ca989866370c
2021-04-06 04:38:03 +00:00
Winson Chung 27d9a92a44 Reset force-minimized split state when in live tile mode
Bug: 184233556
Test: Enter split, go home, launch same task by tapping or swiping
Change-Id: Ied2d56f087e5c05f5f7c4b19428f8088edf4e599
2021-04-05 21:19:25 -07:00
TreeHugger Robot e508dd17a8 Merge "Add split placeholder view above OverviewScrim" into sc-dev am: e77fc9cc25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14094826

Change-Id: I38e33d134b4a7727431d87932ec1716e02c8cedb
2021-04-06 03:15:42 +00:00
TreeHugger Robot e77fc9cc25 Merge "Add split placeholder view above OverviewScrim" into sc-dev 2021-04-06 02:34:19 +00:00
Tony Wickham 9f436dfe8e Ensure taskbar animation ends when running window animation does
- Store the possible parallel animation to cancel/end in
  AbsSwipeUpHandler#endRunningWindowAnim()

Test: 1. remove taskbar during transition, ensure cleaned up properly
2. open a second app during transition to home, ensure taskbar
maintains correct visibility
Bug: 182512211

Change-Id: I71a6b6ce624113d43ad5a599cb5cfec28a555310
2021-04-05 17:52:38 -07:00
Tony Wickham e13a4a4475 Cleanup taskbar touchableInsets
- Remove obsolete visibleInsets hack and isDraggingItem() check
- Have TaskbarController determine whether taskbar is touchable,
  rather than TaskbarContainerView.
- Disallow touches during transition to home (can potentially
  improve this later)

Test: Swupe home, tap taskbar folder during transition, ensure
don't end up in broken state with the uninteractable folder open
Bug: 182512211

Change-Id: Id625ce8b9b876a8a1b450b7d6fb771540e23bc08
2021-04-05 17:33:44 -07:00
Zak Cohen 23b7fea6eb Overview - update Clear All and Empty message drawing
Update Clear All and Empty message to use primary color, not workspace
color, as they are drawn on floating background now, not wallpaper.

Bug: 184260454
Fixes: 184260454
Test: local build, flash and run
Change-Id: Ie8ef4b7ace3053c2068a27b7cbedbbb039fc36d8
2021-04-05 23:45:02 +00:00
Tony Wickham 6a74e65953 Explicitly set which taskbar view is visible at each caller
This makes it more clear which taskbar view is expected for particular
code flows. Also makes it easier to set it to null in cleanup().

Test: call cleanup() while taskbarOnHome is invisible, ensure hotseat
icons go back to being visible
Bug: 182512211
Fixes: 183633496

Change-Id: I680a15582c8034a049b20e035b4d54f5ea5aee04
2021-04-05 16:42:17 -07:00
Becky Qiu 41e66d7deb Merge "Shared element transition between image and sharesheet." into sc-dev am: 9b85dc836d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13926966

Change-Id: Ia460de836ff797d724d1996e9f138e86f01d6649
2021-04-05 22:57:36 +00:00