Commit Graph

733 Commits

Author SHA1 Message Date
Sunny Goyal cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Sunny Goyal 7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Schneider Victor-tulias 19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Schneider Victor-tulias ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
TreeHugger Robot 859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00
Anushree Ganjam 1373c90087 Remove @WorkerThread annotation and Preconditions.assertWorkerThread check. am: f781ef81bf am: 82f0aaa1d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23566433

Change-Id: Iddd70c0bfbe2dae1653d5a9e4348f4751841705f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 22:33:38 +00:00
Anushree Ganjam f781ef81bf Remove @WorkerThread annotation and Preconditions.assertWorkerThread check.
`BaseLauncherBinder.bindAllApps` and `BaseModelUpdateTask.bindApplicationsIfNeeded` can be called on both UI and Background thread.

Bug: 285711446
Test: Manual
Flags: NA
Change-Id: If6f6cce5f6e37fb21609aded8587afbdffda7545
2023-06-05 19:06:00 +00:00
Sunny Goyal 6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
TreeHugger Robot 3b7285f61c Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev am: 4ad5ffd0a1 am: ef529447b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537958

Change-Id: I774fa87ee58d684ab27114a68354ffd42538077c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 20:26:50 +00:00
TreeHugger Robot 4ad5ffd0a1 Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev 2023-06-02 18:59:47 +00:00
Vadim Tryshev d8b470cf2f Revert "Adding tracing for workspace loading that never finishes"
This reverts commit 80bb8a12da.

Reason for revert: Cleanup after the bug is fixed. Tracing is not necessary anymore.

Change-Id: I1bb2bc59dd5debb51b094f14430cd18a203ed33c
2023-06-02 15:28:18 +00:00
Sunny Goyal ee9740462e Simplifying some test utility methods
Bug: 283821111
Test: Presubmit
Flag: N/A
Change-Id: I7b9690bc0cc53d097d26cd4f0ab2dd36ba88e1cb
2023-06-02 13:30:55 +00:00
Santiago Aboy Solanes 0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Vinit Nayak c2545b82cc Merge "Add logs for launcher user cache" into udc-dev am: 43c79d23b3 am: d7037d07e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23523872

Change-Id: I5a512981f5776174f079dca8b81fc3e3fe069a83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 04:24:56 +00:00
Vinit Nayak 43c79d23b3 Merge "Add logs for launcher user cache" into udc-dev 2023-06-02 02:57:40 +00:00
Anushree Ganjam 87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00
Vinit Nayak 134e429189 Add logs for launcher user cache
Bug: 243688989
Flag: None
Change-Id: I6f6ea3f3326c1814c2a50863e9bfbcb7e4323ae8
2023-06-01 17:11:42 -07:00
Anushree Ganjam 97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
TreeHugger Robot 7ae39b1bee Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev am: 78b6e76486 am: dcf359c459
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455279

Change-Id: I0409212df4be2e1554a6a489c65453d65e9e78c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 19:02:32 +00:00
TreeHugger Robot 78b6e76486 Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev 2023-05-30 17:26:53 +00:00
Vinit Nayak 2c353f29a2 Add logs to see if launcher model isn't loaded when work profile app is added
* Add helper method to avoid checking sDebugTracing when
logging for tests

Bug: 243688989
Flag: None
Change-Id: Id6cc3b286171eb598e593c5a8aaea6f2466aad60
2023-05-26 15:45:42 -07:00
Vadim Tryshev ecbad7a0d9 Merge "Adding tracing for workspace loading that never finishes" into udc-dev am: 8cf338148b am: 304ecb6f24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23414622

Change-Id: I0aedfb1de537ea8bf56ecc69a6920bf649b4b88d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 18:41:38 +00:00
vadimt 80bb8a12da Adding tracing for workspace loading that never finishes
Test: presubmit
Bug: 267200150
Flag: N/A
Change-Id: I6cfe6be101412e9d8d9498fc06c70d1d14561441
2023-05-24 10:25:15 -07:00
Sunny Goyal e274d97fe5 Removing support for lagacy shortcuts
> Addition/removal of  shortcus is already removed. This just
  cleans up the unused code path

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I8ab7f57b693f996920e50e8beecafcffab5167e9
2023-05-17 09:20:45 -07:00
Stefan Andonian 9d7bffe37b Fix NPE in LauncherPreviewRenderer.
The LauncherBinder is null in LauncherPreviewRenderer, which was
causing an NPE in LoaderTask.

Bug: 279347305
Test: Used logs to verify that the LauncherPreviewRenderer was actually
loading using the LoaderTask. Most of the time, it does not, so that is
why I didn't catch this before pushing it.

Change-Id: Ic5b45abfdeb73a4bbe1f521ae4d627b6cfcfec54
2023-05-15 22:41:04 +00:00
Sunny Goyal 7bc6cdee56 Revert "Revert "Revert "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""""""
This reverts commit 09905cfa90.

Reason for revert: Fixed the crashing issue

Change-Id: Ibcfc28a89356d262e67e8842d6bae37e230a70f5
2023-05-13 01:59:19 -07:00
Vinit Nayak 88a91bbd16 Add logs to check which userId is used for workProfile matcher
Flag: none
Test: compiles
Bug: 243688989
Change-Id: I0a579203cc0c51f7707180b323ed4828f1dea297
2023-05-11 14:55:00 -07:00
Sunny Goyal 356aa61fe4 Merge "Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""" into udc-dev 2023-05-06 18:19:13 +00:00
Sunny Goyal 3772b246c2 Revert "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly"""
This reverts commit 8d9e468dbb.

Reason for revert: b/281179368

Change-Id: Ibfc5329f72cdbcb37d01a8bf3dac2ba0724b9faf
2023-05-06 18:18:07 +00:00
Sunny Goyal 2185f6f420 Loading widget description on the background thread
Bug: 281074741
Test: Varified on device
Flag: N/A
Change-Id: I6b9b13e712534bdc582b98dbfb7bdfcc40d2f19d
2023-05-05 23:15:41 +00:00
Sunny Goyal 8d9e468dbb Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""
This reverts commit 30bb3a247a.

Reason for revert: Fixed original issue

Change-Id: I02d85d604631795d96f0379eb94b7b6789102ea9
2023-05-05 16:00:49 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Sunny Goyal 9ef41413e0 Changing GridMigrationTask to use ModelDbController directly
instead of using content uris

Bug: 277345535
Test: Updated tests
Flag: Presubmit
Change-Id: Ib62db3334c01d9e7d27ae7b02ea703d046e2bcaa
2023-05-03 08:54:14 -07:00
Fengjiang Li 5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Schneider Victor-tulias 8c1bffb24f Merge "Remove unused debug logs" into udc-dev 2023-04-27 17:44:42 +00:00
Vinit Nayak 6106ae9ac7 Add logs for PackageUpdatedTask
* That's the bit that updates new packages for work profile,
at least from command line.
* There is variability in how long it could take work profile
apps to show up, from 2-8 seconds.

Bug: 243688989
Change-Id: I710befc5f17b4a16bff523eb03f1e88975cafd43
2023-04-26 13:21:57 -07:00
Schneider Victor-tulias fff7cef9f1 Remove unused debug logs
Removing debug logs for bugs that have already been closed. These logs are filling up the logcat buffer and impeding in other test investigations.

Flag: not needed
Test: Tapl tests
Bug: 260260325
Change-Id: I4d69b904f2ea79d758cf6bef7d90d172f2eb2a91
2023-04-25 11:00:37 -07:00
Jeremy Sim 6e0f34cc0a Merge "App Pairs (behind flag): Add new ItemInfo types and DB save functionality" into udc-dev 2023-04-22 03:21:17 +00:00
Jeremy Sim 7cf0dd9e03 App Pairs (behind flag): Add new ItemInfo types and DB save functionality
This is the second of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- AppPairsController, a new controller that will handle creation, launching, and deletion of app pairs
- ITEM_TYPE_APP_PAIR is a new type of FolderInfo (FolderInfo now can be either a folder or an app pair, and should probably be renamed to CollectionInfo or something more generic in future)
- Necessary plumbing for these new types
- Database code that handles saving a new app pair to the database with the correct schema

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: Not included in this CL, but will follow
Change-Id: Ie3aefd4eb9171f471789f54876de742849d3013b
2023-04-21 14:23:54 -07:00
Vinit Nayak b642666e72 Merge "Add logs for work tab missing" into udc-dev 2023-04-19 03:34:39 +00:00
Vinit Nayak f89438718f Add logs for work tab missing
* Start tracing where launcher goes after
it gets the broadcast for new work profile user
unlocked

Bug: 243688989
Flag: None
Change-Id: I53ccab743ac5dd2aee6b7ff6e440bcf731387119
2023-04-18 13:57:33 -07:00
Sunny Goyal ce953a36ec Moving ModelDbController from LauncehrProvider to LauncherModel
Migrating some of the class to use the controller directly, will
update the remaining calls in follow up cls

Bug: 277345535
Test: Presubmit
Change-Id: I8edc7c43665f94702ac64bd92932d6c94cb544a4
2023-04-14 14:13:17 -07:00
Sunny Goyal 348e518b2c Merge "Using a runtime generated layout for tests instead of defining xml" into udc-dev 2023-04-14 18:12:57 +00:00
Sunny Goyal ab2f808196 Using a runtime generated layout for tests instead of defining xml
This allows support for easily setting up default layouts

Bug: 277345535
Test: Presubmit
Flag: N/A
Change-Id: I1c089d60ac3f8add8d7e1060d343e04d30afe094
2023-04-12 22:54:14 +00:00
Sunny Goyal eb27546cc3 Removing remaining code around ENABLE_DATABASE_RESTORE
ENABLE_DATABASE_RESTORE feature is already removed
Also migrating some tests from BackupRestoreTest to RestoreDbTaskTest

Bug: 270392706
Test: Presubmit
Flag: N/A
Change-Id: I71822bbc2232008b3d2b4b9fbed0db5d889591e4
2023-04-12 15:52:35 -07:00
Sunny Goyal 1ae46ca868 Moving all DB management logic from LauncherProvider into a separate class
This would make it easier to move the controller to LauncherModel

Bug: 277345535
Test: Presubmit
Flag: N/A
Change-Id: I4d044cf41361f400968ef65e18de5d3976fcdec7
2023-04-11 11:46:40 -07:00
Sunny Goyal 84b48d8deb Removing support for adding legacy shortcuts.
All existing legacy shortcuts will be migrated one-time to deep shortcuts
This shortcuts are pinned under the Launcher package, with custom badging

Bug: 275875209
Test: Updated unit tests
Flag: N/A
Change-Id: I7da001f724776ad8d6c807517b7e4e259de626c2
2023-04-10 12:28:52 -07:00