Commit Graph

7970 Commits

Author SHA1 Message Date
Fedor Kudasov 49e414974e Merge "Separate getTaskViewAt usage" into sc-v2-dev am: d6a28fe202
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16337818

Change-Id: Ie381041d35bf45041eaa919ff43e326bdeb2bea4
2021-12-01 10:22:10 +00:00
Fedor Kudasov d6a28fe202 Merge "Separate getTaskViewAt usage" into sc-v2-dev 2021-12-01 10:08:06 +00:00
TreeHugger Robot 89fe31ef0e Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev am: f7518d42eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346762

Change-Id: I43fd2aa6994d99dca448116c2dd22ccf66b98e2f
2021-12-01 06:49:57 +00:00
TreeHugger Robot f7518d42eb Merge "Schedule OverviewCommandHelper callbacks for GroupedTaskView" into sc-v2-dev 2021-12-01 06:35:35 +00:00
Vinit Nayak b3f069e06c Merge "Add task unpinning support for 3 button taskbar" into sc-v2-dev am: f198f6e492
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16339859

Change-Id: Id2c29bdcbc43f6e2f556a2b43f882c4dc24ec3e9
2021-12-01 04:49:31 +00:00
Vinit Nayak f198f6e492 Merge "Add task unpinning support for 3 button taskbar" into sc-v2-dev 2021-12-01 04:34:06 +00:00
Vinit Nayak 09a822a6fe Schedule OverviewCommandHelper callbacks for GroupedTaskView
* Schedule runnables to clear pending queue in
OverviewCommandHelper similar to how TaskView does it.
* End callbacks get run when recents animation finishes in
RecentsView in the case of live tile when recents animation
is still running
OR
in directly when the split remote animation finishes

Bug: 207845542
Change-Id: I7e858ce55b08cde6436d44f2e857e28b73458f0b
2021-11-30 20:18:50 -08:00
Vinit Nayak 570653346f Add task unpinning support for 3 button taskbar
Bug: 199544447
Test: Tested on small and large screen
Change-Id: Ib7785992ef11825cd07a929e2cb623d02ef246f1
2021-11-30 17:18:09 -08:00
TreeHugger Robot e9dcc967cc Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev am: 96f3f2214c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16367281

Change-Id: Iaee380e7e3ee610f0d06cbb001bf45f18c945ee6
2021-12-01 00:54:57 +00:00
TreeHugger Robot 96f3f2214c Merge "Fix potential memory leak by setting mControllers = null" into sc-v2-dev 2021-12-01 00:49:56 +00:00
Jerry Chang b1b74d4f63 Merge "Remove stage type from split screen APIs" into sc-v2-dev am: 36eb818600
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16362386

Change-Id: I8018b5bb70324bcaed607d12acb0a625df2e0419
2021-12-01 00:48:34 +00:00
Tracy Zhou 844759496d [DO NOT MERGE] Make the cutout slightly smaller am: bb594548bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16360612

Change-Id: I188f12654814e0fed060dd1156638c4088ea9138
2021-12-01 00:48:21 +00:00
Jerry Chang 36eb818600 Merge "Remove stage type from split screen APIs" into sc-v2-dev 2021-12-01 00:41:10 +00:00
Tracy Zhou d1f9fde371 Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-v2-dev 2021-12-01 00:34:00 +00:00
Tony Wickham f6c28a4381 Fix potential memory leak by setting mControllers = null
Test: N/A
Bug: 202511986
Change-Id: Iad7cc89e0e68ce09ebe4ca3ab89392b50b6a82c7
2021-11-30 14:37:36 -08:00
TreeHugger Robot 7684d31b8e Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev am: b78cbf29e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16331687

Change-Id: I45caaafe38fcb82c4ca4a924ad6b374fe6493d0e
2021-11-30 20:32:35 +00:00
TreeHugger Robot b78cbf29e5 Merge "Possible fix for NullPointerException b/206040100." into sc-v2-dev 2021-11-30 19:58:24 +00:00
TreeHugger Robot a9e6748ea4 Merge "Close task menu scrim when pressing home button" into sc-v2-dev am: 2280f3d5fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365179

Change-Id: I8620705d35fed5313032606d3df095a13110da6a
2021-11-30 19:22:52 +00:00
Sebastian Franco 8afeba605a Possible fix for NullPointerException b/206040100.
There is a NullPointerException when trying to get the
length of the array.

Test: Manually tested
Fix: 206040100
Change-Id: I69a03fd3658094655eaf97fa21039fd373ee37d5
2021-11-30 10:09:02 -06:00
Alex Chau a8fc7e03fd Close task menu scrim when pressing home button
- Generally close all floating view when starting home from Recents

Bug: 193432925
Test: with 3 button, open task menu, then press home
Change-Id: Ic99c50333c797f222fc8e682fd0f3fcc4d641d47
2021-11-30 14:27:36 +00:00
Jerry Chang 8176366f54 Remove stage type from split screen APIs
Bug: 198438631
Test: manual check
Change-Id: Ic4f41e39013e4d49585da4cda9b28151c549357a
2021-11-30 17:15:40 +08:00
Tracy Zhou 2862aecc40 Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev am: 260b90c7ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16360392

Change-Id: I708bb79bba4ffb0f7945ce537ecdf6e7a3088ee9
2021-11-30 04:55:58 +00:00
Tracy Zhou 260b90c7ad Merge "Reset live tile params along with resetTaskVisuals" into sc-v2-dev 2021-11-30 04:41:40 +00:00
Adam Bookatz 2dc067bd88 Merge "Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"" into sc-v2-dev am: cbafa6803b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16360447

Change-Id: I898cd74ea9ea335c0a4e2546f79081f52183c229
2021-11-30 03:55:51 +00:00
Adam Bookatz cbafa6803b Merge "Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"" into sc-v2-dev 2021-11-30 03:44:30 +00:00
Tracy Zhou bb594548bb [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Since we reverted the z order back (launcher on top), we should apply this fix from S and find a proper solution in T

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
(cherry picked from commit 26f47c711a)
2021-11-30 01:01:59 +00:00
Tracy Zhou a56dc760dd Reset live tile params along with resetTaskVisuals
The dismissal animation doesn't return the translationY to 0, but resetTaskVisuals does.

Fixes: 207782306
Test: Drag live tile to dismiss lightly so it doesn't succeed. When it comes back, make sure it matches the cutout.
Change-Id: I64ee06ad72c403ab4fdd4671d08b1843a3e89253
2021-11-30 00:49:02 +00:00
Adam Bookatz 3d34f94784 Revert "Fix issue with Shell listeners being unbound if SysUI is restarted"
This reverts commit 34e384d2e1.

Reason for revert: Multiuser performance (b/208276322)

Change-Id: Icd27ab3095c446895360f8e2faa7f9c92ab2cf01
Bug: 208276322
2021-11-30 00:19:05 +00:00
TreeHugger Robot 6b45ff77e8 Merge "Handle configuration changes in floating rotation button" into sc-v2-dev am: ed05712f04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343605

Change-Id: I6d2ca3c480f2676cc3bc595eecfa007920b76b09
2021-11-29 19:58:51 +00:00
TreeHugger Robot ed05712f04 Merge "Handle configuration changes in floating rotation button" into sc-v2-dev 2021-11-29 19:41:26 +00:00
Nick Chameyev 732e8c59ef Merge "Add WRITE_SECURE_SETTINGS permission to Launcher" into sc-v2-dev am: ed6b29f211
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16357461

Change-Id: Ia0786eae631029c321768ccf0f847ad6662a0ad7
2021-11-29 17:33:06 +00:00
Nick Chameyev ed6b29f211 Merge "Add WRITE_SECURE_SETTINGS permission to Launcher" into sc-v2-dev 2021-11-29 17:14:09 +00:00
Nick Chameyev c52ec89e1b Add WRITE_SECURE_SETTINGS permission to Launcher
We reused a code that handles rotation suggestion button
from SysUI in Launcher. It requires WRITE_SECURE_SETTINGS
permission to write how many times we have shown this button
to show ripple only the first 3 times.
AOSP Launcher didn't have this permission and it was crashing.

Bug: 205491152
Test: tap on rotation suggestion button when in AOSP launcher
Change-Id: I216abb86d43cc505aec1ff581c1f332ae3ad0db4
2021-11-29 12:21:35 +00:00
TreeHugger Robot b73701ad92 Merge "Resets taskSplitTranslation of inactive orientation" into sc-v2-dev am: c5f18aa980
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343601

Change-Id: I5f776fdd999a6cbbd85977ad978d871f9cbc2a82
2021-11-26 18:41:37 +00:00
TreeHugger Robot c5f18aa980 Merge "Resets taskSplitTranslation of inactive orientation" into sc-v2-dev 2021-11-26 18:23:43 +00:00
Alex Chau 9a5f99bfe6 Resets taskSplitTranslation of inactive orientation
Fix: 204185003
Test: manual

Change-Id: I10e49994e8a9723f39d7f9159de7c1f8216ea77f
2021-11-26 12:04:47 +00:00
Nick Chameyev 71eed5ca35 Handle configuration changes in floating rotation button
Update resources in floating rotation button
when configurations such as screen density, screen size,
current locale have changed.

Bug: 200103245
Test: change display size, locale, fold/unfold
 -> check that floating rotation button resources
    are updated
Change-Id: Ia69f4f8b393a686012e286a1e39822650c562d52
2021-11-26 11:38:28 +00:00
Jerry Chang 925b1c3fca Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev am: 71b7d1537d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16331944

Change-Id: Ibcfb68a698f52a1efcc45088e5db42b48b17e79e
2021-11-26 05:56:03 +00:00
Jerry Chang 71b7d1537d Merge "Support to launch app pair from overview with recorded split ratio." into sc-v2-dev 2021-11-26 05:43:34 +00:00
Alex Chau 1dc16efaf1 Merge "Use alternative way to fix split select page snapping issue" into sc-v2-dev am: eace1ba76d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16343354

Change-Id: I161e62e6fbd34fda5e052381a4db765628ccb314
2021-11-25 19:31:17 +00:00
Alex Chau b3a9386556 Use alternative way to fix split select page snapping issue
- Reverted to before ag/16095449 where reset() is called after state transition completed
- Call pageBeginTransition in dismiss animation to make sure onPageEndTransition is triggered to clear mCurrentPageScrollDiff properly
- Fixed a condition in resetFromSplitSelectionState ot use DeviceProfile.overviewShowAsGrid, as when state is in transition, showAsGrid() would be false

Fix: 207744890
Test: manual
Change-Id: I5a812a7ee26df2f953f7fed0155880620d2c4e66
2021-11-25 16:48:39 +00:00
TreeHugger Robot cfa85344b4 Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev am: 32ebd9f94f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307859

Change-Id: I5a771299623f3c838aef76c5a6b6bf3ac4a850c4
2021-11-25 04:16:57 +00:00
TreeHugger Robot 32ebd9f94f Merge "Fix ClassCastException in QuickstepModelDelegate" into sc-v2-dev 2021-11-25 04:00:37 +00:00
Jerry Chang 279c3b7fa2 Support to launch app pair from overview with recorded split ratio.
Bug: 207479945
Test: Quickswitch back to app pair keep split ratio
Change-Id: Id24195c15fe59053cc51515a942f72c3b8e87ba7
2021-11-25 11:38:14 +08:00
TreeHugger Robot f9aec4c708 Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev am: 79132556f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16336335

Change-Id: If250e156ef4e6b3d568793aeddef14586fd34883
2021-11-25 00:23:05 +00:00
TreeHugger Robot 79132556f7 Merge "Add TaskbarControllers#runAfterInit()" into sc-v2-dev 2021-11-25 00:08:08 +00:00
Tony Wickham a143500a69 Add TaskbarControllers#runAfterInit()
And use it in TaskbarModelCallbacks#commitItemsToUI(), which in rare cases can run during init() before other controllers (namely TaskbarStashController) have been initialized.

Test: call commitItemsToUI() in TaskbarModelCallbacks#init(), ensure no crash
Fixes: 204847702
Change-Id: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
Merged-In: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
2021-11-24 23:14:06 +00:00
Schneider Victor-tulias 380f8fd890 Fix ClassCastException in QuickstepModelDelegate
- Added a casting check as an immediate fix to b/173838775
- Added logging to help debug the corrupt state where an item of type other than FolderInfo is used as an other item's container.
- Added LoaderMemoryLogger for adding large logs that are only conditionally printed.

Bug: 173838775
Test: manually checked logs
Change-Id: I9491cb421b9fb807d5fb110b04ad069481de768f
2021-11-24 14:26:45 -08:00
Fedor Kudasov 4e678ff6d5 Separate getTaskViewAt usage
getTaskViewAt is used in two different contexts with different
assumptions:
1. In the context of iterating over the all TaskViews, where
the valid tasks indices are know.
2. In the context of requesting some TaskView by index, where
the caller expects null when the input index is invalid.
The nullability status of the method differs in these contexts
and therefore getTaskViewAt usage can be separated into two
different methods.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I42c04c115c309f1849f9dfbb05c74b9b080acf13
(cherry picked from commit 4da3b4bddd)
2021-11-24 21:19:22 +00:00
Alex Chau 07cbd6659f Merge "Consider two panel in home to overview transition" into sc-v2-dev am: 376b09ade2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330826

Change-Id: I9815176bc3421af44e56914020fc4fb613294ddf
2021-11-24 20:47:48 +00:00