When continuing a gesture during quick switch, we cancel the
previous animation but don't invalidate it (since the gesture
isn't fully finished), and the new gesture handler calls
mRecentsView.setOnPageTransitionEndCallback(), so the previous
handler will never get STATE_RECENTS_SCROLLING_FINISHED. Thus,
continueComputingRecentsScrollIfNecessary() will never end.
To fix this, also check !mCanceled, since that is set when
continuing the gesture. Also use postOnAnimation() instead of
post() since that has better guarantees that the next
computation will wait for the next animation frame, rather
than whenever the message queue is available, which might
happen too frequently.
Test: quick switch from A to B and back to A before settling
on B, ensure we stop calling computeScroll().
Bug: 153589287
Change-Id: I6b4389ef2cf5a818438c7ae36d8807b3e41c8501
Originally touching on the empty space would bring user back to homescreen. We will disable this for select mode.
Test: local
Bug: 154531538
Change-Id: Iee3780755fc2c32682ea0fa039ca5822a95fce2c
- Separate the calls to minimize split and to update the flags (we only
want to minimize in split when swiping up, but we want to update the
flags when quickswitching as well)
Bug: 155410195
Change-Id: I56308cc0fbaa8a855383012738f129671d72feff
- We currently end up using the launcher insets when swiping
up into overview due to how we scale the target rect to
the source bounds, but the thumbnail crop is calculated
only from the task thumbnail insets. For apps that are
letterboxed, this results in a jump after the transition
completes when we crop too far (including the letterbox)
and end up showing the task background.
For now, since we are just cropping by the launcher
insets, we can also take the min of those and the
thumbnail insets to calculate the thumbnail view crop.
Bug: 151770104
Test: Test swiping up with a normal app, a letterboxed app
(like authenticator), an app that has no insets (like
Change-Id: I08342b19c54f9078be4613fca9024e2558403bc9
> Removing 'Launcher' as parameter from state methods called by StateManager
> Converting state properties to methods for easier abstraction
> Moving state handling drom state definition to activity class
Change-Id: I997627df606a7e0bb3bf32688d045a942a47fc94
> Fixing scale up calculator for swipe-down
> Offsetting pivot so that the preview is aligned to bottom-right
> Allowing insets to be available in multi-window mode as well
> Offsetting taskViewSimulator appropriately in multi-window mode
Change-Id: I7da4c145efca72ef219a5ffcaf23d726812df270
Was able to repo the bug reliably when calling cancel() and
end() immediately after starting the StaggeredWorkspaceAnim.
Bug: 153584267
Change-Id: I954d38ad69e72a83535f4dd1ec21dba0f61a3cfb
The rect we passed in was in screen space to match the window, but needs to be
be local to launcher.
Also updated code/comments to make it more readable.
Note that the bounds of the targets being off is a separate issue b/153581126
Bug: 135195169
Change-Id: I4a8c0aa2f504bdf69342a927725cd440fb324a36
We don't clear state on EdgeBackGestureHandler
when we go to Recents or Home.
A more robust solution is in the works with
WM team and will probably be built on top of this.
Needs ag/11273364 to work.
Bug: 154580671
Test: Launch app directly in landscape,
should be able to swipe home on first try.
Change-Id: Ia4c685e16645d0237f278a611f6c61f252f3b79c
This still shows up a bit strange with
notched phones because we are using
RecentsView padding to give ClearAll the
right amount of spacing. However, we're only
adding padding to the left and right and not
the top/bottom.
That's captured here: b/154436527
Fixes: 150389833
Test: Tested landscape/portrait/seascape
launcher, w/ RTL as well
Change-Id: I49defd58048e609a1f7a821abb97374bcbb94b9f
Prevent extra IPC calls when checking for
multiWindowMode by using existing DeviceProfile.
This might be made irrelevant by b/142282126
Fixes: 149571513
Change-Id: Ia41cbfd56c67dd78f4d9c10bf1469d0d2a9e581d
Disable overview rotation in 2-Button
until we can figure out the correct
transition/animation.
TODO: b/154665738
Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.
Change-Id: Ib67906b11e24def870a39f57b5156e29db258fd7
Fixes: 154955192, 150958400
Test: Switched from gesture nav to 3 button,
was no longer able to swipe up
Change-Id: Icc7b27eb7bd1eb5ddf25d7e7c3464a77a3a88f24
Tony Wickham
TreeHugger Robot
Becky Qiu
Sunny Goyal
Winson Chung
thiruram
Zak Cohen
Lucas Dupin
Vinit Nayak
Jonathan Miranda
Sreyas
Bill Yi