Commit Graph

47938 Commits

Author SHA1 Message Date
Tony Wickham 8dedf2f6bc Merge "Fix taskbar being empty" into sc-v2-dev am: 0e0e1cef09
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16439570

Change-Id: I35766ede95fe4e73c883f7a187a23ba109ccb811
2021-12-10 22:30:02 +00:00
Tony Wickham 0e0e1cef09 Merge "Fix taskbar being empty" into sc-v2-dev 2021-12-10 22:11:17 +00:00
Alex Chau ab26c62c4a Allow restore across form factors
- Removed deviceTypeCompatible check and allow restore across for mfactors
- In AOSP default device_profile, mark 3x3, 4x4, and 5x5 as phone only. On tablets they'll reflow to 6x5.

Bug: 198575341
Bug: 210129187
Test: Only 3x3, 4x4 and 5x5 are enabled on phone
Test: Only 6x5 is enabled on tablet
Test: Phone backup of 4x4 get restored and reflow to 6x5 on tablet
Change-Id: I36a641d47fcee86ace0fea3d9194d61d12517f13
2021-12-10 22:00:49 +00:00
Jon Miranda 0c2f0faef1 Display in-memory icon for app close while AdaptiveIcon loads.
- We already display the BubbleTextView icon during app close
  since we need the shadows to ensure a clean handoff.
- Previously, we waited until the icon and the AdaptiveIcon were
  both loaded to show the FloatingIconView.
- This change immediately shows the BubbleTextView icon so that
  we can have something displayed in the cases where AdaptiveIcon
  is slow to load (ie. immediately after killing/restarting launcher).

Currently there are cases where we defer some BubbleTextView drawing to
ClipIconView. We can refactor in master so that ClipIconView is only used
when drawable is an AdaptiveIcon.

Bug: 207389002
Test: manual
Change-Id: Ie54642fef4258862a155ab0aba6e49cea9c9ead0
2021-12-10 13:25:39 -08:00
Jon Miranda 5902269fed Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev am: 7ac2a71b94 am: 48d82e2c19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16425110

Change-Id: I8e7d3a99a70a50352ed51674a7aa9e0c4f970cea
2021-12-10 19:11:28 +00:00
Jon Miranda 48d82e2c19 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev am: 7ac2a71b94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16425110

Change-Id: I60f6a9e8ae87bb011f9e7f4a7b11748415f044c1
2021-12-10 18:48:18 +00:00
Jon Miranda 7ac2a71b94 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev 2021-12-10 18:36:15 +00:00
Alex Chau 58f1b7f77e Don't snap to focused task in split select am: 9ef8e2dcee am: abc325df91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440098

Change-Id: I6ddd47521b21868e7c70d724aedcb42f791d9b32
2021-12-10 18:24:47 +00:00
Tony Wickham 0606773905 Fix taskbar being empty
We set mIconAlignmentForResumedState in endGestureStateOverride(), but then we call applyState() which might aniamte mIAFRS to a different value. To avoid this, set it after applyState() instead.

Specific repro:
1. Open Calculator
2. Go to Overview
3. Dismiss Calculator
  3a. This calls endGestureStateOverride() because the running tile ends
  3b. Previously, we called mIAFRS.updateValue(1) but then applyState() animated it to 0 because we're still in Overview which is an unstashed state. Now the animation to 0 is before setting explicitly to 1.
4. Go home (this sets mIconAlignmentForLauncherState = 1)
5. Open Calculator again. Previously, mIAFRS was already 0 so animating to 0 was ignored. Now, mIAFRS starts at 1 (which is right since launcher is resumed).

Test: see above
Fixes: 210109500
Change-Id: I13f40908f8636291d63ef4b885ac9d08bbf4d393
2021-12-10 18:20:13 +00:00
Alex Chau abc325df91 Don't snap to focused task in split select am: 9ef8e2dcee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16440098

Change-Id: I7b4df5edd72b9f351629ba216cdf506ea8c8f8f9
2021-12-10 18:07:47 +00:00
Alex Chau 9fee3fd379 Allow column size of search container to be configured
- Added numSearchContainerColumns in grid-option to control search container's width, defaults to numColumns if not specified

Bug: 210127246
Test: manual
Change-Id: I0c2594f0eeab8844dcff9468e603282a09fae0bd
2021-12-10 17:55:51 +00:00
Alex Chau 1ced59acb4 Allow snapping to focused task in overview grid am: b6ad9dfaf5 am: 17a0eec015
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16378986

Change-Id: Id925b44f6a324e821150efe1b3e1cc001497c69e
2021-12-10 15:28:44 +00:00
Alex Chau 9ef8e2dcee Don't snap to focused task in split select
- In split select there is no overview actions, and focused task's snappign position is not centered, it's weird to snap so avoid it
- Follow-up of ag/16378986

Bug: 208644826
Test: manual
Change-Id: I260b5c6164db562717346396b1830af02d408944
2021-12-10 15:27:17 +00:00
Alex Chau 17a0eec015 Allow snapping to focused task in overview grid am: b6ad9dfaf5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16378986

Change-Id: I811324cbfa99c9ebf8ba070e6d6d03f6aa467732
2021-12-10 15:13:44 +00:00
Alex Chau b6ad9dfaf5 Allow snapping to focused task in overview grid
Fix: 208644826
Test: manual
Change-Id: Ia6fb2ae44209042f6d40bf8db5d1f43b3b6a27ee
2021-12-10 12:07:21 +00:00
Alex Chau d35c6f97fe Merge "Add split support for 3P launcher" into sc-v2-dev am: 42cbdee25c am: 809cef23a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16416933

Change-Id: I6305941be879350ab192cf3be0fa0a4edf8ffe99
2021-12-10 10:25:32 +00:00
Alex Chau 367f6262e1 Merge "Improving memory dump diag" into sc-v2-dev am: eea4379a5d am: b944b46eeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16434161

Change-Id: I1af6741c983fad7b767f84747c0adadcfdbecdd2
2021-12-10 10:25:24 +00:00
Alex Chau 809cef23a5 Merge "Add split support for 3P launcher" into sc-v2-dev am: 42cbdee25c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16416933

Change-Id: I7fa6dc108941f935a9f1987c23b9c8f2f49dad79
2021-12-10 10:10:55 +00:00
Alex Chau b944b46eeb Merge "Improving memory dump diag" into sc-v2-dev am: eea4379a5d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16434161

Change-Id: If3a45237f8a766eb6b812392e0aa979862a87a5e
2021-12-10 10:10:38 +00:00
Alex Chau 42cbdee25c Merge "Add split support for 3P launcher" into sc-v2-dev 2021-12-10 09:55:00 +00:00
Alex Chau eea4379a5d Merge "Improving memory dump diag" into sc-v2-dev 2021-12-10 09:52:53 +00:00
Hongwei Wang aa6393be02 Merge "Do not start auto-pip transition when swiping from split" into sc-v2-dev am: 293b5bc836 am: 51786b1084
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16418447

Change-Id: I182a048c3a0ae10e630ad87fe9ce37de4b7a0f13
2021-12-10 09:01:08 +00:00
Hongwei Wang 51786b1084 Merge "Do not start auto-pip transition when swiping from split" into sc-v2-dev am: 293b5bc836
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16418447

Change-Id: I9cf5d3738faf0880a31fdcfbbe3eb9bcd309a06e
2021-12-10 08:45:42 +00:00
Hongwei Wang 293b5bc836 Merge "Do not start auto-pip transition when swiping from split" into sc-v2-dev 2021-12-10 08:25:28 +00:00
Tracy Zhou e317d29b04 Tune taskbar handle height
Bug: 200310506
Test: https://screenshot.googleplex.com/B2Ugt2GGahxgm5m
Change-Id: Id639250e4cbcc8750436913c27567cf29dd0de04
2021-12-10 06:53:31 +00:00
Hongwei Wang 8274cb287e Do not start auto-pip transition when swiping from split
Also, pass a PictureInPictureSurfaceTransaction to hide the tasks in
split-screen from Launcher to WM to avoid flicker when any one of the
tasks enters PiP.

Bug: 190855091
Bug: 205894095
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/42RWtayanp2qG0mHSf4Q5
Test: manual, enter PiP from split-screen, see Video
Change-Id: Ia8b6243c0d95c2be8007beeefa2083acc856e404
2021-12-09 20:26:23 -08:00
TreeHugger Robot 86afc595d1 Merge "Only inset IME by 48dp instead of 60dp when taskbar is present" into sc-v2-dev am: 5692501806 am: 1b578f3b71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16433862

Change-Id: Idc3d1364d374fb33e5845f249be80ba3408c9b0c
2021-12-10 00:24:54 +00:00
TreeHugger Robot 1b578f3b71 Merge "Only inset IME by 48dp instead of 60dp when taskbar is present" into sc-v2-dev am: 5692501806
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16433862

Change-Id: Ia9fe894e638bdd4a2743160d16b3e9c5523cfb5a
2021-12-10 00:09:41 +00:00
Android Build Coastguard Worker 1c0a9dff24 Snap for 7985315 from 5b2bbe7e20 to sc-v2-release
Change-Id: Id293dcd4062fbb724f936e5135674f2ffde3b0d6
2021-12-10 00:08:33 +00:00
TreeHugger Robot 5692501806 Merge "Only inset IME by 48dp instead of 60dp when taskbar is present" into sc-v2-dev 2021-12-09 23:48:27 +00:00
Tony Wickham 1a2d581cf0 Only inset IME by 48dp instead of 60dp when taskbar is present
- Update providedInternalImeInsets whenever taskbar height changes, since the insets are subtracted from the taskbar window height. This ensures the IME always has the same bottom inset (48dp) regardless of taskbar's window size
- Also translate nav buttons down to center in the new size when IME is showing

Test: Open IME from home and in apps, both in gesture nav and 3 button mode. Ensure IME bottom inset is always 48dp and nav buttons center within that space
Fixes: 201115344
Change-Id: I5ed25b0ffc08145b2221cc5c960e669cc21b2aa7
2021-12-09 22:17:21 +00:00
vadimt bc1da4ca98 Improving memory dump diag
atest deletes artifacts directory on the device, but saves artifacts at the host machine.

Bug: 187761685
Test: presubmit
Change-Id: I1f5244ebfe6b606c4891f5fca003541b27cc944c
2021-12-09 21:58:45 +00:00
Jorim Jaggi bd94f7c2b8 Add cheap aidl tracing suitable for always-on-tracing (3/3)
Instead of having only one switch to enable all binder tracing,
we seperate between stack tracking and tracing. Stack tracking
still works as before. However, the more lightweight option,
tracing using android.os.Trace, is toggleable separately and will
work on the receiver side without dumping the entire stack trace.

We also make the tracing more efficient by caching
getTransactionName and concatting the class name.

Also, enable this selectively for SysUI+Launcher, which is
currently the focus of always-on-tracing effort to figure out
what kind of binder calls these processes are calling which seems
to contribute a huge amount of jank (long binder calls are in
>= 50% of janky traces).

Test: external/perfetto/tools/record_android_trace gfx view freq sched wm am aidl
Test: atest aidl_unittest
Bug: 202278427
Change-Id: Ia555740400808e0a467d00e305b6743931d3af0a
2021-12-09 22:53:01 +01:00
Vinit Nayak 2a93bc5b30 Add split support for 3P launcher
* Copied logic mostly from
Base/RecentsViewStateController
* There's one KI crash specific to 3P
(b/209694087)
* Swipe to home animation is TODO, but
then again it also seems incorrect for
full-screen app. 3P has many cosmetic issues
throughout.

Bug: 195607777
Test: Tested w/ Nova launcher with grid
and non-grid, able to invoke split screen with
same animations as 1P launcher

Change-Id: I35a1bc92a51caccac4214289e614000cd47bb503
2021-12-09 12:52:04 -08:00
Hyunyoung Song 4a77efe99d Add setSuggestOnChrome method to OneSearch interface
Bug: 205872450
Test: manual
Change-Id: Ib1513111e5d633d7504a386036b44e5e1ee0e1a9
2021-12-09 12:36:20 -08:00
Sebastian Franco 411b71bf09 TalkBack doesn't announce when a task has being closed.
Adding announceForAccessibility() in createTaskDismissAnimation()
to announce the task has being closed.

Test: Manually tested
Fix: 186744160
Change-Id: I71f57e7ba03a61b2ced7e338da4251637e89bd16
2021-12-09 20:27:51 +00:00
TreeHugger Robot b67c9effd3 Merge "Log launcher settings whenever launcher layout is logged using pull atom." 2021-12-09 08:38:09 +00:00
Thiru Ramasamy f7ebfb9a7f Log launcher settings whenever launcher layout is logged using pull atom.
* Whenever launcher setting is changed, only log the changed setting instead of all

Bug: 181703659
Test: wwdebug && wwlogcat AND statsd_testdrive 10108

Change-Id: I9c6b7a17d653038a91f885df455e5ebbb401b49a
2021-12-09 06:13:44 +00:00
Jerry Chang 07f81af3e7 Merge "Always draw background for task thumbnail" into sc-v2-dev am: 5b2bbe7e20 am: b7218408c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16422016

Change-Id: I15b0b99c4352839f5ae6d6b8bb101bab5b30f2a1
2021-12-09 02:38:05 +00:00
Jerry Chang b7218408c5 Merge "Always draw background for task thumbnail" into sc-v2-dev am: 5b2bbe7e20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16422016

Change-Id: I91c97afe091957faa38b3a0bb237a0bdc2be6c5f
2021-12-09 02:22:51 +00:00
Jerry Chang 5b2bbe7e20 Merge "Always draw background for task thumbnail" into sc-v2-dev 2021-12-09 02:03:42 +00:00
Jon Miranda 14d6771aae Clear all DragView in onSaveInstanceState
Multiple users reports view getting stuck on screen. This CL
clears all DragView when user leaves launcher.

Root cause still undetermined, but happens enough that it warrants
a temp fix.

Bug: 162636845
Test: manual
Change-Id: I532b5274a1308c53f67c23c5c8ca07f2b7f9802c
2021-12-08 17:47:33 -08:00
Winson Chung f12e7dbab3 Account for early display rotation for gestures with shell transitions
- Ensure the events are in a consistent coordinate frame from the start
  of the gesture
- Now that the display rotation happens at the start of the gesture, we
  need to use the rotation at the start of the gesture in some cases
- Use the pre-rotation screenspace bounds when calculating the thumbnail
  matrix

Bug: 197687032
Test: Enable shell transitions and swipe up from a landscape app into
      force-portrait Launcher

Change-Id: I61ebe9947a55937c59a47336aa92561e7e3e8b66
2021-12-09 01:42:31 +00:00
TreeHugger Robot 7cc82937fd Merge "add post_notification permission to manifest so the package can send notifications on T+" 2021-12-09 00:32:04 +00:00
Android Build Coastguard Worker dab461a728 Snap for 7981408 from b5a051ca0b to sc-v2-release
Change-Id: I10998b9acd0096f1c512e2dde825f24fbb9467d4
2021-12-09 00:10:29 +00:00
TreeHugger Robot 2636a5d5b2 Merge "Add launcher grid spec for tablet" into sc-v2-dev am: b1ae1ca124 am: 287d976c91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371727

Change-Id: I609dbebde278dfb335a5a66c6bd71fcfa62a3102
2021-12-08 23:30:14 +00:00
TreeHugger Robot 287d976c91 Merge "Add launcher grid spec for tablet" into sc-v2-dev am: b1ae1ca124
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371727

Change-Id: Id456a1dfa7e7f3578aa80cc281eb6680575c4cef
2021-12-08 23:14:44 +00:00
TreeHugger Robot b1ae1ca124 Merge "Add launcher grid spec for tablet" into sc-v2-dev 2021-12-08 22:49:00 +00:00
Tracy Zhou 283d65085e Merge "Add content descriptions to task bar nav buttons" 2021-12-08 21:19:36 +00:00
Steve Elliott 43c2c6c05c add post_notification permission to manifest
so the package can send notifications on T+

Bug: 194833441
Change-Id: I9e93e64939c1bb8281519ad2a959165e74556ab2
2021-12-08 19:15:40 +00:00