Commit Graph

10418 Commits

Author SHA1 Message Date
Tony Wickham 10018d2191 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5 am: 4de1650940
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I3943bc9286ae242dca9e9256ea34e65937463a10
2021-06-21 23:11:35 +00:00
Sunny Goyal 696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00
Sunny Goyal 871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal 2653cd5eb0 Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb am: a56c1e0617
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I40c3949b3427e05a0f86f85d6f82c0a325962c6b
2021-06-21 22:53:33 +00:00
Tony Wickham 66b60ab354 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5 am: f0e1e8bf00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: Icf283921b956e9822ecd7b3fa26755bc809b25da
2021-06-21 22:53:11 +00:00
Sunny Goyal a29220f6b6 Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I0361531f4ff2695d97b5e48c5abc0c40fe505112
2021-06-21 22:42:06 +00:00
Tony Wickham 16119f5004 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: Ia8a964effbc89754cd7f29986404d6ba1474a668
2021-06-21 22:41:32 +00:00
Sunny Goyal a56c1e0617 Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: I68c12433ba07dcba23bb9f6ed1ed507ea21484bb
2021-06-21 22:40:34 +00:00
Sunny Goyal b6cdee307b Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev am: b3eafe97bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15032078

Change-Id: Ia84604f9126b2dc142c1d99ae54c71f36accaa0f
2021-06-21 22:40:28 +00:00
Tony Wickham 4de1650940 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I0842941791cddd5c8c33c73f7feb68edee78b69b
2021-06-21 22:40:20 +00:00
Tony Wickham f0e1e8bf00 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev am: 82fc5c83a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15052402

Change-Id: I8a21b8c6826cda2341bdf2f23698e1c4aa014246
2021-06-21 22:40:09 +00:00
Sunny Goyal b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
zakcohen 061548668d Fade overview action buttons faster in overview -> home
Spec says transition should take ~80ms, default for this transition is
~300ms, so clamp to a quarter of the range.

Bug: 191699762
Test: Local
Change-Id: I5ef6701eee0d25d5d9987e05cb53aee3e5e8e143
2021-06-21 15:18:16 -07:00
Tony Wickham 82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky 08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham 9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Schneider Victor-tulias abfca747bc Merge "Update All set screen icon" into sc-dev am: 689d69572b am: ad65347a98 am: d431b9cd0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031481

Change-Id: I8d932671942957a8e7ab802bf5a2c8b8762b3ff3
2021-06-21 20:15:03 +00:00
Schneider Victor-tulias d431b9cd0c Merge "Update All set screen icon" into sc-dev am: 689d69572b am: ad65347a98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031481

Change-Id: Ib89e8eca1810273ece698c67bf66466fcee913ee
2021-06-21 20:13:23 +00:00
Schneider Victor-tulias ad65347a98 Merge "Update All set screen icon" into sc-dev am: 689d69572b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031481

Change-Id: Ib1864113e4ec2942eeb111d6b2b9277bf13e59ec
2021-06-21 20:07:59 +00:00
Schneider Victor-tulias b9528fb046 Merge "Update All set screen icon" into sc-dev am: 689d69572b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031481

Change-Id: Ibc35be313e6f53042157daf4a8ced190e74092f7
2021-06-21 19:58:00 +00:00
Tony Wickham 29d762fb82 Merge "Initial commit of taskbar stashing" into sc-v2-dev am: 0ac023196d am: a2be8926bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14941111

Change-Id: I3da658073e4ad181c872021f3b4faa8d6a2d1160
2021-06-21 19:56:54 +00:00
Schneider Victor-tulias ebc85f672d Merge "Update All set screen icon" into sc-dev am: 689d69572b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031481

Change-Id: Ia29d12a91ae58ee0d01118406c1fa82e5aa9d0e6
2021-06-21 19:56:38 +00:00
Tony Wickham a2be8926bd Merge "Initial commit of taskbar stashing" into sc-v2-dev am: 0ac023196d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14941111

Change-Id: I42a6e727f8b2500c69e9542cc182d8386a4365cd
2021-06-21 19:54:24 +00:00
Schneider Victor-tulias 689d69572b Merge "Update All set screen icon" into sc-dev 2021-06-21 17:35:15 +00:00
Tony Wickham 0ac023196d Merge "Initial commit of taskbar stashing" into sc-v2-dev 2021-06-21 15:56:12 +00:00
Jonathan Miranda b1cfdbb1aa Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682 am: 5e7b499dc7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: Ibfda1e6ab85a49556249d956b7e02fd62a926cae
2021-06-20 23:11:04 +00:00
Jonathan Miranda db2f0df330 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682 am: 24ae397544
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: Icc2e06db004672614609b009ffbdb37d092bc7ae
2021-06-20 23:10:13 +00:00
Jonathan Miranda 94df55bada Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: I9ab72caa407fd3e6a2e6130bcf9e924ba2c7726c
2021-06-20 22:59:04 +00:00
Jonathan Miranda 24ae397544 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: I21f9366f93afe6eaf2d9e96927a6a2eef7d5427a
2021-06-20 22:58:15 +00:00
Jonathan Miranda 5e7b499dc7 Merge "Fix bug where workspace alpha does not get set to 1 when animation gets cancelled." into sc-dev am: f9df8f3682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023032

Change-Id: Iaed06dd41e6932628f33b232ae9f77e2194e55a9
2021-06-20 22:58:01 +00:00
Vinit Nayak 0e4375e3b7 Merge "Add IDs to buttons in 3 button nav for Taskbar" into sc-v2-dev am: 3fcc02b8dc am: 7107268df9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15027506

Change-Id: I7fc65aa447ab6ca63b3e5b0ff1802ad056ab4b56
2021-06-19 06:20:53 +00:00
Vinit Nayak 7107268df9 Merge "Add IDs to buttons in 3 button nav for Taskbar" into sc-v2-dev am: 3fcc02b8dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15027506

Change-Id: I0a9ba369f2a852ec1afd4e39663f339db1316d9b
2021-06-19 06:05:40 +00:00
Vinit Nayak b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Sunny Goyal 63f52f8308 Merge "Fixing out of order taskbar callbacks" into sc-v2-dev am: d7e17a860f am: a5422c8902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023048

Change-Id: I99bffa51e5d30143acd2805f4c9d4a841967fb99
2021-06-19 01:12:26 +00:00
Sunny Goyal a5422c8902 Merge "Fixing out of order taskbar callbacks" into sc-v2-dev am: d7e17a860f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15023048

Change-Id: I997bc64fe3b1f39211a03c7ef690e375e13dc61c
2021-06-19 00:59:19 +00:00
Tony Wickham 3fd22847ac Initial commit of taskbar stashing
- Added StashedHandleViewController to provide properties such as ViewOutlineProvider to animate the handle that's shown in place of taskbar while it's stashed
- Added TaskbarStashController to coordinate the stashed state, including orchestrating the animation across taskbar controllers
- Added TaskbarStashInput consumer to detect long press in the nav region when taskbar is stashed

Behavior:
- Long pressing taskbar background animates to the stashed state by morphing the TaskbarView into the stashed handle view and offsetting the background offscreen
- We persist the stashed state across app launches and reboot; to unstash, long press the stashed handle
- We also visually unstash when going back home

Test: long press tasbkar background when in an app to stash it, long press the resulting stashed handle to unstash; while stashed, swipe up to home to also unstash until launching another app
Bug: 189503603
Change-Id: I698eff785388dff1ef717c76879719d6af236c2d
2021-06-18 17:51:39 -07:00
Sunny Goyal d7e17a860f Merge "Fixing out of order taskbar callbacks" into sc-v2-dev 2021-06-19 00:40:46 +00:00
Vinit Nayak dcd9a0cdd6 Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev am: 70565c5e7d am: 0d50bfacb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15017522

Change-Id: I3e010dd812b4b8cc2a3d23081f2fc5328401ef88
2021-06-18 23:20:17 +00:00
Vinit Nayak 0d50bfacb9 Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev am: 70565c5e7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15017522

Change-Id: I008bab1a7f4b850ee1a3dcf8cdb5b4d700790f8f
2021-06-18 23:03:26 +00:00
Vinit Nayak 70565c5e7d Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev 2021-06-18 22:56:24 +00:00
Jon Miranda 651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Schneider Victor-tulias 4ef6bd5a7a Update All set screen icon
Fixes: 191463446
Test: Manual
Change-Id: I746bfb2eab950a01041493bd72d7dda30ac66d7b
2021-06-18 15:36:23 -07:00
Sunny Goyal 6e1ce8ccb8 Fixing out of order taskbar callbacks
OnCreate can come before onDestroy for a previous activity which can
cause the callbacks for taskbar to get cleared

Bug: 190170303
Test: Presubmit
Change-Id: I48334605384d4604043a50ffc3d137f84575148a
2021-06-18 12:44:38 -07:00
Vinit Nayak 4d276961be Merge "Enable 3 button nav for taskbar" into sc-v2-dev am: ae7c8cacd5 am: fe043eafee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985475

Change-Id: I409cf319365ee2554236f5113dd8cc464f874367
2021-06-18 05:56:22 +00:00
Vinit Nayak fe043eafee Merge "Enable 3 button nav for taskbar" into sc-v2-dev am: ae7c8cacd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985475

Change-Id: Id5b929c6c9bd0dfa066e63ee6fc5636d3dc50512
2021-06-18 05:45:21 +00:00
Vinit Nayak ae7c8cacd5 Merge "Enable 3 button nav for taskbar" into sc-v2-dev 2021-06-18 05:43:41 +00:00
TreeHugger Robot 06292bf289 Merge "Fixing Taskbar not initialized properly on recreate" into sc-v2-dev am: cb207ef236 am: fcd4a6b131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15019036

Change-Id: I56454821c074a01871452072f22c2c5e852c1f8d
2021-06-18 01:57:12 +00:00
TreeHugger Robot fcd4a6b131 Merge "Fixing Taskbar not initialized properly on recreate" into sc-v2-dev am: cb207ef236
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15019036

Change-Id: I001a9801f8cbf02bbb1e85d35b33e50b20a07315
2021-06-18 01:35:07 +00:00
Sunny Goyal 4a48a988c8 Simplifying Launcher binding callbacks
> Making all methods as default
> Removing obsolete logic around synchronous binding
> Removing some UI dependencies from bind callbacks

Bug: 187353581
Test: Manual
Change-Id: I0d2bbb060af2cab7c64541d7695055629dfaf0b8
2021-06-17 15:21:01 -07:00