Commit Graph

10418 Commits

Author SHA1 Message Date
Alex Chau 0cfa212203 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev am: 1b0e524d94 am: 48908d7259
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16419683

Change-Id: Ifa85cf38133df316243f6e04a7a1f0cea20e353c
2021-12-08 18:13:09 +00:00
Tony Wickham b05ad5dcbf Merge changes I6cf84ec7,Iea599651,If3238286 into sc-v2-dev am: b5a051ca0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407666

Change-Id: Iffb14ab9d043a5802a92a76b2f388a62423c6625
2021-12-08 17:58:35 +00:00
Alex Chau 48908d7259 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev am: 1b0e524d94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16419683

Change-Id: Id609eb9f37db4f4bf1b6e42bad3ffb9aa88df9e3
2021-12-08 17:58:24 +00:00
Jerry Chang 7d20de28e3 Always draw background for task thumbnail
Always draw background for task thumbnail because the task snapshot
might be translucent or partially empty.

For example, when drag-to-dismiss split screen, it will reparent tasks
from dismissing split root to the bottom of display. Task thumbnail of
those tasks might be partially empty because the snapshot was taken in
new bounds inherits from display but with split screen content.

Fix: 200096421
Test: drag to dismiss split, observed task thumbnail no longger been
      cropped.
Change-Id: I5d04daa55a558f79ccf5127080088bd0698d06d8
2021-12-09 01:44:46 +08:00
Tony Wickham b5a051ca0b Merge changes I6cf84ec7,Iea599651,If3238286 into sc-v2-dev
* changes:
  Improve quick switch from home to taskbar
  Cleanup some taskbar/hotseat handoff issues
  Fix taskbar stash misalignment when going from app to overview
2021-12-08 17:42:54 +00:00
Alex Chau 1b0e524d94 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev 2021-12-08 17:39:32 +00:00
TreeHugger Robot b30aaf6d3d Merge "Fix split animation for grid RTL" into sc-v2-dev am: d1c9cd2700 am: 4dcdd70ce2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16418133

Change-Id: Ic05e4038837357ac7eeef8e4799db73fd5d792a5
2021-12-08 12:42:29 +00:00
TreeHugger Robot 4dcdd70ce2 Merge "Fix split animation for grid RTL" into sc-v2-dev am: d1c9cd2700
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16418133

Change-Id: I98fab9b33140369690a3c893643be02515f0d11f
2021-12-08 12:27:56 +00:00
Alex Chau 129086560b Handle split select rotation am: 86ef5e924a am: bcf2060c5d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405843

Change-Id: I1996ebcf1cb5c669d7394f4285a6b0f441aee9c0
2021-12-08 12:12:17 +00:00
TreeHugger Robot d1c9cd2700 Merge "Fix split animation for grid RTL" into sc-v2-dev 2021-12-08 12:06:23 +00:00
Alex Chau bcf2060c5d Handle split select rotation am: 86ef5e924a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405843

Change-Id: Ife26f26f92bd2f0a238ea19c9e9958d655e96083
2021-12-08 11:55:07 +00:00
Alex Chau 86ef5e924a Handle split select rotation
- Update floatingTaskView, apply splitsSelectTranslation and splitPrimaryScorllOffest when rotating while in split select
- Moved getSplitSelectTranslation to RecentsView
- When in portrait, treat STAGE_POSITION_BOTTOM_OR_RIGHT as STAGE_POSITION_TOP_OR_LEFT in split translation calculation
- Apply splitsSelectTranslation for portrait grid too

Fix: 201721153
Test: manual
Change-Id: I768a3b15de4d434674058b274c368798f5852917
2021-12-08 11:35:02 +00:00
Alex Chau 9fa58b2fee Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 0bd0733ef4.

Reason for revert: b/209025715
Bug: 189807374

Change-Id: I477bacc318e84c16f124cf776ddd8446959755aa
2021-12-08 11:17:14 +00:00
Tracy Zhou 74fd7af92d Add content descriptions to task bar nav buttons
Fixes: 209608812
Test: manual
Change-Id: Iba50abfb2a3d33104b6d88574df0bc7b5daf1d3a
2021-12-08 10:44:31 +00:00
Vinit Nayak 0f12803061 Fix split animation for grid RTL
Fixes: 202156862
Test: Tested grid + non grid,
RTL + LTR

Change-Id: I303f60efdd9f2f2ea412e31e574d9a3b50fecf30
2021-12-07 22:13:06 -08:00
Vinit Nayak 534a53c022 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev am: 4e0d4239e4 am: 4cc39a0d4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16415376

Change-Id: I42f653fb05d46d6f23828808b4341befbee14be3
2021-12-08 04:31:31 +00:00
Vinit Nayak 4cc39a0d4c Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev am: 4e0d4239e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16415376

Change-Id: Ic42943df8cdb92f2b6b5582c908d7edef437d303
2021-12-08 04:15:36 +00:00
Vinit Nayak 4e0d4239e4 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-12-08 04:02:31 +00:00
Tony Wickham b58230d15b Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev am: 779879ce3d am: 562ca940e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405551

Change-Id: Ic703ea1b35ff2e0b8b5e1ea1a316251184fbec42
2021-12-07 21:15:32 +00:00
Tony Wickham 24675d36b7 Improve quick switch from home to taskbar
- Add LauncherState#isTaskbarAlignedWithHotseat() which defaults to !isTaskbarStashed(), but is always false for quick switch from home
- Replaced FLAG_TRANSITION_STATE_START_STASHED and FLAG_TRANSITION_STATE_COMMITTED_STASHED with FLAG_STATE_TRANSITION_RUNNING and a reference to mLauncherState. STATE_START is equivalent to TRANSITION_RUNNING changing to true, and STATE_COMMITTED is equivalent to TRANSITION_RUNNING changing to false. Then can get details from the state such as whether taskbar is stashed and icon alignment from mLauncherState

Test: quick switch from home, both with taskbar stashed in apps and not
Fixes: 194728611
Bug: 204657916
Change-Id: I6cf84ec73a4036e14cc7268667c6f62100884c27
2021-12-07 13:13:48 -08:00
Vinit Nayak 0bd0733ef4 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I529dba5d4df3d0c3366c111e70991a36bec4bfc3
2021-12-07 13:07:32 -08:00
Tony Wickham 562ca940e2 Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev am: 779879ce3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405551

Change-Id: I876064e6ca079acf04ffdf17ee38060e270852a7
2021-12-07 20:56:27 +00:00
Tony Wickham 779879ce3d Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev 2021-12-07 20:42:55 +00:00
Vinit Nayak 0d40e19c4a Animate split divider
* TODO currently it doesn't animate when
dragging a split task back down because we need
to sync that with the other task scaling
animation playback controllers.
* It also doesn't animate in when opening a
split pair from overview because I think shell
is setting it to be visible before the divider
leash even makes it to launcher

Bug: 202914644

Change-Id: I6c60cffdb63aa262d0b547f85acc604c0c8a3637
2021-12-07 11:20:30 -08:00
Alex Chau 992db75dae Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
Merged-In: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 14:50:40 +00:00
Alex Chau a5470710a3 Use percentage scaling for overview thumbnail size am: 4f7952ead4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16389092

Change-Id: I18751b12e2c7fa2b376545a95426594cbadffd07
2021-12-07 14:50:04 +00:00
Alex Chau 4f7952ead4 Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 11:00:48 +00:00
Tony Wickham 9566290e13 Cleanup some taskbar/hotseat handoff issues
- Clearly distinguish Home <-> App icon alignment (ForResumedState and ForGestureState) from Home <-> Home states (ForLauncherState) by renaming onIconAlignmentRatioChanged() to onIconAlignmentRatioChangedForAppAndHomeTransition (for the former)
- Make sure initial state is properly applied by treating all flags as changed
- onIconAlignmentRatioChangedForStateTransition only runs when launcher is resumed (fixes 208648294)
- Animate taskbar background alpha when going between home and app, separate from icon alignment (bug: 204657916)
- Only copy hotseat's alpha to taskbar when hotseat is originally visible (also bug: 204657916)

Test: Open an app on small screen, open large screen and ensure taskbar stays at the bottom instead of aligning with non-present hotseat (bug: 208648294)
Test: Swipe up and down on home scren, ensure taskbar background never appears and there's no jump between taskbar and hotseat
Change-Id: Iea59965118f2bdbd8ce49279f76fb01fbd61f60b
2021-12-06 17:16:19 -08:00
Tony Wickham 7af54403a3 Remove LauncherState.TASKBAR visible element
It's no longer used, so removing to cleanup code and reduce confusion

Test: no functional change
Fixes: 209512651
Change-Id: Ibd671bde7190df976b5365331731a55a9abdbb35
2021-12-06 15:59:39 -08:00
Tony Wickham f1951ce1f7 Fix taskbar stash misalignment when going from app to overview
Keep taskbar unaligned with hotseat if we're stashing anyway

Test: Swipe up from app with taskbar present to overview, check frame by frame to ensure icons morph directly into the handle instead of above it
Fixes: 208697792
Change-Id: If3238286b3383e75eb71fbd3b97d34bb3b44340b
2021-12-06 15:15:34 -08:00
Tony Wickham 94c97fbe59 Merge "Fix taskbar jumping when going home" into sc-v2-dev am: 3d206ca917 am: a19a64e97f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374170

Change-Id: I8c7ee58d94bd0608aec7ddbff5e864782aedf4cc
2021-12-06 20:51:24 +00:00
Tony Wickham a19a64e97f Merge "Fix taskbar jumping when going home" into sc-v2-dev am: 3d206ca917
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374170

Change-Id: I8ad15ee9afd48aeb05ae1e4e89503d0e683ca5a6
2021-12-06 20:36:58 +00:00
Tony Wickham 3d206ca917 Merge "Fix taskbar jumping when going home" into sc-v2-dev 2021-12-06 20:15:20 +00:00
Jon Miranda 986a447ee2 Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev am: 52ee4ec4aa am: faedc9004c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194658

Change-Id: If3e72442f3cd3b976d688ffef366a188683247fe
2021-12-06 19:03:41 +00:00
Jon Miranda faedc9004c Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev am: 52ee4ec4aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194658

Change-Id: If13ed6d01cd440182338c18f8317f691b9d7d33e
2021-12-06 18:38:32 +00:00
Jon Miranda 52ee4ec4aa Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev 2021-12-06 18:17:52 +00:00
Alex Chau 5ec74a16f0 Merge "Add back screenshot button to Launcher3" into sc-v2-dev am: 5656154f1a am: abda7bc69c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365185

Change-Id: I61b276bc55eb8486828e5ee9c19251065564d56e
2021-12-06 18:06:27 +00:00
Alex Chau abda7bc69c Merge "Add back screenshot button to Launcher3" into sc-v2-dev am: 5656154f1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365185

Change-Id: If09fd87ad2c2c1d6ca473c9260fbb91ea3f822c3
2021-12-06 17:51:21 +00:00
Alex Chau 5656154f1a Merge "Add back screenshot button to Launcher3" into sc-v2-dev 2021-12-06 17:37:42 +00:00
Schneider Victor-tulias e9bd547a54 Merge "Update taskbar edu strings for i10n." into sc-v2-dev am: 6c9dbb8db6 am: ad5f39c990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374605

Change-Id: I5a88a4c01933f42f86a656b59d8737509120ac36
2021-12-06 16:03:01 +00:00
Schneider Victor-tulias ad5f39c990 Merge "Update taskbar edu strings for i10n." into sc-v2-dev am: 6c9dbb8db6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374605

Change-Id: I1f8861ac7a692e8336ab05952b938fc00ebafc32
2021-12-06 15:47:56 +00:00
Schneider Victor-tulias 6c9dbb8db6 Merge "Update taskbar edu strings for i10n." into sc-v2-dev 2021-12-06 15:30:11 +00:00
Winson Chung 917227acee Merge "Fix issue with Shell listeners being unbound if SysUI is restarted" into sc-v2-dev am: a21e47c930 am: df569bf73a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16385881

Change-Id: Ieea160280857575469cde9da84e110b0830e9319
2021-12-04 05:19:49 +00:00
Winson Chung df569bf73a Merge "Fix issue with Shell listeners being unbound if SysUI is restarted" into sc-v2-dev am: a21e47c930
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16385881

Change-Id: Ia4a119e1f4b0ae55fe451cd965de79c234547990
2021-12-04 04:57:25 +00:00
Winson Chung a21e47c930 Merge "Fix issue with Shell listeners being unbound if SysUI is restarted" into sc-v2-dev 2021-12-04 04:34:27 +00:00
TreeHugger Robot 88dc380611 Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev am: ad890ac5af am: 4e36642c01
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388226

Change-Id: I53adc3f81e4de6296d7c2f8e76696f33c01e2508
2021-12-03 21:01:09 +00:00
TreeHugger Robot 4e36642c01 Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev am: ad890ac5af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388226

Change-Id: Ib70eeb70bc556885ba35912db78cf0f9518528a3
2021-12-03 20:46:37 +00:00
TreeHugger Robot ad890ac5af Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev 2021-12-03 20:23:58 +00:00
TreeHugger Robot 78b066d230 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev am: 79b56b0659 am: f3bcecf5c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388220

Change-Id: I306259c20ca095772e1ddb036a9c9edf7bfc05b2
2021-12-03 19:15:15 +00:00
TreeHugger Robot f3bcecf5c7 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev am: 79b56b0659
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388220

Change-Id: I19aa71635121bf3acd34b9c434a4bf9a5fd3b67f
2021-12-03 18:59:17 +00:00