Commit Graph

5786 Commits

Author SHA1 Message Date
Jerry Chang d3ceb3dc88 Reset floating split task view after remote animation finished
Move reseting floating task view for entering split after remote
animation finished to prevent the floating task view disappear before
opening split task view being visible and causing flicker.

Bug: 199377815
Test: Manual check the flicker disappear
Change-Id: I4a864335972842570c61291a7a0c423edeb74578
2021-09-23 16:01:18 -07:00
Vinit Nayak ea7e9a48fd Don't show taskbar when keyguard occluded
* Show only back button in taskbar for 3
button nav.

Fixes: 199406716
Test: From lock screen view home controls
or double-tap camera, no taskbar shown.

Change-Id: Ia603c7dbe584e3fab62365de4fc5a790c48d1340
2021-09-23 15:55:22 -07:00
Vinit Nayak 9299a743af Allow tapping on app icon for second split app.
Fixes: 200851336
Test: Split with one app from overview,
tap on app icon for second app. Gets
selected as second app.

Change-Id: I312169fe7bc42007c2f1a0146a5fef5f8d5f46d6
2021-09-23 14:46:59 -07:00
Jon Miranda 13519e4402 Significantly reduce gesture feedback when swiping up to home screen.
- Uses overscroll damping logic to reduce the velocity
- The start to target rect interpolation can be from the
  start, center, or bottom of the rect depending on where the item
  is on the workspace. This reduces the  amount of distance needed to
  travel between, which helps further reduce gesture feedback.

Bug: 173107751
Test: test closing app that is on:
      -  top row of home screen
      -  middle of home screen
      - in hotseat

Change-Id: I055dd61ca3491807109ff2f6c501bf710c8d340f
2021-09-23 20:13:40 +00:00
Vinit Nayak ab02520ca6 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev am: 5dded93a72 am: 870a105b79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857414

Change-Id: I144ed5776c8c64e9827309ef732b82ac0db43433
2021-09-23 06:17:04 +00:00
Vinit Nayak 5dded93a72 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev 2021-09-23 05:55:17 +00:00
Tony Wickham 4af64f0913 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev am: d523841ab4 am: 06743b6818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15889760

Change-Id: If51a0502c0c5c2677c923f5deb596d6d04e3ddbf
2021-09-23 01:03:56 +00:00
Tony Wickham d523841ab4 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev 2021-09-23 00:39:01 +00:00
Vinit Nayak 9e6a642d8b Shorten and center TaskMenuView for landscape
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO

Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.

Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
2021-09-22 14:55:29 -07:00
Tony Wickham 25b6d9783f Allow visual stashing when going to overview in tests
- Seprate out supportsStashing() into supportsVisualStashing() and supportsManualStashing().
- Manual stashing is when user explicitly long presses to stash, which we disable for tests.

Test: testStressSwipeToOverview
Fixes: 200273854
Change-Id: Ib07efa31a1b073de45fdcfac26215129b1b1985b
2021-09-22 13:58:10 -07:00
Schneider Victor-tulias b2339e37d7 Fix stalled gesture navigation tutorial.
Touching the screen after completing the gesture removed all callbacks, preventing the tutorial to progess. Added logic to only remove logic if the gesture is incomplete.

Fixes: 198285152
Test: manual, touched screen and attempted all gestures after completing a step
Change-Id: I320b13cd9b7632a9fb722bc10d3d0a96dc111144
2021-09-22 12:04:24 -07:00
Jonathan Miranda 47bd7aeb3a Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev am: e37b51b30f am: 739afa1bec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15741392

Change-Id: I156b5694002f5c5c299b84d019f70c53536c00b0
2021-09-22 18:58:39 +00:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Vinit Nayak 307614c70a Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev am: 9693766477 am: 38935d3441
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15872704

Change-Id: Iff0b89a2307d833ed52c77835e87818c0ddb3ec2
2021-09-22 17:51:25 +00:00
Vinit Nayak 9693766477 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev 2021-09-22 17:25:08 +00:00
Alex Chau 998a85e913 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev am: 8f990b94a2 am: f6e67fb067
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15857676

Change-Id: Iac12c4380cde4270539f93a9fca552e8fd715ac8
2021-09-22 13:56:59 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Vinit Nayak 7caf5f0ea4 Show distinct TaskMenus for each task in GroupedTaskView
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)

Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.

Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
2021-09-21 17:47:54 -07:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
Vinit Nayak b0ca4b3070 Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev am: 5f412199ad am: 0ada7824c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15854777

Change-Id: I5fd527ce8f4d20a4c915fc6a15e6f1ee00d5d8e6
2021-09-21 17:56:14 +00:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 346af60111 Merge changes I675dbe99,Ia6daa741 into sc-v2-dev am: 139dee45dd am: 8bc27a7ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862033

Change-Id: I412985630ce32cd2f544db3b5b50885405983afb
2021-09-21 17:07:01 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
sfufa@google.com 5b38ff6d16 [Hotseat] Fix hotseat edu flicker
When edu view animation is not started in closed state, it results in a single frame showing right before the animation begins.

Bug: 184610272
Test: visual
Change-Id: I675dbe9927771f4b64d1d81c637f19621037b415
2021-09-21 01:50:41 -07:00
Samuel Fufa 6ebbe4206e Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev am: e4057e628c am: 8998a393b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15864327

Change-Id: Ib5945c7fb5c3c3780a244435526bdb62ddab6752
2021-09-21 07:01:56 +00:00
Samuel Fufa a4c1891723 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev am: cf175820c4 am: fb0bd63b32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862162

Change-Id: I5f465b7078b4ae35521678b88fff0613c80b3ba7
2021-09-21 07:01:37 +00:00
Samuel Fufa e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa cf175820c4 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev 2021-09-21 06:24:37 +00:00
Evan Rosky 218b8cff1d Merge "Register remote transitions on activity start" into sc-v2-dev am: 26c596b813 am: 5684dffff6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15847881

Change-Id: I1554e3c24019525dc07b58a35307a4475d81ba1e
2021-09-20 22:56:27 +00:00
Evan Rosky 26c596b813 Merge "Register remote transitions on activity start" into sc-v2-dev 2021-09-20 22:29:57 +00:00
Samuel Fufa f2a8ead524 Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev am: 7f693253c8 am: 700858930d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862035

Change-Id: I34420cc5c0d4a1ac6cd5037b50e915ea1f5bf44a
2021-09-20 21:38:05 +00:00
Samuel Fufa 8ab7a2eb28 Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev am: 091d91a84b am: de409fc30a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15862161

Change-Id: I616fb524b3f8b95cedb450889e32e9778c56617c
2021-09-20 21:37:46 +00:00
sfufa@google.com 0828fec3d2 [Hotseat] Show edu tip within screen bounds
Screenshot: https://screenshot.googleplex.com/8grkbkYQu5jQhU8
Bug: 163162675
Test: enable hotseat predictions while in landscape mode, dismiss hotseat edu dialog and verify toolTip is shown properly.
Change-Id: Ia6daa7412d728be702e30972136f4c849315793d
2021-09-20 14:22:25 -07:00
sfufa@google.com d0a332371d [Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app
Bug: 182937704
Test: Add direct call widget from widget tray on a predicted spot. verify prediction clears space and no overlap.
Change-Id: Ie4977ca71ec0b7c2297ffe1454cb4a1e78518a75
2021-09-20 14:22:25 -07:00
sfufa@google.com ef5ee36e90 [Hotseat] Fix hotseat migration in landscape mode
Bug: 189860214
Test: performed migration in landspace and verified items are moved properly. change is persisted when device is rotated or launcher is restarted.
Change-Id: Ice088e5524a1405dbfa20c21b4edc597f23da07e
2021-09-20 14:22:24 -07:00
Samuel Fufa 7f693253c8 Merge "[AllApps] Fix ConcurrentModificationException in AppPredictionRow" into sc-v2-dev 2021-09-20 21:19:00 +00:00
Samuel Fufa 091d91a84b Merge "[Hotseat] Remove stale predictions when AppIcon is removed" into sc-v2-dev 2021-09-20 21:16:49 +00:00
Evan Rosky cab41ed670 Register remote transitions on activity start
Was only registering once, but launcher can stop/start
its activity (eg when changing gesture modes), so we
need to try and re-register every time

Bug: 200213691
Test: atest CloseAppHomeButtonTest
      change gesture mode and observe functional animations
Change-Id: I29f1eb647c2168d753e37f57657906979c5518be
2021-09-20 13:41:01 -07:00
Vinit Nayak b7c91b9d2e Prevent focusing next task if focused task part of split select
* Also ensure that in tablet portrait we shift
thumbnails to prevent overlap with the placeholder
view. I'm guessing the time that was written maybe
the grid was taking up a smaller space?

Fixes: 199898622
Test: Go into split selection with focused task,
next task doesn't take focus. Grid shifts down
to not overlap with placeholder view.

Change-Id: I4ed37b1d28287685ad01885331dffd764c7ddfc9
2021-09-20 11:28:55 -07:00
Thales Lima 558ff50698 Merge "launcher: fix animation for quick switch + recents" into sc-v2-dev am: 3b151d630c am: deb17f413b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15853747

Change-Id: Ic7746f14e6f86d554860f38ec11a62cdcafeb599
2021-09-20 14:53:11 +00:00
Vinit Nayak 25c913f7fe Merge "Show multiple icons for GroupedTaskView" into sc-v2-dev am: 03c13ad130 am: f94d7ca492
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15847979

Change-Id: Ib2b29b92516c6922a8cfa6f260ca280ac0f2941e
2021-09-20 12:32:44 +00:00
Tracy Zhou f32330c8a5 Merge "Stash the bar after settling in Overview" into sc-v2-dev am: 088ec093e5 am: d05a3d2040
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15801649

Change-Id: I8b162508cceb90e9c872e1c24afc40fa0b37f23f
2021-09-20 12:29:27 +00:00
Thales Lima f2d44e8756 launcher: fix animation for quick switch + recents
We need to account for the fact that the running task is outside the
screen in this case, so we need to add that amount to the grid
translation.

Bug: 199265499
Test: manual, check the bug
Change-Id: I8c6ca28c5486ce9769bd6fa8fbb3d70eb9619dc6
2021-09-20 12:14:56 +01:00
sfufa@google.com a46da7390c [AllApps] Fix ConcurrentModificationException in AppPredictionRow
Bug: 190574986
Test: presubmit
Change-Id: Ic74d1d466e8c7b0ecb870dd5ab47dc91ba71a01e
2021-09-19 22:55:43 -07:00
sfufa@google.com b39cf0bb33 [Hotseat] Remove stale predictions when AppIcon is removed
Bug: 200088725
Test: Install work profile clock app, verify it is visible in the hotseat, launch (which should remove the icon from AllApps). Go home and verify icon is removed from the hotseat.
Change-Id: I5915f5469fd4f90da0471dc177ef0965e99d07c7
2021-09-19 12:41:23 -07:00
Vinit Nayak 03c13ad130 Merge "Show multiple icons for GroupedTaskView" into sc-v2-dev 2021-09-17 21:27:18 +00:00
Tracy Zhou 3d458313de Hide task bar icons when notification shade is expanded
Fixes: 199163951
Test: manual
Change-Id: Id2556aa5f08db55059c95d8c13cdc4d46b7d8c55
2021-09-17 12:11:25 -07:00
Vinit Nayak af6b85e3bc Show multiple icons for GroupedTaskView
* Hide all overview actions for GroupedTaskView
* Move some logic from TaskView into respective
PagedOrientationHandlers
* Remove unused methods from PagedOrientationHandler
* NOTE this is just visual changes. Properly showing
task menu's is still in-progress

Bug: 181704764
Test: Tested GroupedTaskView in portrait/landscape,
fake landscape in small screen, and real portrait/landscape
in large screen

Change-Id: I9c13ca114024db0a8e3fa5d295951696adb8516f
2021-09-17 10:16:56 -07:00
Tracy Zhou 308851d866 Stash the bar after settling in Overview
Test: https://recall.googleplex.com/projects/81822932-8526-4ee7-b5f7-4ef6d6603f1d/sessions/f0f7a3db-76b6-4f60-87e8-8918bd6cf180
Bug: 193938970
Change-Id: Ic08d3156f5c78a34f353783b760d5cf098e442e8
2021-09-16 00:06:47 -07:00