Commit Graph

5637 Commits

Author SHA1 Message Date
Sam Dubey 48eaf72a93 Merge "Revert "Removing AM.getTasks call on UI thread during touch down"" into tm-dev am: 1e0648475b am: f771fdf90a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17800077

Change-Id: Ic7f480c9844f43aba5a6193e64b6a37801b652c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-18 18:00:25 +00:00
Sunny Goyal 42c010d6cb Merge "Removing AM.getTasks call on UI thread during touch down" into tm-dev am: 2207b577d0 am: 0de0fe8ffe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17735255

Change-Id: Ib4c7a0e5d53ee74f757d90332b664a294472a4ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-18 17:17:41 +00:00
Sam Dubey 1e0648475b Merge "Revert "Removing AM.getTasks call on UI thread during touch down"" into tm-dev 2022-04-18 17:11:50 +00:00
Sam Dubey f9042d32ae Revert "Removing AM.getTasks call on UI thread during touch down"
This reverts commit 013a8a75ab.

Reason for revert: Broke builds

Bug: 229619753
Change-Id: Idb1aecf1d43db50aa4f11dbb88079c37e401d694
2022-04-18 16:47:24 +00:00
Sunny Goyal 2207b577d0 Merge "Removing AM.getTasks call on UI thread during touch down" into tm-dev 2022-04-18 16:19:41 +00:00
TreeHugger Robot 691d878b48 Merge "Polish the back to home gesture animation to match the spec." into tm-dev am: cf80645111 am: 08805831f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17646341

Change-Id: Ibabff84f94f739f031840ded295380201f88b7ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-16 02:53:09 +00:00
TreeHugger Robot cf80645111 Merge "Polish the back to home gesture animation to match the spec." into tm-dev 2022-04-16 01:51:10 +00:00
Tony Wickham 2da9bd5eae Merge "Move Taskbar background drawing to TaskbarBackgroundRenderer" into tm-dev am: 8bb0bdc42b am: 4e2dcdac29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17766315

Change-Id: I85be082cbf2daeb5bae9835e2dd6e2d1ea58269b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-15 23:38:05 +00:00
Mady Mellor 1c1d2b5d12 Fix crash/flicker with taskbar when canceling drag and drop am: 729eb8458b am: 0cb7c659b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17776925

Change-Id: Ida1ee71762e25c7b09dd9ff6837a4ad8aea4ab15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-15 23:37:54 +00:00
Tony Wickham 8bb0bdc42b Merge "Move Taskbar background drawing to TaskbarBackgroundRenderer" into tm-dev 2022-04-15 23:06:40 +00:00
Mady Mellor 729eb8458b Fix crash/flicker with taskbar when canceling drag and drop
The surfaceControl transaction is performed more than once so close
the transaction at the end of the animation.

Test: manual - start a drag from taskbar into split and then pull it
               back so that it doesn't complete
             => ensure taskbar doesn't flicker / no crash in logs
Bug: 228006271
Change-Id: I38c8efe310596bbbbf09f361c266a7fefc1b2eea
2022-04-15 20:25:35 +00:00
Shan Huang 4ce2b40f91 Polish the back to home gesture animation to match the spec.
Bug:228533817
Test: Enable back animation from FlagFlipper (Predicitve Back Animation)
and swipe back on Flag Flipper. Try in both portrait and landscape mode.

Change-Id: I7792dc5079698c1b5a7dd3cd06344ba46c4a2da6
2022-04-15 19:26:11 +00:00
Hongwei Wang b709655961 Merge "Fix flicker when entering PiP from split-screen / overview" into tm-dev am: 778b5e6bd0 am: a53f1fb84a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17762727

Change-Id: Ie3d261d2f0e4bf1ef8c9a1b09b9df07d0aef87c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-15 03:43:14 +00:00
Hongwei Wang 778b5e6bd0 Merge "Fix flicker when entering PiP from split-screen / overview" into tm-dev 2022-04-15 02:48:08 +00:00
TreeHugger Robot abea3bd0cd Merge "Add flag that disables depth on overlay scroll" into tm-dev am: 8c65675382 am: ac1d0b7089
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17766312

Change-Id: Id36a98777f2067abbc285ef5013c139af1f9bbe7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 23:57:27 +00:00
TreeHugger Robot 8c65675382 Merge "Add flag that disables depth on overlay scroll" into tm-dev 2022-04-14 23:16:20 +00:00
Tony Wickham 2604dd348c Move Taskbar background drawing to TaskbarBackgroundRenderer
Currently used by both TaskbarDragLayer and TaskbarScrimView

Test: stash and unstash taskbar, background drawn as before; open a
Bubble and ensure taskbar is still scrimmed
Bug: 225200928

Change-Id: I3f7f4c1b1232b53c3eacb0e000d1c3aec25bb49d
2022-04-14 14:18:35 -07:00
Lucas Dupin 4d90868075 Add flag that disables depth on overlay scroll
Test: manual
Fixes: 229261804
Change-Id: I132d9b5ca78255447ca72655b0a1fb1a4f86c3a1
2022-04-14 14:06:11 -07:00
Sunny Goyal 013a8a75ab Removing AM.getTasks call on UI thread during touch down
We maintain a cached task queue using TaskStackChangeListener.
It keeps the top RunningTaskInfo partially in sync with platfrom:
   taskInfo is only initialized when the top task changes
   but not when there are changes within the task itself.

Bug: 214581894
Bug: 220742398
Test: Manual and presubmit
Change-Id: Ifafde574040c03435b78f044350c45f3b49c4bcb
2022-04-14 14:02:28 -07:00
TreeHugger Robot cb4ba9fe73 Merge "Prevent double selection of second split app" into tm-dev am: 998c47e594 am: 726c49e77c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17622348

Change-Id: I815795ea8b0c589189ab98da3319f73af16fe446
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 20:46:34 +00:00
Sunny Goyal 14fc91ff3e Merge "Updating code due to TaskStackChangeListener changes" into tm-dev am: bc25ec02a2 am: c03a5a6e80
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17730696

Change-Id: Ic4862c56d9ea47bfde93ec033cf768edd1f6c434
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 20:45:28 +00:00
TreeHugger Robot 998c47e594 Merge "Prevent double selection of second split app" into tm-dev 2022-04-14 20:13:59 +00:00
Sunny Goyal bc25ec02a2 Merge "Updating code due to TaskStackChangeListener changes" into tm-dev 2022-04-14 20:11:58 +00:00
Vinit Nayak a4e5a9eebe Prevent double selection of second split app
* Also fix small other bug where we were
checking only for LauncherState
OVERVIEW_SPLIT_SELECT and not for equivalent
3P RecentsState

Fixes: 227419997
Test: Repro steps don't cause bug. Yay.
Change-Id: Ibb8238185b959d22d8455b6812d29b2e268d9739
2022-04-14 11:06:47 -07:00
Hongwei Wang 5f5bd84d99 Fix flicker when entering PiP from split-screen / overview
This is a follow-up of ag/16418447 where we hide the Tasks in
split-screen mode on swipe-home-to-pip and here we use the same
mechanism when we are entering PiP from the overview and the pip-able
task is in split-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bNtg3ZOhuTBKm9nU9CPeNQ
Bug: 228289777
Test: follow the reproduce steps in bug, see video
Change-Id: Icab11d52cedaf94af0ee72023cebca8ec51d8851
2022-04-14 10:49:29 -07:00
TreeHugger Robot 3c3649d9a2 Merge "Creaet separate pull back animation for AllApps" into tm-dev am: 7ea312db9b am: e063262626
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17636490

Change-Id: I68d876317749b9449cd720ae55310c1d915da412
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 14:53:36 +00:00
TreeHugger Robot 7ea312db9b Merge "Creaet separate pull back animation for AllApps" into tm-dev 2022-04-14 14:07:58 +00:00
TreeHugger Robot 00aba03657 Merge "Use bottomMargin to align OverviewActions with 3 button" into tm-dev am: bf5a0d5fe3 am: 3aeefbe017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17729757

Change-Id: I2f1b2f0de571b02ae5f2e04abf3aeeddf74c6983
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 11:49:59 +00:00
TreeHugger Robot bf5a0d5fe3 Merge "Use bottomMargin to align OverviewActions with 3 button" into tm-dev 2022-04-14 10:56:43 +00:00
Alex Chau a74a8595fb Creaet separate pull back animation for AllApps
- In tablet, only animate recyclerView on pullback to be consistent with widget bottom sheet, and avoid showing a gap below mAppsView

Fix: 220345008
Test: manual on small and large screen
Change-Id: I1f7d03b6bd16af7a91a51a0985ef163d9e365261
2022-04-14 11:01:25 +01:00
Evan Rosky c5b8c4d05c Merge "Finish recents animation always" into tm-qpr-dev 2022-04-14 01:16:11 +00:00
Vinit Nayak 37ce441089 Merge "Listen for density changes through DisplayController callbacks" into tm-dev 2022-04-13 22:57:00 +00:00
Evan Rosky 19002551bc Finish recents animation always
Previously, some launcher-side state would be finished, but the
actual animation would never be finished until the next touch-down.

This is a problem for shell-transitions because it relies on
animations finishing. This change handles the scenario where
the gesture finishes before the animation even starts by slotting
in a placeholder listener that just immediately finishes. If the
animation has started but there was no motion, then it directly
finishes the recents animation.

Bug: 228898164
Test: open an app, tap on the bottom-bar. With logging it should
      be evident that the transition finishes.
Change-Id: I27e00ceb4b21a2c37dc556bfecb4a90ef7155a85
2022-04-13 14:44:43 -07:00
Alex Chau b1508b8023 Use bottomMargin to align OverviewActions with 3 button
- This ensure the updated OverviewActions position is considered when calculating modal task size

Fix: 228976149
Test: manual
Change-Id: I635e00096fdb26c164bc76fc94f6bf203f5c9c71
2022-04-13 18:51:40 +01:00
Hongwei Wang d34d3b4834 Merge "Pass sourceRectHint to auto-enter-pip transition" into tm-dev 2022-04-13 17:38:34 +00:00
Sunny Goyal afb6e23500 Updating code due to TaskStackChangeListener changes
Bug: 221961069
Test: Presubmit
Change-Id: I40b2e5a12c4cd6faa53ee788939c31b25bf5c37b
2022-04-13 10:31:18 -07:00
András Klöczl fed1182660 Merge "Change page snapping logic for large screen devices" into tm-dev 2022-04-13 11:18:39 +00:00
Shikha Malhotra 80a315e50f Merge "Review comments followup" into tm-dev 2022-04-13 08:00:31 +00:00
TreeHugger Robot d9939d8174 Merge "Adjust the insets frame providing method per API change" into tm-dev 2022-04-13 01:53:04 +00:00
Andras Kloczl 07111f25f4 Change page snapping logic for large screen devices
Use 15% of the screen width instead of 40% of the page
width currently used for phones.

Test: try page snapping on Launcher home
Bug: 213305066
Change-Id: I6a525100bf942c5089f580a27250c425ca95cf00
2022-04-12 20:23:23 +01:00
Shikha Malhotra f78da1bae3 Review comments followup
These are review comments followup from ag/17399997

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: I9865a37c1ed663370dc28e7678994f3d961e3cd1
2022-04-12 14:33:07 +00:00
Pat Manning 29fbab4ddd Animate clear all button's alpha after last task has scrolled beyond its edge.
Test: manual
Fix: 208879377
Change-Id: Iad43abbe36d11317869a0c5aa6a8d59fd1fddb67
2022-04-12 15:32:06 +01:00
Brian Isganitis 4ad53f1268 Defer unstashing taskbar on all apps close if gesture in progress.
This behavior is more consistent with how we update taskbar stashing when IME is dismissed.

Test: Verified stashing behavior with gestures, 3-button, and bottom sheet dismiss.
Fix: 223837786
Change-Id: Ib85ebe629f33f0bddc36bbc8d99136711105b279
2022-04-11 19:54:53 -07:00
Tracy Zhou b5d7744c1b Merge "Play icon alignment animation in live tile mode" into tm-dev 2022-04-12 00:05:34 +00:00
Tracy Zhou abc2288399 Merge "Update task bar icon alignment logic when launcher is paused and resumed in Overview" into tm-dev 2022-04-12 00:03:15 +00:00
Tracy Zhou d4ed2f7717 Update task bar icon alignment logic when launcher is paused and resumed in Overview
If launcher is paused and resumed in overview, goingToUnstashedLauncherStateChanged doesn't change, so we should not use goingToUnstashedLauncherState as a signal for the end value of mIconAlignmentForResumedState anim

Bug: 223109070
Test: go to overview, use the share functionality, share to drive, and make sure task bar ends up in stashed state. Making sure that it never unstashes is out of scope for this change
Change-Id: I5684be6b58279a9b41e257dd72591f7d692c2fbc
2022-04-11 23:12:49 +00:00
Tracy Zhou 42e30963c3 Play icon alignment animation in live tile mode
aka launcher is not resumed but recents animation is running

Fixes: 210047102
Test: Go to overview in live tile mode, tap on somewhere outside any task in overview, and make sure icon alignment animation is played.
Change-Id: Ic300ee296049b6fdcdf6d2595916cc84c09d95fa
2022-04-11 16:11:28 -07:00
Hongwei Wang 51cf7d18a7 Pass sourceRectHint to auto-enter-pip transition
Bug: 198309223
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/eODHpvqAQPfbwjFamtRYC1
Test: manual, see video
Change-Id: I169603c5285f9a226ab0423dbd36d8e3e2ca51a1
2022-04-11 14:33:44 -07:00
Josh Tsuji 538581639e Merge "Add the staggered ring appear animation!" into tm-dev 2022-04-11 14:32:44 +00:00
Alex Chau e7b727e88e Merge "Force update orientation handler for initial recents view state." into tm-dev 2022-04-11 12:43:54 +00:00