Commit Graph

7772 Commits

Author SHA1 Message Date
Tony Wickham 0165aa82c6 Merge "Update folder leave-behind color for taskbar" into tm-qpr-dev 2023-03-21 16:38:46 +00:00
Jon Miranda ce06cf89b0 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev am: 149246f077
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22141153

Change-Id: Ia0212c2829b01c5b0faf120d6303b7cf6d147ad6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 13:33:32 +00:00
Jon Miranda 149246f077 Merge "Add a way to fade out taskbar view when closing an app in the taskbar." into tm-qpr-dev 2023-03-21 13:01:30 +00:00
Hyunyoung Song a38aab93b9 Revert "Revert "Hide the splash icon when launching with no view..."
Revert submission 21916962-revert-21447384-no-splash-UILAXIUPKJ

Reason for revert: Retry errorprone target

Reverted changes: /q/submissionid:21916962-revert-21447384-no-splash-UILAXIUPKJ
Flag: production issue. Not hidden behind flag
Bug: 269343536
Test: manual

Change-Id: Ia365f886d39d63472d72afc2033fc67e19109f57
2023-03-20 23:33:11 -07:00
randypfohl 127329fe46 Updating overview tutorial to new simple tutorial flow am: 1c0a27a28e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163527

Change-Id: I0658dc8bbb4d92d46f29c8851415de49164ea64d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21 05:36:11 +00:00
randypfohl 1c0a27a28e Updating overview tutorial to new simple tutorial flow
test: built and tested on multiple devices. recorded videos and shared in chat.

bug: b/253520701, b/253521660, b/241813570

Change-Id: I57f88f5fb35c6a7b1219fac6e992bb84354b91ef
2023-03-20 23:16:10 +00:00
Jon Miranda 03bb5fe49c Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev am: fad8c1c449
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146526

Change-Id: Iaa1d5cf3e030398c97841fe604ad923cce4e25e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:34:11 +00:00
Jon Miranda fad8c1c449 Merge "Tune springs when app animates home into the hotseat on devices with a taskbar." into tm-qpr-dev 2023-03-20 20:54:27 +00:00
Jagrut Desai d78b4ecbd0 Clear Accessibility Focus from Taskbar Icon after Shorcut Menu invoked
Test: Manual
Bug: 267698319
Flag: not needed
Change-Id: I2726504094af2abacf1c41089c7bcd4efb588099
2023-03-20 12:41:17 -07:00
Saumya Prakash 813a373212 Merge "Redesign the gesture tutorial for the Back gesture" into tm-qpr-dev am: 60c419b9b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21779343

Change-Id: I00170b244f7e51be704d980b526c19b4980ed954
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 19:03:12 +00:00
Saumya Prakash 60c419b9b7 Merge "Redesign the gesture tutorial for the Back gesture" into tm-qpr-dev 2023-03-20 18:48:34 +00:00
Jon Miranda 9c2a40576e Merge "Taskbar motion polish to keep icons within taskbar bg bounds." into tm-qpr-dev am: 8a53e78f22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22133846

Change-Id: I1ede6c749f24762727fbf7dc8ae1085a70ab0bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 18:42:46 +00:00
Jon Miranda c0c1c55c5d Add a way to fade out taskbar view when closing an app in the taskbar.
Prior to this change, if taskbar is showing and we are cloing an app
that is visible in the taskbar, the taskbar view would immediately
disappear.

Now we will fade out the view until the animation is 33% complete,
at which point the 'space' will be clear for the FloatingIconView
to settle at its final location.

Bug: 273961611
Test: open app in hotseat
      note that the taskbar view is gone immediately
      have taskbar visible, close app that is shown in taskbar
      note that the taskbar view fades out

Change-Id: I5589e2ce3033cfa19669d1bfaf568aef2a96015e
2023-03-20 18:21:42 +00:00
Jon Miranda 8a53e78f22 Merge "Taskbar motion polish to keep icons within taskbar bg bounds." into tm-qpr-dev 2023-03-20 18:04:39 +00:00
Jon Miranda 18c53ac26b Tune springs when app animates home into the hotseat on devices
with a taskbar.

Thought about using the Builder pattern here but the CL becomes
much larger due to SwipePipToHomeAnimator having its own
Builder.

Bug: 268026344
Test: swipe up to close app thats in hotseat
      swipe back to close app thats in hotseat

Change-Id: Idd0729224374579753fc91c7820f3b04a7d3e1a4
2023-03-20 10:56:43 -07:00
Jon Miranda d0c8aa31bd Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev am: ad94440c5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22140592

Change-Id: I7c5c1c5f39906eb5e4f5caff4ec4a8c828e5300c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 16:45:42 +00:00
Jon Miranda ad94440c5f Merge "Keep foreground drawable centered during app open/close animation." into tm-qpr-dev 2023-03-20 16:14:43 +00:00
Jon Miranda f23e2d1e16 Keep foreground drawable centered during app open/close animation.
For apps that use AdaptiveIcon, we used to animate the foreground
drawable independently from the background. This is sometimes
perceived as jank so we remove the animation since it is very subtle
in the best case scenario.

Bug: 268026344
Test: open/close apps/folders that use AdaptiveIcons
Change-Id: I500bf56e04823757d511d909a93d3b30703249a1
2023-03-20 16:13:02 +00:00
Jon Miranda f0e14ac7da Taskbar motion polish to keep icons within taskbar bg bounds.
Instead of making the icons themselves move faster, we change
the startDelay/duration of the taskbar bg alpha animation
so that the taskbar is only visible when the icons are within
the taskbar bounds.

This is still an approximation. For U+, we should support taskbar
width change to fit the icons when they are in the 'hotseat'
alignment.

Bug: 273961611
Test: home <-> overview
      home <-> app
      stash <-> unstash
      foldable/tablet
      RTL
Change-Id: I39bedafac4afd641d250f7c97abf1e2de070d646
2023-03-20 07:12:53 -07:00
Nick Chameyev 1b08ab957e Merge "[Unfold animation] Adjust animation parameters" into tm-qpr-dev am: 927875c6cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21850203

Change-Id: Icf993567039d463e893cf7ce29d898d06ac8be9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 11:20:38 +00:00
Nick Chameyev 927875c6cd Merge "[Unfold animation] Adjust animation parameters" into tm-qpr-dev 2023-03-20 10:51:10 +00:00
Jon Miranda 28d2bc872a Merge "Fix QSB flicker when returning home." into tm-qpr-dev am: 5b01486024
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22118378

Change-Id: I3161c17c1d3eb17e6cdbb100abbc03ec21a170b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-18 18:12:37 +00:00
Jon Miranda 5b01486024 Merge "Fix QSB flicker when returning home." into tm-qpr-dev 2023-03-18 17:36:45 +00:00
Mateusz Cicheński e24ca392e1 Merge "Enable ENABLE_PIP_KEEP_CLEAR_ALGORITHM for teamfood" into tm-qpr-dev am: c8f3c1f172
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21353290

Change-Id: I45816fea7e30e740d4f06e37a0de18b01bb3d6fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-18 01:01:39 +00:00
Mateusz Cicheński c8f3c1f172 Merge "Enable ENABLE_PIP_KEEP_CLEAR_ALGORITHM for teamfood" into tm-qpr-dev 2023-03-18 00:43:08 +00:00
Tony Wickham aa77adbcfa Merge "Fix launcher <-> taskbar dark themed icons background color" into tm-qpr-dev am: d1f024ac7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22102386

Change-Id: I439777933b21875b1999b1a39eadae5743231bdb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-18 00:41:08 +00:00
Tony Wickham d1f024ac7a Merge "Fix launcher <-> taskbar dark themed icons background color" into tm-qpr-dev 2023-03-18 00:07:57 +00:00
Saumya Prakash fd79b4dfbd Redesign the gesture tutorial for the Back gesture
This change adds in a new animation and layout to change the existing back tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the overview gesture. Large screen animations are also added for Home and Back tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 241813570
Bug: 253521922
Bug: 253520701
Test: Manual
Change-Id: Ied18b88a83a3b673a7cf40fd33b6013f24998e44
2023-03-17 23:20:36 +00:00
Pat Manning 745010e6c9 Merge "Revert "Stash taskbar on swipe to go home for 3p fallback launcher."" into tm-qpr-dev am: c58e2be2dd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119024

Change-Id: Iaa33b85cdc5f90bbac962e7272815756a105ed11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 22:49:24 +00:00
Pat Manning c58e2be2dd Merge "Revert "Stash taskbar on swipe to go home for 3p fallback launcher."" into tm-qpr-dev 2023-03-17 22:18:15 +00:00
Jon Miranda 4b5f6913ef Fix QSB flicker when returning home.
We only set qsb alpha if isQsbInline = true, since that is when
we draw/animate the qsb in the taskbar.

Fixes: 269164187
Test: isQsbInline = true / false
Change-Id: I92022135e74f734a8e50c606dc9c605df39a9f97
2023-03-17 13:38:39 -07:00
Mateusz Cicheński 2ef25f91ba Enable ENABLE_PIP_KEEP_CLEAR_ALGORITHM for teamfood
Change-Id: I7c09494514dd6ea1baea51a03114c8e77cae118d
Test: atest WMShellFlickerTests
Bug: 183746978
2023-03-17 19:37:41 +00:00
Hongwei Wang e83a3e29d4 Merge "VisD update for the PipAppIconOverlay 2/N" into tm-qpr-dev am: 452e014caa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22107736

Change-Id: Icc997145598aa5b0575558546eddd1e294085a29
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 16:54:41 +00:00
Hongwei Wang 452e014caa Merge "VisD update for the PipAppIconOverlay 2/N" into tm-qpr-dev 2023-03-17 16:24:56 +00:00
Mike Schneider ea674e208c Merge "Add optional debug logging to on flag changes" into tm-qpr-dev am: 8daf6d804e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21868395

Change-Id: I8a871b40687dffb7feb45fb7da9b27727e36ba97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 08:28:05 +00:00
Mike Schneider 8daf6d804e Merge "Add optional debug logging to on flag changes" into tm-qpr-dev 2023-03-17 07:54:33 +00:00
Goooler 0a029d9ef5 Fix NPE in DepthController (#3371) 2023-03-17 11:51:59 +08:00
Ats Jenk aacd5d330b Merge "Make sure desktop task view is only used in proto 2" into tm-qpr-dev am: b219e31477
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22121446

Change-Id: I8ee5c66b978ce10da77f167d3dbbc45504394790
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 22:33:50 +00:00
Ats Jenk b219e31477 Merge "Make sure desktop task view is only used in proto 2" into tm-qpr-dev 2023-03-16 22:00:00 +00:00
Ats Jenk 20f89a41f4 Merge "Directly use launcher activity interface" into tm-qpr-dev am: 8b4ac56ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22121678

Change-Id: If5e7027172b903c14831627f51930e5b6d9b077d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 20:59:14 +00:00
Ats Jenk 8b4ac56ee2 Merge "Directly use launcher activity interface" into tm-qpr-dev 2023-03-16 20:24:06 +00:00
Tony Wickham ec6fd6ffb5 Update folder leave-behind color for taskbar
Test: open folder in light theme and dark theme
Fixes: 265828742
Change-Id: Ib544ab85dad16c203917ae02f924650e8a5bbc6f
2023-03-16 18:13:20 +00:00
Pat Manning 6bf7c6b816 Merge "Add automirroring to kids mode back button." into tm-qpr-dev am: aaa932d78c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099529

Change-Id: Ibb3b22420e54291613edba5806446dbe0284b5ba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 17:02:42 +00:00
Ats Jenk 6adae751e7 Make sure desktop task view is only used in proto 2
When swiping up to recents and creating the current tasks TaskView, we
were checking for proto 1 or proto 2 to be enabled. And if they were, we
were creating the DesktopTaskView object. The DesktopTaskView should
only be enabled in proto 2.
Updated the feature flag check.

Bug: 273950066
Test: enable proto 1 and gesture nav, have a desktop app open, swipe up
  to recents, no desktop tile
Test: enable proto 2 and gesture nav, have a desktop app open, swipe up
  to recents, see the desktop tile
Change-Id: I73a47347d60e0f57ad6cf6e363a6fe83ac8cc509
2023-03-16 09:26:10 -07:00
Pat Manning aaa932d78c Merge "Add automirroring to kids mode back button." into tm-qpr-dev 2023-03-16 16:23:00 +00:00
Tony Wickham 08ea122c79 Fix launcher <-> taskbar dark themed icons background color
- Moved colors to final in TaskbarViewController (since controllers are
  recreated on theme change)
- Clarified some variable names
- Animate from progress 1 to 0 instead of vice versa, since 0
  corresponds to launcher's theme icon color which is what the alignment
  animation is going towards

Test: in gesture nav with dark themed icons in hotseat, go to overview
and ensure smooth transition to ligher themed background; return home
and ensure reverse transition
Flag: none
Fixes: 271651337

Change-Id: I4451f995a3e79e512c59a834051f601ead70ff87
2023-03-16 16:04:50 +00:00
Ats Jenk c7c9d594a1 Directly use launcher activity interface
When desktop tasks become visible or hidden, we update a SysUI state
flag. This flag update gets processed in TouchInteractionService which
then calls DesktopVisibilityController to update launcher state based on
whether desktop tasks are visible or not.
We were getting a reference to the DesktopVisibilityController through
OverviewComponentObserver. This was causing issues when device was
unlocked with desktop tasks visible. And 3-button navigation was enabled.
In this scenario, we are immediately processing a SysUI flags update
that desktop tasks are visible again (they are hidden while device is
locked). When this update is processed, OverviewComponentObserver
returns the fallback launcher interface. And not the nexus launcher.
The fallback launcher interface does not contain the
DesktopVisibilityController. Since the fallback controller does not
return the visiblity controller, we skipped processing the update that
desktop tasks are visible. Which resulted in launcher remaining in a bad
state with home screen icons visible and desktop tasks on top.

Bug: 273594452
Test: enable 3-button nav and proto 2, move an app to desktop, lock
  screen with desktop app visible, unlock screen, observe launcher icons
  hidden
Test: enable gesture nav and proto 2, move and app to desktop and lock
  screen with desktop app visible, unlock and observe launcher icons
  hidden
Test: repeat the same steps with proto 1 enabled
Change-Id: Id52ac4cf2df151b2aee2070ee2eb14de3d74fead
2023-03-16 08:58:50 -07:00
Pat Manning f0c7fa20ca Revert "Stash taskbar on swipe to go home for 3p fallback launcher."
This reverts commit 9fdd7a1340.

Reason for revert: testing for b/273809618

Change-Id: Icd0b862f1f5a5a9930a08774c339f21e740d2fa0
2023-03-16 15:53:53 +00:00
Nick Chameyev 6a9535e00c [Unfold animation] Adjust animation parameters
Turns down the amount of translation/scale
of the animation to make it more subtle.

Bug: 271563317
Test: manual
Change-Id: I1cdd045cf4e045a9a238e71a6315d7d813e9f398
2023-03-16 15:32:07 +00:00
Tony Wickham 0c6ccca22d Restore proper nav buttons translation when taskbar is recreated
Since mTaskbarInAppDisplayProgressMultiProp is set by various states
that are hard to query in init() (e.g. state of all apps, -1, widgets,
etc.), we store the last mTaskbarInAppDisplayProgressMultiProp in the
TaskbarSharedState and restore those values in init().

Also updated some debug logs in the dump.

Test: manual: from home screen, swipe down to quick settings and toggle
Dark theme, ensure nav buttons don't translate; do the same but over
launcher all apps
Flag: none
Fixes: 267325761

Change-Id: Ib8e6778582ed39c674cd3c1e95312e673659f6a7
2023-03-16 00:06:22 +00:00