Commit Graph

19551 Commits

Author SHA1 Message Date
Federico Baron 47b45c6d0d Modify logging to log the specifc grid size when taking a snapshot
We do a snapshot once a day, so this would get us an accurate number for
how many users have each grid type on any given day

Bug: 401051097
Test: EXEMPT logging
Flag: EXEMPT add logging
Change-Id: I74a14e6df51cb8c3872021520f527d6eca44cfe3
2025-03-06 13:56:10 -08:00
Sunny Goyal 84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Treehugger Robot 325545ac2f Merge "Allow recent task to have long-press menu" into main 2025-03-04 20:11:42 -08:00
Treehugger Robot 57cab7794a Merge "Simplifying some view iteration methods" into main 2025-03-04 18:42:06 -08:00
Wen-Chien Wang 5ada92b966 Allow recent task to have long-press menu
Bug: 375648361
Bug: 344657629
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu

Change-Id: If496c56a3fe47905a3e9947407f51077f180d5a2
2025-03-04 21:47:32 +00:00
Sunny Goyal 476d926972 Simplifying some view iteration methods
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ieffa3a66fbf8595d542995c348df578a3aec9083
2025-03-04 10:39:55 -08:00
Charlie Anderson ded687da03 Merge "Make sure folder positioning is behind flag" into main 2025-03-04 10:39:26 -08:00
Treehugger Robot aeb890b43d Merge "Revert "Not refresh predicted app in right click"" into main 2025-03-04 09:29:57 -08:00
Sunny Goyal 372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Charlie Anderson 9b001f527e Make sure folder positioning is behind flag
Bug: 392610664
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually verify with flag on/off
Change-Id: I3564a0fee5bf0948994c056fd22f4e2c3c91f0ee
2025-03-04 11:15:29 -05:00
Daniel Chapin f65c5d1c02 Revert "Not refresh predicted app in right click"
This reverts commit b17cde5c3a.

Reason for revert: bug: b/400596380

Change-Id: I8f4d6755653d59ec6264bf93a2835c60122640be
2025-03-04 07:06:52 -08:00
Wen-chien Wang 8444f38c92 Merge "pin-shortcut: Tracks hotseat states and adds unpin option for taskbar" into main 2025-03-03 16:50:48 -08:00
Treehugger Robot 19e93afd91 Merge "Test all apps -> workspace drag for taskbar on home" into main 2025-03-03 11:59:21 -08:00
Ana Salazar Maldonado 0a128474db Merge "Fix tokens for App Contrast Pill" into main 2025-03-03 10:55:39 -08:00
Sunny Goyal 5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Helen Cheuk 7fd7325fb8 Merge "Not refresh predicted app in right click" into main 2025-03-03 08:44:59 -08:00
helencheuk b17cde5c3a Not refresh predicted app in right click
When users right click the mouse/touchpad, predicted apps in hotseat refresh and it is weird.
It refreshes because the right click is treated as a drag and a drag would trigger predicted apps refresh.
This fix adds a PreDragCondition to avoid it from starting drag.

Bug: 343650193
Test: Manual, connect to touchpad and right click on widget and folderIcon
Flag: NONE, Bug fix
Change-Id: I650f34f02a920b61e3a1f1ada7d2da10e1625e47
2025-03-03 14:37:05 +00:00
Uwais Ashraf f58fbaae2d Merge "Revert "Fix OutlineProvider for PageIndicatorDots for new visual updates."" into main 2025-03-03 06:28:16 -08:00
Pechetty Sravani (xWF) 6208483668 Revert "Fix OutlineProvider for PageIndicatorDots for new visual updates."
This reverts commit c09f4d331a.

Reason for revert: <Droidmonitor created revert due to b/400302622.Will be verified through ABTD for standard investigation.>

Change-Id: Ie088a7ceebb79966c9951e13ed0059c8ea75ca6c
2025-03-03 00:43:57 -08:00
Treehugger Robot 7caa7cb9be Merge "Fix OutlineProvider for PageIndicatorDots for new visual updates." into main 2025-03-02 17:34:20 -08:00
Treehugger Robot b43cae24a4 Merge "Fix home screen page description when removing an existing page." into main 2025-02-28 21:26:35 -08:00
Mykola Podolian b0fe82378a Merge changes from topic "bubblebar_drop_target" into main
* changes:
  Removed fly-back animation after a taskbar item drop on the bubble bar
  Added BubbleBarLocation drop target.
2025-02-28 18:02:48 -08:00
Treehugger Robot 55dd78123c Merge "Taskbar on home should open all apps that support drag to workspace" into main 2025-02-28 17:04:20 -08:00
Treehugger Robot dad3394772 Merge "Fix LauncherPrefs crash by allowing sub-types of Set" into main 2025-02-28 16:49:02 -08:00
Toni Barzic a5c5536d7d Test all apps -> workspace drag for taskbar on home
Adds TAPL test that verifies users are able to drag app items from all
apps to workspace when all apps is opened on from a pinned taskbar shown
on the home screen, as may be the case when a desktop mode taskbar is
shown on home screen.

Adapts LauncherInstrumentation to handle the case where taskbar is shown
on home - when verifying launcher states, it sets taskbar visibility
expectations to account for a posibility that taskbar is visible in
home, or workspace states. Adds a request to the test protocol to
determine whether taskbar should be visible on home.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: Ran TaplTestLockedTaskbar tests
Change-Id: I40b06da70aaa49b0a3e0673797e6c18773a72238
2025-03-01 00:31:46 +00:00
Stefan Andonian c09f4d331a Fix OutlineProvider for PageIndicatorDots for new visual updates.
Bug: 394355070
Test: Verified locally that the active indicator is outlined properly.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Ia8bd95285292c532f741707e446c83df01c3d540
2025-02-28 15:12:28 -08:00
Brian Isganitis fbe72436c8 Merge "Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE." into main 2025-02-28 14:58:30 -08:00
Charlie Anderson 4e4ad89696 Fix LauncherPrefs crash by allowing sub-types of Set
Bug: 396616795
Test: LauncherPrefsTest
Flag: EXEMPT bugfix
Change-Id: Id380a6e4bb5eb809978070ff1b523c9e98e6b869
2025-02-28 21:57:43 +00:00
Toni Barzic 26ad16592a Taskbar on home should open all apps that support drag to workspace
If taskbar is shown on home screen, have the taskbar all apps button
toggle the launcher activity version of all apps UI. This makes the
behavior consistent with how all apps system action (keyboard shortcut)
works, and addresses a gap in functionality where users are unable to
drag apps from the taskbar all apps UI to the workspace.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: On desktop device, toggle all apps from taskbar on home screen,
      drag and app from all apps to workspace.
Change-Id: Ida0f230bf38c6e1e35041556f33de1be85daf785
2025-02-28 21:31:46 +00:00
Treehugger Robot d300486e66 Merge "Adding option to skip animations for testing" into main 2025-02-28 13:10:53 -08:00
Ana Salazar Maldonado d4cce41c27 Fix tokens for App Contrast Pill
Bug: 397101795
Test: update screenshots
Flag: com.android.launcher3.enable_contrast_tiles
Change-Id: Iffe86d8b1bdebbf8ddab9dcfd6197ad24edb684f
2025-02-28 11:23:44 -08:00
Brian Isganitis 8bab8eb171 Remove TYPE_TASKBAR_OVERLAY_PROXY from TYPE_ACCESSIBLE.
The invisible proxy view was preventing anything below it from being
accessible.

Flag: EXEMPT bugfix
Fix: 377526512
Test: #14 in bug.
Change-Id: I9d4596ebbbc4317a9ff7ded37b43b5fa1885e6ea
2025-02-27 19:41:48 -05:00
Treehugger Robot 1e8125c76b Merge "Merging some notification dots implementation" into main 2025-02-27 16:08:10 -08:00
Treehugger Robot 029b6016d2 Merge "Fixing widgets broken during reconfiguration" into main 2025-02-27 15:59:30 -08:00
Jagrut Desai 2ac4d9c794 Merge "Update Taskbar Icon content description to include state description" into main 2025-02-27 15:47:09 -08:00
mpodolian c666b9587b Added BubbleBarLocation drop target.
A drop target for the BubbleBarLocation has been added. This
implementation enables the Launcher process to handle application
drag-and-drop actions onto the bubble bar.

Known issues:
1) Upon dropping, the dragged icon animates back to its original taskbar
position from the top-left corner.
2) The expanded view drop target is not presented.
3) When an icon is dropped on the opposite side of the bubble bar, the
resulting location does not change, even though the drop target is
correctly displayed.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Navigate to the overview screen, drag a taskbar icon to
the left or right side, targeting the bubble bar drop zone. Verify the
drop target's appearance. Then, drop the icon and observe that a new
application bubble is added.

Change-Id: I0f64a664620959f2503ac3fd711476b354a09348
2025-02-27 14:32:32 -08:00
Treehugger Robot 8459313c57 Merge "Converting LauncherBindableItemsContainer to kotlin" into main 2025-02-27 14:07:03 -08:00
Treehugger Robot a708bee45b Merge "Fix jumpcuts in folder background color when opening/closing" into main 2025-02-27 14:01:50 -08:00
Alex Chau ee1bae7d72 Merge "Multi property refactor" into main 2025-02-27 13:41:07 -08:00
Treehugger Robot 9a5cd11da5 Merge "Move MainThreadInitializedObject to Launcher3 Go." into main 2025-02-27 13:03:12 -08:00
Sunny Goyal fc2735ed96 Fixing widgets broken during reconfiguration
Async widget inflation may complete after the updates have been deferred,
leading the widget to a broken state.
Reapply widget if its root content changed while deferred

Bug: 375442765
Bug: 327696338
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I78d0f4ce92ee9bd2ee001de3a0e181f2e727218c
2025-02-27 12:36:15 -08:00
Shamali P 94e276c1c5 Fix home screen page description when removing an existing page.
When we remove an in-between or last empty page, we manually set the
current page but don't update the description that's set on the
accessibility view. Due to which, when talkback focuses on it, it sees
the stale page count in the description.

This fix ensures to keep the state updated during removal.

Bug: 390360063
Fix: 390360063
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: Idd9a54d3a1ee43e56f51db78e614776eca6a12f7
2025-02-27 12:16:23 -08:00
Charlie Anderson 4ac496c510 Merge "Make Folder preview items appear as square grid instead of circle" into main 2025-02-27 11:49:43 -08:00
Sihua Ma 4160ad3967 Fix jumpcuts in folder background color when opening/closing
Background drawable is not associated with any folder view, and as a
result invalidating the drawable doesn't cause it to be redrawn on the
screen

Fix: 392617057
Bug: 399674389
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I6d2bd97f66b53cdbeb4a715e53ff89b3450546f0
2025-02-27 18:48:51 +00:00
Sunny Goyal d237c9587b Converting LauncherBindableItemsContainer to kotlin
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I4d2fa18b6b275742d84de16ed604987c2deee6e8
2025-02-27 10:34:37 -08:00
Jagrut Desai 536097dec2 Update Taskbar Icon content description to include state description
This cl inlcudes: while user is in desktop mode, we will add state description(active, minimized) of each app icon to it's content description.

Test: Manual
Bug: 397555157
Flag: EXEMPT bugfix
Change-Id: Iaec18e7099108e8b076b76c637a41e29ed837265
2025-02-27 09:58:31 -08:00
Charlie Anderson 39f902cd84 Make Folder preview items appear as square grid instead of circle
- Eventually we should remove circular geometry from ClippedFolderIconLayoutRule altogether

Bug: 392610664
Test: changing shapes with different size folders
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I15c854c19186a3e4262e8d2b40960f3519ec2729
2025-02-27 09:09:10 -08:00
Sunny Goyal 39063bf167 Merging some notification dots implementation
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ie02311afba85f06fbafd265a5015cd23bd356a36
2025-02-27 08:50:26 -08:00
Sunny Goyal d8e5ddb4cd Removing unnecessary isBindingItems method from ActivityContext
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I06fd1dcc81da5e5502a9fb0751c2701b26fd4621
2025-02-27 08:49:33 -08:00
Alex Chau 3c3d636dc9 Multi property refactor
- Introduced MultiPropertyDelegate to delegate Kotlin var to MultipPropertyFactory, allowing easy creation of var for MultiPropertyFactory
- Introduced KFloatProperty to map any Kotlin var to a FloatProperty, which simplify the code to creaet FloatProperty a lot
- Combined the above to refactor usage of MultipPropertyFactory, use var to simplfiy things, and expose them as FloatProperty directly when needed

Fix: 399635468
Test: Smoke test main flow of enter Overview, task launching etc.
Test: presubmit
Flag: EXEMPT REFACTOR
Change-Id: Ie7dd8b69da7e3bda9026a0ef7b0377c26a78a332
2025-02-27 16:01:32 +00:00