Bug: 247880037
Test: manually tested app popup. Also ran Launcher tests locally with U flag on/off.
Change-Id: I93c04f9715d583376c36d823c23353619afd26b6
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.
bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after: https://screenshot.googleplex.com/7pkwUto6HGzMYoT
Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.
Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
Previously 'no widgets found' appeared on the left pane, but in large screen landscape we want it to appear on the right pane. Additionally, we added rounded edges to the right pane that turn into sharp edges when we scroll.
Fix: 268558448
Fix: 268557435
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and on tablet landscape mode go to the widget picker and search for a widget that doesn't exist, verify that 'no widgets found' appears on the right pane. Also verify that right pane has rounded corner that turn into sharp corners as we scroll
Change-Id: I6c89c63941e3b0680836828d0c7849d789cbce61
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.
Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d
Widget picker had weird issues because when we adjusted margin/padding on orientation change we were changing margin/padding of things that didn't have that amount set initially. The function onContentHorizontalMarginChanged was changing the margin/padding of recyclerviews and the stickyheaderlayout. This corrects the issue and there should be no margin/padding errors when we rotate, as the recyclerviews and stickyheaderlayout have the right margin set from the beginning.
Fix: 269348654
Test: Go to widget picker on tablet, rotate to landscape/portrait, rotate back to landscape/portrait. Verify that marins on the sides of widget picker are correct.
Change-Id: If5a26ae23b440c8a4a55cd0029042b2a5d5398b3
1. setClipChildren(false) for WidgetFullSheet and content view during animation
2. setClipToOutline(true) for WidgetsRecyclerView and provide ViewOutlineProvider to expand bottom by 5% of height
3. Override calculateExtraLayoutSpace() for ScrollableLayoutManager
4. Manually modify AbstractSlideInView#mContent's background drawable during scale animation
bug: b/260956481
Test: manual
Change-Id: Ic391639de887cf4a70bc4965dc0b1fd9bc12dd2c
Now pressing the enter key will exit the keyboard instead of clearing
filtered results.
Test: manual
Bug: 269200077
Change-Id: I9b717aa3300cad1eede874108e50dd62eeec82ff
used for all entries
This helps reduce launcher memory by avoiding multuple duplicate
drawable generation
Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
The widget picker design is currently not optimized for large screen form factor devices.
We resolve that by adding a two pane widget picker like that of the design in go/widget-picker-2023.
Bug: 256684299
Test: Make sure to be on a tablet in landscape mode.
1.Turn on flag LARGE_SCREEN_WIDGET_PICKER.
2. Press and hold on an empty spot in workspace until the popup menu appears.
3. Click widgets.
4. Notice the new two pane layout
Change-Id: Ia3ea17dc320f72f9bc5dea52399ff51d9161602b
This CL will make sure scale animation doesn't reveal the offscreen main/work recycler view on tablet in all apps to home transition
Bug: b/267226558
Test: manual, see before/after video in bug
Change-Id: I9a8add0ac2c902e3f4315de099939f9297f6604a
Before this change removing the competing long press haptic,long
pressing to drag the widget causes a doubleclickesque haptic because
of the first haptic being quickly cancelled.
Bug: 257531349
Test: manual
Change-Id: I320339725f5ba27a22e550c28838adda94384c0f
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher
Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
Removes background and manually draws it while drawing scrim. Then
draws header protection on top as needed.
Currently this only applies to all apps from Launcher, as Taskbar
doesn't seem to use the same scrim flow. So taskbar adds the same
static background that was previously used.
Demo videos: https://drive.google.com/drive/folders/11PyFsrLV6-QhU_E-zD3s5bfzZK2nOU87?resourcekey=0-E41uw5TP9xuqTifLAs71yw&usp=sharing
Test: Manually on phone and tablet with dark/light mode, floating
search bar on/off, work profile present/absent, taskbar/home entry
Bug: 240670050
Change-Id: I81dcc956d9dbbc7552c8a227a49741bcf71eed71
- Adds background protection for the search bar
- Views animating based on keyboard now support manual swipes.
Bug: 213954333
Bug: 259004115
Bug: 251460671
Test: Manual
Change-Id: I055766126fb46a8e8b48907e442c9e54aaa4badf
We can reuse the all_apps_content.xml in other all_apps.xml
This is step1. As step2, I will refactor secondary_launcher.xml
and taskbar_all_apps.xml.
Bug: 204781396
Test: Manual
Change-Id: Ia842ca082ec38220d327f512221807ed21ad2ad3
Previously, the margin of the recommendation table was changed to fix the bug b/209579563 , but this leaves a bug where the left/right sides of the recommendation table would be too close to the screen border. This CL should leave enough space for both sides and reveal the scroll bar again, while keeping the talkback focused on the title first once it enters the widget picker.
Test: Manual
Bug: 206481237
Change-Id: I808c279c3264a51b21a0bb7af8ca455d284e36ff
Before the flag name would only fit 'delightful pagination' for folders, but now we're adding that feature to workspace also, hence the flag rename.
The flag is now also used in launcher to show the new XML file that uses PageIndicatorDots rather than WorkspacePageIndicator
Bug: 249773534
Test: manual
Change-Id: I6cf6d52e76ad1ec60ecb54c5cca204e9ac35cc39
The alpha wasn't initialized properly so the footer would show up before it was expected to. Alpha is now initalized in the XML file so that the footer starts to appear only once the animation begins.
Test: Manual
Fix: 233690408
Change-Id: I9e08547401cb37ce2f9e711fc4ba000250c49c2e
Reduced elevation of app drawer to 0dp because it was conflicting with popup container elevation
Test: Manual
Change-Id: I222866ddfc44ebf9ecd9787bb448e502339a1688
Fix: 233932585
(cherry picked from commit 354fe14cd4)
Charlie Anderson
Brandon Dayauon
TreeHugger Robot
Federico Baron
Fengjiang Li
Tony Wickham
Sunny Goyal
Sebastián Franco
Sihua Ma
Jagrut Desai
Jason Mylen
Andy Wickham
Anushree Ganjam
Thales Lima
Mateusz Cicheński
Sukesh Ram