cafab1d7cc
Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029
Change-Id: Ie1f24b78ea9f49a1089e15331cadc35af0073490
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-30 16:47:18 +00:00
d8e5795131
Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922
Change-Id: I916c0e191cb2e335b9e393ea76c34cff39778481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-30 16:47:04 +00:00
1db2fcbd19
Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev
2023-03-29 18:54:22 +00:00
90259a6db4
Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev
2023-03-29 17:03:59 +00:00
95c9996088
Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev am: eed10f31f7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22296252
Change-Id: I0222aa84ca570dd7aa97880fee3d54877c990660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-28 22:45:21 +00:00
eed10f31f7
Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev
2023-03-28 22:30:56 +00:00
a402713eb2
Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev am: 40f065d1fd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21995352
Change-Id: I031594c4dc3fd7e230d41a63939995172f1a2534
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-28 22:29:22 +00:00
40f065d1fd
Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev
2023-03-28 22:02:03 +00:00
857c24a3f6
Merge "Make taskbar accessibility announcement when user is in app only." into tm-qpr-dev am: 6fcdfb166d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22244591
Change-Id: I7c147e306d91535170485c8cd9c0d0492e8083e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-27 22:58:21 +00:00
6fcdfb166d
Merge "Make taskbar accessibility announcement when user is in app only." into tm-qpr-dev
2023-03-27 22:38:54 +00:00
2851be8cba
Add the gesture nav tutorial menu page
...
- Added the gesture tutorial menu page (launched using an intent extra)
- tutorial steps now launch the menu when complete if launched from the menu
- the new default set of tutorial steps is home -> back -> overview. this is to handle the case where an intent is launched that is meant to launch the tutorial menu, but ENABLE_NEW_GESTURE_NAV_TUTORIAL is false
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 274463555
Test: Ran the tutorial and menu on a large screen, foldable and phone
Change-Id: I2eb5f658115be4d5ecb0233a8f09d22efe6ebadc
2023-03-27 14:36:01 -07:00
7cd0ae3f73
Fix TwoPanelWorkspaceTests
...
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click
Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
f96827b331
checking if outline provider is null to handle rare NPE
...
test: verified that a null value wouldn't cause a crash, and would still show the well being toasts correctly. defaulting a value could cause abnormal behavior so I have created a task to follow up with to figure out why this value is being set to null.
bug: 236918951
Change-Id: I9d4282273cb0bc5b6b095dbd082dd1ef79add0dc
2023-03-27 20:18:46 +00:00
f641813483
Add extra error checking for Home Gesture Tutorial
...
Add an error message for when a user swipes horizontally from the middle
of the screen.
Fix: 275386244
Test: Manual
Change-Id: If4d0dd412c3d1625da18f9c068e5fd7b281548c5
2023-03-27 19:56:35 +00:00
4661854dd6
Make taskbar accessibility announcement when user is in app only.
...
Test: Manual
Bug: 265099829
Change-Id: I9d90ed7ae3479cf51b261bba63aedccf515bd2c5
2023-03-24 17:02:58 -07:00
55c85ef2f2
Merge "Revert "Do not allow system gestures when dreaming."" into tm-qpr-dev am: 1276443016
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22244586
Change-Id: Id879fd8d97166bb8818e45e49eafc453fd7ab87f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 23:36:43 +00:00
1276443016
Merge "Revert "Do not allow system gestures when dreaming."" into tm-qpr-dev
2023-03-24 22:58:03 +00:00
3cd39729dc
Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076
Change-Id: I687ea2a249e73036f8d4c4d187d999fd224b9f02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 22:02:13 +00:00
bb1237eb76
Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev am: e8abfee5e9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22067827
Change-Id: I1d5e7b401cfb874a0f801cfc0b5b76b53a608c64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 22:00:27 +00:00
085c53869f
Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev
2023-03-24 21:51:42 +00:00
e8abfee5e9
Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev
2023-03-24 21:41:04 +00:00
d914d88884
Merge "Update transient taskbar shadow alpha for light/dark theme." into tm-qpr-dev am: d22b3af81c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22235599
Change-Id: Ie6b6229342e4c6d473d98ee4594d648095f5babc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 19:40:17 +00:00
9c478b6c29
Add taskbarIconSize to GridOption/DisplayOptions
...
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
sizes
Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
340f6c0988
Revert "Do not allow system gestures when dreaming."
...
This reverts commit 05c9d551d8
2023-03-24 18:34:11 +00:00
a8f03bbe13
Update transient taskbar shadow alpha for light/dark theme.
...
Bug: 259712417
Test: manual
Change-Id: If3b24efa7b619501e8ed07621d8673e68d2c903d
Flag: ENABLE_TRANSIENT_TASKBAR true
2023-03-24 17:22:39 +00:00
d49c81775b
Merge "Auto-stash taskbar when locking device" into tm-qpr-dev am: 1a09d4a2a2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22196304
Change-Id: I3b35873bda6a7e65e4b0b290a25e278fd9c5efe9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 11:00:20 +00:00
1a09d4a2a2
Merge "Auto-stash taskbar when locking device" into tm-qpr-dev
2023-03-24 10:32:43 +00:00
cea344515e
Merge "Fix taskbar linger above notification shade" into tm-qpr-dev am: 96892011ff
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22162582
Change-Id: Iec6bfc729ea0c5b9c40cc3f491dd850427039349
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 10:05:08 +00:00
96892011ff
Merge "Fix taskbar linger above notification shade" into tm-qpr-dev
2023-03-24 09:46:42 +00:00
9e4619e243
Merge "Make clear announcment for taskbar education." into tm-qpr-dev am: 601e0ff89c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146024
Change-Id: I17dcffb5e72b672fedd2d54bbee6f09f99a395dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-24 00:24:37 +00:00
601e0ff89c
Merge "Make clear announcment for taskbar education." into tm-qpr-dev
2023-03-23 23:52:24 +00:00
a106266c06
Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev am: bc65c3d442
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22225432
Change-Id: Ic742a73372f90ac630af30af51d5313ede0283f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-23 21:17:39 +00:00
bc65c3d442
Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev
2023-03-23 20:39:06 +00:00
0324f024b0
Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev am: 2b8b47952f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22147222
Change-Id: I6d774a769e11294efd0b0bd39429807528176b18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-23 19:47:22 +00:00
ba19f31669
Auto-stash taskbar when locking device
...
This greatly reduces the the jank of the taskbar being shown above the
lockscreen.
Before: http://shortn/_PhXhkWR73t
After: http://shortn/_MC3ZLGHp4o
Bug: 264604213
Test: manual (http://shortn/_ISEXThUFM2 ), tapl
Change-Id: Ib1c5dbaafd4d0e1d69fbc03d908632e0275c8a0b
2023-03-23 19:30:12 +00:00
2b8b47952f
Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev
2023-03-23 18:54:09 +00:00
ef1a9b798d
Make clear announcment for taskbar education.
...
Test: Manual
Bug: 273393698
Bug: 273408584
Flag: not needed
Change-Id: I6c6eb1e1e1047a2e702592290bf5735e8bfa6ce2
2023-03-23 11:26:09 -07:00
3d8a020ab5
Merge "Update nav bar buttons to spec." into tm-qpr-dev am: fc8606dadc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22211900
Change-Id: I420f528cb0558fb3b7716df9f0b26344c392c9e6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-23 18:20:13 +00:00
0f43611645
Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345
Change-Id: I25e8204b0e93dd986a88329d53fef8e0507b7832
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-23 18:18:42 +00:00
70727e87eb
Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev
2023-03-23 18:03:14 +00:00
fc8606dadc
Merge "Update nav bar buttons to spec." into tm-qpr-dev
2023-03-23 17:37:53 +00:00
cbe578b269
Merge "Fix spring not springing when unstashing." into tm-qpr-dev
2023-03-23 17:37:35 +00:00
04c6def895
reorder System shortcuts for taskbar and secondary display
...
Bug: 269343928
Bug: 272418357
Test: locally on device
Change-Id: Iec7f9ad702214c7ab7f49758dbf2463fe63b0324
2023-03-23 15:27:12 +00:00
c73db73a79
Handle swipe down on taskbar to stash
...
- Moved all touch-to-stash logic to new TaskbarStashViaTouchController
(handles both tap outside to stash instantly as well as swipe down
inside to stash after letting go)
- This is a TouchController on TaskbarDragLayer, so it intercepts
touches from TaskbarView before icons can be dragged during swipe down
Test: swipe up to invoke transient taskbar in an app, swipe down or
touch outside to stash
Flag: ENABLE_TRANSIENT_TASKBAR=true
Fixes: 246631710
Change-Id: I5cf64848bba34ad32fcc80a93fb4f79ebd2c10a7
2023-03-23 15:13:52 +00:00
94a6313bbf
Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243
Change-Id: I71e90d16b58de5f99db0838219e9624b06d77645
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-23 11:33:21 +00:00
c2e5bfca50
Fix taskbar linger above notification shade
...
Remarks:
1. I think the correct fix for this would be to have the Taskbar z-ordered below the notification shade. That however seems to be difficult because there are cases when the taskbar window must be above the notification shade.
2. This CL improves the behaviour by starting the taskbar disappear animation when the notification panel is half expanded instead of waiting for the full expansion. This improves the UX when expanding the shade slowly. When expanding the shade quickly, this CL does unfortunately not significantly improve the UX.
3. I believe that the `SYSUI_STATE_NOTIFICATION_PANEL_EXPANDED` and `SYSUI_STATE_QUICK_SETTINGS_EXPANDED` flags can be replaced by the newly introduced one. But since this would pose the risk of introducing new bugs, I did not do that in this CL. It is my intention to create a CL with that replacement in udc.
Bug: 272621219
Test: Manual, i.e. observe Taskbar behaviour when pulling down notification shade and expanding quick settings
Change-Id: Ic79d3f41ed224cb1abdbac9011c6d27e0f458ec2
2023-03-23 10:31:25 +01:00
43700f61f7
Ensure FLAG_IN_APP is correctly set after launcher-restart.
...
This is a follow-up to ag/21699905, which caused the nav-bar to be visible after a device-restart alongside the hotseat, until an app was launched.
Currently, when restarting launcher (for example a device restart), there is no guarantee when the SysUI flags are received for the first time. The current init-codepath expects the launcher to be fully initialized at the time. From there, only deltas are processed:
- during the initial resume, launcher is not considered active because the screen is still off
- the SCREEN_ON event itself is not processed to update the FLAG_IN_APP
Before: http://shortn/_MGQjGFRIaB
After: http://shortn/_awiv2CxFn9
Bug: 261418621
Test: manual (http://shortn/_ty9EDuLM97 ), tapl
Change-Id: Ie3b3ba1ebe249efe8fc43850052bc9956cafcd24
2023-03-23 08:54:01 +01:00
8ab17926ac
Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682
Change-Id: I4c5ee30a5256ff07afb805b7f2f98793976b6e43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-23 07:07:51 +00:00
064d88d8b8
Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev
2023-03-23 06:25:43 +00:00
071a196a77
Update nav bar buttons to spec.
...
Bug: 259712417
Test: manual
Change-Id: I9ec51dc99392e371c15e3918af239a0970809ec2
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-22 18:00:38 -07:00
Schneider Victor-tulias
Saumya Prakash
Randy Pfohl
Jagrut Desai
Bryce Lee
Jon Miranda
Hyunyoung Song
Mike Schneider
Johannes Gallmann
Charlie Anderson
Tony Wickham
Bill Yi
Jerry Chang