Commit Graph

14642 Commits

Author SHA1 Message Date
Alex Chau 4537638dfd Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev 2022-12-19 11:37:39 +00:00
Andy Wickham 36e2ae4cba Merge "Adds additional top padding in All Apps with floating searchbar." into tm-qpr-dev 2022-12-19 11:23:14 +00:00
Luca Zuccarini 49d07b1688 Merge "Update timings for the Home <> All Apps transition." into tm-qpr-dev 2022-12-19 11:10:14 +00:00
Thales Lima 6a59006592 Polish hotseat and taskbar with 3 buttons
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
2022-12-17 11:20:21 +00:00
Holly Jiuyu Sun be61b0735c Merge "No need to override the isImeEnabledOnSwipeUp flag in Launcher3." into tm-qpr-dev 2022-12-17 01:21:42 +00:00
Sebastián Franco 791c9dbf8d Merge "Clean mPreviousSolution on change of CellLayout target" into tm-qpr-dev 2022-12-16 22:43:09 +00:00
Alex Chau 98d33cdff9 Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev 2022-12-16 16:45:21 +00:00
Pat Manning 346ca5abcc Merge "Match ArrowTipView width to parent so text can center." into tm-qpr-dev 2022-12-16 13:54:28 +00:00
Andy Wickham 9cdba2f395 Adds additional top padding in All Apps with floating searchbar.
This is by UX/PM request.

Test: Manually with and without work profile on phone and tablet
with floating search enabled and disabled.
Bug: 213954333

Change-Id: I024aed629ab6f09b3dfd22a39c2149974863538e
2022-12-15 15:29:46 -08:00
Alex Chau 0c2d7e8da3 Merge "Use overridden default xml for TwoPanelWorkspaceTest" into tm-qpr-dev 2022-12-15 23:09:13 +00:00
Jeremy Sim 2ebdc76fa5 Merge "Fix juttering problem with split staging animation" into tm-qpr-dev 2022-12-15 21:38:31 +00:00
Holly Sun f565d1bafa No need to override the isImeEnabledOnSwipeUp flag in Launcher3.
It's only used in NexusLauncher now.

Bug: 262729669
Test: manual
Change-Id: Ic145d7ad007ec314974713b6c4bf880d55607cf7
2022-12-15 12:18:27 -08:00
Pat Manning 618df8b34e Merge "Get home rotation default value from DisplayController Info in case DeviceProfile is not updated." into tm-qpr-dev 2022-12-15 20:02:14 +00:00
Alex Chau a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal 09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Alex Chau f8b79d4235 Use overridden default xml for TwoPanelWorkspaceTest
- Partially reverted TAPL and TwoPanelWorkspaceTest changes on http://ag/19195512

Fix: 262627208
Fix: 262632384
Test: TwoPanelWorkspaceTest
Change-Id: I8b793bfb3874cc6305ce8b0f9f7b0a116d01222b
2022-12-15 15:48:09 +00:00
Alex Chau 3ad5eef4b8 Merge "Avoid overlapping snackbar with nav buttons in tablets" into tm-qpr-dev 2022-12-15 14:47:02 +00:00
Pat Manning a79880a1d8 Match ArrowTipView width to parent so text can center.
Fix: 260302416
Test: manual
Change-Id: I75478ec57e2535578dacb16fefaf7c45e136f1f5
2022-12-15 14:40:58 +00:00
Alex Chau 3fa6669261 Merge "Temporarily use 1f bottomSheetDepth for multi-display" into tm-qpr-dev 2022-12-15 12:19:27 +00:00
Sihua Ma dbaec70d48 Merge "Reducing the no-intercept area to widget picker recycler view" into tm-qpr-dev 2022-12-14 23:26:03 +00:00
Alex Chau 8a7dc2b244 Merge "Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute" into tm-qpr-dev 2022-12-14 21:50:34 +00:00
Sebastian Franco 5aa71cee20 Clean mPreviousSolution on change of CellLayout target
The previous reorder solution is not peropperly cleaned and
that leads to wrong solution being used. For example when
longpressing an icon, it triggers a drag but the drag never
finishes.

Fix: 261122618
Test: You can no longer overlap a shortcut in the same app icon (see attached bug)
Test: atest ReorderWidget

Change-Id: Iff8651926cc4179561761c7ce0ac5007f13fc9af
2022-12-14 15:20:50 -06:00
Sunny Goyal adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Alex Chau ab800f71d0 Temporarily use 1f bottomSheetDepth for multi-display
Bug: 259893832
Test: Manual and DeviceProfileDumpTest
Change-Id: I196958e6f9f889de003b4d3a22a176bfd7e49511
2022-12-14 18:17:18 +00:00
Holly Jiuyu Sun 80872f32da Merge "[QL-v2] Reset input state on scroll and restore state on scrolling back." into tm-qpr-dev 2022-12-14 17:25:45 +00:00
Alex Chau 5c1eb61391 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev 2022-12-14 17:15:21 +00:00
Alex Chau 86a41d1a42 Avoid overlapping snackbar with nav buttons in tablets
Fix: 249378243
Test: manual
Change-Id: Ibbd0e917b1cbe657b2424acbad0134d6de807f62
2022-12-14 16:18:18 +00:00
TreeHugger Robot c995ec1dd8 Merge "Set the default value for SCROLL_TOP_TO_RESET to true." into tm-qpr-dev 2022-12-13 20:44:23 +00:00
TreeHugger Robot 5c1cc6ac4b Merge "Reset TASKBAR_EDU_SEEN preference." into tm-qpr-dev 2022-12-13 19:21:01 +00:00
TreeHugger Robot be968ab8e2 Merge "Adding feature flag for simulating two CellLayouts using one." into tm-qpr-dev 2022-12-13 16:56:38 +00:00
Pat Manning e95a12c329 Get home rotation default value from DisplayController Info in case DeviceProfile is not updated.
Bug: 260059325
Test: manual
Change-Id: I7f5ea9f4607ea50ffafb7a19f0ae0e62df2dbb14
2022-12-13 16:55:48 +00:00
Alex Chau be753137a2 Don't scale iconSize and textSize in non-default display size
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space

Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
2022-12-13 16:30:14 +00:00
Jeremy Sim 8e8352e27e Fix juttering problem with split staging animation
This patch makes it so that app icons no longer jutter uncomfortably when staging and confirming a split from home.

The problem occurred because I used Math.round when calculating the position at which to center the app icon within the SplitPlaceholderView. When an inexact integer is used to calculate the x and y position on every frame, it creates juttering, especially when numerical values are small.

Solved by removing Math.round and using floats going forward.

Fixes: 262308025
Test: Manual
Change-Id: If91d1d3ee52652c155ed7e4e1d4f4620fdc41cc9
2022-12-12 18:18:20 -08:00
TreeHugger Robot 742294305f Merge "Changed widget picker personal-work tab layout" into tm-qpr-dev 2022-12-12 22:59:08 +00:00
Holly Sun 196d55aa77 [QL-v2] Reset input state on scroll and restore state on scrolling back.
Bug: 261872461
Test: see video in bug
Change-Id: I18e1923bdd4c40e84e46579296b69268d46c9fa1
2022-12-12 14:03:31 -08:00
Andy Wickham 29b95b58ba Merge "Adds header protection on tablet all apps panel." into tm-qpr-dev 2022-12-12 19:08:37 +00:00
Brian Isganitis 8f981e4bad Reset TASKBAR_EDU_SEEN preference.
The EDU has been updated to support both transient and persistent
taskbar cases, so we should show it to the use again.

Test: Manual
Bug: 217261955
Change-Id: Ied59e6226c4f9599ad98333012313db57edc7c1f
2022-12-12 13:56:35 -05:00
TreeHugger Robot 9c19638ca3 Merge "Support mouse right click on HomeScreen to show the customization menu" into tm-qpr-dev 2022-12-11 01:57:52 +00:00
TreeHugger Robot f7590ed79c Merge "Remove delightful page indicator" into tm-qpr-dev 2022-12-10 05:47:19 +00:00
Jon Miranda 229d9bc3b7 Merge "Enable transient taskbar flag on by default." into tm-qpr-dev 2022-12-10 02:03:04 +00:00
Sebastian Franco 5f022614b0 Adding feature flag for simulating two CellLayouts using one.
Bug: 188081026
Test: compiles
Change-Id: Idd9ad8c6d0e4814d93fc9dd019e250d9469020d8
2022-12-10 00:37:43 +00:00
Federico Baron 9a6a2c8a2d Merge "Move AnimatedFloat from quickstep to launcher" into tm-qpr-dev 2022-12-09 23:33:17 +00:00
Sihua Ma 60813a89f7 Changed widget picker personal-work tab layout
Used layout margin instead of padding. Also making sure that Talkback would focus on the widgets title once the widget picker is opened.

Before: https://screenshot.googleplex.com/AgZspqTc7yS2Lte
Now: https://screenshot.googleplex.com/5W66ky7XAByCFRZ

Fix: 247121867
Test: Manual
Change-Id: I76534454754c5e57ab51ae7ce06ca4370a3fd22b
2022-12-09 13:58:57 -08:00
Sunny Goyal d31c8baef1 Merge "Removing some unnecessary interfaces and merging them to ActivityContext" into tm-qpr-dev 2022-12-09 15:35:59 +00:00
Fengjiang Li a6a67e347d Support mouse right click on HomeScreen to show the customization menu
Bug: b/250089861
Fix: b/250089861
Test: Manual Testing
Video: https://b.corp.google.com/action/issues/250089861/attachments/40243664?download=true
Change-Id: Ia23e302bf8f3e18fafd6ccd079740c8005ae7860
2022-12-09 02:44:09 +00:00
Federico Baron 3f82a06c7f Remove delightful page indicator
Due to design changes, we are no longer going to use the  changes guarded under the flag SHOW_DELIIGHTFUL_PAGINATION, so we remove the flag and the code that was guarded by that flag

Bug: 261904707
Test: verify flag SHOW_DELIGHTFUL_PAGINATION no longer exists and that the regular pagination works without issues after removing all this code
Change-Id: I244b88b98df0357aa99a325a11988e8248a03206
2022-12-08 15:00:02 -08:00
Holly Sun 66a7fdcd90 Set the default value for SCROLL_TOP_TO_RESET to true.
Per UX, we can enable this feature by default.

Bug: 218846025
Test: manual
Change-Id: I828515ec45e84007cee3893cd2b76fca7c5afee2
2022-12-08 14:13:07 -08:00
Federico Baron 47d81686e6 Move AnimatedFloat from quickstep to launcher
We are moving AnimatedFloat to launcher to be able to use this in class in launcher. Having it in launcher will allow us to do restore icon treatment animations to do with scaling the icon size

Bug: 254858049
Test: verified that the device still works
Change-Id: I1c4c47ab436c389a94abf7c910c1a44724efc955
2022-12-08 13:58:07 -08:00
Sunny Goyal 9898d7906e Merge "Adding support for generating manachrome icon from a colored icon" into tm-qpr-dev 2022-12-08 18:54:59 +00:00
Sunny Goyal 54fa110bba Removing some unnecessary interfaces and merging them to ActivityContext
Bug: 259733681
Test: Everything compiles
Change-Id: If6b530f6e589a851cf8554f5de0849843bd66dd4
2022-12-08 10:15:55 -08:00